Re: [HACKERS] patch for contrib/isn

2010-08-10 Thread Jan Otto
On Aug 6, 2010, at 11:08 PM, Peter Eisentraut wrote: > On ons, 2010-08-04 at 19:32 +0200, Jan Otto wrote: >> patch against HEAD is attached and validated against a lot of >> previously wrong and correct hyphenated isbn. > > I think this module could use a regression test. i'll take a look at th

Re: [HACKERS] patch for contrib/isn

2010-08-06 Thread Peter Eisentraut
On ons, 2010-08-04 at 19:32 +0200, Jan Otto wrote: > patch against HEAD is attached and validated against a lot of > previously wrong and correct hyphenated isbn. I think this module could use a regression test. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make chang

Re: [HACKERS] patch for contrib/isn

2010-08-04 Thread Kevin Grittner
Robert Haas wrote: > Please put "contrib/isn" in the name somewhere so that there is > some overlap between the subject line and the CF entry. It is now "contrib/isn isbn update". -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscript

Re: [HACKERS] patch for contrib/isn

2010-08-04 Thread Robert Haas
On Wed, Aug 4, 2010 at 2:58 PM, Kevin Grittner wrote: > "Joshua D. Drake" wrote: >> On Wed, 2010-08-04 at 19:32 +0200, Jan Otto wrote: > >>> patch against HEAD is attached and validated against a lot of >>> previously wrong and correct hyphenated isbn. > >> Great! Thanks. We will get it on the re

Re: [HACKERS] patch for contrib/isn

2010-08-04 Thread Kevin Grittner
"Joshua D. Drake" wrote: > On Wed, 2010-08-04 at 19:32 +0200, Jan Otto wrote: >> patch against HEAD is attached and validated against a lot of >> previously wrong and correct hyphenated isbn. > Great! Thanks. We will get it on the review list. I added it as "isbn update" to the 2010-09 Commi

Re: [HACKERS] patch for contrib/isn

2010-08-04 Thread Joshua D. Drake
On Wed, 2010-08-04 at 19:32 +0200, Jan Otto wrote: > hi all, > > currently i am working on a big project for a german bookseller and > publisher. one of the requirements was correct hyphenation of ISBN-13 > for about 14.400.000 books in postgresql database. so added support > for hyphenating isbn

[HACKERS] patch for contrib/isn

2010-08-04 Thread Jan Otto
hi all, currently i am working on a big project for a german bookseller and publisher. one of the requirements was correct hyphenation of ISBN-13 for about 14.400.000 books in postgresql database. so added support for hyphenating isbn with the new 979-prefix and additionally added all missing rang