Re: [HACKERS] patch review : Add ability to constrain backend temporary file space

2011-06-02 Thread Cédric Villemain
2011/6/2 Mark Kirkwood : > On 01/06/11 09:24, Cédric Villemain wrote: >> * I am not sure it is better to add a fileSize like you did or use >> relationgetnumberofblock() when file is about to be truncated or >> unlinked, this way the seekPos should be enough to increase the global >> counter. >> >

[HACKERS] patch review : Add ability to constrain backend temporary file space

2011-05-31 Thread Cédric Villemain
Hello here is a partial review of your patch, better than keeping it sleeping in the commitfest queue I hope. Submission review * The patch is not in context diff format. * The patch apply, but contains some extra whitespace. * Documentation is here but not explicit