Re: [HACKERS] patch to fix client only builds

2009-02-04 Thread Bruce Momjian
Tom Lane wrote: Merlin Moncure mmonc...@gmail.com writes: Noticed another issue with 'client only' type installs in the Makefile. Shouldn't make install on libpq install postgres_ext.h in addition to the interface headers? I don't think libpq's Makefile has any business doing that.

Re: [HACKERS] patch to fix client only builds

2009-02-04 Thread Merlin Moncure
On Wed, Feb 4, 2009 at 1:22 PM, Bruce Momjian br...@momjian.us wrote: Tom Lane wrote: Merlin Moncure mmonc...@gmail.com writes: Noticed another issue with 'client only' type installs in the Makefile. Shouldn't make install on libpq install postgres_ext.h in addition to the interface

Re: [HACKERS] patch to fix client only builds

2009-01-08 Thread Bruce Momjian
Did we address this? --- Merlin Moncure wrote: On Thu, Nov 6, 2008 at 12:45 PM, Tom Lane t...@sss.pgh.pa.us wrote: Merlin Moncure mmonc...@gmail.com writes: IMO, the client only build should be fixed, so we can: *)

Re: [HACKERS] patch to fix client only builds

2008-11-17 Thread Merlin Moncure
On Thu, Nov 6, 2008 at 12:45 PM, Tom Lane [EMAIL PROTECTED] wrote: Merlin Moncure [EMAIL PROTECTED] writes: IMO, the client only build should be fixed, so we can: *) put the makefile hack I proposed in *) implement the keywords.c change suggested above *) set up backend/parser symlink from

Re: [HACKERS] patch to fix client only builds

2008-11-17 Thread Tom Lane
Merlin Moncure [EMAIL PROTECTED] writes: Noticed another issue with 'client only' type installs in the Makefile. Shouldn't make install on libpq install postgres_ext.h in addition to the interface headers? I don't think libpq's Makefile has any business doing that. Maybe we should bite the

Re: [HACKERS] patch to fix client only builds

2008-11-17 Thread Peter Eisentraut
Tom Lane wrote: Maybe we should bite the bullet and provide some kind of top-level make targets for client-only build/install. That would probably work best. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

[HACKERS] patch to fix client only builds

2008-11-06 Thread Merlin Moncure
I'm trying to do client only builds on a bunch of legacy platforms and noticed that the include path is messed up...if keywords.o is not already built, it fails to build be because src/backend/parser but not src/backend is in the include path. (keywords.c includes parser/gram.h). The following

Re: [HACKERS] patch to fix client only builds

2008-11-06 Thread Tom Lane
Merlin Moncure [EMAIL PROTECTED] writes: I'm trying to do client only builds on a bunch of legacy platforms and noticed that the include path is messed up...if keywords.o is not already built, it fails to build be because src/backend/parser but not src/backend is in the include path.

Re: [HACKERS] patch to fix client only builds

2008-11-06 Thread Merlin Moncure
On Thu, Nov 6, 2008 at 11:09 AM, Tom Lane [EMAIL PROTECTED] wrote: Merlin Moncure [EMAIL PROTECTED] writes: I'm trying to do client only builds on a bunch of legacy platforms and noticed that the include path is messed up...if keywords.o is not already built, it fails to build be because

Re: [HACKERS] patch to fix client only builds

2008-11-06 Thread Tom Lane
Merlin Moncure [EMAIL PROTECTED] writes: This looks caused by a change to clean up some quoting issues: No, that patch is unrelated --- it didn't modify the inclusion situation at all. regards, tom lane -- Sent via pgsql-hackers mailing list

Re: [HACKERS] patch to fix client only builds

2008-11-06 Thread Merlin Moncure
On Thu, Nov 6, 2008 at 12:26 PM, Tom Lane [EMAIL PROTECTED] wrote: Merlin Moncure [EMAIL PROTECTED] writes: This looks caused by a change to clean up some quoting issues: No, that patch is unrelated --- it didn't modify the inclusion situation at all. oopright againcvs annotate

Re: [HACKERS] patch to fix client only builds

2008-11-06 Thread Tom Lane
Merlin Moncure [EMAIL PROTECTED] writes: IMO, the client only build should be fixed, so we can: *) put the makefile hack I proposed in *) implement the keywords.c change suggested above *) set up backend/parser symlink from different/additional place. The last of these seems the correct fix.