Re: [HACKERS] pg_archivecleanup debug message consistency

2010-08-22 Thread Tom Lane
Erik Rijkers e...@xs4all.nl writes: If only for consistency, this patch adds the path info to that message. Seems reasonable, but speaking of consistency: +#ifdef WIN32 + snprintf(WALFilePath, MAXPGPATH, %s\\%s, archiveLocation, exclusiveCleanupFileName); +#else

Re: [HACKERS] pg_archivecleanup debug message consistency

2010-08-22 Thread Erik Rijkers
On Sun, August 22, 2010 17:54, Tom Lane wrote: Erik Rijkers e...@xs4all.nl writes: If only for consistency, this patch adds the path info to that message. Seems reasonable, but speaking of consistency: +#ifdef WIN32 +snprintf(WALFilePath, MAXPGPATH, %s\\%s,

Re: [HACKERS] pg_archivecleanup debug message consistency

2010-08-22 Thread Tom Lane
Erik Rijkers e...@xs4all.nl writes: yes, I agree that's better; attached is that change. Looks good, applied to HEAD and 9.0. (I also snuck in a couple of cosmetic cleanups while I was looking at the file.) regards, tom lane -- Sent via pgsql-hackers mailing list

[HACKERS] pg_archivecleanup debug message consistency

2010-08-21 Thread Erik Rijkers
pg_archivecleanup -d (=verbose/DEBUG mode) mainly emits 2 types of messages: pg_archivecleanup: keep WAL file 00010002 and later and: pg_archivecleanup: removing file /var/data2/pg_stuff/dump/hotprime/replication_archive/0001001B I found it a bit annoying to