Re: [HACKERS] pg_basebackup is not checking IDENTIFY_SYSTEM numbre of columns

2012-01-20 Thread Magnus Hagander
On Sun, Jan 15, 2012 at 22:00, Jaime Casanova ja...@2ndquadrant.com wrote: On Wed, Jan 11, 2012 at 5:11 PM, Magnus Hagander mag...@hagander.net wrote: No, no reason. Adding such a check would be a good idea. ok. patch attached, it also adds a few PQclear() calls before

Re: [HACKERS] pg_basebackup is not checking IDENTIFY_SYSTEM numbre of columns

2012-01-15 Thread Jaime Casanova
On Wed, Jan 11, 2012 at 5:11 PM, Magnus Hagander mag...@hagander.net wrote: No, no reason. Adding such a check would be a good idea. ok. patch attached, it also adds a few PQclear() calls before disconnect_and_exit(). btw, in BaseBackup() in line 1149 (after the patch is applied) there is an

[HACKERS] pg_basebackup is not checking IDENTIFY_SYSTEM numbre of columns

2012-01-11 Thread Jaime Casanova
Hi, I just notice $SUBJECT and this could lead us to a segmentation fault if by accident we point to a system with a different number of columns in IDENTIFY_SYSTEM, at least i point pg_receivexlog from current head to a 9.0 instalation and got that. Any reason for not checking number of columns?

Re: [HACKERS] pg_basebackup is not checking IDENTIFY_SYSTEM numbre of columns

2012-01-11 Thread Magnus Hagander
On Wed, Jan 11, 2012 at 22:31, Jaime Casanova ja...@2ndquadrant.com wrote: Hi, I just notice $SUBJECT and this could lead us to a segmentation fault if by accident we point to a system with a different number of columns in IDENTIFY_SYSTEM, at least i point pg_receivexlog from current head to