Re: [HACKERS] pg_dump and inserts

2003-02-14 Thread Bruce Momjian
Attached is a patch the more clearly handles autocommit in pg_dump. I had already fixed pg_dump for doing autocommit while dumping, but didn't handle setting autocommit on restore. I focused on the initial script file startup, every \\connect, pg_restore, and pg_dumpall. I think I got them

Re: [HACKERS] pg_dump and inserts

2003-01-28 Thread Kevin Brown
Bruce Momjian wrote: I just checked and pg_dump -d _doesn't_ place the INSERT's in a transsaction. Seems it should, and perhaps add a: SET autocommit TO 'on' as well. Of course, that SET would fail when restoring to prior releases, but they don't have autocommit off anyway so it

Re: [HACKERS] pg_dump and inserts

2003-01-28 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: I just checked and pg_dump -d _doesn't_ place the INSERT's in a transsaction. Seems it should, I think this is a bad idea. If one were after speed, one would have used the COPY format in the first place. If one uses INSERTs, there may be a reason for

[HACKERS] pg_dump and inserts

2003-01-27 Thread Bruce Momjian
I just checked and pg_dump -d _doesn't_ place the INSERT's in a transsaction. Seems it should, and perhaps add a: SET autocommit TO 'on' as well. Of course, that SET would fail when restoring to prior releases, but they don't have autocommit off anyway so it can be ignored. Comments?