Re: [HACKERS] pg_dump gets attributes from tables in extensions

2015-02-24 Thread Alvaro Herrera
Michael Paquier wrote: On Tue, Feb 24, 2015 at 3:13 PM, Rushabh Lathia rushabh.lat...@gmail.com wrote: rushabh@rushabh-centos-vm:dump_test$ cat dump_test--1.0.sql /* dump_test/dump_test--1.0.sql */ Hm. I think it would be a good idea to collect these extension files somewhere so that

Re: [HACKERS] pg_dump gets attributes from tables in extensions

2015-02-24 Thread Alvaro Herrera
Michael Paquier wrote: On Tue, Feb 24, 2015 at 11:55 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Maybe something in src/test/modules could keep these files so that pg_dump can be tested. Is anybody interested in doing that? For the patch to fix data dump of extensions that

Re: [HACKERS] pg_dump gets attributes from tables in extensions

2015-02-24 Thread Michael Paquier
On Wed, Feb 25, 2015 at 10:30 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Michael Paquier wrote: On Tue, Feb 24, 2015 at 11:55 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Maybe something in src/test/modules could keep these files so that pg_dump can be tested. Is

Re: [HACKERS] pg_dump gets attributes from tables in extensions

2015-02-24 Thread Alvaro Herrera
Michael Paquier wrote: On Wed, Feb 25, 2015 at 10:30 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: That looks interesting -- I don't recall seeing it. Does it support more doing than one extension? If so, we could certainly integrate it. It uses TAP tests to kick pg_dump commands,

Re: [HACKERS] pg_dump gets attributes from tables in extensions

2015-02-24 Thread Michael Paquier
On Tue, Feb 24, 2015 at 11:55 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Michael Paquier wrote: On Tue, Feb 24, 2015 at 3:13 PM, Rushabh Lathia rushabh.lat...@gmail.com wrote: rushabh@rushabh-centos-vm:dump_test$ cat dump_test--1.0.sql /* dump_test/dump_test--1.0.sql */

Re: [HACKERS] pg_dump gets attributes from tables in extensions

2015-02-23 Thread Michael Paquier
On Mon, Feb 23, 2015 at 5:57 PM, Rushabh Lathia rushabh.lat...@gmail.com wrote: Thanks to the easy handy testcase, was able to replicate the test scenario on my local environment. And yes tbinfo-dobj.ext_member check into getTableAttrs() do fix the issue. Looking more into pg_dump code what I

Re: [HACKERS] pg_dump gets attributes from tables in extensions

2015-02-23 Thread Rushabh Lathia
Thanks to the easy handy testcase, was able to replicate the test scenario on my local environment. And yes tbinfo-dobj.ext_member check into getTableAttrs() do fix the issue. Looking more into pg_dump code what I found that, generally PG don't have tbinfo-dobj.ext_member check to ignore the

Re: [HACKERS] pg_dump gets attributes from tables in extensions

2015-02-23 Thread Rushabh Lathia
On Mon, Feb 23, 2015 at 7:45 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Mon, Feb 23, 2015 at 5:57 PM, Rushabh Lathia rushabh.lat...@gmail.com wrote: Thanks to the easy handy testcase, was able to replicate the test scenario on my local environment. And yes

Re: [HACKERS] pg_dump gets attributes from tables in extensions

2015-02-19 Thread Peter Eisentraut
On 2/16/15 2:45 AM, Michael Paquier wrote: While looking at the patch to fix pg_dump with extensions containing tables referencing each other, I got surprised by the fact that getTableAttrs tries to dump table attributes even for tables that are part of an extension. Is that normal? Attached

Re: [HACKERS] pg_dump gets attributes from tables in extensions

2015-02-19 Thread Michael Paquier
On Fri, Feb 20, 2015 at 5:33 AM, Peter Eisentraut pete...@gmx.net wrote: On 2/16/15 2:45 AM, Michael Paquier wrote: While looking at the patch to fix pg_dump with extensions containing tables referencing each other, I got surprised by the fact that getTableAttrs tries to dump table attributes

Re: [HACKERS] pg_dump gets attributes from tables in extensions

2015-02-15 Thread Michael Paquier
On Mon, Feb 16, 2015 at 4:45 PM, Michael Paquier michael.paqu...@gmail.comwrote: but not dumping any tables that are part of ext_member. Excuse the typo = s/but/by/. -- Michael

[HACKERS] pg_dump gets attributes from tables in extensions

2015-02-15 Thread Michael Paquier
Hi all, While looking at the patch to fix pg_dump with extensions containing tables referencing each other, I got surprised by the fact that getTableAttrs tries to dump table attributes even for tables that are part of an extension. Is that normal? Attached is a patch that I think makes things