Re: [HACKERS] pg_dump incorrect output in plaintext mode

2012-09-04 Thread Magnus Hagander
On Fri, Aug 31, 2012 at 2:05 PM, Magnus Hagander mag...@hagander.net wrote: On Aug 28, 2012 9:59 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: On Tue, Aug 28, 2012 at 6:42 PM, Tom Lane t...@sss.pgh.pa.us wrote: I don't see anything particularly

Re: [HACKERS] pg_dump incorrect output in plaintext mode

2012-09-04 Thread Magnus Hagander
On Tue, Sep 4, 2012 at 3:51 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: On Aug 28, 2012 9:59 PM, Tom Lane t...@sss.pgh.pa.us wrote: Well, why don't we just s/restoring/processing/ in the debug message, and call it good? Are we allowed to backpatch

Re: [HACKERS] pg_dump incorrect output in plaintext mode

2012-09-04 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: On Aug 28, 2012 9:59 PM, Tom Lane t...@sss.pgh.pa.us wrote: Well, why don't we just s/restoring/processing/ in the debug message, and call it good? Are we allowed to backpatch things to 9.2 at this point that changes strings for translators? Well,

Re: [HACKERS] pg_dump incorrect output in plaintext mode

2012-08-31 Thread Magnus Hagander
On Aug 28, 2012 9:59 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: On Tue, Aug 28, 2012 at 6:42 PM, Tom Lane t...@sss.pgh.pa.us wrote: I don't see anything particularly incorrect about that. The point of the --verbose switch is to track what pg_dump is

[HACKERS] pg_dump incorrect output in plaintext mode

2012-08-28 Thread Magnus Hagander
$ pg_dump -v postgres -Fc -t t /dev/null ... pg_dump: dumping contents of table t ... but in plaintext: $ pg_dump -v postgres -Fp -t t /dev/null pg_dump: creating TABLE t pg_dump: restoring data for table t pg_dump: dumping contents of table t pg_dump: setting owner and privileges for TABLE t

Re: [HACKERS] pg_dump incorrect output in plaintext mode

2012-08-28 Thread Alvaro Herrera
Excerpts from Magnus Hagander's message of mar ago 28 08:08:24 -0400 2012: In particular, the restoring data is obviously completely wrong. But AFAICT, the creating table and setting owner etc are also wrong... This is because pg_dump calls RestoreArchive(fout). Do we need to pass down a

Re: [HACKERS] pg_dump incorrect output in plaintext mode

2012-08-28 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: but in plaintext: $ pg_dump -v postgres -Fp -t t /dev/null pg_dump: creating TABLE t pg_dump: restoring data for table t pg_dump: dumping contents of table t pg_dump: setting owner and privileges for TABLE t pg_dump: setting owner and privileges

Re: [HACKERS] pg_dump incorrect output in plaintext mode

2012-08-28 Thread Magnus Hagander
On Tue, Aug 28, 2012 at 6:42 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: but in plaintext: $ pg_dump -v postgres -Fp -t t /dev/null pg_dump: creating TABLE t pg_dump: restoring data for table t pg_dump: dumping contents of table t pg_dump: setting

Re: [HACKERS] pg_dump incorrect output in plaintext mode

2012-08-28 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: On Tue, Aug 28, 2012 at 6:42 PM, Tom Lane t...@sss.pgh.pa.us wrote: I don't see anything particularly incorrect about that. The point of the --verbose switch is to track what pg_dump is doing, and if what it's doing involves going through