Re: [HACKERS] pg_trgm partial-match

2013-01-16 Thread Fujii Masao
On Fri, Nov 23, 2012 at 2:11 AM, Fujii Masao wrote: > On Mon, Nov 19, 2012 at 10:56 AM, Tomas Vondra wrote: >> I've done a quick review of the current patch: > > Thanks for the commit! > > As Alexander pointed out upthread, another infrastructure patch is required > before applying this patch. So

Re: [HACKERS] pg_trgm partial-match

2012-11-22 Thread Fujii Masao
On Mon, Nov 19, 2012 at 10:56 AM, Tomas Vondra wrote: > I've done a quick review of the current patch: Thanks for the commit! As Alexander pointed out upthread, another infrastructure patch is required before applying this patch. So I will implement the infra patch first. Regards, -- Fujii Ma

Re: [HACKERS] pg_trgm partial-match

2012-11-22 Thread Fujii Masao
On Mon, Nov 19, 2012 at 7:55 PM, Alexander Korotkov wrote: > On Mon, Nov 19, 2012 at 10:05 AM, Alexander Korotkov > wrote: >> >> On Thu, Nov 15, 2012 at 11:39 PM, Fujii Masao >> wrote: >>> >>> Note that we cannot do a partial-match if KEEPONLYALNUM is disabled, >>> i.e., if query key contains mu

Re: [HACKERS] pg_trgm partial-match

2012-11-19 Thread Alexander Korotkov
On Mon, Nov 19, 2012 at 10:05 AM, Alexander Korotkov wrote: > On Thu, Nov 15, 2012 at 11:39 PM, Fujii Masao wrote: > >> Note that we cannot do a partial-match if KEEPONLYALNUM is disabled, >> i.e., if query key contains multibyte characters. In this case, byte >> length of >> the trigram string mi

Re: [HACKERS] pg_trgm partial-match

2012-11-18 Thread Alexander Korotkov
Hi! On Thu, Nov 15, 2012 at 11:39 PM, Fujii Masao wrote: > Note that we cannot do a partial-match if KEEPONLYALNUM is disabled, > i.e., if query key contains multibyte characters. In this case, byte > length of > the trigram string might be larger than three, and its CRC is used as a > trigram k

Re: [HACKERS] pg_trgm partial-match

2012-11-18 Thread Tomas Vondra
On 15.11.2012 20:39, Fujii Masao wrote: > Hi, > > I'd like to propose to extend pg_trgm so that it can compare a partial-match > query key to a GIN index. IOW, I'm thinking to implement the 'comparePartial' > GIN method for pg_trgm. > > Currently, when the query key is less than three characters,

[HACKERS] pg_trgm partial-match

2012-11-15 Thread Fujii Masao
Hi, I'd like to propose to extend pg_trgm so that it can compare a partial-match query key to a GIN index. IOW, I'm thinking to implement the 'comparePartial' GIN method for pg_trgm. Currently, when the query key is less than three characters, we cannot use a GIN index (+ pg_trgm) efficiently, be