Re: [HACKERS] pg_typeof() patch review

2008-11-07 Thread David E. Wheeler
On Nov 3, 2008, at 11:15 AM, Tom Lane wrote: David E. Wheeler [EMAIL PROTECTED] writes: On Nov 3, 2008, at 10:52 AM, Alvaro Herrera wrote: Maybe we should link to this page in the pg_typeof() description. Also, perhaps this page needs more examples. Yes, both of those would help a lot, I

Re: [HACKERS] pg_typeof() patch review

2008-11-07 Thread Tom Lane
David E. Wheeler [EMAIL PROTECTED] writes: On Nov 3, 2008, at 11:15 AM, Tom Lane wrote: Feel free to send in a docs patch ... Well, I wasn't sure of the appropriate place to add examples to datatype.sgml. But this patch would certainly make the output of pg_typeof() much clearer to

Re: [HACKERS] pg_typeof() patch review

2008-11-07 Thread David E. Wheeler
On Nov 7, 2008, at 2:55 PM, Tom Lane wrote: Well, I wasn't sure of the appropriate place to add examples to datatype.sgml. But this patch would certainly make the output of pg_typeof() much clearer to newbies like me. Applied with some further editorialization. Thanks! David -- Sent via

[HACKERS] pg_typeof() patch review

2008-11-03 Thread Kurt Harriman
Hi, Brendan Jurd submitted a patch to add a pg_typeof() builtin function: http://archives.postgresql.org/pgsql-patches/2008-09/msg00029.php I've reviewed the patch and it looks fine. An updated version is attached, having made these changes: 1) Rebased to current CVS head 2) func.sgml:

Re: [HACKERS] pg_typeof() patch review

2008-11-03 Thread David E. Wheeler
On Nov 3, 2008, at 1:28 AM, Kurt Harriman wrote: 2) func.sgml: clarifying that the function returns an OID rather than a string Actually, it returns a regtype, no? Best, David -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] pg_typeof() patch review

2008-11-03 Thread Alvaro Herrera
David E. Wheeler escribió: On Nov 3, 2008, at 1:28 AM, Kurt Harriman wrote: 2) func.sgml: clarifying that the function returns an OID rather than a string Actually, it returns a regtype, no? Yes -- regtype, which is an OID alias type. -- Alvaro Herrera

Re: [HACKERS] pg_typeof() patch review

2008-11-03 Thread Tom Lane
David E. Wheeler [EMAIL PROTECTED] writes: On Nov 3, 2008, at 1:28 AM, Kurt Harriman wrote: 2) func.sgml: clarifying that the function returns an OID rather than a string Actually, it returns a regtype, no? I thought the description was good, because it emphasizes that the result is-a OID;

Re: [HACKERS] pg_typeof() patch review

2008-11-03 Thread David E. Wheeler
On Nov 3, 2008, at 10:02 AM, Tom Lane wrote: David E. Wheeler [EMAIL PROTECTED] writes: On Nov 3, 2008, at 1:28 AM, Kurt Harriman wrote: 2) func.sgml: clarifying that the function returns an OID rather than a string Actually, it returns a regtype, no? I thought the description was good,

Re: [HACKERS] pg_typeof() patch review

2008-11-03 Thread Alvaro Herrera
David E. Wheeler escribió: Well, as someone who was until recently unfamiliar with regtypes, and who thinks of an OID as essentially just a number, I would find it very useful if the description indicated that, as a regtype, the return value could be used as either an OID or as string.

Re: [HACKERS] pg_typeof() patch review

2008-11-03 Thread Tom Lane
Kurt Harriman [EMAIL PROTECTED] writes: Brendan Jurd submitted a patch to add a pg_typeof() builtin function: http://archives.postgresql.org/pgsql-patches/2008-09/msg00029.php I've reviewed the patch and it looks fine. An updated version is attached, having made these changes: Applied,

Re: [HACKERS] pg_typeof() patch review

2008-11-03 Thread David E. Wheeler
On Nov 3, 2008, at 10:52 AM, Alvaro Herrera wrote: Give this a read http://www.postgresql.org/docs/8.3/static/datatype-oid.html Yeah. Maybe we should link to this page in the pg_typeof() description. Also, perhaps this page needs more examples. Yes, both of those would help a lot, I

Re: [HACKERS] pg_typeof() patch review

2008-11-03 Thread Tom Lane
David E. Wheeler [EMAIL PROTECTED] writes: On Nov 3, 2008, at 10:52 AM, Alvaro Herrera wrote: Maybe we should link to this page in the pg_typeof() description. Also, perhaps this page needs more examples. Yes, both of those would help a lot, I think. Feel free to send in a docs patch ...