Re: [HACKERS] pg_upgrade's bindir options could be optional

2011-05-07 Thread Bruce Momjian
Alvaro Herrera wrote: Excerpts from Tom Lane's message of vie may 06 17:11:35 -0300 2011: As an example, the proposed defaults would be not only wrong, but disastrous in the perfectly-reasonable situation where the user has moved the old installation aside and then installed the new

Re: [HACKERS] pg_upgrade's bindir options could be optional

2011-05-07 Thread Peter Eisentraut
On fre, 2011-05-06 at 21:54 -0300, Alvaro Herrera wrote: Excerpts from Tom Lane's message of vie may 06 17:11:35 -0300 2011: As an example, the proposed defaults would be not only wrong, but disastrous in the perfectly-reasonable situation where the user has moved the old installation

Re: [HACKERS] pg_upgrade's bindir options could be optional

2011-05-07 Thread Peter Eisentraut
On lör, 2011-05-07 at 13:33 -0400, Bruce Momjian wrote: Another interesting approach would be to assume the /bin directory is ../bin from the data directory. That would work for some installs, particularly for people moving things around, but again, it is worth trying to default something

Re: [HACKERS] pg_upgrade's bindir options could be optional

2011-05-07 Thread Bruce Momjian
Peter Eisentraut wrote: On fre, 2011-05-06 at 21:54 -0300, Alvaro Herrera wrote: Excerpts from Tom Lane's message of vie may 06 17:11:35 -0300 2011: As an example, the proposed defaults would be not only wrong, but disastrous in the perfectly-reasonable situation where the user has

Re: [HACKERS] pg_upgrade's bindir options could be optional

2011-05-07 Thread Bruce Momjian
Peter Eisentraut wrote: On l?r, 2011-05-07 at 13:33 -0400, Bruce Momjian wrote: Another interesting approach would be to assume the /bin directory is ../bin from the data directory. That would work for some installs, particularly for people moving things around, but again, it is worth

Re: [HACKERS] pg_upgrade's bindir options could be optional

2011-05-07 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On lör, 2011-05-07 at 13:33 -0400, Bruce Momjian wrote: Another interesting approach would be to assume the /bin directory is ../bin from the data directory. That would work for some installs, particularly for people moving things around, but again,

[HACKERS] pg_upgrade's bindir options could be optional

2011-05-06 Thread Peter Eisentraut
Just a thought: To make things a bit easier, the bindir options of pg_upgrade (-b/-B, --old-bindir/--new-bindir) could be made optional, I think. The new bindir should normally be the one that pg_upgrade itself is in. And the old bindir could be found out by looking at the postmaster.opts file

Re: [HACKERS] pg_upgrade's bindir options could be optional

2011-05-06 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: Just a thought: To make things a bit easier, the bindir options of pg_upgrade (-b/-B, --old-bindir/--new-bindir) could be made optional, I think. The new bindir should normally be the one that pg_upgrade itself is in. And the old bindir could be found

Re: [HACKERS] pg_upgrade's bindir options could be optional

2011-05-06 Thread Alvaro Herrera
Excerpts from Tom Lane's message of vie may 06 17:11:35 -0300 2011: As an example, the proposed defaults would be not only wrong, but disastrous in the perfectly-reasonable situation where the user has moved the old installation aside and then installed the new executables in the same place