Re: [HACKERS] pg_upgrade bugs

2012-09-03 Thread Andrew Dunstan
On 09/03/2012 12:00 AM, Tom Lane wrote: Alvaro Herrera alvhe...@2ndquadrant.com writes: Maybe, to reduce future backpatching pain, we could backpatch the change to exec_prog() API now that you have fixed the implementation? I'm inclined to think this is a good idea, but keep in mind we're

[HACKERS] pg_upgrade bugs

2012-09-02 Thread Andrew Dunstan
I have been wrestling for a couple of days trying to get pg_upgrade testing working on Windows, with a view to having it tested on the buildfarm. The test script has its own issues, which I'll deal with separately, but there are two issues in pg_upgrade's exec.c that make me suspect that if

Re: [HACKERS] pg_upgrade bugs

2012-09-02 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: I have been wrestling for a couple of days trying to get pg_upgrade testing working on Windows, with a view to having it tested on the buildfarm. The test script has its own issues, which I'll deal with separately, but there are two issues in

Re: [HACKERS] pg_upgrade bugs

2012-09-02 Thread Alvaro Herrera
Excerpts from Andrew Dunstan's message of dom sep 02 22:11:42 -0300 2012: I have been wrestling for a couple of days trying to get pg_upgrade testing working on Windows, with a view to having it tested on the buildfarm. The test script has its own issues, which I'll deal with separately,

Re: [HACKERS] pg_upgrade bugs

2012-09-02 Thread Tom Lane
Alvaro Herrera alvhe...@2ndquadrant.com writes: Maybe, to reduce future backpatching pain, we could backpatch the change to exec_prog() API now that you have fixed the implementation? I'm inclined to think this is a good idea, but keep in mind we're less than four days from wrapping 9.2.0.