Re: [HACKERS] pg_upgrade in 9.5 broken for adminpack

Bruce Momjian writes: > On Thu, Apr 16, 2015 at 11:29:07PM -0700, Jeff Janes wrote: >> Of course after sending that it became obvious.  The C function is not >> getting >> called because the SQL function is marked as being strict, yet is called with >> NULL arguments. >> >> Trivial patch

Re: [HACKERS] pg_upgrade in 9.5 broken for adminpack

Andreas Seltenreich writes: > Shouldn't there be some validation of arguments now that the function is > no longer marked strict? Currently, unprivileged users can crash the > server calling binary_upgrade_create_empty_extension with null > arguments. Found using sqlsmith.

Re: [HACKERS] pg_upgrade in 9.5 broken for adminpack

On Fri, Apr 17, 2015 at 04:11:44PM +0900, Michael Paquier wrote: On Fri, Apr 17, 2015 at 3:29 PM, Jeff Janes wrote: Of course after sending that it became obvious. The C function is not getting called because the SQL function is marked as being strict, yet is called with NULL arguments.

Re: [HACKERS] pg_upgrade in 9.5 broken for adminpack

On Thu, Apr 16, 2015 at 11:29:07PM -0700, Jeff Janes wrote: Of course after sending that it became obvious.  The C function is not getting called because the SQL function is marked as being strict, yet is called with NULL arguments. Trivial patch attached to unset strict flag in pg_proc.h.

[HACKERS] pg_upgrade in 9.5 broken for adminpack

pg_upgrade was recently broken for use upgrading from a system with adminpack installed. Breaking commit is: commit 30982be4e5019684e1772dd9170aaa53f5a8e894 Author: Peter Eisentraut pete...@gmx.net Integrate pg_upgrade_support module into backend from pg_upgrade_dump_12870.log

Re: [HACKERS] pg_upgrade in 9.5 broken for adminpack

On Thu, Apr 16, 2015 at 07:33:50PM -0700, Jeff Janes wrote: pg_upgrade was recently broken for use upgrading from a system with adminpack installed. Breaking commit is: commit 30982be4e5019684e1772dd9170aaa53f5a8e894 Author: Peter Eisentraut pete...@gmx.net     Integrate