Re: [HACKERS] pg_upgrade log files

2012-06-29 Thread Alvaro Herrera
Excerpts from Tom Lane's message of vie jun 29 01:04:13 -0400 2012: > Alvaro Herrera writes: > > I propose this patch which echoes the commands to the respective log > > files. I would backpatch this to 9.2. > > OK, but the fflush just before fclose seems a bit pointless; fclose > will do that

Re: [HACKERS] pg_upgrade log files

2012-06-28 Thread Tom Lane
Alvaro Herrera writes: > I propose this patch which echoes the commands to the respective log > files. I would backpatch this to 9.2. OK, but the fflush just before fclose seems a bit pointless; fclose will do that anyway no? regards, tom lane -- Sent via pgsql-hackers

[HACKERS] pg_upgrade log files

2012-06-28 Thread Alvaro Herrera
Right now, the pg_upgrade output files contain the output of the commands it runs. However, it does not contain the actual commands being run ... so if you want to figure out what is happening, you have to trace the pg_upgrade source while reading the log file. This is, to say the least, suboptim