On Sat, Jan 16, 2016 at 09:57:45AM +, Simon Riggs wrote:
> On 16 January 2016 at 02:10, Noah Misch wrote:
> > On Wed, Jan 13, 2016 at 12:13:11PM -0500, Tom Lane wrote:
> > > Basically this is trading off convenience of the committer (all of the
> > > alternatives Noah
On 16 January 2016 at 02:10, Noah Misch wrote:
> On Wed, Jan 13, 2016 at 12:13:11PM -0500, Tom Lane wrote:
> > Simon Riggs writes:
> > > On 13 January 2016 at 14:48, Noah Misch wrote:
> > >> I've noticed commits, from a few of you,
On Wed, Jan 13, 2016 at 12:13:11PM -0500, Tom Lane wrote:
> Simon Riggs writes:
> > On 13 January 2016 at 14:48, Noah Misch wrote:
> >> I've noticed commits, from a few of you, carrying pgindent changes to lines
> >> the patch would not otherwise change.
On 01/13/2016 12:13 PM, Tom Lane wrote:
Simon Riggs writes:
On 13 January 2016 at 14:48, Noah Misch wrote:
I've noticed commits, from a few of you, carrying pgindent changes to lines
the patch would not otherwise change.
Could we review again why
On Thu, Jan 14, 2016 at 11:25 AM, Andrew Dunstan wrote:
> I do think it makes life easier when going through the git history if
> semantic changes are separated from formatting changes.
I agree. And I agree with Mark Dilger's point, too.
--
Robert Haas
EnterpriseDB:
> On Jan 13, 2016, at 9:13 AM, Tom Lane wrote:
>
> Simon Riggs writes:
>> On 13 January 2016 at 14:48, Noah Misch wrote:
>>> I've noticed commits, from a few of you, carrying pgindent changes to lines
>>> the patch would not
I've noticed commits, from a few of you, carrying pgindent changes to lines
the patch would not otherwise change. (That is to say, the next pgindent run
would have made the same changes anyway.) From
https://wiki.postgresql.org/wiki/Submitting_a_Patch#Reasons_your_patch_might_be_returned:
The
Simon Riggs writes:
> On 13 January 2016 at 14:48, Noah Misch wrote:
>> I've noticed commits, from a few of you, carrying pgindent changes to lines
>> the patch would not otherwise change.
> Could we review again why this matters?
Basically this is
On 13 January 2016 at 14:48, Noah Misch wrote:
> I've noticed commits, from a few of you, carrying pgindent changes to lines
> the patch would not otherwise change.
Could we review again why this matters?
--
Simon Riggshttp://www.2ndQuadrant.com/