Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-12-04 Thread Michael Paquier
On Sun, Dec 4, 2016 at 5:58 AM, Noah Misch wrote: > On Wed, Nov 30, 2016 at 04:24:34PM +, Christian Ullrich wrote: >> * From: Michael Paquier >> > would be nice to mention in a code comment that this what Noah has >> > mentioned upthread: if a CRT loads while

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-12-03 Thread Noah Misch
On Wed, Nov 16, 2016 at 08:45:20PM +, Christian Ullrich wrote: > * Noah Misch wrote: > > I prefer the simplicity of abandoning the cache (patch 4), if it > > performs decently. Would you compare the performance of patch 1, > > patches 1+2+3, and patches 1+2+4? This should measure the right

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-12-02 Thread Robert Haas
On Wed, Nov 30, 2016 at 2:56 AM, Michael Paquier wrote: > On Tue, Nov 29, 2016 at 08:45:13PM +0100, Christian Ullrich wrote: >> * Michael Paquier wrote: >> >> > On Wed, Nov 16, 2016 at 12:45 PM, Christian Ullrich >> > wrote: >> >> I also did a

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-11-30 Thread Michael Paquier
On Thu, Dec 1, 2016 at 1:24 AM, Christian Ullrich wrote: > * From: Michael Paquier > >> With 0005 I am seeing a compilation failure: you need to have the >> declarations in the _MSC_VER block at the beginning of the routine. It > > Sorry, too used to C++. > >> would be nice

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-11-30 Thread Christian Ullrich
* From: Michael Paquier > With 0005 I am seeing a compilation failure: you need to have the > declarations in the _MSC_VER block at the beginning of the routine. It Sorry, too used to C++. > would be nice to mention in a code comment that this what Noah has > mentioned upthread: if a CRT loads

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-11-29 Thread Michael Paquier
On Tue, Nov 29, 2016 at 08:45:13PM +0100, Christian Ullrich wrote: > * Michael Paquier wrote: > > > On Wed, Nov 16, 2016 at 12:45 PM, Christian Ullrich > > wrote: > >> I also did a debug build with 1+2+4 that came in at 84 μs/iteration. > > > > Moved to next CF. Christian,

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-11-29 Thread Christian Ullrich
* Michael Paquier wrote: > On Wed, Nov 16, 2016 at 12:45 PM, Christian Ullrich > wrote: >> I also did a debug build with 1+2+4 that came in at 84 μs/iteration. > > Moved to next CF. Christian, perhaps this patch should have an extra > round of reviews? It is significantly

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-11-28 Thread Michael Paquier
On Wed, Nov 16, 2016 at 12:45 PM, Christian Ullrich wrote: > I also did a debug build with 1+2+4 that came in at 84 μs/iteration. Moved to next CF. Christian, perhaps this patch should have an extra round of reviews? -- Michael -- Sent via pgsql-hackers mailing list

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-11-16 Thread Christian Ullrich
* Noah Misch wrote: > On Tue, Apr 26, 2016 at 07:39:29PM +0200, Christian Ullrich > wrote: > > * Christian Ullrich wrote: > Patch 1 looks good, except that it should be three patches: > > - cosmetic parts: change whitespace and s/0/NULL/ > - remove CloseHandle() call > - probe for debug CRT

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-11-15 Thread Noah Misch
On Tue, Apr 26, 2016 at 07:39:29PM +0200, Christian Ullrich wrote: > * Christian Ullrich wrote: > > >wrong even without considering the debug/release split. If we load a > >compiled extension built with a CRT we have not seen yet, _after_ the > >first call to pgwin32_putenv(), that module's CRT's

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-10-02 Thread Michael Paquier
On Tue, Sep 6, 2016 at 9:36 PM, Michael Paquier wrote: > OK, let's get to the next step of the game and get a committer to look > at this patch. Moved to next CF. It would be good to get a committer on this one. We have come on a conclusion on what to do. Actually,

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-09-06 Thread Michael Paquier
(Just remembered to remove pgsql-committers here). On Tue, Sep 6, 2016 at 9:21 PM, Christian Ullrich wrote: > * Michael Paquier wrote: > >> On Tue, Sep 6, 2016 at 5:36 PM, Christian Ullrich >> wrote: >>> >>> * Michael Paquier wrote: > In order to

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-09-06 Thread Christian Ullrich
* Michael Paquier wrote: On Tue, Sep 6, 2016 at 5:36 PM, Christian Ullrich wrote: * Michael Paquier wrote: In order to avoid any problems with the load and unload windows, my bet goes for 0001, 0002 and 0003, with the last two patches merged together, 0001 being only

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-09-06 Thread Michael Paquier
On Tue, Sep 6, 2016 at 5:36 PM, Christian Ullrich wrote: > * Michael Paquier wrote: >> In order to avoid any problems with the load and unload windows, my >> bet goes for 0001, 0002 and 0003, with the last two patches merged >> together, 0001 being only a set of independent

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-09-06 Thread Christian Ullrich
* Michael Paquier wrote: On Thu, Sep 1, 2016 at 4:03 PM, Christian Ullrich wrote: My conclusion from April stands: The fact that master looks like it does means that there have not been many (or any) complaints about missing cross-module environment variables. If

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-09-06 Thread Michael Paquier
On Thu, Sep 1, 2016 at 4:03 PM, Christian Ullrich wrote: > * Michael Paquier wrote: > >> On Wed, Apr 27, 2016 at 2:39 AM, Christian Ullrich >> wrote: > >>> * Christian Ullrich wrote: > >> And actually, by looking at those patches, isn't it a dangerous

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-09-01 Thread Christian Ullrich
* Michael Paquier wrote: > On Wed, Apr 27, 2016 at 2:39 AM, Christian Ullrich wrote: >> * Christian Ullrich wrote: > And actually, by looking at those patches, isn't it a dangerous > practice to be able to load multiple versions of the same DLL routines > in the same

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-04-26 Thread Christian Ullrich
* Christian Ullrich wrote: wrong even without considering the debug/release split. If we load a compiled extension built with a CRT we have not seen yet, _after_ the first call to pgwin32_putenv(), that module's CRT's view of its environment will be frozen because we will never attempt to

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-04-25 Thread Christian Ullrich
* Christian Ullrich wrote: * Andrew Dunstan wrote: What if both are present? Is a release build prevented from loading a debug dll and vice versa? Debug and release are simply two separate CRTs. If your process contains a module that needs the one, and another that needs the other, you

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-04-25 Thread Christian Ullrich
* Andrew Dunstan wrote: On 04/25/2016 09:27 AM, Christian Ullrich wrote: * Magnus Hagander wrote: On Sun, Apr 24, 2016 at 9:56 PM, Christian Ullrich wrote: Just noticed something. This DLL detection by name has never worked in debug builds where the DLL names end in

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-04-25 Thread Christian Ullrich
* Magnus Hagander wrote: On Sun, Apr 24, 2016 at 9:56 PM, Christian Ullrich wrote: * Magnus Hagander wrote: Add putenv support for msvcrt from Visual Studio 2013 http://git.postgresql.org/pg/commitdiff/9f633b404cb3be6139f8dfdea00538489ffef9ab Just noticed something.

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-04-25 Thread Magnus Hagander
On Sun, Apr 24, 2016 at 9:56 PM, Christian Ullrich wrote: > * Magnus Hagander wrote: > > Add putenv support for msvcrt from Visual Studio 2013 >> >> This was missed when VS 2013 support was added. >> >> Michael Paquier >> >> Branch >> -- >> master >> >> Details >>

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-04-24 Thread Christian Ullrich
* Magnus Hagander wrote: Add putenv support for msvcrt from Visual Studio 2013 This was missed when VS 2013 support was added. Michael Paquier Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9f633b404cb3be6139f8dfdea00538489ffef9ab Just noticed something. This