Re: [HACKERS] pgsql: Add quotes to message

2009-02-23 Thread Gregory Stark

pet...@postgresql.org (Peter Eisentraut) writes:

 Log Message:
 ---
 Add quotes to message

 errdetail(Returned type %s does not match expected type 
!  %s in column \%s\.,
   OidIsValid(returned-attrs[i]-atttypid) ?
   format_type_be(returned-attrs[i]-atttypid) :
   _(dropped_column_type),

I'm surprised there isn't a regression test for this case.


-- 
  Gregory Stark
  EnterpriseDB  http://www.enterprisedb.com
  Ask me about EnterpriseDB's 24x7 Postgres support!

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] pgsql: Add quotes to message

2009-02-23 Thread Peter Eisentraut

Gregory Stark wrote:

pet...@postgresql.org (Peter Eisentraut) writes:


Log Message:
---
Add quotes to message


 errdetail(Returned type %s does not match expected type 
!  %s in column \%s\.,
   OidIsValid(returned-attrs[i]-atttypid) ?
   format_type_be(returned-attrs[i]-atttypid) :
   _(dropped_column_type),

I'm surprised there isn't a regression test for this case.


Me too actually. ;-)  In general, the plpgsql test doesn't appear to 
cover the error paths very well at all.  I changed the wording of about 
50 error messages the other day and only two or three of those appeared 
in a regression test case.


(The test coverage framework doesn't cover the PLs yet, so I don't have 
anything more precise to say on that.)


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers