Re: [HACKERS] pl/python custom exceptions for SPI

2011-03-01 Thread Jan Urbański
On 28/02/11 19:38, Tom Lane wrote: > Peter Eisentraut writes: >> On mån, 2011-02-28 at 12:08 -0500, Tom Lane wrote: >>> I'm seeing a core dump as well as multiple inconsistencies in error >>> message spelling in the plpython regression tests on a Fedora 13 box >>> (python 2.6.4). Several buildfar

Re: [HACKERS] pl/python custom exceptions for SPI

2011-02-28 Thread Tom Lane
Peter Eisentraut writes: > On mån, 2011-02-28 at 12:08 -0500, Tom Lane wrote: >> I'm seeing a core dump as well as multiple inconsistencies in error >> message spelling in the plpython regression tests on a Fedora 13 box >> (python 2.6.4). Several buildfarm critters don't look too happy either.

Re: [HACKERS] pl/python custom exceptions for SPI

2011-02-28 Thread Peter Eisentraut
On mån, 2011-02-28 at 12:08 -0500, Tom Lane wrote: > Peter Eisentraut writes: > > On lör, 2011-02-12 at 11:58 +0100, Jan Urbański wrote: > >> Here's an updated patch with documentation. It's an incremental patch on > >> top of the latest explicit-subxacts version. > > > Committed. > > I'm seeing

Re: [HACKERS] pl/python custom exceptions for SPI

2011-02-28 Thread Tom Lane
Peter Eisentraut writes: > On lör, 2011-02-12 at 11:58 +0100, Jan Urbański wrote: >> Here's an updated patch with documentation. It's an incremental patch on >> top of the latest explicit-subxacts version. > Committed. I'm seeing a core dump as well as multiple inconsistencies in error message

Re: [HACKERS] pl/python custom exceptions for SPI

2011-02-28 Thread Peter Eisentraut
On lör, 2011-02-12 at 11:58 +0100, Jan Urbański wrote: > On 11/02/11 10:53, Jan Urbański wrote: > > On 10/02/11 22:26, Steve Singer wrote: > > Here's an updated patch with documentation. It's an incremental patch on > top of the latest explicit-subxacts version. Committed. -- Sent via pgsql-ha

Re: [HACKERS] pl/python custom exceptions for SPI

2011-02-13 Thread Steve Singer
On 11-02-12 05:58 AM, Jan Urbański wrote: On 11/02/11 10:53, Jan Urbański wrote: On 10/02/11 22:26, Steve Singer wrote: Here's an updated patch with documentation. It's an incremental patch on top of the latest explicit-subxacts version. This looks fine. I've attached a one word documentati

Re: [HACKERS] pl/python custom exceptions for SPI

2011-02-12 Thread Jan Urbański
On 11/02/11 10:53, Jan Urbański wrote: > On 10/02/11 22:26, Steve Singer wrote: Here's an updated patch with documentation. It's an incremental patch on top of the latest explicit-subxacts version. Cheers, Jan diff --git a/doc/src/sgml/plpython.sgml b/doc/src/sgml/plpython.sgml index 87be8c2..aee

Re: [HACKERS] pl/python custom exceptions for SPI

2011-02-11 Thread Jan Urbański
On 10/02/11 22:26, Steve Singer wrote: > On 11-02-10 03:13 PM, Jan Urbański wrote: >> On 10/02/11 20:24, Peter Eisentraut wrote: > > Here is the rest of my review. Thanks! > Ideally char * members of ExceptionMap would be const, but since many > versions of python take a non-const value to PyErr

Re: [HACKERS] pl/python custom exceptions for SPI

2011-02-10 Thread Steve Singer
On 11-02-10 03:13 PM, Jan Urbański wrote: On 10/02/11 20:24, Peter Eisentraut wrote: Here is the rest of my review. Submission Review --- Patch applies cleanly. Documentation is still outstanding but Jan has promised it soon. Usability Review --- We don't have

Re: [HACKERS] pl/python custom exceptions for SPI

2011-02-10 Thread Jan Urbański
On 10/02/11 20:24, Peter Eisentraut wrote: > On sön, 2011-02-06 at 20:44 +0100, Jan Urbański wrote: >> On 27/01/11 23:24, Jan Urbański wrote: >>> On 11/01/11 12:20, Jan Urbański wrote: On 11/01/11 01:27, Tom Lane wrote: > Hannu Krosing writes: >> On 10.1.2011 17:20, Jan Urbański wrote

Re: [HACKERS] pl/python custom exceptions for SPI

2011-02-10 Thread Peter Eisentraut
On sön, 2011-02-06 at 20:44 +0100, Jan Urbański wrote: > On 27/01/11 23:24, Jan Urbański wrote: > > On 11/01/11 12:20, Jan Urbański wrote: > >> On 11/01/11 01:27, Tom Lane wrote: > >>> Hannu Krosing writes: > On 10.1.2011 17:20, Jan Urbański wrote: > > I changed that patch to use Perl ins

Re: [HACKERS] pl/python custom exceptions for SPI

2011-02-06 Thread Jan Urbański
On 27/01/11 23:24, Jan Urbański wrote: > On 11/01/11 12:20, Jan Urbański wrote: >> On 11/01/11 01:27, Tom Lane wrote: >>> Hannu Krosing writes: On 10.1.2011 17:20, Jan Urbański wrote: > I changed that patch to use Perl instead of sed to generate the > exceptions, which should be a mor

Re: [HACKERS] pl/python custom exceptions for SPI

2011-01-27 Thread Jan Urbański
On 11/01/11 12:20, Jan Urbański wrote: > On 11/01/11 01:27, Tom Lane wrote: >> Hannu Krosing writes: >>> On 10.1.2011 17:20, Jan Urbański wrote: I changed that patch to use Perl instead of sed to generate the exceptions, which should be a more portable. Updated as an incremental patch o

Re: [HACKERS] pl/python custom exceptions for SPI

2011-01-11 Thread Jan Urbański
On 11/01/11 01:27, Tom Lane wrote: > Hannu Krosing writes: >> On 10.1.2011 17:20, Jan Urbański wrote: >>> I changed that patch to use Perl instead of sed to generate the >>> exceptions, which should be a more portable. > >> Why not python ? > > Because we're not adding even more different tool r

Re: [HACKERS] pl/python custom exceptions for SPI

2011-01-10 Thread Tom Lane
Hannu Krosing writes: > On 10.1.2011 17:20, Jan Urbański wrote: >> I changed that patch to use Perl instead of sed to generate the >> exceptions, which should be a more portable. > Why not python ? Because we're not adding even more different tool requirements to the build process. Perl is wha

Re: [HACKERS] pl/python custom exceptions for SPI

2011-01-10 Thread Hannu Krosing
On 10.1.2011 17:20, Jan Urbański wrote: On 23/12/10 15:40, Jan Urbański wrote: Here's a patch implementing custom Python exceptions for SPI errors mentioned in http://archives.postgresql.org/pgsql-hackers/2010-12/msg01991.php. It's an incremental patch on top of the explicit-subxacts patch sent

Re: [HACKERS] pl/python custom exceptions for SPI

2011-01-10 Thread Jan Urbański
On 23/12/10 15:40, Jan Urbański wrote: > Here's a patch implementing custom Python exceptions for SPI errors > mentioned in > http://archives.postgresql.org/pgsql-hackers/2010-12/msg01991.php. It's > an incremental patch on top of the explicit-subxacts patch sent eariler. I changed that patch to u

[HACKERS] pl/python custom exceptions for SPI

2010-12-23 Thread Jan Urbański
Here's a patch implementing custom Python exceptions for SPI errors mentioned in http://archives.postgresql.org/pgsql-hackers/2010-12/msg01991.php. It's an incremental patch on top of the explicit-subxacts patch sent eariler. Git branch for this patch: https://github.com/wulczer/postgres/tree/cust