Re: [HACKERS] plpgsql: open for execute - add USING clause

2010-01-18 Thread Tom Lane
Pavel Stehule pavel.steh...@gmail.com writes: ok, I accept all comments. revised version are attached. Applied with minor editorialization. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] plpgsql: open for execute - add USING clause

2010-01-18 Thread Pavel Stehule
2010/1/19 Tom Lane t...@sss.pgh.pa.us: Pavel Stehule pavel.steh...@gmail.com writes: ok, I accept all comments. revised version are attached. Applied with minor editorialization. thank you Pavel                        regards, tom lane -- Sent via pgsql-hackers mailing list

Re: [HACKERS] plpgsql: open for execute - add USING clause

2010-01-13 Thread Pavel Stehule
2010/1/12 Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp: Hi, I'm reviewing OPEN FOR EXECUTE USING patch and have a couple of trivial comments. Pavel Stehule pavel.steh...@gmail.com wrote: this small patch add missing USING clause to OPEN FOR EXECUTE statement + cleaning part of

Re: [HACKERS] plpgsql: open for execute - add USING clause

2010-01-13 Thread Takahiro Itagaki
Pavel Stehule pavel.steh...@gmail.com wrote: ok, I accept all comments. revised version are attached. Good. This patch is ready to commit. I'll do it soon if no objections. BTW, I found inconsistent parameter dumps in the codes. Some of them add '$', but others does not. Are they

Re: [HACKERS] plpgsql: open for execute - add USING clause

2010-01-13 Thread Pavel Stehule
2010/1/14 Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp: Pavel Stehule pavel.steh...@gmail.com wrote: ok, I accept all comments. revised version are attached. Good. This patch is ready to commit. I'll do it soon if no objections. BTW, I found inconsistent parameter dumps in the codes.

Re: [HACKERS] plpgsql: open for execute - add USING clause

2010-01-12 Thread Takahiro Itagaki
Hi, I'm reviewing OPEN FOR EXECUTE USING patch and have a couple of trivial comments. Pavel Stehule pavel.steh...@gmail.com wrote: this small patch add missing USING clause to OPEN FOR EXECUTE statement + cleaning part of exec_stmt_open function - Can we use read_sql_expression2() instead of

[HACKERS] plpgsql: open for execute - add USING clause

2009-11-17 Thread Pavel Stehule
Hello, this small patch add missing USING clause to OPEN FOR EXECUTE statement + cleaning part of exec_stmt_open function see http://archives.postgresql.org/pgsql-hackers/2009-11/msg00713.php Regards Pavel Stehule *** ./doc/src/sgml/plpgsql.sgml.orig 2009-11-13 23:43:39.0 +0100 ---

Re: [HACKERS] plpgsql: open for execute - add USING clause

2009-11-17 Thread Robert Haas
On Tue, Nov 17, 2009 at 3:04 PM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello, this small patch add missing USING clause to OPEN FOR EXECUTE statement + cleaning part of exec_stmt_open function see http://archives.postgresql.org/pgsql-hackers/2009-11/msg00713.php This is now the

Re: [HACKERS] plpgsql: open for execute - add USING clause

2009-11-17 Thread Pavel Stehule
2009/11/17 Robert Haas robertmh...@gmail.com: On Tue, Nov 17, 2009 at 3:04 PM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello, this small patch add missing USING clause to OPEN FOR EXECUTE statement + cleaning part of exec_stmt_open function see

Re: [HACKERS] plpgsql: open for execute - add USING clause

2009-11-17 Thread Pavel Stehule
2009/11/17 Pavel Stehule pavel.steh...@gmail.com: 2009/11/17 Robert Haas robertmh...@gmail.com: On Tue, Nov 17, 2009 at 3:04 PM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello, this small patch add missing USING clause to OPEN FOR EXECUTE statement + cleaning part of exec_stmt_open

Re: [HACKERS] plpgsql: open for execute - add USING clause

2009-11-17 Thread Kevin Grittner
Pavel Stehule pavel.steh...@gmail.com wrote: 2009/11/17 Robert Haas robertmh...@gmail.com: This is now the fourth patch you've submitted since the start of the CommitFest... These patches are for next commitfest. What I know, the current commitfest is closed for new patches. Is it ok?

Re: [HACKERS] plpgsql: open for execute - add USING clause

2009-11-17 Thread Pavel Stehule
2009/11/17 Kevin Grittner kevin.gritt...@wicourts.gov: Pavel Stehule pavel.steh...@gmail.com wrote: 2009/11/17 Robert Haas robertmh...@gmail.com: This is now the fourth patch you've submitted since the start of the CommitFest... These patches are for next commitfest. What I know, the

Re: [HACKERS] plpgsql: open for execute - add USING clause

2009-11-17 Thread Joshua D. Drake
On Tue, 2009-11-17 at 14:33 -0600, Kevin Grittner wrote: Pavel Stehule pavel.steh...@gmail.com wrote: 2009/11/17 Robert Haas robertmh...@gmail.com: This is now the fourth patch you've submitted since the start of the CommitFest... These patches are for next commitfest. What I

Re: [HACKERS] plpgsql: open for execute - add USING clause

2009-11-17 Thread Pavel Stehule
2009/11/17 Joshua D. Drake j...@commandprompt.com: On Tue, 2009-11-17 at 14:33 -0600, Kevin Grittner wrote: Pavel Stehule pavel.steh...@gmail.com wrote: 2009/11/17 Robert Haas robertmh...@gmail.com: This is now the fourth patch you've submitted since the start of the CommitFest...

Re: [HACKERS] plpgsql: open for execute - add USING clause

2009-11-17 Thread Kevin Grittner
Pavel Stehule pavel.steh...@gmail.com wrote: I never sent these (last two) patches to THIS commitfest. Is it clean? Counting the In Progress commitfest and the two preceding ones, you have submitted nine patches and contributed to the review of none. Surely you noticed recent threads about

Re: [HACKERS] plpgsql: open for execute - add USING clause

2009-11-17 Thread Joshua D. Drake
On Tue, 2009-11-17 at 15:40 -0600, Kevin Grittner wrote: Pavel Stehule pavel.steh...@gmail.com wrote: I never sent these (last two) patches to THIS commitfest. Is it clean? I'm sure it would be much appreciated, and help to alleviate the frustration and burnout of some other

Re: [HACKERS] plpgsql: open for execute - add USING clause

2009-11-17 Thread Greg Smith
Pavel Stehule wrote: I don't wont to apply these patches tomorrow, I don't sending these patches for last moment. If I have to wait one weak or two weeks, ok. Declare it. I'll respect it. But actually I respecting all rules, what I know. If you're sending stuff intended for the next

Re: [HACKERS] plpgsql: open for execute - add USING clause

2009-11-17 Thread Robert Haas
On Tue, Nov 17, 2009 at 5:34 PM, Greg Smith g...@2ndquadrant.com wrote: Pavel Stehule wrote: I don't wont to apply these patches tomorrow, I don't sending these patches for last moment. If I have to wait one weak or two weeks, ok. Declare it. I'll respect it. But actually I respecting all

Re: [HACKERS] plpgsql: open for execute - add USING clause

2009-11-17 Thread Pavel Stehule
2009/11/17 Joshua D. Drake j...@commandprompt.com: On Tue, 2009-11-17 at 15:40 -0600, Kevin Grittner wrote: Pavel Stehule pavel.steh...@gmail.com wrote: I never sent these (last two) patches to THIS commitfest. Is it clean? I'm sure it would be much appreciated, and help to alleviate the

Re: [HACKERS] plpgsql: open for execute - add USING clause

2009-11-17 Thread Pavel Stehule
2009/11/17 Robert Haas robertmh...@gmail.com: On Tue, Nov 17, 2009 at 5:34 PM, Greg Smith g...@2ndquadrant.com wrote: Pavel Stehule wrote: I don't wont to apply these patches tomorrow, I don't sending these patches for last moment. If I have to wait one weak or two weeks, ok. Declare it.