Re: [HACKERS] plpgsql - additional extra checks

2017-09-12 Thread Pavel Stehule
2017-09-13 1:42 GMT+02:00 Daniel Gustafsson : > > On 08 Apr 2017, at 15:46, David Steele wrote: > > > >> On 1/13/17 6:55 AM, Marko Tiikkaja wrote: > >>> On Fri, Jan 13, 2017 at 2:46 AM, Jim Nasby >>>

Re: [HACKERS] plpgsql - additional extra checks

2017-09-12 Thread Daniel Gustafsson
> On 08 Apr 2017, at 15:46, David Steele wrote: > >> On 1/13/17 6:55 AM, Marko Tiikkaja wrote: >>> On Fri, Jan 13, 2017 at 2:46 AM, Jim Nasby >> > wrote: >>> >>>On 1/11/17 5:54 AM, Pavel Stehule wrote: >>> >>>

Re: [HACKERS] plpgsql - additional extra checks

2017-04-08 Thread David Steele
> On 1/13/17 6:55 AM, Marko Tiikkaja wrote: >> On Fri, Jan 13, 2017 at 2:46 AM, Jim Nasby > > wrote: >> >> On 1/11/17 5:54 AM, Pavel Stehule wrote: >> >> +too_many_rows >> + >> + >> +

Re: [HACKERS] plpgsql - additional extra checks

2017-03-16 Thread David Steele
On 1/13/17 6:55 AM, Marko Tiikkaja wrote: > On Fri, Jan 13, 2017 at 2:46 AM, Jim Nasby > wrote: > > On 1/11/17 5:54 AM, Pavel Stehule wrote: > > +too_many_rows > + > + > + When

Re: [HACKERS] plpgsql - additional extra checks

2017-01-13 Thread Marko Tiikkaja
On Fri, Jan 13, 2017 at 2:46 AM, Jim Nasby wrote: > On 1/11/17 5:54 AM, Pavel Stehule wrote: > >> +too_many_rows >> + >> + >> + When result is assigned to a variable by INTO >> clause, >> + checks if query returns more than one row. In this case

Re: [HACKERS] plpgsql - additional extra checks

2017-01-13 Thread Pavel Stehule
2017-01-13 2:46 GMT+01:00 Jim Nasby : > On 1/11/17 5:54 AM, Pavel Stehule wrote: > >> +too_many_rows >> + >> + >> + When result is assigned to a variable by INTO >> clause, >> + checks if query returns more than one row. In this case the >>

Re: [HACKERS] plpgsql - additional extra checks

2017-01-12 Thread Pavel Stehule
2017-01-13 2:46 GMT+01:00 Jim Nasby : > On 1/11/17 5:54 AM, Pavel Stehule wrote: > >> +too_many_rows >> + >> + >> + When result is assigned to a variable by INTO >> clause, >> + checks if query returns more than one row. In this case the >>

Re: [HACKERS] plpgsql - additional extra checks

2017-01-12 Thread Jim Nasby
On 1/11/17 5:54 AM, Pavel Stehule wrote: +too_many_rows + + + When result is assigned to a variable by INTO clause, + checks if query returns more than one row. In this case the assignment + is not deterministic usually - and it can be signal some issues in design.

Re: [HACKERS] plpgsql - additional extra checks

2017-01-11 Thread Pavel Stehule
2017-01-11 15:08 GMT+01:00 Marko Tiikkaja : > On Wed, Jan 11, 2017 at 2:54 PM, Pavel Stehule > wrote: > >> 1. strict_multi_assignment - checks the number of target variables and >> source values. >> > > I've proposed this before (maybe around a year ago),

Re: [HACKERS] plpgsql - additional extra checks

2017-01-11 Thread Marko Tiikkaja
On Wed, Jan 11, 2017 at 2:54 PM, Pavel Stehule wrote: > 1. strict_multi_assignment - checks the number of target variables and > source values. > I've proposed this before (maybe around a year ago), except the checks were done at parse time, rather than runtime. I much

[HACKERS] plpgsql - additional extra checks

2017-01-11 Thread Pavel Stehule
Hi I am starting new thread for this patch (related to merging some ideas from plpgsql2 project thread). Here is simple patch with two new extra_warnings, extra_errors checks 1. strict_multi_assignment - checks the number of target variables and source values. 2. too_many_rows - checks if