Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-05-01 Thread Bruce Momjian
On Fri, May 1, 2015 at 05:25:53AM +0200, Pavel Stehule wrote: It is done Uh, I am not sure why you say that as I don't see any commit related to this. Can you show me the commit? --- Dne 1.5.2015 3:11 napsal uživatel

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-05-01 Thread Petr Jelinek
On 01/05/15 15:01, Bruce Momjian wrote: On Fri, May 1, 2015 at 05:25:53AM +0200, Pavel Stehule wrote: It is done Uh, I am not sure why you say that as I don't see any commit related to this. Can you show me the commit? 865f14a2d31af23a05bbf2df04c274629c5d5c4d -- Petr Jelinek

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-05-01 Thread Bruce Momjian
On Fri, May 1, 2015 at 03:13:28PM +0200, Petr Jelinek wrote: On 01/05/15 15:01, Bruce Momjian wrote: On Fri, May 1, 2015 at 05:25:53AM +0200, Pavel Stehule wrote: It is done Uh, I am not sure why you say that as I don't see any commit related to this. Can you show me the commit?

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-05-01 Thread Petr Jelinek
On 01/05/15 15:17, Bruce Momjian wrote: On Fri, May 1, 2015 at 03:13:28PM +0200, Petr Jelinek wrote: On 01/05/15 15:01, Bruce Momjian wrote: On Fri, May 1, 2015 at 05:25:53AM +0200, Pavel Stehule wrote: It is done Uh, I am not sure why you say that as I don't see any commit related to

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-05-01 Thread Robert Haas
On Thu, Apr 30, 2015 at 9:11 PM, Bruce Momjian br...@momjian.us wrote: On Tue, Mar 10, 2015 at 02:51:30PM -0400, Robert Haas wrote: On Tue, Mar 10, 2015 at 2:32 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 1. funcname_signature_string 2. get_rule_expr Thanks. Patch attached. I'll

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-04-30 Thread Bruce Momjian
On Tue, Mar 10, 2015 at 02:51:30PM -0400, Robert Haas wrote: On Tue, Mar 10, 2015 at 2:32 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 1. funcname_signature_string 2. get_rule_expr Thanks. Patch attached. I'll commit this if there are no objections. Robert, are you going to apply

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-04-30 Thread Pavel Stehule
It is done Dne 1.5.2015 3:11 napsal uživatel Bruce Momjian br...@momjian.us: On Tue, Mar 10, 2015 at 02:51:30PM -0400, Robert Haas wrote: On Tue, Mar 10, 2015 at 2:32 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 1. funcname_signature_string 2. get_rule_expr Thanks. Patch

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-03-12 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Tue, Mar 10, 2015 at 11:50 AM, Tom Lane t...@sss.pgh.pa.us wrote: Was there any consideration given to whether ruleutils should start printing NamedArgExprs with =? Or do we think that needs to wait? I have to

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-03-12 Thread Tom Lane
Kevin Grittner kgri...@ymail.com writes: Tom Lane t...@sss.pgh.pa.us wrote: Presumably we are going to change it at some point; maybe we should just do it rather than waiting another 5 years. +1 It has been deprecated long enough that I don't see the point of waiting. Uh, just to clarify,

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-03-12 Thread Pavel Stehule
2015-03-10 17:07 GMT+01:00 Petr Jelinek p...@2ndquadrant.com: On 10/03/15 17:01, Pavel Stehule wrote: 2015-03-10 16:50 GMT+01:00 Tom Lane t...@sss.pgh.pa.us mailto:t...@sss.pgh.pa.us: Robert Haas robertmh...@gmail.com mailto:robertmh...@gmail.com writes: Committed with a

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-03-10 Thread Robert Haas
On Tue, Mar 10, 2015 at 11:50 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Thu, Feb 19, 2015 at 3:15 PM, Pavel Stehule pavel.steh...@gmail.com wrote: I am marking this as Ready For Committer, the patch is trivial and works as expected, there is nothing

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-03-10 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Tue, Mar 10, 2015 at 11:50 AM, Tom Lane t...@sss.pgh.pa.us wrote: Was there any consideration given to whether ruleutils should start printing NamedArgExprs with =? Or do we think that needs to wait? I have to admit that I didn't consider that.

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-03-10 Thread Robert Haas
On Thu, Feb 19, 2015 at 3:15 PM, Pavel Stehule pavel.steh...@gmail.com wrote: I am marking this as Ready For Committer, the patch is trivial and works as expected, there is nothing to be added to it IMHO. The = operator was deprecated for several years so it should not be too controversial

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-03-10 Thread Petr Jelinek
On 10/03/15 17:01, Pavel Stehule wrote: 2015-03-10 16:50 GMT+01:00 Tom Lane t...@sss.pgh.pa.us mailto:t...@sss.pgh.pa.us: Robert Haas robertmh...@gmail.com mailto:robertmh...@gmail.com writes: Committed with a few documentation tweaks. Was there any consideration given to

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-03-10 Thread Pavel Stehule
2015-03-10 16:50 GMT+01:00 Tom Lane t...@sss.pgh.pa.us: Robert Haas robertmh...@gmail.com writes: On Thu, Feb 19, 2015 at 3:15 PM, Pavel Stehule pavel.steh...@gmail.com wrote: I am marking this as Ready For Committer, the patch is trivial and works as expected, there is nothing to be

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-03-10 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Feb 19, 2015 at 3:15 PM, Pavel Stehule pavel.steh...@gmail.com wrote: I am marking this as Ready For Committer, the patch is trivial and works as expected, there is nothing to be added to it IMHO. The = operator was deprecated for several

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-03-10 Thread Pavel Stehule
2015-03-10 19:02 GMT+01:00 Tom Lane t...@sss.pgh.pa.us: Kevin Grittner kgri...@ymail.com writes: Tom Lane t...@sss.pgh.pa.us wrote: Presumably we are going to change it at some point; maybe we should just do it rather than waiting another 5 years. +1 It has been deprecated long

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-03-10 Thread Robert Haas
On Tue, Mar 10, 2015 at 2:32 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 1. funcname_signature_string 2. get_rule_expr Thanks. Patch attached. I'll commit this if there are no objections. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-02-19 Thread Pavel Stehule
2015-02-19 16:06 GMT+01:00 Petr Jelinek p...@2ndquadrant.com: On 19/01/15 17:14, Pavel Stehule wrote: 2015-01-19 14:27 GMT+01:00 Robert Haas robertmh...@gmail.com mailto:robertmh...@gmail.com: On Mon, Jan 19, 2015 at 2:59 AM, Pavel Stehule pavel.steh...@gmail.com

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-02-19 Thread Petr Jelinek
On 19/01/15 17:14, Pavel Stehule wrote: 2015-01-19 14:27 GMT+01:00 Robert Haas robertmh...@gmail.com mailto:robertmh...@gmail.com: On Mon, Jan 19, 2015 at 2:59 AM, Pavel Stehule pavel.steh...@gmail.com mailto:pavel.steh...@gmail.com wrote: I think you should just remove the

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-01-19 Thread Pavel Stehule
2015-01-19 4:54 GMT+01:00 Robert Haas robertmh...@gmail.com: On Sat, Jan 17, 2015 at 8:27 PM, Pavel Stehule pavel.steh...@gmail.com wrote: two years a operator = is marked as deprecated (from PostgreSQL 9.2). Isn't time to use it for named parameters now (for PostgreSQL 9.5) ? I'm cool

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-01-19 Thread Alvaro Herrera
Pavel Stehule wrote: It looks so quoting doesn't help here + CREATE OPERATOR = ( +leftarg = int8,-- right unary +procedure = numeric_fac + ); + ERROR: syntax error at or near ( + LINE 1: CREATE OPERATOR = ( + ^ Does it work to use

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-01-19 Thread Robert Haas
On Mon, Jan 19, 2015 at 2:59 AM, Pavel Stehule pavel.steh...@gmail.com wrote: I think you should just remove the WARNING, not change it to an error. If somebody wants to quote the operator name to be able to continue using it, I think that's OK. It looks so quoting doesn't help here +

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-01-19 Thread Pavel Stehule
2015-01-19 14:30 GMT+01:00 Alvaro Herrera alvhe...@2ndquadrant.com: Pavel Stehule wrote: It looks so quoting doesn't help here + CREATE OPERATOR = ( +leftarg = int8,-- right unary +procedure = numeric_fac + ); + ERROR: syntax error at or near ( + LINE 1: CREATE

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-01-19 Thread Pavel Stehule
2015-01-19 14:27 GMT+01:00 Robert Haas robertmh...@gmail.com: On Mon, Jan 19, 2015 at 2:59 AM, Pavel Stehule pavel.steh...@gmail.com wrote: I think you should just remove the WARNING, not change it to an error. If somebody wants to quote the operator name to be able to continue using it,

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-01-18 Thread Pavel Stehule
2015-01-19 4:54 GMT+01:00 Robert Haas robertmh...@gmail.com: On Sat, Jan 17, 2015 at 8:27 PM, Pavel Stehule pavel.steh...@gmail.com wrote: two years a operator = is marked as deprecated (from PostgreSQL 9.2). Isn't time to use it for named parameters now (for PostgreSQL 9.5) ? I'm cool

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-01-18 Thread Robert Haas
On Sat, Jan 17, 2015 at 8:27 PM, Pavel Stehule pavel.steh...@gmail.com wrote: two years a operator = is marked as deprecated (from PostgreSQL 9.2). Isn't time to use it for named parameters now (for PostgreSQL 9.5) ? I'm cool with that. It's possible that there are installations out there

[HACKERS] proposal: disallow operator = and use it for named parameters

2015-01-17 Thread Pavel Stehule
Hello two years a operator = is marked as deprecated (from PostgreSQL 9.2). Isn't time to use it for named parameters now (for PostgreSQL 9.5) ? I am sending a implementation where syntax based on = symbol is second (but preferred) variant of := syntax .. syntax := will be supported still.