Re: [HACKERS] psql's \r broken since e984ef5861d

2017-07-19 Thread Julien Rouhaud
On 20/07/2017 04:24, Tom Lane wrote: > I wrote: >> Ah. I don't feel like trawling the archives for the discussion right now, >> but I believe this was an intentional change to make the behavior more >> consistent. > > Oh ... a quick look in the commit log finds the relevant discussion: > https://

Re: [HACKERS] psql's \r broken since e984ef5861d

2017-07-19 Thread Tom Lane
I wrote: > Ah. I don't feel like trawling the archives for the discussion right now, > but I believe this was an intentional change to make the behavior more > consistent. Oh ... a quick look in the commit log finds the relevant discussion: https://www.postgresql.org/message-id/flat/9b4ea968-753f

Re: [HACKERS] psql's \r broken since e984ef5861d

2017-07-19 Thread Tom Lane
Julien Rouhaud writes: > On 20/07/2017 03:34, Tom Lane wrote: >> Works for me. Please describe exactly what misbehavior you're seeing. > Here's a simple test case, last \p still show the query buffer: Ah. I don't feel like trawling the archives for the discussion right now, but I believe this

Re: [HACKERS] psql's \r broken since e984ef5861d

2017-07-19 Thread Julien Rouhaud
On 20/07/2017 03:34, Tom Lane wrote: > Julien Rouhaud writes: >> Unless I miss something, \r isn't working anymore, > > Works for me. Please describe exactly what misbehavior you're seeing. > What libreadline or libedit version are you using? > I have libreadline 7.0_p3. Here's a simple test

Re: [HACKERS] psql's \r broken since e984ef5861d

2017-07-19 Thread Tom Lane
Julien Rouhaud writes: > Unless I miss something, \r isn't working anymore, Works for me. Please describe exactly what misbehavior you're seeing. What libreadline or libedit version are you using? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers

[HACKERS] psql's \r broken since e984ef5861d

2017-07-19 Thread Julien Rouhaud
Hello, Unless I miss something, \r isn't working anymore, since exec_command_print() fallback to display previous_buf if query_buf has been freed. Trivial patch to fix issue (free both buffers in exec_command_reset()) attached. Regards. -- Julien Rouhaud diff --git a/src/bin/psql/command.c b/s