Re: [HACKERS] remove checkpoint_warning

2016-07-13 Thread Robert Haas
On Tue, Jul 12, 2016 at 3:19 AM, Magnus Hagander wrote: > +1, this is a useful warning. +1. I'd like to see more people turn log_checkpoints=on, and I often ask customers to do that when they're having systemic performance problems. But this warning regularly alerts me to

Re: [HACKERS] remove checkpoint_warning

2016-07-12 Thread PostgreSQL - Hans-Jürgen Schönig
On 07/09/2016 11:12 PM, Tom Lane wrote: Alvaro Herrera writes: the checkpoint_warning feature was added by commit 2986aa6a668bce3cfb836 in November 2002 when we didn't have any logging of checkpointing at all. I propose to remove it: surely anyone who cares about

Re: [HACKERS] remove checkpoint_warning

2016-07-12 Thread Magnus Hagander
On Tue, Jul 12, 2016 at 3:32 AM, Craig Ringer wrote: > On 11 July 2016 at 22:25, Stephen Frost wrote: > >> * Tom Lane (t...@sss.pgh.pa.us) wrote: >> > Alvaro Herrera writes: >> > > the checkpoint_warning feature was added by

Re: [HACKERS] remove checkpoint_warning

2016-07-11 Thread Craig Ringer
On 11 July 2016 at 22:25, Stephen Frost wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > Alvaro Herrera writes: > > > the checkpoint_warning feature was added by commit > 2986aa6a668bce3cfb836 > > > in November 2002 when we didn't have any

Re: [HACKERS] remove checkpoint_warning

2016-07-11 Thread Stephen Frost
* Andres Freund (and...@anarazel.de) wrote: > On 2016-07-11 11:14:29 -0700, Peter Geoghegan wrote: > > On Mon, Jul 11, 2016 at 7:25 AM, Stephen Frost wrote: > > >> Or in short, this may be a fine change to make, but I don't like your > > >> argument for it. > > > > > > I don't

Re: [HACKERS] remove checkpoint_warning

2016-07-11 Thread Andres Freund
On 2016-07-11 11:14:29 -0700, Peter Geoghegan wrote: > On Mon, Jul 11, 2016 at 7:25 AM, Stephen Frost wrote: > >> Or in short, this may be a fine change to make, but I don't like your > >> argument for it. > > > > I don't agree that it's sensible to get rid of. Having just >

Re: [HACKERS] remove checkpoint_warning

2016-07-11 Thread Peter Geoghegan
On Mon, Jul 11, 2016 at 7:25 AM, Stephen Frost wrote: >> Or in short, this may be a fine change to make, but I don't like your >> argument for it. > > I don't agree that it's sensible to get rid of. Having just > log_checkpoints will have the logs filled with checkpoints

Re: [HACKERS] remove checkpoint_warning

2016-07-11 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > Alvaro Herrera writes: > > the checkpoint_warning feature was added by commit 2986aa6a668bce3cfb836 > > in November 2002 when we didn't have any logging of checkpointing at > > all. I propose to remove it: surely anyone who cares

Re: [HACKERS] remove checkpoint_warning

2016-07-09 Thread Tom Lane
Alvaro Herrera writes: > the checkpoint_warning feature was added by commit 2986aa6a668bce3cfb836 > in November 2002 when we didn't have any logging of checkpointing at > all. I propose to remove it: surely anyone who cares about analyzing > checkpointing behavior

Re: [HACKERS] remove checkpoint_warning

2016-07-09 Thread Andres Freund
On 2016-07-09 16:46:32 -0400, Alvaro Herrera wrote: > the checkpoint_warning feature was added by commit 2986aa6a668bce3cfb836 > in November 2002 when we didn't have any logging of checkpointing at > all. I propose to remove it: surely anyone who cares about analyzing > checkpointing behavior

[HACKERS] remove checkpoint_warning

2016-07-09 Thread Alvaro Herrera
the checkpoint_warning feature was added by commit 2986aa6a668bce3cfb836 in November 2002 when we didn't have any logging of checkpointing at all. I propose to remove it: surely anyone who cares about analyzing checkpointing behavior nowadays is using the log_checkpoint feature instead, which