Re: [HACKERS] review: pgbench - aggregation of info written into log

>>> On Thu, Jan 17, 2013 at 7:43 PM, Tatsuo Ishii wrote: So if my understating is correct, 1)Tomas Vondra commits to work on Windows support for 9.4, 2)on the assumption that one of Andrew Dunstan, Dave Page or Magnus Hagander will help him in Windows development. Ok?

Re: [HACKERS] review: pgbench - aggregation of info written into log

>> On Thu, Jan 17, 2013 at 7:43 PM, Tatsuo Ishii wrote: >>> So if my understating is correct, 1)Tomas Vondra commits to work on >>> Windows support for 9.4, 2)on the assumption that one of Andrew >>> Dunstan, Dave Page or Magnus Hagander will help him in Windows >>> development. >>> >>> Ok? If so,

Re: [HACKERS] review: pgbench - aggregation of info written into log

> On Thu, Jan 17, 2013 at 7:43 PM, Tatsuo Ishii wrote: >> So if my understating is correct, 1)Tomas Vondra commits to work on >> Windows support for 9.4, 2)on the assumption that one of Andrew >> Dunstan, Dave Page or Magnus Hagander will help him in Windows >> development. >> >> Ok? If so, I can

Re: [HACKERS] review: pgbench - aggregation of info written into log

On Thu, Jan 17, 2013 at 7:43 PM, Tatsuo Ishii wrote: > So if my understating is correct, 1)Tomas Vondra commits to work on > Windows support for 9.4, 2)on the assumption that one of Andrew > Dunstan, Dave Page or Magnus Hagander will help him in Windows > development. > > Ok? If so, I can commit t

Re: [HACKERS] review: pgbench - aggregation of info written into log

> On Thu, Jan 17, 2013 at 2:29 PM, Andrew Dunstan wrote: >> >> On 01/17/2013 06:04 AM, Tomas Vondra wrote: >>> >>> The problem is I have access to absolutely no Windows machines, >>> not mentioning the development tools (and that I have no clue about it). >>> >>> I vaguely remember there were peop

Re: [HACKERS] review: pgbench - aggregation of info written into log

On Thu, Jan 17, 2013 at 2:29 PM, Andrew Dunstan wrote: > > On 01/17/2013 06:04 AM, Tomas Vondra wrote: >> >> The problem is I have access to absolutely no Windows machines, >> not mentioning the development tools (and that I have no clue about it). >> >> I vaguely remember there were people on thi

Re: [HACKERS] review: pgbench - aggregation of info written into log

On Thu, Jan 17, 2013 at 1:29 PM, Andrew Dunstan wrote: > > On 01/17/2013 06:04 AM, Tomas Vondra wrote: >> >> The problem is I have access to absolutely no Windows machines, >> not mentioning the development tools (and that I have no clue about it). >> >> I vaguely remember there were people on thi

Re: [HACKERS] review: pgbench - aggregation of info written into log

On 01/17/2013 06:04 AM, Tomas Vondra wrote: The problem is I have access to absolutely no Windows machines, not mentioning the development tools (and that I have no clue about it). I vaguely remember there were people on this list doing Windows development on a virtual machine or something. An

Re: [HACKERS] review: pgbench - aggregation of info written into log

On 01/17/2013 06:11 AM, Tomas Vondra wrote: Dne 17.01.2013 11:16, Magnus Hagander napsal: On Thu, Jan 17, 2013 at 11:09 AM, Dave Page wrote: On Thu, Jan 17, 2013 at 9:36 AM, Magnus Hagander wrote: We have committed platform-specific features before, but generally only when it's not *possibl

Re: [HACKERS] review: pgbench - aggregation of info written into log

Dne 17.01.2013 11:16, Magnus Hagander napsal: On Thu, Jan 17, 2013 at 11:09 AM, Dave Page wrote: On Thu, Jan 17, 2013 at 9:36 AM, Magnus Hagander wrote: We have committed platform-specific features before, but generally only when it's not *possible* to do them for all platforms. For example t

Re: [HACKERS] review: pgbench - aggregation of info written into log

Dne 17.01.2013 10:36, Magnus Hagander napsal: On Thu, Jan 17, 2013 at 2:35 AM, Tatsuo Ishii wrote: This might be way more than we want to do, but there is an article that describes some techniques for doing what seems to be missing (AIUI):

Re: [HACKERS] review: pgbench - aggregation of info written into log

On Thu, Jan 17, 2013 at 11:09 AM, Dave Page wrote: > On Thu, Jan 17, 2013 at 9:36 AM, Magnus Hagander wrote: >> On Thu, Jan 17, 2013 at 2:35 AM, Tatsuo Ishii wrote: >> This might be way more than we want to do, but there is an article >> that describes some techniques for doing what seem

Re: [HACKERS] review: pgbench - aggregation of info written into log

On Thu, Jan 17, 2013 at 9:36 AM, Magnus Hagander wrote: > On Thu, Jan 17, 2013 at 2:35 AM, Tatsuo Ishii wrote: > This might be way more than we want to do, but there is an article > that describes some techniques for doing what seems to be missing > (AIUI): > >

Re: [HACKERS] review: pgbench - aggregation of info written into log

On Thu, Jan 17, 2013 at 2:35 AM, Tatsuo Ishii wrote: This might be way more than we want to do, but there is an article that describes some techniques for doing what seems to be missing (AIUI): >>> Even this would be

Re: [HACKERS] review: pgbench - aggregation of info written into log

>>> This might be way more than we want to do, but there is an article >>> that describes some techniques for doing what seems to be missing >>> (AIUI): >>> >>> >> Even this would be doable, I'm afraid it may not fit in 9.3 if we >> think abo

Re: [HACKERS] review: pgbench - aggregation of info written into log

On 01/16/2013 08:05 PM, Tatsuo Ishii wrote: It seems instr_time.h on Windows simply does not provide current timestamp. From pgbench.c: /* * if transaction finished, record the time it took in the log */ if (logfile && commands[s

Re: [HACKERS] review: pgbench - aggregation of info written into log

>> It seems instr_time.h on Windows simply does not provide current >> timestamp. From pgbench.c: >> >> /* >> * if transaction finished, record the time it took in the log >> */ >> if (logfile && commands[st->state + 1] == NULL) >>

Re: [HACKERS] review: pgbench - aggregation of info written into log

On 01/16/2013 06:48 PM, Tatsuo Ishii wrote: I'm looking into this as a committer. It seems that this is the newest patch and the reviewer(Pavel) stated that it is ready for commit. However, I noticed that this patch adds a Linux/UNIX only feature(not available on Windows). So I would like to as

Re: [HACKERS] review: pgbench - aggregation of info written into log

>> I'm looking into this as a committer. It seems that this is the >> newest patch and the reviewer(Pavel) stated that it is ready for >> commit. However, I noticed that this patch adds a Linux/UNIX only >> feature(not available on Windows). So I would like to ask cores if >> this is ok or not. >

Re: [HACKERS] review: pgbench - aggregation of info written into log

On 01/16/2013 05:59 PM, Tatsuo Ishii wrote: Hi, I'm looking into this as a committer. It seems that this is the newest patch and the reviewer(Pavel) stated that it is ready for commit. However, I noticed that this patch adds a Linux/UNIX only feature(not available on Windows). So I would like

Re: [HACKERS] review: pgbench - aggregation of info written into log

Hi, I'm looking into this as a committer. It seems that this is the newest patch and the reviewer(Pavel) stated that it is ready for commit. However, I noticed that this patch adds a Linux/UNIX only feature(not available on Windows). So I would like to ask cores if this is ok or not. -- Tatsuo Is

[HACKERS] review: pgbench - aggregation of info written into log

Hello this patch was proposed http://archives.postgresql.org/pgsql-hackers/2012-08/msg00817.php and there was no objections * there are no issue with patching * no warnings * code is clean and respect our source code policy * tested without errors My last objections was satisfied - last interval

Re: [HACKERS] review: pgbench - aggregation of info written into log

Hi, attached is a v5 of this patch. Details below: On 8.12.2012 16:33, Andres Freund wrote: > Hi Tomas, > > On 2012-11-27 14:55:59 +0100, Pavel Stehule wrote: >>> attached is a v4 of the patch. There are not many changes, mostly some >>> simple tidying up, except for handling the Windows. > > A

Re: [HACKERS] review: pgbench - aggregation of info written into log

On 8.12.2012 16:33, Andres Freund wrote: > Hi Tomas, > > On 2012-11-27 14:55:59 +0100, Pavel Stehule wrote: >>> attached is a v4 of the patch. There are not many changes, mostly some >>> simple tidying up, except for handling the Windows. > > After a quick look I am not sure what all the talk abo

Re: [HACKERS] review: pgbench - aggregation of info written into log

Hi Tomas, On 2012-11-27 14:55:59 +0100, Pavel Stehule wrote: > > attached is a v4 of the patch. There are not many changes, mostly some > > simple tidying up, except for handling the Windows. After a quick look I am not sure what all the talk about windows is about? instr_time.h seems to provide

Re: [HACKERS] review: pgbench - aggregation of info written into log

Hello 2012/11/12 Tomas Vondra : > Hi, > > attached is a v4 of the patch. There are not many changes, mostly some > simple tidying up, except for handling the Windows. > > After a bit more investigation, it seems to me that we can't really get > the same behavior as in other systems - basically the

Re: [HACKERS] review: pgbench - aggregation of info written into log

Hi, attached is a v4 of the patch. There are not many changes, mostly some simple tidying up, except for handling the Windows. After a bit more investigation, it seems to me that we can't really get the same behavior as in other systems - basically the timestamp is unavailable so we can't log the

[HACKERS] review: pgbench - aggregation of info written into log

Hello I did review of pgbench patch http://archives.postgresql.org/pgsql-hackers/2012-09/msg00737.php * this patch is cleanly patched * I had a problem with doc make[1]: Entering directory `/home/pavel/src/postgresql/doc/src/sgml' openjade -wall -wno-unused-param -wno-empty -wfully-tagged -D .