Re: [HACKERS] review: psql and pset without any arguments

2013-10-03 Thread Robert Haas
On Wed, Oct 2, 2013 at 5:18 AM, Pavel Stehule wrote: > Hello all > > there are no comments, so I'll close this topic > > This feature is ready for commit The patch looks nice and clean, and I like the feature, too. Committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterpr

Re: [HACKERS] review: psql and pset without any arguments

2013-10-02 Thread Pavel Stehule
Hello all there are no comments, so I'll close this topic This feature is ready for commit Regards Pavel Stehule 2013/10/1 Pavel Stehule > Hello all > > I am thinking so almost all is done > > I fixed a help and appended a simple test > > But it is a cosmetic changes. > > Comments? > > Rega

Re: [HACKERS] review: psql and pset without any arguments

2013-10-01 Thread Pavel Stehule
Hello all I am thinking so almost all is done I fixed a help and appended a simple test But it is a cosmetic changes. Comments? Regards Pavel Stehule 2013/9/30 Gilles Darold > Le 30/09/2013 17:35, Peter Eisentraut a écrit : > > Please remove the tabs from the SGML files. > > Done. I've a

Re: [HACKERS] review: psql and pset without any arguments

2013-09-30 Thread Gilles Darold
Le 30/09/2013 17:35, Peter Eisentraut a écrit : > Please remove the tabs from the SGML files. Done. I've also fixed the typo reported by Ian. Here is the attached v4 patch. Thanks a lot for your review. Regards, -- Gilles Darold Administrateur de bases de données http://dalibo.com - http://dal

Re: [HACKERS] review: psql and pset without any arguments

2013-09-30 Thread Peter Eisentraut
Please remove the tabs from the SGML files. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] review: psql and pset without any arguments

2013-09-30 Thread Ian Lawrence Barwick
Hi 2013/9/30 Gilles Darold : (...) > That's right, here is the patch modified with just a little change with > your suggestion: > > if (popt->topt.numericLocale) > printf(_("Locale-adjusted numeric output (%s) is > on.\n"), param); > else >

Re: [HACKERS] review: psql and pset without any arguments

2013-09-30 Thread Gilles Darold
Le 30/09/2013 05:43, Alvaro Herrera a écrit : > Gilles Darold escribió: > >> +else if (strcmp(param, "numericlocale") == 0) >> +{ >> +if (popt->topt.numericLocale) >> +puts(_("Locale-adjusted numeric output (numericlocale) >> is on.")); >> +else

Re: [HACKERS] review: psql and pset without any arguments

2013-09-29 Thread Alvaro Herrera
Gilles Darold escribió: > + else if (strcmp(param, "numericlocale") == 0) > + { > + if (popt->topt.numericLocale) > + puts(_("Locale-adjusted numeric output (numericlocale) > is on.")); > + else > + puts(_("Locale-adjusted nu

Re: [HACKERS] review: psql and pset without any arguments

2013-09-29 Thread Pavel Stehule
> Pavel > > > Hello, > > Sorry for the delay, here is the new patch. The \pset output will look > like follow: > > postgres=# \pset > > Border style (border) is 1. > Target width (columns) unset. > > Expanded display (expanded) is off. > Field separator (fieldsep) is "|". > Default footer (footer)

Re: [HACKERS] review: psql and pset without any arguments

2013-09-29 Thread Gilles Darold
Le 07/09/2013 21:22, Pavel Stehule a écrit : > > > > 2013/9/7 Gilles Darold > > > Le 07/09/2013 10:02, Pavel Stehule a écrit : > > Hello > > > > * patch is cleanly patchable and compilation is without warnings > > * all regression tests passed >

Re: [HACKERS] review: psql and pset without any arguments

2013-09-07 Thread Pavel Stehule
2013/9/7 Gilles Darold > Le 07/09/2013 10:02, Pavel Stehule a écrit : > > Hello > > > > * patch is cleanly patchable and compilation is without warnings > > * all regression tests passed > > * no impact on dump, performance or any current features > > * no comments to programming style > > * we w

Re: [HACKERS] review: psql and pset without any arguments

2013-09-07 Thread Gilles Darold
Le 07/09/2013 10:02, Pavel Stehule a écrit : > Hello > > * patch is cleanly patchable and compilation is without warnings > * all regression tests passed > * no impact on dump, performance or any current features > * no comments to programming style > * we would this feature - it is consistent with

Re: [HACKERS] review: psql and pset without any arguments

2013-09-07 Thread Marc Mamin
> 2) there is only one open question > http://www.postgresql.org/message-id/b6f6fd62f2624c4c9916ac0175d56d880ce00...@jenmbs01.ad.intershop.net > - > there is no clean relation between output and some pset option. > I don't think so Marc' proposal is ideal (these values are not a variables) - >

[HACKERS] review: psql and pset without any arguments

2013-09-07 Thread Pavel Stehule
Hello * patch is cleanly patchable and compilation is without warnings * all regression tests passed * no impact on dump, performance or any current features * no comments to programming style * we would this feature - it is consistent with \set and it gives a fast resume about psql printer settin