Re: [HACKERS] small issue with host names in hba

2012-10-01 Thread Peter Eisentraut
On Tue, 2012-08-14 at 18:52 -0400, Bruce Momjian wrote: > I assume we didn't feel any action was necessary on this issue. I propose the attached patch to reduce the redundant code as discussed. > > --- > > On Thu, Aug 11, 2

Re: [HACKERS] small issue with host names in hba

2012-08-14 Thread Bruce Momjian
I assume we didn't feel any action was necessary on this issue. --- On Thu, Aug 11, 2011 at 01:50:02PM -0400, Tom Lane wrote: > Robert Haas writes: > > On Tue, Aug 9, 2011 at 2:16 PM, Peter Eisentraut wrote: > >> But I'm a

Re: [HACKERS] small issue with host names in hba

2011-08-11 Thread Tom Lane
Robert Haas writes: > On Tue, Aug 9, 2011 at 2:16 PM, Peter Eisentraut wrote: >> But I'm a little confused by what this code is really trying >> to accomplish: ... > I think the intended behavior of NI_NUMERICHOST is to suppress the > name lookup, and return the text format *even if* the name lo

Re: [HACKERS] small issue with host names in hba

2011-08-11 Thread Robert Haas
On Tue, Aug 9, 2011 at 2:16 PM, Peter Eisentraut wrote: > When a host name is used in pg_hba.conf, then we call > pg_getnameinfo_all() to get the host name for the client's IP address, > either in postmaster.c or in hba.c, whichever happens first.  But if the > IP address has no host name, the get

[HACKERS] small issue with host names in hba

2011-08-09 Thread Peter Eisentraut
When a host name is used in pg_hba.conf, then we call pg_getnameinfo_all() to get the host name for the client's IP address, either in postmaster.c or in hba.c, whichever happens first. But if the IP address has no host name, the getnameinfo calls return the IP address in text form, which is then