I wrote:
> That previous approach of adding extra expected files isn't going to
> scale nicely if there are multiple places at risk ... but do we need
> multiple places selecting the sequence contents? I remain of the
> opinion that just omitting the value isn't good testing policy.
Actually, on
Josh Kupershmidt writes:
> Hmph, looks like buildfarm members koi and jaguar are failing make check now:
>
> http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=koi&dt=2011-06-22%2008%3A06%3A00
> due to a difference in sequence.out. I didn't muck with the part about
> SELECT * FROM foo_seq_new
On Wed, Jun 22, 2011 at 9:14 AM, Josh Kupershmidt wrote:
> On Tue, Jun 21, 2011 at 10:58 PM, Robert Haas wrote:
>> Committed the main patch, and your regression tests.
>
> Hmph, looks like buildfarm members koi and jaguar are failing make check now:
> http://www.pgbuildfarm.org/cgi-bin/show_log.
On Tue, Jun 21, 2011 at 10:58 PM, Robert Haas wrote:
> Committed the main patch, and your regression tests.
Hmph, looks like buildfarm members koi and jaguar are failing make check now:
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=koi&dt=2011-06-22%2008%3A06%3A00
due to a difference in s
On Thu, Jun 9, 2011 at 10:27 PM, Josh Kupershmidt wrote:
> On Wed, Jun 8, 2011 at 6:36 PM, Brar Piening wrote:
>> I tried to look at everything and cover everthing but please consider that
>> this is my first review so please have a second look at it!
>
> I took a look at this as well, and I didn
On Wed, Jun 8, 2011 at 6:36 PM, Brar Piening wrote:
> I tried to look at everything and cover everthing but please consider that
> this is my first review so please have a second look at it!
I took a look at this as well, and I didn't encounter any problems
either. The patch is surprisingly small
On Wed, 8 Jun 2011 19:29:42 -0400, Robert Haas
wrote:
You should also change the status to either "Waiting on Author" or
"Ready for Committer" based on the content of the review. I think the
latter would be appropriate since your review seems to have been
favorable.
Well - not being a review pr
On Wed, Jun 8, 2011 at 6:36 PM, Brar Piening wrote:
>>> New patch attached.
>
> Review for '20110607_serial2_v2.diff':
I see you added this review to the CommitFest application - excellent.
You should also change the status to either "Waiting on Author" or
"Ready for Committer" based on the cont
On Jun 8, 2011, at 5:36 PM, Brar Piening wrote:
> Pros
> Mike Pultz (patch author): "since serial4 and serial8 are simply
> pseudo-types- effectively there for convenience, I’d argue that it should
> simply be there for completeness"
> Robert Haas: "We should be trying to put all types on equal f
On Tue, 7 Jun 2011 20:35:12 -0400, Mike Pultz wrote:
New patch attached.
Review for '20110607_serial2_v2.diff':
Submission review
- Is the patch in context diff format?
Yes.
- Does it apply cleanly to the current git master?
Yes.
- Does it include reasonable tests, necessary doc patches,
Yup- it's attached.
Mike
From: Brar Piening [mailto:b...@gmx.de]
Sent: Tuesday, June 07, 2011 6:58 PM
To: Mike Pultz
Cc: pgsql-hackers@postgresql.org
Subject: Re: [HACKERS] smallserial / serial2
On Wed, 20 Apr 2011 21:27:27 -0400, Mike Pultz <mailto:m...@mikepultz.com
Sorry, forgot the documentation- I guess that stuff doesn't magically
happen!
New patch attached.
Mike
From: Brar Piening [mailto:b...@gmx.de]
Sent: Tuesday, June 07, 2011 6:58 PM
To: Mike Pultz
Cc: pgsql-hackers@postgresql.org
Subject: Re: [HACKERS] smallserial / serial2
O
On Wed, 20 Apr 2011 21:27:27 -0400, Mike Pultz wrote:
Can this be added?
Probably not - since it's not a complete patch ;-)
I tried to test this one but was unable to find a complete version of
the patch in my local mail archives and in the official archives
(http://archives.postgresql.or
On Thu, Apr 21, 2011 at 11:06 AM, Mike Pultz wrote:
> And since serial4 and serial8 are simply pseudo-types- effectively there for
> convenience, I’d argue that it should simply be there for completeness- just
> because it may be less used, doesn’t mean it shouldn’t be convenient?
Right now, smal
constraint
between two different types.
Mike
-Original Message-
From: Tom Lane [mailto:t...@sss.pgh.pa.us]
Sent: Thursday, April 21, 2011 10:26 AM
To: Mike Pultz
Cc: pgsql-hackers@postgresql.org
Subject: Re: [HACKERS] smallserial / serial2
"Mike Pultz" < <mailto
"Mike Pultz" writes:
> I use tables all the time that have sequences on smallint's;
> I'd like to simplify my create files by not having to create the sequence
> first, but I also don't want to give up those 2 bytes per column!
A sequence that can only go to 32K doesn't seem all that generally
u
I use tables all the time that have sequences on smallint's;
I'd like to simplify my create files by not having to create the sequence
first, but I also don't want to give up those 2 bytes per column!
Can this be added?
Mike
--- postgresql-9.0.4/src/backend/parser/parse_utilcmd.
17 matches
Mail list logo
