Re: [HACKERS] timestamptz parsing bug?

2012-08-25 Thread Bruce Momjian
On Wed, Aug 15, 2012 at 05:29:26PM -0400, Bruce Momjian wrote: I assume we want to apply this patch based on discussion that we should allow a wider range of date/time formats. Applied, thanks. --- On Mon, Aug 29,

Re: [HACKERS] timestamptz parsing bug?

2012-08-15 Thread Bruce Momjian
I assume we want to apply this patch based on discussion that we should allow a wider range of date/time formats. --- On Mon, Aug 29, 2011 at 06:40:07PM +0100, Dean Rasheed wrote: On 29 August 2011 15:40, Andrew Dunstan

[HACKERS] timestamptz parsing bug?

2011-08-29 Thread Andrew Dunstan
Why do we parse this as a correct timestamptz literal: 2011-08-29T09:11:14.123 CDT but not this: 2011-08-29T09:11:14.123 America/Chicago Replace the ISO-8601 style T between the date and time parts of the latter with a space and the parser is happy again. cheers andrew -- Sent

Re: [HACKERS] timestamptz parsing bug?

2011-08-29 Thread Dean Rasheed
On 29 August 2011 15:40, Andrew Dunstan and...@dunslane.net wrote: Why do we parse this as a correct timestamptz literal:    2011-08-29T09:11:14.123 CDT but not this:    2011-08-29T09:11:14.123 America/Chicago Replace the ISO-8601 style T between the date and time parts of the latter

Re: [HACKERS] timestamptz parsing bug?

2011-08-29 Thread Tom Lane
Dean Rasheed dean.a.rash...@gmail.com writes: On 29 August 2011 15:40, Andrew Dunstan and...@dunslane.net wrote: Why do we parse this as a correct timestamptz literal: 2011-08-29T09:11:14.123 CDT but not this: 2011-08-29T09:11:14.123 America/Chicago For this input string the T is

Re: [HACKERS] timestamptz parsing bug?

2011-08-29 Thread David E. Wheeler
On Aug 29, 2011, at 12:30 PM, Tom Lane wrote: When it gets to the timezone America/Chicago at the end, this is handled in the DTK_DATE case, because of the /. But because ptype is still set, it is expecting this to be an ISO time, so it errors out. Do we actually *want* to support this?

Re: [HACKERS] timestamptz parsing bug?

2011-08-29 Thread Andrew Dunstan
On 08/29/2011 03:35 PM, David E. Wheeler wrote: On Aug 29, 2011, at 12:30 PM, Tom Lane wrote: When it gets to the timezone America/Chicago at the end, this is handled in the DTK_DATE case, because of the /. But because ptype is still set, it is expecting this to be an ISO time, so it errors

Re: [HACKERS] timestamptz parsing bug?

2011-08-29 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: On 08/29/2011 03:35 PM, David E. Wheeler wrote: On Aug 29, 2011, at 12:30 PM, Tom Lane wrote: Do we actually *want* to support this? The T is supposed to mean that the string is strictly ISO-conformant, no? In that case we shouldn't be accepting an

Re: [HACKERS] timestamptz parsing bug?

2011-08-29 Thread Dean Rasheed
On 29 August 2011 20:43, Andrew Dunstan and...@dunslane.net wrote: On 08/29/2011 03:35 PM, David E. Wheeler wrote: On Aug 29, 2011, at 12:30 PM, Tom Lane wrote: When it gets to the timezone America/Chicago at the end, this is handled in the DTK_DATE case, because of the /. But because