Re: [HACKERS] unlink for DROPs after releasing locks (was Re: Should I implement DROP INDEX CONCURRENTLY?)

2012-06-14 Thread Robert Haas
On Sun, Jun 10, 2012 at 5:37 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Sun, Jun 10, 2012 at 4:19 PM, Noah Misch n...@leadboat.com wrote: Agreed.  We now have $OLD_SUBJECT, but this is a win independently.  I have reviewed the code that runs between the

Re: [HACKERS] unlink for DROPs after releasing locks (was Re: Should I implement DROP INDEX CONCURRENTLY?)

2012-06-14 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: Is RESOURCE_RELEASE_AFTER_LOCKS actually used for anything? Is it just for extensions? I'm too lazy to go look, but it certainly ought to be in use. The idea is that that's the phase for post-lock-release cleanup, and anything that can possibly be

Re: [HACKERS] unlink for DROPs after releasing locks (was Re: Should I implement DROP INDEX CONCURRENTLY?)

2012-06-14 Thread Robert Haas
On Thu, Jun 14, 2012 at 10:45 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Is RESOURCE_RELEASE_AFTER_LOCKS actually used for anything?  Is it just for extensions? I'm too lazy to go look, but it certainly ought to be in use. The idea is that that's the

[HACKERS] unlink for DROPs after releasing locks (was Re: Should I implement DROP INDEX CONCURRENTLY?)

2012-06-10 Thread Noah Misch
On Wed, Aug 24, 2011 at 03:38:09PM -0400, Tom Lane wrote: Merlin Moncure mmonc...@gmail.com writes: On Wed, Aug 24, 2011 at 1:24 PM, Daniel Farina dan...@heroku.com wrote: At Heroku we use CREATE INDEX CONCURRENTLY with great success, but recently when frobbing around some indexes I

Re: [HACKERS] unlink for DROPs after releasing locks (was Re: Should I implement DROP INDEX CONCURRENTLY?)

2012-06-10 Thread Robert Haas
On Sun, Jun 10, 2012 at 4:19 PM, Noah Misch n...@leadboat.com wrote: On Wed, Aug 24, 2011 at 03:38:09PM -0400, Tom Lane wrote: Merlin Moncure mmonc...@gmail.com writes: On Wed, Aug 24, 2011 at 1:24 PM, Daniel Farina dan...@heroku.com wrote: At Heroku we use CREATE INDEX CONCURRENTLY with

Re: [HACKERS] unlink for DROPs after releasing locks (was Re: Should I implement DROP INDEX CONCURRENTLY?)

2012-06-10 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Sun, Jun 10, 2012 at 4:19 PM, Noah Misch n...@leadboat.com wrote: Agreed. We now have $OLD_SUBJECT, but this is a win independently. I have reviewed the code that runs between the old and new call sites, and I did not identify a hazard of moving