Re: [HACKERS] use strict in all Perl programs

2017-01-06 Thread Michael Paquier
On Fri, Jan 6, 2017 at 11:13 PM, David Steele wrote: > With regard to warnings, I prefer to use: > > use warnings FATAL => qw(all); > > This transforms all warnings into errors rather than just printing a message > to stderr, which is very easy to miss among the other output.

Re: [HACKERS] use strict in all Perl programs

2017-01-06 Thread David Steele
On 1/5/17 12:37 PM, Peter Eisentraut wrote: On 12/31/16 1:34 AM, Michael Paquier wrote: On Sat, Dec 31, 2016 at 3:07 PM, Peter Eisentraut wrote: Here is a patch to add 'use strict' to all Perl programs (that I could find), or move it to the right place where

Re: [HACKERS] use strict in all Perl programs

2017-01-05 Thread Peter Eisentraut
On 12/31/16 1:34 AM, Michael Paquier wrote: > On Sat, Dec 31, 2016 at 3:07 PM, Peter Eisentraut > wrote: >> Here is a patch to add 'use strict' to all Perl programs (that I could >> find), or move it to the right place where it was already there. I >> think that

Re: [HACKERS] use strict in all Perl programs

2016-12-30 Thread Michael Paquier
On Sat, Dec 31, 2016 at 3:07 PM, Peter Eisentraut wrote: > Here is a patch to add 'use strict' to all Perl programs (that I could > find), or move it to the right place where it was already there. I > think that is a pretty standard thing to do nowadays. > > I

[HACKERS] use strict in all Perl programs

2016-12-30 Thread Peter Eisentraut
Here is a patch to add 'use strict' to all Perl programs (that I could find), or move it to the right place where it was already there. I think that is a pretty standard thing to do nowadays. I tried testing the changes in pgcheckdefines, but it just spits out nonsense before and after. --