[HACKERS] very elaborate mkdir error checking in pg_dump

2012-07-19 Thread Peter Eisentraut
Is there a real point to all this code in pg_backup_directory.c? static void createDirectory(const char *dir) { struct stat st; /* the directory must not exist yet. */ if (stat(dir, st) == 0) { if (S_ISDIR(st.st_mode)) exit_horribly(modulename,

Re: [HACKERS] very elaborate mkdir error checking in pg_dump

2012-07-19 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: Couldn't we just call mkdir() and report the strerrno(errno) to begin with, like everyone else does? +1. It'll provide pretty much the same information anyway. regards, tom lane -- Sent via pgsql-hackers mailing list