Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-08-19 Thread Noah Misch
On Mon, Aug 18, 2014 at 12:30:40PM +0100, Greg Stark wrote: On Tue, Aug 5, 2014 at 3:41 AM, Noah Misch n...@leadboat.com wrote: This remains open for 9.4. Your proposal to revert the feature in 9.4 and fix it in 9.5 sounds reasonable. Ok, I've gone ahead and done this. I'm sorry for

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-08-18 Thread Greg Stark
On Tue, Aug 5, 2014 at 3:41 AM, Noah Misch n...@leadboat.com wrote: This remains open for 9.4. Your proposal to revert the feature in 9.4 and fix it in 9.5 sounds reasonable. Ok, I've gone ahead and done this. I'm sorry for the delays and confusion. On Thu, Jul 10, 2014 at 04:15:35PM +0100,

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-08-18 Thread Michael Paquier
On Mon, Aug 18, 2014 at 8:30 PM, Greg Stark st...@mit.edu wrote: On Tue, Aug 5, 2014 at 3:41 AM, Noah Misch n...@leadboat.com wrote: This remains open for 9.4. Your proposal to revert the feature in 9.4 and fix it in 9.5 sounds reasonable. Ok, I've gone ahead and done this. I'm sorry for

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-08-18 Thread Greg Stark
On Mon, Aug 18, 2014 at 12:55 PM, Michael Paquier michael.paqu...@gmail.com wrote: I imagine that you also need to fix the release notes accordingly. Patch attached for master and REL9_4_STABLE. Thanks. Done for 9.4 but the patch is still in master. In fact it's the most recent version and I'm

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-08-18 Thread Michael Paquier
On Mon, Aug 18, 2014 at 10:02 PM, Greg Stark st...@mit.edu wrote: On Mon, Aug 18, 2014 at 12:55 PM, Michael Paquier michael.paqu...@gmail.com wrote: Done for 9.4 but the patch is still in master. In fact it's the most recent version and I'm still pretty convinced it's a good patch. If this

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-08-04 Thread Noah Misch
This remains open for 9.4. Your proposal to revert the feature in 9.4 and fix it in 9.5 sounds reasonable. On Thu, Jul 10, 2014 at 04:15:35PM +0100, Greg Stark wrote: On Mon, Jul 7, 2014 at 8:35 AM, Sergey Muraviov sergey.k.murav...@gmail.com wrote: So what's wrong with the patch? And what

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-07-10 Thread Greg Stark
On Mon, Jul 7, 2014 at 8:35 AM, Sergey Muraviov sergey.k.murav...@gmail.com wrote: So what's wrong with the patch? And what should I change in it for 9.5? Possibly nothing. The concern was tha it's modifying the output in cases where the output is not \expanded and/or not wrapped. Now I've

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-07-07 Thread Sergey Muraviov
So what's wrong with the patch? And what should I change in it for 9.5? 2014-07-07 3:12 GMT+04:00 Greg Stark st...@mit.edu: On Sun, Jul 6, 2014 at 8:40 AM, Sergey Muraviov sergey.k.murav...@gmail.com wrote: Is there anyone who can commit the patch? So what I'm inclined to do here (sigh)

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-07-06 Thread Sergey Muraviov
Hi. Is there anyone who can commit the patch? 2014-06-25 20:17 GMT+04:00 Pavel Stehule pavel.steh...@gmail.com: 2014-06-24 19:45 GMT+02:00 Sergey Muraviov sergey.k.murav...@gmail.com: Hi. Is there any problem with the patch? I tested it and I had not any issue with last version

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-07-06 Thread Greg Stark
On Sun, Jul 6, 2014 at 8:40 AM, Sergey Muraviov sergey.k.murav...@gmail.com wrote: Is there anyone who can commit the patch? So what I'm inclined to do here (sigh) is commit it into 9.5 and revert it in 9.4. I think it's an improvement but I there's enough confusion and surprise about the

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-06-25 Thread Pavel Stehule
2014-06-24 19:45 GMT+02:00 Sergey Muraviov sergey.k.murav...@gmail.com: Hi. Is there any problem with the patch? I tested it and I had not any issue with last version So, please, commit it Regards Pavel 2014-06-17 0:21 GMT+04:00 Greg Stark st...@mit.edu: On Mon, Jun 16, 2014 at

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-06-24 Thread Sergey Muraviov
Hi. Is there any problem with the patch? 2014-06-17 0:21 GMT+04:00 Greg Stark st...@mit.edu: On Mon, Jun 16, 2014 at 9:05 PM, Robert Haas robertmh...@gmail.com wrote: So, it seems like we need to do something about this one way or another. Who's working on that? So I'm fine finishing

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-06-17 Thread Pavel Stehule
2014-06-16 23:28 GMT+02:00 Jeff Janes jeff.ja...@gmail.com: On Wed, Jun 11, 2014 at 12:59 PM, Greg Stark st...@mit.edu wrote: I think this whole exercise has mostly just convinced me we should implement an HTTP interface and reimplement psql as a browser app. I certainly hope not. I've

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-06-16 Thread Robert Haas
On Wed, Jun 11, 2014 at 10:16 PM, Tom Lane t...@sss.pgh.pa.us wrote: Noah Misch n...@leadboat.com writes: Based on the commit message and procedural history, I thought commit 6513633 was changing behavior solely for the combination of \pset expanded and \pset format wrapped. Peter's and my

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-06-16 Thread Greg Stark
On Mon, Jun 16, 2014 at 9:05 PM, Robert Haas robertmh...@gmail.com wrote: So, it seems like we need to do something about this one way or another. Who's working on that? So I'm fine finishing what I started. I've just been a bit busy this past week. My inclination is to try to push forward

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-06-16 Thread Jeff Janes
On Wed, Jun 11, 2014 at 12:59 PM, Greg Stark st...@mit.edu wrote: I think this whole exercise has mostly just convinced me we should implement an HTTP interface and reimplement psql as a browser app. I certainly hope not. I've seen lots of browser apps that were nice enough to use for casual

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-06-11 Thread Peter Eisentraut
On 6/8/14, 11:29 PM, Noah Misch wrote: The patch did not restore 9.3 behavior for that one. Starting with commit 6513633, the first line of letters is space-padded on the right to the width of the second line of letters. To illustrate, I have attached raw psql output from both commit 6513633

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-06-11 Thread Greg Stark
On Wed, Jun 11, 2014 at 7:52 PM, Peter Eisentraut pete...@gmx.net wrote: On 6/8/14, 11:29 PM, Noah Misch wrote: The patch did not restore 9.3 behavior for that one. Starting with commit 6513633, the first line of letters is space-padded on the right to the width of the second line of letters.

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-06-11 Thread Greg Stark
And Gmail has thoroughly mangled that email. Let me see if I can resend it from Emacs more clearly. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-06-11 Thread Noah Misch
On Wed, Jun 11, 2014 at 08:59:34PM +0100, Greg Stark wrote: The leading space that you (ie Peter) are complaining about in: col | 1 +-- col | 2 Is there because if the cell wrapped it would get an ellipsis (ie '...' but it's a single unicode character) in that column to indicate

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-06-11 Thread Tom Lane
Noah Misch n...@leadboat.com writes: Based on the commit message and procedural history, I thought commit 6513633 was changing behavior solely for the combination of \pset expanded and \pset format wrapped. Peter's and my test cases show that it also changed behavior for \pset expanded alone.

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-06-08 Thread Noah Misch
On Fri, May 23, 2014 at 10:10:23AM -0400, Alvaro Herrera wrote: Sergey Muraviov wrote: I found some new bugs and fix them. And I had to make many changes. This version fixes some bugs I had noticed in expanded mode too. For instance, the original looked like this (five lines plus

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-06-06 Thread Pavel Stehule
Hello where we are with this feature? Is there some barriers to commit bugfix? Regards Pavel 2014-05-18 19:46 GMT+02:00 Sergey Muraviov sergey.k.murav...@gmail.com: I found some new bugs and fix them. And I had to make many changes. 2014-05-17 21:31 GMT+04:00 Greg Stark st...@mit.edu:

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-05-23 Thread Alvaro Herrera
Sergey Muraviov wrote: I found some new bugs and fix them. And I had to make many changes. This version fixes some bugs I had noticed in expanded mode too. For instance, the original looked like this (five lines plus header): -[ RECORD 49

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-05-17 Thread Greg Stark
I'm trying to review all the combinations of the options exhaustively but in the process I noticed a few pre-existing psql oddities. Both of these are present in 9.3: Can anyone explain this? It's linestyle=old-style, border=1, expanded=off, format=aligned. It looks like it's using new-style

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-05-17 Thread Greg Stark
Sorry, a couple things still look to not be quite right. 1) The width of the table when linestyle=old-ascii and border=0 or border=1 (and expanded=on and format=wrapped) seems to off by one. 2) The hyphens following the RECORD NN are short by one I'm surprised the last patch was so big since it

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-05-15 Thread Pavel Stehule
Hello 2014-05-15 15:04 GMT+02:00 Sergey Muraviov sergey.k.murav...@gmail.com: Hi. Please review the new patch. This version works perfect Regards Pavel PS Issues which were described by Tom and Pavel were relevant to single-line headers. So I've added appropriate regression tests

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-05-14 Thread Pavel Stehule
Hello With this patch it works perfect Thank you Regards Pavel 2014-05-13 21:33 GMT+02:00 Sergey Muraviov sergey.k.murav...@gmail.com: Please check this patch. 2014-05-12 22:56 GMT+04:00 Sergey Muraviov sergey.k.murav...@gmail.com: Hi. I'll try to fix it tomorrow. 2014-05-12

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-05-13 Thread Sergey Muraviov
Please check this patch. 2014-05-12 22:56 GMT+04:00 Sergey Muraviov sergey.k.murav...@gmail.com: Hi. I'll try to fix it tomorrow. 2014-05-12 18:42 GMT+04:00 Tom Lane t...@sss.pgh.pa.us: Greg Stark st...@mit.edu writes: On Mon, May 12, 2014 at 2:12 PM, Greg Stark st...@mit.edu wrote:

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-05-12 Thread Emre Hasegeli
Pavel Stehule pavel.steh...@gmail.com: Hello I am checking feature http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=6513633b94173fc1d9e2b213c43f9422ddbf5faa It works perfect with pager less, but it works badly with default more see attached screenshots, pls It is

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-05-12 Thread Tom Lane
Emre Hasegeli e...@hasegeli.com writes: Pavel Stehule pavel.steh...@gmail.com: I am checking feature http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=6513633b94173fc1d9e2b213c43f9422ddbf5faa It works perfect with pager less, but it works badly with default more I do not

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-05-12 Thread Greg Stark
On Mon, May 12, 2014 at 2:00 PM, Tom Lane t...@sss.pgh.pa.us wrote: but where did those leading spaces come from? The header line is definitely not on board with that, and I think those spaces are contributing to the lines being too long for the window. I think possibly the code is also

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-05-12 Thread Greg Stark
On Mon, May 12, 2014 at 2:12 PM, Greg Stark st...@mit.edu wrote: Hm, there was an off by one error earlier in some cases, maybe we fixed it by breaking other case. Will investigate. Those spaces are coming from the ascii wrapping indicators. i.e. the periods in:

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-05-12 Thread Tom Lane
Greg Stark st...@mit.edu writes: On Mon, May 12, 2014 at 2:12 PM, Greg Stark st...@mit.edu wrote: Hm, there was an off by one error earlier in some cases, maybe we fixed it by breaking other case. Will investigate. Those spaces are coming from the ascii wrapping indicators. i.e. the periods

Re: [HACKERS] wrapping in extended mode doesn't work well with default pager

2014-05-12 Thread Sergey Muraviov
Hi. I'll try to fix it tomorrow. 2014-05-12 18:42 GMT+04:00 Tom Lane t...@sss.pgh.pa.us: Greg Stark st...@mit.edu writes: On Mon, May 12, 2014 at 2:12 PM, Greg Stark st...@mit.edu wrote: Hm, there was an off by one error earlier in some cases, maybe we fixed it by breaking other case.