On Tue, 2010-07-27 at 19:41 -0400, Robert Haas wrote: > On Tue, Jul 27, 2010 at 7:33 PM, David Fetter <da...@fetter.org> wrote: > > Minor quibble with the regression tests: should we be using > > dollar quotes in things like this? Doubled-up quote marks: > > > > SELECT xpath_exists('//town[text() = > > ''Cwmbran'']','<towns><town>Bidford-on-Avon</town><town>Cwmbran</town><town>Bristol</town></towns>'::xml); > > > > Dollar quote: > > > > SELECT xpath_exists($$//town[text() = > > 'Cwmbran']$$,'<towns><town>Bidford-on-Avon</town><town>Cwmbran</town><town>Bristol</town></towns>'::xml); > > Personally, I don't really see that as an improvement. Dollar-quotes > are really nice for longer strings, or where you would otherwise have > quadrupled quotes (or more), but I don't see a big advantage to it > here. Still, it's a question of opinion more than anything else.
I like the idea of using dollar quotes, but I think they should be used for both arguments (or neither). Using $$ for one and then shifting to "'" for the second argument with no whitespace at all seems like the least readable option. Regards, Jeff Davis -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers