Re: pending patch: Re: [HACKERS] Streaming replication and pg_xlogfile_name()

2010-04-06 Thread Heikki Linnakangas
Fujii Masao wrote: > On Tue, Apr 6, 2010 at 11:48 PM, Heikki Linnakangas > wrote: >> Fujii Masao wrote: >>> On Tue, Apr 6, 2010 at 8:02 PM, Fujii Masao wrote: > Should we throw an error in pg_xlogfile_name() if called during > recovery? It's not doing anything useful as it is. I have

Re: pending patch: Re: [HACKERS] Streaming replication and pg_xlogfile_name()

2010-04-06 Thread Fujii Masao
On Tue, Apr 6, 2010 at 11:48 PM, Heikki Linnakangas wrote: > Fujii Masao wrote: >> On Tue, Apr 6, 2010 at 8:02 PM, Fujii Masao wrote: Should we throw an error in pg_xlogfile_name() if called during recovery? It's not doing anything useful as it is. >>> I have no objection for now. >> >>

Re: pending patch: Re: [HACKERS] Streaming replication and pg_xlogfile_name()

2010-04-06 Thread Heikki Linnakangas
Fujii Masao wrote: > On Tue, Apr 6, 2010 at 8:02 PM, Fujii Masao wrote: >>> Should we throw an error in pg_xlogfile_name() if called during >>> recovery? It's not doing anything useful as it is. >> I have no objection for now. > > Here is the patch. > ... > + if (RecoveryInProgress()) > +

Re: pending patch: Re: [HACKERS] Streaming replication and pg_xlogfile_name()

2010-04-06 Thread Fujii Masao
On Tue, Apr 6, 2010 at 8:02 PM, Fujii Masao wrote: >> Should we throw an error in pg_xlogfile_name() if called during >> recovery? It's not doing anything useful as it is. > > I have no objection for now. Here is the patch. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT

Re: pending patch: Re: [HACKERS] Streaming replication and pg_xlogfile_name()

2010-04-06 Thread Fujii Masao
On Tue, Apr 6, 2010 at 7:25 PM, Heikki Linnakangas wrote: > Fujii Masao wrote: >> On Fri, Apr 2, 2010 at 2:22 AM, Robert Haas wrote: >>> Can someone explain to me in plain language what problem this is >>> trying to fix?  I'm having trouble figuring it out. >> >> The problem is that pg_xlogfile_n

Re: pending patch: Re: [HACKERS] Streaming replication and pg_xlogfile_name()

2010-04-06 Thread Heikki Linnakangas
Fujii Masao wrote: > On Fri, Apr 2, 2010 at 2:22 AM, Robert Haas wrote: >> Can someone explain to me in plain language what problem this is >> trying to fix? I'm having trouble figuring it out. > > The problem is that pg_xlogfile_name(pg_last_xlog_receive_location()) and > pg_xlogfile_name(pg_la

Re: pending patch: Re: [HACKERS] Streaming replication and pg_xlogfile_name()

2010-04-01 Thread Fujii Masao
On Fri, Apr 2, 2010 at 2:22 AM, Robert Haas wrote: > Can someone explain to me in plain language what problem this is > trying to fix?  I'm having trouble figuring it out. The problem is that pg_xlogfile_name(pg_last_xlog_receive_location()) and pg_xlogfile_name(pg_last_xlog_replay_location()) mi

Re: pending patch: Re: [HACKERS] Streaming replication and pg_xlogfile_name()

2010-04-01 Thread Robert Haas
On Tue, Mar 30, 2010 at 5:14 AM, Fujii Masao wrote: > On Wed, Mar 3, 2010 at 11:03 PM, Fujii Masao wrote: >> On Tue, Mar 2, 2010 at 10:52 PM, Fujii Masao wrote: It's not clear what it should return, a TLI corresponding the filename of the WAL segment the record was replayed from, so th

pending patch: Re: [HACKERS] Streaming replication and pg_xlogfile_name()

2010-03-30 Thread Fujii Masao
On Wed, Mar 3, 2010 at 11:03 PM, Fujii Masao wrote: > On Tue, Mar 2, 2010 at 10:52 PM, Fujii Masao wrote: >>> It's not clear what it should return, a TLI corresponding the filename >>> of the WAL segment the record was replayed from, so that you can use >>> pg_xlogfile_name() to find out the file