Re: [HACKERS] WIP: Covering + unique indexes.

2017-11-28 Thread Andrey Borodin
> 29 нояб. 2017 г., в 8:45, Peter Geoghegan <p...@bowt.ie> написал(а): > > On Tue, Nov 28, 2017 at 6:16 PM, Michael Paquier > <michael.paqu...@gmail.com> wrote: >> On Sun, Nov 12, 2017 at 8:40 PM, Andrey Borodin <x4...@yandex-team.ru> wrote: >>>

Re: [HACKERS] CUBE seems a bit confused about ORDER BY

2017-11-29 Thread Andrey Borodin
ll commit > it before next commitfest. Hi! I've took a glance at the patch, here's what catches my eye in comments: corrdinate, dimenstions, descinding, stoty. I'll try to provide meaningful review next week. Best regards, Andrey Borodin.

Re: [HACKERS] WIP: Covering + unique indexes.

2017-11-30 Thread Andrey Borodin
the heapallindexed check doesn't actually > care about index structure at all. Seems like it was not a big deal of patching, I've fixed those bits (see attachment). I've done only simple tests as for now, but I'm planning to do better testing before next CF. Thanks for mentioning

Re: Commit fest 2017-11

2017-11-29 Thread Andrey Borodin
t; . Seems like we have common view with Peter Geoghegan and Anastasia that found drawback will be fixed before next CF. If there is no objections, I'll put "needs review" to move. Best regards, Andrey Borodin.

Re: [HACKERS] WIP: Covering + unique indexes.

2017-12-04 Thread Andrey Borodin
> 30 нояб. 2017 г., в 23:07, Andrey Borodin <x4...@yandex-team.ru> написал(а): > > Seems like it was not a big deal of patching, I've fixed those bits (see > attachment). > I've done only simple tests as for now, but I'm planning to do better testing > before next CF.

Re: Tracking of page changes for backup purposes. PTRACK [POC]

2017-12-18 Thread Andrey Borodin
I have two concerns about this: 1. Does this affect the performance of the database when PTRACK is not enabled? 2. What is the cost of having PTRACK enabled? Best regards, Andrey Borodin.

Re: GSoC 2018

2017-12-15 Thread Andrey Borodin
ary at least to validate the idea. I'd sign up as co-mentor for this. Moreover this will attract students from huge pool of ML hackers. Also, I'm planning to add my previous-year project about sorting. Or add something WAL-G-related under Postgres umbrella (probably, WAL-scanning for delta-backup

Re: New gist vacuum.

2017-12-19 Thread Andrey Borodin
Hi hackers! Here is the patch that deletes pages during GiST VACUUM. > 12 нояб. 2017 г., в 23:20, Andrey Borodin <x4...@yandex-team.ru> написал(а): > > If author and community do not object, I want to continue work on > Konstantin's patch. ==Purpose== Long story sh

Re: CUBE seems a bit confused about ORDER BY

2017-12-08 Thread Andrey Borodin
of these macro-funcs and fix cube_out, almost all tests pass again. This is evidence of good compatibility and shows that compatibility overhead is added everywhere. I think that this patch is ready for committer. Best regards, Andrey Borodin. The new status of this patch is: Ready for Committer

Re: Do we actually need an ItemId array on nbtree pages containing fixed-width tuples?

2017-12-03 Thread Andrey Borodin
le is places wherever free space starts. You just shift bytes in ItemId array. And you always have to insert tuple in specific position, since B-tree relies on tuple order. Best regards, Andrey Borodin.

Re: GSoC 2018

2017-12-20 Thread Andrey Borodin
earned index prototype Expected outcome: Design for integration of learned indexes into PostgreSQL (possibly, using index-as-extension technology), prototype implementation and benchmarks. Best regards, Andrey Borodin.

Re: New gist vacuum.

2017-12-30 Thread Andrey Borodin
Hi! > 28 дек. 2017 г., в 16:37, Andrey Borodin <x4...@yandex-team.ru> написал(а): > Here is new version of the patch for GiST VACUUM. > There are two main changes: > 1. During rescan for page deletion only know to be recently empty pages are > rescanned. > 2. I've re-i

Re: Faster inserts with mostly-monotonically increasing values

2017-12-31 Thread Andrey Borodin
hat it already has implementation. I'd suggest to do not 1\1 split for these pages, to keep tree lower. Like fillfactor/(1-fillfactor) split. Also, this will make splits less frequent. Best regards, Andrey Borodin.

Re: [HACKERS] wrong t_bits alignment in pageinspect

2018-01-04 Thread Andrey Borodin
think that patch is ready for committer. Best regards, Andrey Borodin. The new status of this patch is: Ready for Committer

Re: [HACKERS] WIP: Covering + unique indexes.

2018-01-08 Thread Andrey Borodin
Hello! The patch does not apply currently. Anastasia, can you, please, rebase the patch? Best regards, Andrey Borodin.

Re: [HACKERS] A design for amcheck heapam verification

2018-01-11 Thread Andrey Borodin
e may as well fully embrace > non-determinism. I think that determinism across platforms is not that important as determinism across runs. Thanks for the amcheck! It is very useful. Best regards, Andrey Borodin.

Re: [HACKERS] GSoC 2017 : Patch for predicate locking in Gist index

2018-01-04 Thread Andrey Borodin
Hello everyone!29 нояб. 2017 г., в 22:50, Shubham Barai <shubhambara...@gmail.com> написал(а): I have fixed formatting style. Please take a look at updated patch.Here's rebased patch. Every issue has been addressed, so I'm marking this patch as ready for committer.Best regards, Andrey B

Re: [HACKERS] WIP: Covering + unique indexes.

2018-01-18 Thread Andrey Borodin
s. Thanks for working on this feature, hope to see it in 11. Best regards, Andrey Borodin.

Re: New gist vacuum.

2018-01-15 Thread Andrey Borodin
shouldCount = !heap_attisnull(rel->rd_indextuple, > Anum_pg_index_indpred) || > info->estimated_count; We do not need to count if we have exact count from heap and this index is not partial. ITSM that it is quite common case. Best regards, Andrey Borodin.

Re: New gist vacuum.

2018-01-16 Thread Andrey Borodin
level description in > src/backend/access/gist/README. Given this description, it would be much > easier to review the patches. Yes, that's definitely true. Please find README patch attached. Best regards, Andrey Borodin. 0003-Update-README-with-info-on-new-GiST-VACUUM.patch Description: Binary data

Re: WIP: Covering + unique indexes.

2018-01-21 Thread Andrey Borodin
I feel sorry for the noise, switching this patch there and back. But the patch needs rebase again. It still applies with -3, but do not compile anymore. Best regards, Andrey Borodin. The new status of this patch is: Waiting on Author

Re: [HACKERS] WIP: Covering + unique indexes.

2018-01-21 Thread Andrey Borodin
> 21 янв. 2018 г., в 3:36, Peter Geoghegan <p...@bowt.ie> написал(а): > > On Wed, Jan 17, 2018 at 12:45 AM, Andrey Borodin <x4...@yandex-team.ru> wrote: >> Unfortunately, amcheck_next does not work currently on HEAD (there are >> problems with AllocSetContextCre

Re: New gist vacuum.

2018-01-21 Thread Andrey Borodin
Hello, Alexander! > 16 янв. 2018 г., в 21:42, Andrey Borodin <x4...@yandex-team.ru> написал(а): > Please find README patch attached. Here's v2 version. Same code, but x2 comments. Also fixed important typo in readme BFS->DFS. Feel free to ping me any time with questions. Best

Re: [HACKERS] WIP: Covering + unique indexes.

2018-01-17 Thread Andrey Borodin
w versions that must be removed. [install]check[-world] passed :) From my POV, patch is in a good shape. I think it is time to make the patch ready for committer again. Best regards, Andrey Borodin.

Re: Index-only scan returns incorrect results when using a composite GIST index with a gist_trgm_ops column.

2018-01-17 Thread Andrey Borodin
ugh there are tests in cube and seg for that, if your patch passes check-world, than this behavior is not affected. Thank you for the patch! Best regards, Andrey Borodin.

Re: GSoC 2018

2018-01-18 Thread Andrey Borodin
on our > projects page here: I've added project for amcheck enhancement to wiki, I hope it's not too late. Currently, only I'm listed as a mentor (same for WAL-G project too), but, I hope, we will find backup mentor if necessary. Best regards, Andrey Borodin.

Re: [HACKERS] Can ICU be used for a database's default sort order?

2018-02-02 Thread Andrey Borodin
and Postgres Pro already have various flavours of similar feature. Maybe they are planning to publish that? Best regards, Andrey Borodin.

Re: [PoC PATCH] Parallel dump to /dev/null

2018-02-02 Thread Andrey Borodin
O to /dev/null in production. These copies were parallelized on the side of verification script. Not sure this counts for feature or against it. Best regards, Andrey Borodin.

[WiP] GiST intrapage indexing

2018-02-11 Thread Andrey Borodin
significant improvement of searches. I expect that this technology will protect GiST from degradation on big block sizes (thanks to Oleg for suggestion)Currently, patch is stable, passes all my test and checkworlds, WAL seems to work. Though, it is "work in progress".Best regards, Andrey Borodin

Re: GSoC 2018 Project Ideas & Mentors - Last Call

2018-02-13 Thread Andrey Borodin
ization this year. https://summerofcode.withgoogle.com/organizations/6357583019900928/ <https://summerofcode.withgoogle.com/organizations/6357583019900928/> Time to attract some great students :) Best regards, Andrey Borodin.

Re: [WIP PATCH] Index scan offset optimisation using visibility map

2018-02-05 Thread Andrey Borodin
s this, patch looks good. Please, add it to the following commitfest so that work on the patch could be tracked. Best regards, Andrey Borodin.

Re: [HACKERS] A design for amcheck heapam verification

2018-02-08 Thread Andrey Borodin
l to some callers. Bloom filter behaves deterministically, but differently. This does not ensures any thing, but probably will give something with hight probability. Thanks! Best regards, Andrey Borodin.

Re: New gist vacuum.

2018-02-07 Thread Andrey Borodin
Hi, David! > 7 февр. 2018 г., в 18:39, David Steele <da...@pgmasters.net> написал(а): > > Hi Andrey, > > On 1/21/18 5:34 AM, Andrey Borodin wrote: >> Hello, Alexander! >>> 16 янв. 2018 г., в 21:42, Andrey Borodin <x4...@yandex-team.ru> написал

Re: [HACKERS] Can ICU be used for a database's default sort order?

2018-02-16 Thread Andrey Borodin
Hi everyone! > 10 февр. 2018 г., в 20:45, Andrey Borodin <x4...@yandex-team.ru> написал(а): > > I'm planning to provide review > So, I was looking into the patch. The patch adds: 1. Ability to specify collation provider (with version) in --locale for initdb and cre

Re: [WIP PATCH] Index scan offset optimisation using visibility map

2018-02-19 Thread Andrey Borodin
wiki.postgresql.org/wiki/Index-only_scans I do not know if it is possible to take into account this optimization in cost estimation. Does Limit node take cost of scanning into startup cost? Thanks! Best regards, Andrey Borodin.

Re: Online enabling of checksums

2018-02-22 Thread Andrey Borodin
eads mentioned by Magnus [2,3] Or do you mean extracting "worker+lancher" for reuse for other purposes? Best regards, Andrey Borodin. [0] https://www.postgresql.org/message-id/flat/E2B195BF-7AA1-47AF-85BE-0E936D157902%40endpoint.com#e2b195bf-7aa1-47af-85be-0e936d157...@endpoint.com &

Re: New gist vacuum.

2017-12-28 Thread Andrey Borodin
Hi hackers! > 19 дек. 2017 г., в 15:58, Andrey Borodin <x4...@yandex-team.ru> написал(а): > Here is the patch that deletes pages during GiST VACUUM. Here is new version of the patch for GiST VACUUM. There are two main changes: 1. During rescan for page deletion only know to be re

Re: [HACKERS] wrong t_bits alignment in pageinspect

2018-01-02 Thread Andrey Borodin
ll be a little bit easier to read. Best regards, Andrey Borodin. [0] https://github.com/postgres/postgres/blob/master/contrib/pageinspect/heapfuncs.c#L439

Re: Tracking of page changes for backup purposes. PTRACK [POC]

2017-12-27 Thread Andrey Borodin
Hi! > 21 дек. 2017 г., в 5:51, Michael Paquier > написал(а): > > On Thu, Dec 21, 2017 at 7:35 AM, Robert Haas wrote: >> On Wed, Dec 20, 2017 at 3:45 PM, Tomas Vondra >> wrote: Isn't more effective hold this

Re: [Patch] Checksums for SLRU files

2018-01-01 Thread Andrey Borodin
e()). +1 was a tough thing for me to understand before looking around and reading those comments. 4. I could not understand purpose of this expression page[BLCKSZ - 1] & 0X00FF Happy New Year :) Keep up good work. Best regards, Andrey Borodin.

Re: Index-only scan returns incorrect results when using a composite GIST index with a gist_trgm_ops column.

2018-01-23 Thread Andrey Borodin
hich was required before 11. I think, explain results will be identical. Best regards, Andrey Borodin.

Re: [WIP PATCH] Index scan offset optimisation using visibility map

2018-03-06 Thread Andrey Borodin
ck could be removed from loop. We do not expect that it's state will change during execution, do we? Besides this, I think the patch is ready for committer. Best regards, Andrey Borodin.

Re: [HACKERS] GSoC 2017: weekly progress reports (week 6)

2018-03-12 Thread Andrey Borodin
list. We were discussing this with Shubham back in July, chosen some approach that seemed better, but I can't remember what was that... Best regards, Andrey Borodin.

Re: [WIP PATCH] Index scan offset optimisation using visibility map

2018-03-12 Thread Andrey Borodin
is ready for committer. Best regards, Andrey Borodin. The new status of this patch is: Ready for Committer

Re: [WIP PATCH] Index scan offset optimisation using visibility map

2018-03-11 Thread Andrey Borodin
e I've incorrectly expressed what I wanted to say. I mean this Assert() can be checked before loop, not on every loop cycle. Best regards, Andrey Borodin.

Re: Online enabling of checksums

2018-02-27 Thread Andrey Borodin
ike implement utility for offline checksum enabling, without WAL-logging, surely. Thanks for the patch! Best regards, Andrey Borodin.

Re: Online enabling of checksums

2018-02-28 Thread Andrey Borodin
-log page whenever it is checksummed by worker? Even if the checksum was correct? Best regards, Andrey Borodin.

Re: Online enabling of checksums

2018-02-28 Thread Andrey Borodin
e provide backporting for such features? Best regards, Andrey Borodin.

Re: [WIP PATCH] Index scan offset optimisation using visibility map

2018-03-13 Thread Andrey Borodin
seems outside of the patch scope and I believe it's better avoid messing with SSI internals without strong reason. Best regards, Andrey Borodin.

Re: [HACKERS] GSoC 2017: weekly progress reports (week 6)

2018-03-13 Thread Andrey Borodin
will prevent this kind of problems with enabling fastupdate. Best regards, Andrey Borodin.

Re: Google Summer of Code: Potential Applicant

2018-03-13 Thread Andrey Borodin
lse implement more algorithms. amcheck. June - implement checks for Gin (like b-tree in b-tree, resembles existing amcheck), July - checks for Hash, BRIN and SP-GiST, August - RUM, patch, commitfest, reviews. Best regards, Andrey Borodin.

Re: 2018-03 CFM

2018-03-06 Thread Andrey Borodin
> 7 марта 2018 г., в 12:00, Michael Paquier <mich...@paquier.xyz> написал(а): > > On Wed, Mar 07, 2018 at 11:56:01AM +0500, Andrey Borodin wrote: >> Actually, as for now, it is impossible to register patch at CF >> 2018-09. At least I do not see the "new pa

Re: [WIP PATCH] Index scan offset optimisation using visibility map

2018-04-09 Thread Andrey Borodin
Hi! The work on the patch goes on, where was some discussion of this patch off-list with author. Advise-request is still actual. I think that we should move this patch to next CF. So I'm marking patch as needs review. Best regards, Andrey Borodin.

Re: [HACKERS] GSoC 2017: weekly progress reports (week 6)

2018-04-09 Thread Andrey Borodin
ck only segments where we actually were looking, not all the posting tree of B. BTW I do not think that we lock ranges. We lock possibility of appearance of tuples that we might find. Ranges are shortcuts for places where we were looking.. That's how I understand, chances are I'm missing something. Best regards, Andrey Borodin.

Re: Online enabling of checksums

2018-04-05 Thread Andrey Borodin
> 5 апр. 2018 г., в 19:58, Magnus Hagander <mag...@hagander.net> написал(а): > > > > On Thu, Apr 5, 2018 at 4:55 PM, Andrey Borodin <x4...@yandex-team.ru> wrote: > > > > 5 апр. 2018 г., в 14:33, Tomas Vondra <tomas.von...@2ndquadrant.com> >

Re: Online enabling of checksums

2018-04-05 Thread Andrey Borodin
e-write the page to wal". Best regards, Andrey Borodin.

Covering GiST indexes

2018-04-12 Thread Andrey Borodin
sense for example for geometries like PostGIS. Index keys are truncated to small MBRs while having whole complex geometry right in an index could be handy. Any feedback will be appreciated. Best regards, Andrey Borodin. [0] https://www.postgresql.org/message-id/7780A07B-4D04-41E2-B228

Re: [HACKERS] GSoC 2017: weekly progress reports (week 6)

2018-04-09 Thread Andrey Borodin
> 9 апр. 2018 г., в 23:04, Heikki Linnakangas <hlinn...@iki.fi> написал(а): > > On 09/04/18 18:21, Andrey Borodin wrote: >>> 9 апр. 2018 г., в 19:50, Teodor Sigaev <teo...@sigaev.ru> >>> написал(а): >>>> 3. Why do we *not* lock the entry

Re: WIP: Covering + unique indexes.

2018-04-13 Thread Andrey Borodin
Hi! > 12 апр. 2018 г., в 21:21, Teodor Sigaev <teo...@sigaev.ru> написал(а): I was adapting tests for GiST covering index and found out that REINDEX test is somewhat not a REINDEX test... I propose following micropatch. Best regards, Andrey Borodin. fix-reindex-test.diff Descriptio

Re: Covering GiST indexes

2018-04-13 Thread Andrey Borodin
CREATE INDEX. Here's V2, with basic set of tests. Currently, I'm investigating what to document and more places to tests. Also, I do not use generic function index_truncate_tuple(), because it deforms and then forms tuple, but GiST usually have already deformed tuple. Best regards, Andrey Bor

Re: [HACKERS] Clock with Adaptive Replacement

2018-04-25 Thread Andrey Borodin
> 24 апр. 2018 г., в 23:14, Andres Freund <and...@anarazel.de> написал(а): > > On 2018-04-24 17:16:47 +0500, Andrey Borodin wrote: >> But, I think that cost of development of real page eviction strategy >> itself is neglectable small compared to infrastructure chang

Re: [HACKERS] Clock with Adaptive Replacement

2018-04-23 Thread Andrey Borodin
Q. Then, benchmark them well. Or even make this algorithm pluggable? But currently we have a lot of dependent parts in the system. I do not even know where to start. Best regards, Andrey Borodin. [0] http://diku.dk/forskning/Publikationer/tekniske_rapporter/2004/04-03.pdf [1] https

Re: [HACKERS] Clock with Adaptive Replacement

2018-04-24 Thread Andrey Borodin
> designate read/write access. Yes, this is good idea to track pattern of blocks usage. But, I think that cost of development of real page eviction strategy itself is neglectable small compared to infrastructure changes needed by any non-CS5 strategy. Best regards, Andrey Borodin.

Re: [HACKERS] GSoC 2017 : Patch for predicate locking in Gist index

2018-03-27 Thread Andrey Borodin
edicate locking stuff will be placed in > single function... gistplacetopage() is called from 1. Buffered build - probably harmless 2. Finish split - i'm not sure about this. It seems to me that it is necessary... then your version is correct. Best regards, Andrey Borodin.

Re: [HACKERS] GSoC 2017 : Patch for predicate locking in Gist index

2018-03-27 Thread Andrey Borodin
> 27 марта 2018 г., в 13:45, Alexander Korotkov <a.korot...@postgrespro.ru> > написал(а): > > On Tue, Mar 27, 2018 at 11:16 AM, Andrey Borodin <x4...@yandex-team.ru > <mailto:x4...@yandex-team.ru>> wrote: > > 27 марта 2018 г., в 12:53, Teodor Si

Re: A design for amcheck heapam verification

2018-03-27 Thread Andrey Borodin
that this patch is ready for committer. Best regards, Andrey Borodin. The new status of this patch is: Ready for Committer

Re: WIP: Covering + unique indexes.

2018-03-28 Thread Andrey Borodin
s too. > In particular insert-conflict-*.spec and lock-*.spec and probably more. Currently, I couldn't compose good test scenarios, but I will think a bit about it more. Best regards, Andrey Borodin. 0001-Tests-of-covering-indexes-in-amcheck.patch Description: Binary data 0002-Tests-for-dbli

Re: Diagonal storage model

2018-04-02 Thread Andrey Borodin
ons to > provide additional views like double diagonal view. Alas! it all > collapses since I was late to the party. BTW, MDX expression actually provides mulitidimensional result. They have COLUMNS, ROWS, PAGES, SECTIONS, CHAPTERS, and AXIS(N) for those who is not satisfied with named dimensions. Best regards, Andrey Borodin.

Re: Online enabling of checksums

2018-03-18 Thread Andrey Borodin
ing the state back to 'Waiting on Author'; if you think the > above points are moot, maybe switch it back to 'Needs Review' as Andrey > Borodin also marked himself down as reviewer and might want to have > another look as well. Yep, i'm already doing another pass on the code again. Hope to fi

Re: Google Summer of Code: Potential Applicant

2018-03-18 Thread Andrey Borodin
Did you submit your proposal to GSoC website? If so - mentors are not registered on that site yet. Best regards, Andrey Borodin.

Re: [GSoC 2018] Proposal Draft

2018-03-18 Thread Andrey Borodin
committed you will have to review someone else patch. This is required by Postgres dev process. Best regards, Andrey Borodin.

Re: Online enabling of checksums

2018-03-19 Thread Andrey Borodin
ble online. If we commit online checksums before SLRU checksums, we will need very neat hacks if we decide to protect SLRU eventually. What do you think about this problem? Best regards, Andrey Borodin.

Re: [Patch] Checksums for SLRU files

2018-03-19 Thread Andrey Borodin
Hi, Ivan! > 5 марта 2018 г., в 20:58, Andrey Borodin <x4...@yandex-team.ru> написал(а): > > I've found that there are few more places with SLRU items per page I was looking into this patch mainly because I was reviewing other checksums patch in different thread. But the purpos

Re: Online enabling of checksums

2018-03-19 Thread Andrey Borodin
Hi Magnus! > 19 марта 2018 г., в 16:57, Magnus Hagander <mag...@hagander.net> написал(а): > > On Mon, Mar 19, 2018 at 12:24 PM, Magnus Hagander <mag...@hagander.net > <mailto:mag...@hagander.net>> wrote: > On Mon, Mar 19, 2018 at 11:40 AM, Andrey Borodin &l

Re: Online enabling of checksums

2018-03-20 Thread Andrey Borodin
o not stop on wrong checksum, may be we should not stop on short reads either? I agree with all of Heikki's comments. Besides these I have no other questions, patch looks good. Best regards, Andrey Borodin.

Re: [HACKERS] A design for amcheck heapam verification

2018-03-23 Thread Andrey Borodin
Hi! > 8 февр. 2018 г., в 22:45, Peter Geoghegan <p...@bowt.ie> написал(а): > > On Thu, Feb 8, 2018 at 6:05 AM, Andrey Borodin <x4...@yandex-team.ru> wrote: >> I do not see a reason behind hashing the seed. > > It made some sense when I was XOR'ing it to mix.

Re: Google Summer of Code: Potential Applicant

2018-03-19 Thread Andrey Borodin
review proposals carefully. To rate them and choose best of them. Mentors should not influence on your proposal directly, just answer questions about project ideas. Here are some of my generic recommendations on sorting project idea [0,1]. Best regards, Andrey Borodin. [0] https://www.pos

Re: [Patch] Checksums for SLRU files

2018-03-05 Thread Andrey Borodin
regards, Andrey Borodin. moar_slru.diff Description: Binary data

Re: New gist vacuum.

2018-03-02 Thread Andrey Borodin
> 2 марта 2018 г., в 21:25, Tom Lane <t...@sss.pgh.pa.us> написал(а): > > Andrey Borodin <x4...@yandex-team.ru> writes: >> So, I agree, unconditional counting is a good idea. Here's the v3 patch. > > Pushed with trivial cosmetic adjustments. > > I've m

Re: New gist vacuum.

2018-03-01 Thread Andrey Borodin
te() in main vacuum patch (for v12). Both functions will have less code. So, I agree, unconditional counting is a good idea. Here's the v3 patch. Best regards, Andrey Borodin. 0001-Fix-GiST-stats-for-partial-indexes-v3.patch Description: Binary data

Re: [WIP PATCH] Index scan offset optimisation using visibility map

2018-03-01 Thread Andrey Borodin
Hi, Michail! Here are points that we need to address before advancing the patch. > 20 февр. 2018 г., в 11:45, Andrey Borodin <x4...@yandex-team.ru> написал(а): > > Minor spots: > There are some trailing whitespaces at line ends >> Offset cannot be optimized because

Re: [HACKERS] Clock with Adaptive Replacement

2018-04-30 Thread Andrey Borodin
Hi! > 30 апр. 2018 г., в 23:15, Andres Freund <and...@anarazel.de> написал(а): > On 2018-04-30 15:39:08 +0500, Andrey Borodin wrote: >> I suspect that performance benefits can be not that big or even >> marginal, if we do not extend comprehensive eviction strateg

Re: [HACKERS] Clock with Adaptive Replacement

2018-04-30 Thread Andrey Borodin
> 30 апр. 2018 г., в 0:48, Andres Freund <and...@anarazel.de> написал(а): > > On 2018-04-25 11:31:12 +0500, Andrey Borodin wrote: >> >> 1. Teaching BgWriter to used data from eviction strategy to aggressively >> flush data to disk (instead of ++next_to_clea

Re: GSOC 2018

2018-05-03 Thread Andrey Borodin
Hi, Joshua! > 2 мая 2018 г., в 22:05, Joshua D. Drake <j...@commandprompt.com> написал(а): > > Who is coordinating GSOC this year? Stephen Frost is org admin. Best regards, Andrey Borodin.

Re: [HACKERS] Clock with Adaptive Replacement

2018-05-06 Thread Andrey Borodin
lot of magic numbers) to merge this spikes into one event does not look promising to me. But this is just my superstition, chances are that you can tune your algorithm into serious advancement. But please publish benchmarks, whatever result will be. Best regards, Andrey Borodin.

Re: [HACKERS] Clock with Adaptive Replacement

2018-05-05 Thread Andrey Borodin
ir first NBlock/32 replacements). > I do not understand where these numbers come from... Best regards, Andrey Borodin.

Re: Clock with Adaptive Replacement

2018-05-14 Thread Andrey Borodin
buffers. Best regards, Andrey Borodin.

Re: GSoC 2018: Sorting Algorithm and Benchmarking

2018-04-27 Thread Andrey Borodin
> 27 апр. 2018 г., в 23:23, Kefan Yang <starord...@gmail.com> написал(а): > > I think Slack would be great for our communication Here's Slack invite app http://postgres-slack.herokuapp.com/ Should we create a channel for this project? Best regards, Andrey Borodin.

Re: GSoC 2018: Sorting Algorithm and Benchmarking

2018-04-27 Thread Andrey Borodin
Hi! > 26 апр. 2018 г., в 0:12, Kefan Yang написал(а): > > My name is Kefan Yang. I am so excited that my proposal ‘Sorting Algorithm > and Benchmarking 2018’ has been accepted. Welcome! I'm also glad you've chosen this project. > I see on the Wiki page that you can

Re: [HACKERS] Clock with Adaptive Replacement

2018-05-06 Thread Andrey Borodin
5 мая 2018 г., в 13:25, Yura Sokolov <funny.fal...@gmail.com> написал(а):05.05.2018 09:16, Andrey Borodin пишет:Hi!4 мая 2018 г., в 16:05, Юрий Соколов <funny.fal...@gmail.com>написал(а):I didn't suggest log scale of usages, but rather"replacement-period based" increm

Re: [HACKERS] Clock with Adaptive Replacement

2018-05-04 Thread Andrey Borodin
ckend doesn't justify a > separate usage count bump each time. Upper in this thread Yura suggested that usages should not create equal bump each time. He effectively suggested log scale of usages, thus many consecutive usages will be taken into account but not dramatically more important than just few recent usages. Best regards, Andrey Borodin.

Re: Postgres 11 release notes

2018-05-17 Thread Andrey Borodin
and decompress functions. If compress function is omited, IndexOnlyScan is enabled for opclass without any extra change. https://github.com/postgres/postgres/commit/d3a4f89d8a3e500bd7c0b7a8a8a5ce1b47859128 <https://github.com/postgres/postgres/commit/d3a4f89d8a3e500bd7c0b7a8a8a5ce1b47859128>

Re: [WIP PATCH] Index scan offset optimisation using visibility map

2018-05-22 Thread Andrey Borodin
e concept of scan that you propose looks interesting. I have few questions: 1. Charts are measured in percents of pgbench TPS, right? 2. For example, is 97% actually 3% degrade? 3. The results are obtained on actual "sort of TPC-B" script? Best regards, Andrey Borodin.

Re: Error on vacuum: xmin before relfrozenxid

2018-05-24 Thread Andrey Borodin
to restore database from backups and inspect it, if necessary. Though first occurrence of this error was beyond recovery window. Best regards, Andrey Borodin.

Re: [Patch] Checksums for SLRU files

2018-05-16 Thread Andrey Borodin
Hi, Ivan! > 19 марта 2018 г., в 15:32, Andrey Borodin <x4...@yandex-team.ru> написал(а): > I was looking into this patch mainly because I was reviewing other checksums > patch in different thread. But the purpose of this patch seems viable for me. > After looking into

Re: GiST VACUUM

2018-05-16 Thread Andrey Borodin
Hi, Thomas! > 17 мая 2018 г., в 9:40, Thomas Munro <thomas.mu...@enterprisedb.com> > написал(а): > > On Wed, Mar 7, 2018 at 7:50 PM, Andrey Borodin <x4...@yandex-team.ru> wrote: >> Here's new version of GiST VACUUM patch set aimed at CF 2018-09. > > Hi A