Re: [HACKERS] Timeline ID in backup_label file

2017-11-15 Thread Michael Paquier
On Wed, Nov 15, 2017 at 11:16 PM, David Steele <da...@pgmasters.net> wrote: > Find my review below. > > On 10/26/17 2:03 PM, Michael Paquier wrote: >> >> Thanks for the feedback. Attached is a patch to achieve so, I have >> added as well a STOP TIMELINE field

Re: [HACKERS] [PATCH] Add recovery_min_apply_delay_reconnect recovery option

2017-11-15 Thread Michael Paquier
On Fri, Oct 20, 2017 at 3:46 AM, Eric Radman <ericsh...@eradman.com> wrote: > On Tue, Oct 17, 2017 at 12:34:17PM +0900, Michael Paquier wrote: >> On Tue, Oct 17, 2017 at 12:51 AM, Eric Radman <ericsh...@eradman.com> wrote: >> > This administrative compromise is nec

Re: [HACKERS] Assertion failure when the non-exclusive pg_stop_backup aborted.

2017-11-15 Thread Michael Paquier
On Wed, Nov 15, 2017 at 5:21 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Wed, Nov 15, 2017 at 2:38 PM, Michael Paquier > <michael.paqu...@gmail.com> wrote: >> On Wed, Nov 15, 2017 at 12:12 PM, Masahiko Sawada <sawada.m...@gmail.com> >> wrot

Re: [HACKERS] Assertion failure when the non-exclusive pg_stop_backup aborted.

2017-11-14 Thread Michael Paquier
On Wed, Nov 15, 2017 at 12:12 PM, Masahiko Sawada wrote: > I think we need to check only sessionBackupState and don't need to > check XLogCtl->Insert.exclusiveBackupState in do_pg_abort_backup(). We > can quickly return if sessionBackupState != >

Re: [HACKERS] More stats about skipped vacuums

2017-11-14 Thread Michael Paquier
On Mon, Oct 30, 2017 at 8:57 PM, Kyotaro HORIGUCHI wrote: > At Thu, 26 Oct 2017 15:06:30 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI > wrote in > <20171026.150630.115694437.horiguchi.kyot...@lab.ntt.co.jp> >> At Fri, 20 Oct

Re: [HACKERS] Timeline ID in backup_label file

2017-11-15 Thread Michael Paquier
On Thu, Nov 16, 2017 at 9:20 AM, David Steele wrote: > For this patch at least, I think we should do #1. Getting rid of the order > dependency is attractive but there may be other programs that are depending > on the order. I know you are not proposing to change the order

Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

2017-11-28 Thread Michael Paquier
On Tue, Nov 28, 2017 at 9:20 PM, Jan Michálek wrote: > Thanks Please avoid top-posting. This breaks the thread logic. > My english is little bit poor and my understanding of formal part of commit > process is only partial. Don't worry, we'll all here to learn. If you

Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256

2017-11-28 Thread Michael Paquier
On Wed, Nov 29, 2017 at 2:41 AM, Robert Haas wrote: > On Tue, Nov 28, 2017 at 11:10 AM, Peter Eisentraut > wrote: >> I also wonder whether there should be a mechanism to turn off channel >> binding from the client. Right now, there is no

Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256

2017-11-28 Thread Michael Paquier
On Wed, Nov 29, 2017 at 7:08 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Wed, Nov 29, 2017 at 2:41 AM, Robert Haas <robertmh...@gmail.com> wrote: >> On Tue, Nov 28, 2017 at 11:10 AM, Peter Eisentraut >> <peter.eisentr...@2ndquadrant.com>

Re: Add PGDLLIMPORT lines to some variables

2017-11-28 Thread Michael Paquier
On Wed, Nov 29, 2017 at 5:00 AM, Brian Cloutier wrote: > Sorry, I'm new to pg-hackers, so I'm not sure what the next step is. > > Do I submit this to commitfest? > > When submitting, do I submit multiple changes, one per branch this should be > packported to? If you want a

Re: [HACKERS] Assertion failure when the non-exclusive pg_stop_backup aborted.

2017-11-28 Thread Michael Paquier
On Wed, Nov 29, 2017 at 6:44 AM, Robert Haas wrote: > On Tue, Nov 21, 2017 at 4:32 AM, Masahiko Sawada > wrote: >> Thank you for comments. Attached updated patch. > > I see that Michael has marked this Ready for Committer, but also that > he didn't

Re: [HACKERS] [PATCH] Vacuum: Update FSM more frequently

2017-11-28 Thread Michael Paquier
On Mon, Nov 27, 2017 at 2:39 PM, Jing Wang wrote: > A few general comments. > > + FreeSpaceMapVacuum(onerel, 64); > > Just want to know why '64' is used here? It's better to give a description. > > +else > + { > + newslot = fsm_get_avail(page, 0); > + } > >

Re: [HACKERS] More stats about skipped vacuums

2017-11-26 Thread Michael Paquier
On Sun, Nov 26, 2017 at 9:59 AM, Tom Lane wrote: > I'd say so ... that's something the average user will never bother with, > and even if they knew to bother, it's far from obvious what to do with > the information. Besides, I don't think you could just save the number > of

Re: [HACKERS] Cache lookup errors with functions manipulation object addresses

2017-11-26 Thread Michael Paquier
On Fri, Nov 24, 2017 at 9:13 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > Attached is a rebased patch set. Álvaro, as you have introduced most > of the problems with 4464303 & friends dated of 2015 when you > introduced get_object_address(), could you look at thi

Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256

2017-11-26 Thread Michael Paquier
On Tue, Nov 21, 2017 at 1:36 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > So attached are rebased patches: > - 0001 to introduce the connection parameter saslchannelbinding, which > allows libpq to enforce the type of channel binding used during an > exchange. &

Re: Code cleanup patch submission for extended_stats.c

2017-11-25 Thread Michael Paquier
On Sun, Nov 26, 2017 at 11:07 AM, Mark Dilger wrote: > >> On Nov 25, 2017, at 2:05 PM, Tom Lane wrote: >> >> Mark Dilger writes: >>> It looks to me like Alvaro introduced this in the original version of the >>> file which

Re: [HACKERS] More stats about skipped vacuums

2017-11-25 Thread Michael Paquier
On Sun, Nov 26, 2017 at 12:34 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Michael Paquier <michael.paqu...@gmail.com> writes: >> On Sat, Nov 25, 2017 at 12:55 AM, Robert Haas <robertmh...@gmail.com> wrote: >>> I think that's a good thing to worry about.

Re: documentation is now XML

2017-11-24 Thread Michael Paquier
On Fri, Nov 24, 2017 at 5:39 AM, Tom Lane wrote: > Peter Eisentraut writes: >> The documentation sources are now DocBook XML, not SGML. (The files are >> still named *.sgml. That's something to think about separately.) > > I think we should

Re: [HACKERS] More stats about skipped vacuums

2017-11-26 Thread Michael Paquier
On Mon, Nov 27, 2017 at 2:49 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Michael Paquier <michael.paqu...@gmail.com> writes: >> ... Would you think >> that it is acceptable to add the number of index scans that happened >> with the verbose output then? > > I d

Re: [HACKERS] More stats about skipped vacuums

2017-11-26 Thread Michael Paquier
On Mon, Nov 27, 2017 at 5:19 AM, Tom Lane wrote: > Robert Haas writes: >> On Sat, Nov 25, 2017 at 12:09 PM, Tom Lane wrote: >>> Mumble. It's a property I'm pretty hesitant to give up, especially >>> since the stats views have

Re: [HACKERS] GnuTLS support

2017-11-26 Thread Michael Paquier
On Mon, Nov 27, 2017 at 10:05 AM, Andreas Karlsson wrote: > The script for the windows version takes the > --with-openssl= switch so that cannot just be translated to a single > --with-ssl switch. Should to have both --with-openssl and --with-gnutls or >

Re: [PATCH] using arc4random for strong randomness matters.

2017-11-22 Thread Michael Paquier
On Tue, Nov 21, 2017 at 9:08 PM, David CARLIER wrote: > Motivation : > - Using fail-safe, file descriptor free solution on *BSD and Darwin system > - Somehow avoiding at the moment FreeBSD as it still uses RC4 (seemingly > updated to Chacha20 for FreeBSD 12.0 and eventually

Re: [HACKERS] Commits don't block for synchronous replication

2017-11-22 Thread Michael Paquier
On Thu, Nov 23, 2017 at 4:32 AM, Ashwin Agrawal <aagra...@pivotal.io> wrote: > > On Wed, Nov 22, 2017 at 9:57 AM, Simon Riggs <si...@2ndquadrant.com> wrote: >> >> On 15 November 2017 at 10:07, Michael Paquier <michael.paqu...@gmail.com> >> wrote: &g

Re: PostgreSLQ v10.1 and xlC compiler on AIX

2017-11-23 Thread Michael Paquier
On Thu, Nov 23, 2017 at 7:57 PM, REIX, Tony wrote: > We are porting PostgreSQL v10.1 on AIX (7.2 for now). > And we have several tests failures, in 32bit and 64bit. > We are using xlc 13.01.0003.0003 with -O2. > Tests were 100% OK with version 9.6.2 . > > About 32 bit failures

Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove pgbench "progress" test pending solution of its timing is (fwd)

2017-11-28 Thread Michael Paquier
On Sun, Sep 24, 2017 at 11:30 PM, Fabien COELHO wrote: > Attached is an attempt at improving the situation: > > (1) there are added comments to explain the whys, which is to provide > coverage for pgbench time-related features... while still not being > time-sensitive, which

Re: [HACKERS] Pluggable storage

2017-11-28 Thread Michael Paquier
On Tue, Nov 14, 2017 at 5:09 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Tue, Nov 7, 2017 at 6:34 PM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> On Tue, Oct 31, 2017 at 8:59 PM, Haribabu Kommi <kommi.harib...@gmail.com> >> wrote:

Re: [HACKERS] Push down more UPDATEs/DELETEs in postgres_fdw

2017-11-28 Thread Michael Paquier
On Mon, Oct 2, 2017 at 9:08 AM, Daniel Gustafsson wrote: > This patch has been marked Ready for Committer in the current commitfest > without being committed or rejected. Moving to the next commitfest, but since > it has bitrotted I’m moving it to Waiting for author. No updates

Re: [HACKERS] why not parallel seq scan for slow functions

2017-11-28 Thread Michael Paquier
On Fri, Nov 10, 2017 at 4:42 AM, Robert Haas wrote: > On Thu, Nov 9, 2017 at 3:47 AM, Amit Kapila wrote: >> I think I understood your concern after some offlist discussion and it >> is primarily due to the inheritance related check which can skip

Re: [HACKERS] Refactoring identifier checks to consistently use strcmp

2017-11-28 Thread Michael Paquier
On Tue, Nov 28, 2017 at 10:07 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > I was just looking at the tsearch code which uses pg_strcmpcase, and > those are defined with makeDefElem() so you should switch to strcmp in > this case as well, no? If I patch the code mys

Re: [HACKERS] Race between SELECT and ALTER TABLE NO INHERIT

2017-11-28 Thread Michael Paquier
On Tue, Sep 19, 2017 at 3:04 PM, Kyotaro HORIGUCHI wrote: >> By the way, I will take a look at your patch when I come back from the >> vacation. Meanwhile, I noticed that it needs another rebase after >> 0a480502b092 [1]. Moved to CF 2018-01. -- Michael

Re: [HACKERS] UPDATE of partition key

2017-11-28 Thread Michael Paquier
On Mon, Nov 27, 2017 at 5:28 PM, Amit Khandekar wrote: > So, in the upcoming patch version, I am intending to include the above > two, and if possible, Robert's idea of re-using is_partition_attr() > for pull_child_partition_columns(). Discussions are still going on, so

Re: [HACKERS] static assertions in C++

2017-11-28 Thread Michael Paquier
On Fri, Sep 1, 2017 at 8:28 AM, Robert Haas wrote: > On Thu, Aug 31, 2017 at 6:37 PM, Tom Lane wrote: >> Meh. We support ancient versions of C for backwards compatibility >> reasons, but considering that compiling backend code with C++ isn't >>

Re: [HACKERS] A design for amcheck heapam verification

2017-11-28 Thread Michael Paquier
On Sat, Oct 21, 2017 at 9:34 AM, Peter Geoghegan wrote: > I should point out that I shipped virtually the same code yesterday, > as v1.1 of the Github version of amcheck (also known as amcheck_next). > Early adopters will be able to use this new "heapallindexed" > functionality in

Re: [HACKERS] WIP: Restricting pg_rewind to data/wal dirs

2017-11-28 Thread Michael Paquier
On Wed, Nov 1, 2017 at 5:58 PM, Chris Travers wrote: > I would also like to address a couple of important points here: > > 1. I think default restrictions plus additional paths is the best, safest > way forward. Excluding shell-globs doesn't solve the "I need this >

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2017-11-28 Thread Michael Paquier
On Fri, Oct 27, 2017 at 3:13 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Thu, Oct 26, 2017 at 3:05 AM, Kyotaro HORIGUCHI > <horiguchi.kyot...@lab.ntt.co.jp> wrote: >> The largest obstacle to do that is that walreceiver is not >> utterly concerned to re

Re: [HACKERS] A design for amcheck heapam verification

2017-11-28 Thread Michael Paquier
On Wed, Nov 29, 2017 at 2:54 PM, Peter Geoghegan wrote: > My understanding of your earlier remarks, rightly or wrongly, was that > you wanted me to adopt the Bloom filter to actually be usable from SQL > in some kind of general way. As opposed to what I just said -- adding > a stub

Re: [HACKERS] postgres_fdw: Add support for INSERT OVERRIDING clause

2017-11-28 Thread Michael Paquier
On Wed, Nov 29, 2017 at 8:12 AM, Tom Lane wrote: > IIRC, this issue was debated at great length back when we first put > in foreign tables, because early drafts of postgres_fdw did what you > propose here, and we ran into very nasty problems. We eventually decided > that

Re: [HACKERS] parallel.c oblivion of worker-startup failures

2017-11-28 Thread Michael Paquier
On Fri, Oct 27, 2017 at 9:54 PM, Amit Kapila wrote: > The patch still applies (with some hunks). I have added it in CF [1] > to avoid losing track. > > [1] - https://commitfest.postgresql.org/15/1341/ This did not get reviews and the patch still applies. I am moving it

Re: new function for tsquery creartion

2017-11-28 Thread Michael Paquier
On Tue, Nov 28, 2017 at 11:57 PM, Aleksander Alekseev wrote: >> I like the idea and I think it's a great patch. However in current shape it >> requires some amount of reworking to meet PostgreSQL standards of code >> quality. > > Also I would like to add that I agree

Re: [HACKERS] Walsender timeouts and large transactions

2017-11-28 Thread Michael Paquier
On Fri, Nov 17, 2017 at 4:35 PM, Kyotaro HORIGUCHI wrote: > I'm a reviewer of this patch but I think I'm not allowed to mark > this "Ready for Commiter" since the last change is made by me. Yes, it is a better idea to wait for reviews here. -- Michael

Re: [HACKERS] Re: proposal - psql: possibility to specify sort for describe commands, when size is printed

2017-11-28 Thread Michael Paquier
On Tue, Nov 28, 2017 at 4:18 AM, Pavel Stehule wrote: > This proposal is first time, when we cannot to detect full semantic from > \xxx command. When user extend query correctly, then it is better than > before, when not it is worse than before. As the discussion is

Re: [HACKERS] proposal - Default namespaces for XPath expressions (PostgreSQL 11)

2017-11-28 Thread Michael Paquier
On Sat, Nov 25, 2017 at 2:32 AM, Pavel Stehule wrote: > fixed regress test The last patch still applies, but did not get any reviews. Horiguchi-san, you are marked as a reviewer of this patch. Could you look at it? For now, I am moving it to next CF. -- Michael

Re: [HACKERS] A design for amcheck heapam verification

2017-11-28 Thread Michael Paquier
On Wed, Nov 29, 2017 at 2:48 PM, Peter Geoghegan wrote: > I still don't think that regression tests as such make sense. However, > it seems like it might be a good idea to add a test harness for the > Bloom filter code. I actually wrote code like this for myself during >

Re: [HACKERS] Function to move the position of a replication slot

2017-11-28 Thread Michael Paquier
On Tue, Sep 5, 2017 at 11:51 AM, Andres Freund <and...@anarazel.de> wrote: > On 2017-09-05 11:36:47 +0900, Michael Paquier wrote: >> On Thu, Aug 31, 2017 at 9:19 PM, Magnus Hagander <mag...@hagander.net> wrote: >> > PFA an updated and rebased patch

Re: [HACKERS] Another oddity in handling of WCO constraints in postgres_fdw

2017-11-28 Thread Michael Paquier
On Fri, Nov 10, 2017 at 8:36 PM, Etsuro Fujita wrote: > For local constraints on foreign tables, it's the user's responsibility to > ensure that those constraints matches the remote side, so we don't need to > ensure those constraints locally. But I'm not sure if the

Re: [HACKERS] CUBE seems a bit confused about ORDER BY

2017-11-28 Thread Michael Paquier
On Tue, Nov 21, 2017 at 7:07 AM, Alexander Korotkov wrote: > On Mon, Nov 20, 2017 at 1:59 PM, Alexander Korotkov > wrote: >> >> On Mon, Nov 20, 2017 at 4:09 AM, Tomas Vondra >> wrote: >>> >>> Seems fine to me,

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

2017-11-28 Thread Michael Paquier
On Wed, Nov 8, 2017 at 8:50 AM, Haribabu Kommi wrote: > Ok. Removed the documentation changes that it cannot be used for normal > scenarios, and also added a Note section explaining the problem of using > the dump with pg_restore command with --clean and --create

Re: [HACKERS] CUBE seems a bit confused about ORDER BY

2017-11-29 Thread Michael Paquier
On Wed, Nov 29, 2017 at 7:59 PM, Alexander Korotkov wrote: > Sure, patch got some review. I've no objection against moving this to the > next commitfest though. Please note that as this is qualified as a bug fix, I was not going to mark it as returned with feedback or

Re: [HACKERS] logical decoding of two-phase transactions

2017-11-28 Thread Michael Paquier
On Fri, Nov 24, 2017 at 3:41 PM, Craig Ringer wrote: > It looks amazingly simple from here. Which probably means there's more to it > that I haven't seen yet. I could use advice from someone who knows the > locking subsystem better. The status of this patch is I think not

Re: [HACKERS] Add Roman numeral conversion to to_number

2017-11-28 Thread Michael Paquier
On Sun, Nov 19, 2017 at 3:32 AM, Tom Lane wrote: > Oliver Ford writes: >> Attached is v2 of src, tests and docs. Doc patch is unchanged from v1. > > I took a quick look at this patch. This got a review, and no replies after 10 days to I am marking it as

Re: [HACKERS] SQL/JSON in PostgreSQL

2017-11-28 Thread Michael Paquier
On Wed, Nov 15, 2017 at 10:17 AM, Nikita Glukhov wrote: > Attached the new version of the patches where displaying of SQL/JSON > constructor nodes was fixed. I decided not to invent new nodes but to > extend > existing FuncExpr, Aggref, WindowFunc nodes with new

Re: [HACKERS] postgres_fdw: support parameterized foreign joins

2017-11-28 Thread Michael Paquier
On Mon, Oct 2, 2017 at 9:06 AM, Daniel Gustafsson wrote: > This patch has been marked Ready for Committer in the current commitfest > without being committed or rejected. Moving to the next commitfest, but since > it has bitrotted I’m moving it to Waiting for author. One month

Re: [HACKERS] Vacuum: allow usage of more than 1GB of work mem

2017-11-28 Thread Michael Paquier
On Mon, Oct 2, 2017 at 11:02 PM, Claudio Freire wrote: > Rebased version of the patches attached The status of the patch is misleading: https://commitfest.postgresql.org/15/844/. This was marked as waiting on author but a new version has been published. Let's be careful.

Re: [HACKERS] Runtime Partition Pruning

2017-11-28 Thread Michael Paquier
On Wed, Nov 15, 2017 at 3:53 PM, Beena Emerson wrote: > Thank you for your suggestion. I am looking into this and will post a > patch soon. It has been two weeks since this update and no new patch has showed up. I am marking the patch as returned with feedback. If you

Re: [HACKERS] Range Merge Join v1

2017-11-28 Thread Michael Paquier
On Mon, Sep 18, 2017 at 2:24 AM, Jeff Davis wrote: > Any comments or alternative suggestions welcome. This will probably > take a few days at least, so I put the patch in "waiting on author" > state. This did not receive an update for two months. I am marking it as returned

Re: [HACKERS] Small improvement to compactify_tuples

2017-11-28 Thread Michael Paquier
On Wed, Nov 29, 2017 at 8:00 AM, Peter Geoghegan wrote: > On Tue, Nov 28, 2017 at 2:41 PM, Andres Freund wrote: >> Maybe it's a stupid question. But would we still want to have this after >> the change? These should be just specializations of the template

Re: [HACKERS] GSoC 2017: weekly progress reports (week 4) and patch for hash index

2017-11-28 Thread Michael Paquier
On Mon, Sep 25, 2017 at 10:34 PM, Shubham Barai wrote: > I have attached the rebased version of patch here. The patch does not apply and there has been no reviews as well. In consequence, I am moving it to next CF with "waiting on author" as status. Please provide a

Re: Jsonb transform for pl/python

2017-11-28 Thread Michael Paquier
On Mon, Nov 20, 2017 at 10:48 PM, Aleksander Alekseev wrote: > Well frankly I very much doubt that this: > [snip] > I'm afraid that tests fail on Python 3: So this still needs more work.. I am marking it as returned with feedback as there has been no updates for more

Re: [HACKERS] GSoC 2017 : Patch for predicate locking in Gist index

2017-11-28 Thread Michael Paquier
On Mon, Nov 27, 2017 at 4:47 PM, Alexander Korotkov wrote: > Also, you've long comment lines in predicate-gist.spec. Please, break long > comments into multiple lines. Two days is to short to reply. I am moving this patch to next CF. -- Michael

Re: [HACKERS] GSoC 2017: weekly progress reports (week 6)

2017-11-28 Thread Michael Paquier
On Tue, Oct 3, 2017 at 1:51 AM, Alexander Korotkov wrote: > I think that isolation tests should be improved. It doesn't seems that any > posting tree would be generated by the tests that you've provided, because > all the TIDs could fit the single posting list. Note,

Re: [HACKERS] Causal reads take II

2017-11-28 Thread Michael Paquier
On Sat, Oct 28, 2017 at 6:24 AM, Thomas Munro wrote: > I managed to reproduce something like this on one of my home lab > machines running a different OS. Not sure why yet and it doesn't > happen on my primary development box which is how I hadn't noticed it. > I

Re: [HACKERS] GSoC 2017: Foreign Key Arrays

2017-11-28 Thread Michael Paquier
On Mon, Nov 27, 2017 at 10:47 AM, Andreas Karlsson wrote: > Cool, feel free to ask if you need some assistance. I want this patch. The last patch submitted did not get a review, and it does not apply as well. So I am moving it to next CF with waiting on author as status.

Re: [HACKERS] Statement-level rollback

2017-11-28 Thread Michael Paquier
On Mon, Nov 6, 2017 at 9:36 PM, MauMau wrote: > From: Thomas Munro > With your v2 patch "make docs" fails. Here is a small patch to apply > on top of yours to fix that and some small copy/paste errors, if I > understood correctly. > > Ouch, thanks. I'd like to merge your

Re: [HACKERS] Re: Is anything preventing us from allowing write to foreign tables from standby?

2017-11-28 Thread Michael Paquier
On Fri, Oct 27, 2017 at 4:44 PM, Robert Haas wrote: > However, as Michael also points out, it's arguably wrong to allow a > nominally read-only transaction to write data regardless of whether it > works. In the case of a standby it could be argued that your > transaction

Re: [HACKERS] [Proposal] Make the optimiser aware of partitions ordering

2017-11-28 Thread Michael Paquier
On Wed, Sep 27, 2017 at 2:59 AM, Julien Rouhaud wrote: > On Tue, Sep 26, 2017 at 2:56 PM, Robert Haas wrote: >> On Sat, Sep 23, 2017 at 6:29 AM, Julien Rouhaud wrote: >>> That's true, but numCols, sortColdIdx etc are also used to

Re: [HACKERS] WIP: Covering + unique indexes.

2017-11-28 Thread Michael Paquier
On Sun, Nov 12, 2017 at 8:40 PM, Andrey Borodin wrote: > Postgres crashes: > TRAP: FailedAssertion("!(((const void*)() != ((void*)0)) && > (scankey->sk_attno) > 0)", File: "nbtsearch.c", Line: 466) > > May be I'm doing something wrong or amcheck support will go with

Re: [HACKERS] SERIALIZABLE with parallel query

2017-11-29 Thread Michael Paquier
On Fri, Nov 24, 2017 at 1:06 PM, Haribabu Kommi wrote: > The latest patch is good. It lacks a test that verifies the serialize > support with actual parallel workers, so in case if it broken, it is > difficult to know. Could this question be answered? The patch still

Re: [HACKERS] Cached plans and statement generalization

2017-11-29 Thread Michael Paquier
On Wed, Sep 13, 2017 at 2:11 AM, Konstantin Knizhnik wrote: > One more patch passing all regression tests with autoprepare_threshold=1. > I still do not think that it should be switch on by default... This patch does not apply, and did not get any reviews. So I am

Re: [HACKERS] [PATCH] Overestimated filter cost and its mitigation

2017-11-29 Thread Michael Paquier
On Thu, Nov 9, 2017 at 12:33 PM, Ashutosh Bapat wrote: > Looking at order_qual_clauses(), we can say that a set of quals q1 > qn are ordered the same irrespective of the set of clauses they > are subset of. E.g. if {q1 .. qn} is subset of Q (ordered as Qo)

Re: [HACKERS] Proposal: generic WAL compression

2017-11-29 Thread Michael Paquier
On Mon, Nov 20, 2017 at 4:49 PM, Antonin Houska wrote: > One more idea: > > I think the metadata (ALIGN_GAP) should be stored separate from the actual > data so that you can use memcpy() instead of this loop: > > while (i < j) > { > charc =

Re: [HACKERS] create_unique_path and GEQO

2017-11-29 Thread Michael Paquier
On Fri, Mar 24, 2017 at 10:50 PM, Tom Lane wrote: > Ashutosh Bapat writes: >>> Do you have test case, which can reproduce the issue you >>> explained above? > >> No. It would require some surgery in standard_planner() to measure the >> memory

Re: [HACKERS] postgres_fdw: Add support for INSERT OVERRIDING clause

2017-11-29 Thread Michael Paquier
On Wed, Nov 29, 2017 at 1:53 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Wed, Nov 29, 2017 at 8:12 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> IIRC, this issue was debated at great length back when we first put >> in foreign tables, because early drafts o

Re: [HACKERS] Parallel Append implementation

2017-11-29 Thread Michael Paquier
On Tue, Nov 28, 2017 at 8:02 PM, amul sul wrote: > Apart from this I have added few assert to keep eye on node->as_whichplan > value in the attached patch, thanks. This is still hot, moved to next CF. -- Michael

Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

2017-11-29 Thread Michael Paquier
On Wed, Nov 29, 2017 at 5:33 AM, Robert Haas wrote: > On Sun, Nov 26, 2017 at 9:33 PM, Masahiko Sawada > wrote: >> Attached latest patch incorporated all comments so far. Please review it. > > I think you only need RelExtLockReleaseAllI() where we

Re: [HACKERS] Removing LEFT JOINs in more cases

2017-11-29 Thread Michael Paquier
On Wed, Nov 22, 2017 at 10:30 PM, Ashutosh Bapat wrote: > On Wed, Nov 1, 2017 at 5:39 AM, David Rowley > wrote: > >> In this case, the join *can* cause row duplicates, but the distinct or >> group by would filter these out again

Re: [HACKERS] [PATCH] Add ALWAYS DEFERRED option for constraints

2017-11-29 Thread Michael Paquier
On Wed, Nov 8, 2017 at 8:30 AM, Nico Williams wrote: > On Mon, Nov 06, 2017 at 05:50:21PM +1300, Thomas Munro wrote: >> On Fri, Oct 20, 2017 at 9:05 AM, Nico Williams wrote: >> > Rebased (there were conflicts in the SGML files). >> >> Hi Nico >> >>

Re: [HACKERS] Custom compression methods

2017-11-29 Thread Michael Paquier
On Thu, Nov 30, 2017 at 8:30 AM, Tomas Vondra wrote: > On 11/28/2017 02:29 PM, Ildus Kurbangaliev wrote: >> On Mon, 27 Nov 2017 18:20:12 +0100 >> Tomas Vondra wrote: >> >>> I guess the trick might be -DRANDOMIZE_ALLOCATED_MEMORY (I

Re: [HACKERS] INSERT .. ON CONFLICT DO SELECT [FOR ..]

2017-11-29 Thread Michael Paquier
On Tue, Sep 5, 2017 at 3:28 AM, Marko Tiikkaja wrote: > On Mon, Sep 4, 2017 at 7:46 PM, Peter Geoghegan wrote: >> >> On Mon, Sep 4, 2017 at 10:05 AM, Marko Tiikkaja wrote: >> >> > But I'm generally against >> > interfaces which put arbitrary

Re: [HACKERS] log_destination=file

2017-11-29 Thread Michael Paquier
On Wed, Nov 15, 2017 at 12:33 AM, Robert Haas wrote: > On Sun, Sep 10, 2017 at 5:29 AM, Dmitry Dolgov <9erthali...@gmail.com> wrote: >> average latency: >> >> clients patch master >> 10 0.321 0.286 >> 20 0.669 0.602 >> 30

Re: [HACKERS] REINDEX CONCURRENTLY 2.0

2017-11-29 Thread Michael Paquier
On Wed, Nov 1, 2017 at 1:20 PM, Andreas Karlsson wrote: > Here is a rebased version of the patch. The patch does not apply, and needs a rebase. I am moving it to next CF with waiting on author as status. -- Michael

Re: [HACKERS] WIP: [[Parallel] Shared] Hash

2017-11-29 Thread Michael Paquier
On Wed, Jun 28, 2017 at 9:58 AM, Thomas Munro wrote: > Rebased for the recent re-indent and shm_toc API change; no functional > changes in this version. > > (I have a new patch set in the pipeline adding the skew optimisation > and some other things, more on that

Re: [HACKERS] Re: Improve OR conditions on joined columns (common star schema problem)

2017-11-29 Thread Michael Paquier
On Tue, Sep 12, 2017 at 9:48 PM, Tom Lane wrote: > Jim Nasby writes: >> I've verified that the patch still applies and make check-world is clean. > > Not any more :-(. Here's a v3 rebased over HEAD. No substantive > change from v2. Patch applies and

Re: [HACKERS] <> join selectivity estimate question

2017-11-29 Thread Michael Paquier
On Thu, Sep 14, 2017 at 2:23 PM, Ashutosh Bapat wrote: > Are you referring to rounding errors? We should probably add some fuzz > factor to cover the rounding errors and cause a diff when difference > in expected and reported plan rows is beyond that fuzz factor.

Re: [HACKERS] path toward faster partition pruning

2017-11-29 Thread Michael Paquier
On Thu, Nov 30, 2017 at 10:43 AM, Amit Langote wrote: > I'm working on a revised version of these patches to address recent > comments by Horiguchi-san. I will also consider the points above before > sending the new version. Ok, this is fresh news, so I am moving

Re: [HACKERS] [PATCH] Call RelationDropStorage() for broader range of object drops.

2017-11-29 Thread Michael Paquier
On Fri, Sep 15, 2017 at 4:36 AM, Alexander Korotkov wrote: > +1, > FDW looks OK for prototyping pluggable storage, but it doesn't seem suitable > for permanent implementation. > BTW, Hadi, could you visit "Pluggable storage" thread and check how suitable > upcoming

Re: [HACKERS] postgres_fdw bug in 9.6

2017-11-29 Thread Michael Paquier
On Thu, Nov 30, 2017 at 7:32 AM, Tom Lane wrote: > [snip] Moving to next CF per the hotness of the topic. -- Michael

Re: [HACKERS] Bug in to_timestamp().

2017-11-29 Thread Michael Paquier
On Thu, Nov 23, 2017 at 12:23 AM, Arthur Zakirov wrote: > Messages have the following format now: > > SELECT to_timestamp('97/Feb/16', 'FXYY:Mon:DD'); > ERROR: unexpected character "/", expected ":" > HINT: In FX mode, punctuation in the input string must exactly match

Re: WIP: BRIN multi-range indexes

2017-11-29 Thread Michael Paquier
On Sun, Nov 19, 2017 at 5:45 AM, Tomas Vondra wrote: > Apparently there was some minor breakage due to duplicate OIDs, so here > is the patch series updated to current master. Moved to CF 2018-01. -- Michael

Re: [HACKERS] Support to COMMENT ON DATABASE CURRENT_DATABASE

2017-11-29 Thread Michael Paquier
On Mon, Nov 27, 2017 at 11:41 AM, Jing Wang wrote: > Hi All, > > This is a patch for current_database working on ALTER ROLE/GRANT/REVOKE > statements which should be applied after the previous patch > "comment_on_current_database_no_pgdump_v4.4.patch". > > By using the

Re: [HACKERS] Dynamic result sets from procedures

2017-11-29 Thread Michael Paquier
On Thu, Nov 16, 2017 at 8:27 PM, Daniel Verite wrote: > Peter Eisentraut wrote: > >> There is also one need error that needs further investigation. > > I've looked at this bit in the regression tests about \gexec: > > --- a/src/test/regress/expected/psql.out > +++

Re: [HACKERS] CONNECTION LIMIT and Parallel Query don't play well together

2017-11-29 Thread Michael Paquier
On Fri, Aug 25, 2017 at 6:25 PM, David Rowley wrote: > I just had a quick glance over this and wondered about 2 things. > > 1. Why a GUC and not a new per user option so it can be configured > differently for different users? Something like ALTER USER ... WORKER >

Re: [HACKERS] [POC] Faster processing at Gather node

2017-11-29 Thread Michael Paquier
On Sun, Nov 26, 2017 at 5:15 PM, Amit Kapila wrote: > Yeah and I think something like that can happen after your patch > because now the memory for tuples returned via TupleQueueReaderNext > will be allocated in ExecutorState and that can last for long. I > think it is

Re: [HACKERS] PATCH: enabling parallel execution for cursors explicitly (experimental)

2017-11-29 Thread Michael Paquier
On Thu, Nov 2, 2017 at 11:35 AM, Robert Haas wrote: > On Thu, Nov 2, 2017 at 8:01 AM, Craig Ringer wrote: >> That forces materialization, and I'm guessing part of Tomas's goal >> here is to prevent the need to materialize into a temp table / >>

Re: [HACKERS] eval_const_expresisions and ScalarArrayOpExpr

2017-11-29 Thread Michael Paquier
On Mon, Oct 2, 2017 at 7:52 AM, Tom Lane wrote: > I wrote: >> This patch no longer applies cleanly on HEAD, so here's a rebased version >> (no substantive changes). As before, I think the most useful review task >> would be to quantify whether it makes planning noticeably

Re: [HACKERS] make async slave to wait for lsn to be replayed

2017-11-29 Thread Michael Paquier
On Tue, Oct 31, 2017 at 9:42 PM, Ants Aasma wrote: > Robert made a good point that people will still rely on the token > being an LSN, but perhaps they will be slightly less angry when we > explicitly tell them that this might change in the future. This thread has stalled, I

Re: [HACKERS] [PROPOSAL] Temporal query processing with range types

2017-11-29 Thread Michael Paquier
On Tue, Nov 21, 2017 at 6:36 PM, Peter Moser wrote: > 2017-11-14 18:42 GMT+01:00 Tom Lane : >> You might consider putting the rewriting into, um, the rewriter. >> It could be a separate pass after view expansion, if direct integration >> with the existing

Re: [HACKERS] plpgsql - additional extra checks

2017-11-29 Thread Michael Paquier
On Wed, Sep 13, 2017 at 12:51 PM, Pavel Stehule wrote: > > > 2017-09-13 1:42 GMT+02:00 Daniel Gustafsson : >> >> > On 08 Apr 2017, at 15:46, David Steele wrote: >> > >> >> On 1/13/17 6:55 AM, Marko Tiikkaja wrote: >> >>> On Fri, Jan

Re: Protect syscache from bloating with negative cache entries

2017-11-29 Thread Michael Paquier
On Thu, Nov 30, 2017 at 12:32 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Wed, Nov 29, 2017 at 8:25 PM, Michael Paquier > <michael.paqu...@gmail.com> wrote: >> On Tue, Oct 31, 2017 at 6:46 PM, Kyotaro HORIGUCHI >> <horiguchi.kyot...@lab.ntt.co.jp>

Re: [HACKERS] Flexible configuration for full-text search

2017-11-29 Thread Michael Paquier
On Tue, Nov 7, 2017 at 3:18 PM, Aleksandr Parfenov wrote: > On Mon, 6 Nov 2017 18:05:23 +1300 > Thomas Munro wrote: > >> On Sat, Oct 21, 2017 at 1:39 AM, Aleksandr Parfenov >> wrote: >> > In attachment updated

Re: pl/perl extension fails on Windows

2017-11-29 Thread Michael Paquier
On Thu, Nov 30, 2017 at 1:34 PM, Tom Lane wrote: > Noah Misch writes: >> On Thu, Aug 17, 2017 at 12:15:58PM -0400, Tom Lane wrote: >>> ... it's now looking to me like we should do the above with X = 5.13.4. >>> That won't be a perfect solution, but it's

  1   2   3   4   5   6   7   8   9   10   >