Re: Do we accept doc changes to back branches?

2017-11-27 Thread Stephen Frost
Greetings, * Joshua D. Drake (j...@commandprompt.com) wrote: > I don't recall, do we allow non-bug fix (or what constitutes a bug) > for back branches with docs? I have been reviewing the logical > replication docs and they could use some love but I need to know > which branch I should start work

Re: [HACKERS] postgres_fdw super user checks

2017-11-28 Thread Stephen Frost
Tom, Robert, all, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Robert Haas writes: > > OK, let me try to summarize where we are with this. > > > Currently, postgres_fdw requires a password unless you are logged in > > as a superuser. Jeff proposes to change that so that it

Re: [HACKERS] postgres_fdw super user checks

2017-11-29 Thread Stephen Frost
Ashutosh, * Ashutosh Bapat (ashutosh.ba...@enterprisedb.com) wrote: > On Wed, Nov 29, 2017 at 4:56 AM, Stephen Frost <sfr...@snowman.net> wrote: > > The "global rethink" being contemplated seems to be more about > > authentication forwarding than it is about this s

Re: using index or check in ALTER TABLE SET NOT NULL

2017-11-29 Thread Stephen Frost
Robert, * Robert Haas (robertmh...@gmail.com) wrote: > On Tue, Nov 28, 2017 at 1:59 PM, Sergei Kornilov wrote: > > I write patch to speed up ALTER TABLE SET NOT NULL by check existed check > > constraints or indexes. Huge phase 3 with verify table data will be skipped > > if

Re: using index or check in ALTER TABLE SET NOT NULL

2017-11-29 Thread Stephen Frost
Tom, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost <sfr...@snowman.net> writes: > > Isn't the first concern addressed by using SPI..? > > I did not look at the patch yet, but TBH if it uses SPI for sub-operations > of ALTER TABLE I think that is sufficient

Re: using index or check in ALTER TABLE SET NOT NULL

2017-11-29 Thread Stephen Frost
Robert, * Robert Haas (robertmh...@gmail.com) wrote: > On Wed, Nov 29, 2017 at 10:52 AM, Sergei Kornilov wrote: > > I agree this. Thinking a little about idea of index scan i can not give > > reasonable usecase which required index. My target problem of adding NOT > > NULL to

Re: [HACKERS] postgres_fdw super user checks

2017-12-03 Thread Stephen Frost
Robert, all, * Robert Haas (robertmh...@gmail.com) wrote: > On Fri, Dec 1, 2017 at 12:31 AM, Michael Paquier > wrote: > > I am moving this patch to next CF 2018-01. > > There now seems to be a consensus for superuser -> superuser_arg > rather than what Jeff did

Re: Speeding up pg_upgrade

2017-12-05 Thread Stephen Frost
Bruce, * Bruce Momjian (br...@momjian.us) wrote: > On Tue, Dec 5, 2017 at 09:16:02AM -0500, Stephen Frost wrote: > > > There are clusters that take a long time to dump the schema from the old > > > cluster and recreate it in the new cluster. One idea of speeding up &

Re: Speeding up pg_upgrade

2017-12-05 Thread Stephen Frost
Bruce, * Bruce Momjian (br...@momjian.us) wrote: > > In any case, of course, if we're able to move part of what pg_upgrade > > does to be while the old server is online then that takes whatever the > > cost of that is out of the downtime window. The question is if that's a > > 5% improvement in

Re: PATCH: Exclude unlogged tables from base backups

2017-12-13 Thread Stephen Frost
David, * David Steele (da...@pgmasters.net) wrote: > On 12/12/17 8:48 PM, Stephen Frost wrote: > > I don't think there is, because, as David points out, the unlogged > > tables are cleaned up first and then WAL replay happens during recovery, > > so the init fork wi

Re: GSoC 2018

2017-12-18 Thread Stephen Frost
Aleksander, * Aleksander Alekseev (a.aleks...@postgrespro.ru) wrote: > Thanks you a lot for your feedback. I modified the project description > to make it more clear that it implies augmenting an existing HA > solution, particularly Stolon, and doesn't imply solving existing > limitations of

GSoC 2018

2017-12-14 Thread Stephen Frost
Greetings -hackers, Google Summer of Code 2018 was announced back in September and they've changed up the timeline a bit [1]. Specifically, they moved up the dates for things like the mentoring organization application deadline, so it's time to start working on our Idea's page for 2018 in

Re: GSoC 2018

2017-12-15 Thread Stephen Frost
Aleksander, * Aleksander Alekseev (a.aleks...@postgrespro.ru) wrote: > > HA/fail-over is a very broad topic, with a lot of pieces that need to be > > done such that I'm not sure it's really viable, but perhaps a precursor > > project (synchronous logical replication seems like a prereq, no?)

Re: GSoC 2018

2017-12-15 Thread Stephen Frost
Alex, * Alex Kliukin (al...@hintbits.com) wrote: > On Fri, Dec 15, 2017, at 14:30, Stephen Frost wrote: > > * Aleksander Alekseev (a.aleks...@postgrespro.ru) wrote: > > > > > Regarding the difficulty of the project - in fact it's not that > > > difficult. P

Re: GSoC 2018

2017-12-15 Thread Stephen Frost
Aleksander, * Aleksander Alekseev (a.aleks...@postgrespro.ru) wrote: > > New entries are certainly welcome and encouraged, just be sure to note > > them as '2018' when you add it. > > I proposed a few ideas: Thanks! > * High availability / failover based on logical replication > * Thrift

Re: GSoC 2018

2017-12-15 Thread Stephen Frost
Stefan, * Stefan Keller (sfkel...@gmail.com) wrote: > 2017-12-15 4:14 GMT+01:00 Stephen Frost <sfr...@snowman.net>: > > Unsurprisingly, we'll need to have an Ideas page again, so I've gone > > ahead and created one (copying last year's): > > What about adding &quo

Re: GSoC 2018

2017-12-15 Thread Stephen Frost
Alex, * Alex Kliukin (al...@hintbits.com) wrote: > On Fri, Dec 15, 2017, at 14:52, Aleksander Alekseev wrote: > > Completely agree, this project can be an improvement for Stolon (or > > Patroni, but I personally never tested or used it, also I got a feeling > > that Google guys will prefer a

Re: PATCH: Exclude unlogged tables from base backups

2017-12-12 Thread Stephen Frost
Andres, * Andres Freund (and...@anarazel.de) wrote: > On 2017-12-12 18:04:44 -0500, David Steele wrote: > > If the forks are written out of order (i.e. main before init), which is > > definitely possible, then I think worst case is some files will be backed up > > that don't need to be. The main

Re: Schedule for migration to pglister

2017-11-16 Thread Stephen Frost
Magnus, all, * Magnus Hagander (mag...@hagander.net) wrote: > mbox access should now be restored, and as Stephen says, now handled by the > Date in the message. Let me know if there are any issues with the new ones. > (They're now generated by the same code as the per-thread ones). And just fyi,

Re: Migration to PGLister - After

2017-11-13 Thread Stephen Frost
Greetings, * Tatsuo Ishii (is...@sraoss.co.jp) wrote: > > This list has now been migrated to new mailing list software known as > > 'PGLister'. This migration will impact all users of this mailing list > > in one way or another. > > > > If you would like to unsubscribe from this mailing list,

Migration to PGLister - After

2017-11-13 Thread Stephen Frost
Greetings! This list has now been migrated to new mailing list software known as 'PGLister'. This migration will impact all users of this mailing list in one way or another. If you would like to unsubscribe from this mailing list, please click on 'Show Original' or 'Show Headers' in your client

Re: to_typemod(type_name) information function

2017-11-21 Thread Stephen Frost
Greeting, Sophie! * Sophie Herold (sophi...@hemio.de) wrote: > I did not find any advice on how to choose a new OID for pg_proc. (Haven't looked at the patch itself yet really, but wanted to answer this.) The main thing is to not duplicate the OID, which you can avoid by calling 'unused_oids'

Re: Schedule for migration to pglister

2017-11-15 Thread Stephen Frost
Noah, * Noah Misch (n...@leadboat.com) wrote: > On Mon, Nov 06, 2017 at 10:36:38AM -0500, Stephen Frost wrote: > > Our planned migration schedule is as follows: > > > > Nov 6 - > > pgsql-www > > > > Nov 13 - > > pgsql-hackers > > When each

Re: [HACKERS] postgres_fdw super user checks

2017-12-05 Thread Stephen Frost
Robert, Ashutosh, * Robert Haas (robertmh...@gmail.com) wrote: > On Mon, Dec 4, 2017 at 5:57 PM, Ashutosh Bapat > wrote: > > I think the real behaviour can be described as something like this: > > > > "Only superusers may connect to foreign servers without

Re: Speeding up pg_upgrade

2017-12-08 Thread Stephen Frost
Bruce, * Bruce Momjian (br...@momjian.us) wrote: > I think the big problem with two-stage pg_upgrade is that the user steps > are more complex, so what percentage of users are going use the > two-stage method. The bad news is that only a small percentage of users > who will benefit from it will

Re: Speeding up pg_upgrade

2017-12-08 Thread Stephen Frost
Mark, * Mark Dilger (hornschnor...@gmail.com) wrote: > > On Dec 7, 2017, at 10:24 PM, Bruce Momjian wrote: > > I think the big problem with two-stage pg_upgrade is that the user steps > > are more complex, so what percentage of users are going use the > > two-stage method. The

Re: Speeding up pg_upgrade

2017-12-07 Thread Stephen Frost
Alexander, * Alexander Kukushkin (cyberd...@gmail.com) wrote: > Couple of months ago we at Zalando upgraded a few databases of different > sizes to 9.6. Thanks for sharing your experience! > During preparations to the I've found 2.5 pain-points: > > 1. We are using schema-based api deployment.

Re: Speeding up pg_upgrade

2017-12-07 Thread Stephen Frost
Alvaro, * Alvaro Herrera (alvhe...@alvh.no-ip.org) wrote: > Stephen Frost wrote: > > * Alexander Kukushkin (cyberd...@gmail.com) wrote: > > > > 2 ANALYZE phase is a pain. I think everybody agrees with it. > > > > > > 2.5 Usually ANALYZE stage 1 compl

Re: Speeding up pg_upgrade

2017-12-07 Thread Stephen Frost
Tom, David, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost <sfr...@snowman.net> writes: > > Well, if it's dropped, I think we need to make sure that users are aware > > of that going in and that's why I was suggesting a switch. If you've > > got a better idea

Re: Speeding up pg_upgrade

2017-12-07 Thread Stephen Frost
Robert, all, * Robert Haas (robertmh...@gmail.com) wrote: > On Thu, Dec 7, 2017 at 11:42 AM, Tom Lane wrote: > > Alvaro Herrera writes: > >> It seems pretty clear to me that we should somehow transfer stats from > >> the old server to the new one.

Re: Speeding up pg_upgrade

2017-12-07 Thread Stephen Frost
Tom, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost <sfr...@snowman.net> writes: > > If we go down that route, since this makes a pretty serious difference > > in terms of what the user has to deal with post-pg_upgrade, I'd suggest > > we require an additional

Re: Speeding up pg_upgrade

2017-12-09 Thread Stephen Frost
Bruce, * Bruce Momjian (br...@momjian.us) wrote: > On Fri, Dec 8, 2017 at 12:26:55PM -0500, Stephen Frost wrote: > > * Bruce Momjian (br...@momjian.us) wrote: > > > I think the big problem with two-stage pg_upgrade is that the user steps > > > are more complex,

Re: That mode-700 check on DATADIR again

2017-12-11 Thread Stephen Frost
Greetings Chapman, * Chapman Flack (c...@anastigmatix.net) wrote: > I have, more or less, this classic question: > > https://www.postgresql.org/message-id/4667C403.1070807%40t3go.de [...] > So, it seems there's at least one use case where some kind of >

Re: Speeding up pg_upgrade

2017-12-05 Thread Stephen Frost
Bruce, * Bruce Momjian (br...@momjian.us) wrote: > As part of PGConf.Asia 2017 in Tokyo, we had an unconference topic about > zero-downtime upgrades. After the usual discussion of using logical > replication, Slony, and perhaps having the server be able to read old > and new system catalogs, we

Re: perlcritic and perltidy

2018-05-06 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Andrew Dunstan writes: > > On 05/06/2018 11:53 AM, Tom Lane wrote: > >> What sort of changes do we get if we remove those two flags as you prefer? > >> It'd help to see some examples. > > > Essentially it adds

Re: GSoC 2018: thrift encoding format

2018-05-04 Thread Stephen Frost
Greetings, * Aleksander Alekseev (a.aleks...@postgrespro.ru) wrote: > > I understand that you're open to having it as a new data type or as a > > bytea, but I don't agree. This should be a new data type, just as json > > is a distinct data type and so is jsonb. > > Could you please explain in a

Re: perlcritic and perltidy

2018-05-06 Thread Stephen Frost
Michael, * Michael Paquier (mich...@paquier.xyz) wrote: > On Sun, May 06, 2018 at 01:46:28PM -0400, Stephen Frost wrote: > > I definitely prefer to have the braces on their own line- makes working > > with the files a lot easier when you've got a lot of hashes > > (partic

Re: Verbosity of genbki.pl

2018-04-28 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Peter Eisentraut writes: > > Maybe we can take another look at this. Right now, make -s world > > produces *only* the following output: > > > $ make -s world > > Generating BKI files and symbol definition

Re: [HACKERS] Clock with Adaptive Replacement

2018-04-28 Thread Stephen Frost
Greetings, * Peter Geoghegan (p...@bowt.ie) wrote: > On Thu, Apr 26, 2018 at 10:39 AM, Robert Haas wrote: > > I'm personally not very excited about making rules like "index pages > > are more valuable than heap pages". Such rules will in many cases be > > true, but it's

Re: Patch missing from back branches

2018-04-28 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > There is dory in the buildfarm which compiles using VS 2015, but it runs > only 9.6 and newer versions. That would be specifically because compiling 9.5 didn't work.. We'd be happy to have dory running on older major versions, if

Re: Postgres, fsync, and OSs (specifically linux)

2018-04-28 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2018-04-27 19:38:30 -0400, Bruce Momjian wrote: > > On Fri, Apr 27, 2018 at 04:10:43PM -0700, Andres Freund wrote: > > > On 2018-04-27 19:04:47 -0400, Bruce Momjian wrote: > > > > On Fri, Apr 27, 2018 at 03:28:42PM -0700, Andres Freund

Re: Postgres, fsync, and OSs (specifically linux)

2018-04-28 Thread Stephen Frost
Greetings, * Craig Ringer (cr...@2ndquadrant.com) wrote: > On 28 April 2018 at 06:28, Andres Freund wrote: > > - Add a pre-checkpoint hook that checks for filesystem errors *after* > > fsyncing all the files, but *before* logging the checkpoint completion > > record.

Re: "could not reattach to shared memory" on buildfarm member dory

2018-04-28 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Noah Misch writes: > > On Tue, Apr 24, 2018 at 11:37:33AM +1200, Thomas Munro wrote: > >> Maybe try asking what's mapped there with VirtualQueryEx() on failure? > > > +1. An implementation of that: > >

Re: Toast issues with OldestXmin going backwards

2018-04-28 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Fri, Apr 27, 2018 at 11:35 AM, Andrew Gierth > wrote: > >> "Robert" == Robert Haas writes: > > Robert> One idea that occurred to me is to somehow record -- I guess in > >

Re: perlcritic and perltidy

2018-05-08 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Sun, May 06, 2018 at 09:14:06PM -0400, Stephen Frost wrote: > > While I appreciate the support, I'm not sure that you're actually > > agreeing with me.. I was arguing that braces should be on their own > &g

Re: perlcritic and perltidy

2018-05-08 Thread Stephen Frost
Greetings, * Andrew Dunstan (andrew.duns...@2ndquadrant.com) wrote: > On 05/08/2018 10:06 AM, Andrew Dunstan wrote: > > { find . -type f -a \( -name > > '*.pl' -o -name '*.pm' \) -print; find . -type f -perm -100 > > -exec file {} \; -print    | egrep -i > >

Re: perlcritic and perltidy

2018-05-08 Thread Stephen Frost
Greetings, * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > Stephen Frost wrote: > > > * Andrew Dunstan (andrew.duns...@2ndquadrant.com) wrote: > > > > > - 'XLogRecPtr'=> 'pg_lsn'); > > > + 'XLogRecPtr'=> 'pg_lsn

Re: perlcritic and perltidy

2018-05-08 Thread Stephen Frost
Andrew, * Andrew Dunstan (andrew.duns...@2ndquadrant.com) wrote: > On 05/08/2018 12:51 PM, Stephen Frost wrote: > > * Andrew Dunstan (andrew.duns...@2ndquadrant.com) wrote: > > There's not much point adding the ',' unless you're also putting the > >

Re: perlcritic and perltidy

2018-05-08 Thread Stephen Frost
Andrew, * Andrew Dunstan (andrew.duns...@2ndquadrant.com) wrote: > On 05/08/2018 01:18 PM, Stephen Frost wrote: > > * Andrew Dunstan (andrew.duns...@2ndquadrant.com) wrote: > >> On 05/08/2018 12:51 PM, Stephen Frost wrote: > >>> * Andrew Dunstan (andrew.

Re: GSoC 2018: thrift encoding format

2018-05-04 Thread Stephen Frost
Greetings, * Aleksander Alekseev (a.aleks...@postgrespro.ru) wrote: > >> Personally I think raw data bytes are OK if functions for getting all > >> keys and values from this data are provided > > > > What is the purpose of using Thrift "encoding" if it turns out to be a > > simple wrapper for

Re: Fix for FETCH FIRST syntax problems

2018-05-20 Thread Stephen Frost
Greetings, * Peter Geoghegan (p...@bowt.ie) wrote: > Whether or not Andrew's patch is formally classified as a bug fix is > subjective. I'm inclined to accept it as a bug fix, but I also think > that it shouldn't matter very much. The practical implication is that > I don't think it's completely

Re: Windows build broken starting at da9b580d89903fee871cf54845ffa2b26bda2e11

2018-05-15 Thread Stephen Frost
Greetings, * Mark Dilger (hornschnor...@gmail.com) wrote: > > On May 15, 2018, at 8:58 AM, Tom Lane wrote: > > Mark Dilger writes: > >> My best guess at the moment is: > > > >> diff --git a/src/backend/utils/init/globals.c > >>

Re: Add --include-table-data-where option to pg_dump, to export only a subset of table data

2018-05-21 Thread Stephen Frost
Greetings, * Carter Thaxton (carter.thax...@gmail.com) wrote: > Many times I've wanted to export a subset of a database, using some sort of > row filter condition on some of the large tables. E.g. copying a > production database to a staging environment, but with some time series > data only

Re: [PATCH v14] GSSAPI encryption support

2018-05-23 Thread Stephen Frost
Greetings Robbie! * Robbie Harwood (rharw...@redhat.com) wrote: > Zombie patch is back from the dead. It's been a bit more than two years > since v12 (the last major revision) and almost three since it was > originally submitted. (I do have enough pride to point out that it did > not actually

Re: Shared PostgreSQL libraries and symbol versioning

2018-05-23 Thread Stephen Frost
Greetings, * Pavel Raiskup (prais...@redhat.com) wrote: > On Thursday, May 10, 2018 12:41:40 PM CEST Pavel Raiskup wrote: > > On Monday, April 9, 2018 11:04:33 PM CEST Tom Lane wrote: > > > Stephen Frost <sfr...@snowman.net> writes: > > > > * Peter Eisentra

Re: Postgres, fsync, and OSs (specifically linux)

2018-05-18 Thread Stephen Frost
Greetings, * Ashutosh Bapat (ashutosh.ba...@enterprisedb.com) wrote: > On Thu, May 17, 2018 at 11:45 PM, Robert Haas wrote: > > On Thu, May 17, 2018 at 12:44 PM, Andres Freund wrote: > >> Hi, > >> > >> On 2018-05-10 09:50:03 +0800, Craig Ringer wrote:

Re: Postgres, fsync, and OSs (specifically linux)

2018-05-18 Thread Stephen Frost
Greetings, * Abhijit Menon-Sen (a...@2ndquadrant.com) wrote: > At 2018-05-18 20:27:57 -0400, sfr...@snowman.net wrote: > > > > I don't agree with the general notion that we can't have a function > > which handles the complicated bits about the kind of error because > > someone grep'ing the source

Re: Flexible permissions for REFRESH MATERIALIZED VIEW

2018-05-18 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Tue, May 15, 2018 at 6:07 PM, Tom Lane wrote: > > That seems like an awful lot of work to handle what's still going to be > > a pretty small set of permissions. Every permission we add is going to > > have to be

Re: WAL prefetch

2018-06-16 Thread Stephen Frost
Greetings, * Tomas Vondra (tomas.von...@2ndquadrant.com) wrote: > On 06/16/2018 12:06 PM, Thomas Munro wrote: > >On Sat, Jun 16, 2018 at 9:38 PM, Tomas Vondra > > wrote: > >>On 06/15/2018 08:01 PM, Andres Freund wrote: > >>>On 2018-06-14 10:13:44 +0300, Konstantin Knizhnik wrote: > On

Re: commitfest 2018-07

2018-06-14 Thread Stephen Frost
Greetings, * Andrew Dunstan (andrew.duns...@2ndquadrant.com) wrote: > Well, this went quiet. I'm happy to be CFM and assisted by Michael and > Ashutosh > > Are there any privileges required that I should see about obtaining? I've set you up with the cf admin privs (which Michael also has).

Re: WAL prefetch

2018-06-14 Thread Stephen Frost
Greetings, * Konstantin Knizhnik (k.knizh...@postgrespro.ru) wrote: > There was very interesting presentation at pgconf about pg_prefaulter: > > http://www.pgcon.org/2018/schedule/events/1204.en.html I agree and I've chatted a bit w/ Sean further about it. > But it is implemented in GO and

Re: commitfest 2018-07

2018-06-05 Thread Stephen Frost
Greetings, * Ashutosh Bapat (ashutosh.ba...@enterprisedb.com) wrote: > On Tue, Jun 5, 2018 at 9:02 AM, Tom Lane wrote: > > Michael Paquier writes: > >> On Mon, Jun 04, 2018 at 07:16:33PM -0400, Peter Eisentraut wrote: > >>> There were some discussions about renaming the existing 2018-09 entry >

Re: commitfest 2018-07

2018-06-05 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Joe Conway writes: > > On 06/05/2018 10:43 AM, Andres Freund wrote: > >> I think we've not fully agreed on that. I'd argue we should manually > >> filter things into the next CF. And both small patches and older things > >> should qualify. >

Re: Code of Conduct plan

2018-06-05 Thread Stephen Frost
Greetings, * Magnus Hagander (mag...@hagander.net) wrote: > On Tue, Jun 5, 2018 at 4:45 PM, Chris Travers > wrote: > > If I may suggest: The committee should be international as well and > > include people from around the world. The last thing we want is for it to > > be dominated by people

Re: [PATCH] Include application_name in "connection authorized" log message

2018-06-25 Thread Stephen Frost
Greetings On Mon, Jun 25, 2018 at 15:57 Don Seiler wrote: > On Mon, Jun 25, 2018 at 10:50 AM, Gilles Darold > wrote: > >> I would prefer the following output to conform to elog.c output: >> >> 2018-06-25 17:32:46.854 CEST [23265] LOG: connection authorized: >> user=postgres

Re: [PATCH] Include application_name in "connection authorized" log message

2018-06-22 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Fri, Jun 22, 2018 at 11:17 AM, Stephen Frost wrote: > > The issue here is exactly that at the point where we emit the > > 'connection authorized' message, we haven't processed generic GUCs from > > the startup pac

Re: [PATCH] Include application_name in "connection authorized" log message

2018-06-20 Thread Stephen Frost
would prefer it be directly visible with the connection itself. With > some guidance from Stephen Frost I've put together this patch which does > that. Yeah, I tend to agree that it'd be extremely useful to have this included in the 'connection authorized' message. > It adds a new a

Re: Tips on committing

2018-07-02 Thread Stephen Frost
Greetings, * Peter Geoghegan (p...@bowt.ie) wrote: > FWIW, I developed a document on committing for my own reference, with > some help from Andres. A lot of it is about commit message style, the > use of fields, and so on. But I've also developed a check list for > committing, knowing that there

Re: "could not reattach to shared memory" on buildfarm member dory

2018-04-30 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > [ Thanks to Stephen for cranking up a continuous build loop on dory ] That was actually Heath, who is also trying to work this issue and has an idea about something else which might help (and some more information about what's happening in the

Re: "could not reattach to shared memory" on buildfarm member dory

2018-04-30 Thread Stephen Frost
Greetings, * Heath Lord (heath.l...@crunchydata.com) wrote: >Any ideas or changes that we could do to help debug or verify would be > helpful. We have considered changing it to run everything as SYSTEM but if > possible we would like to avoid this for security reasons. Thank you in >

Re: jitflags in _outPlannedStmt and _readPlannedStmt treated as bool type

2018-04-28 Thread Stephen Frost
Greetings, On Sat, Apr 28, 2018 at 17:55 Andres Freund wrote: > > > On April 28, 2018 1:47:56 PM PDT, Tom Lane wrote: > >Andres Freund writes: > >> On 2018-04-26 13:34:44 +1000, Haribabu Kommi wrote: > >>> I am thinking of it is a

Re: jitflags in _outPlannedStmt and _readPlannedStmt treated as bool type

2018-04-28 Thread Stephen Frost
Greetings, On Sat, Apr 28, 2018 at 18:23 Tom Lane <t...@sss.pgh.pa.us> wrote: > Stephen Frost <sfr...@snowman.net> writes: > > On Sat, Apr 28, 2018 at 17:55 Andres Freund <and...@anarazel.de> wrote: > >> Perhaps Steven could change dory's config so it rebuil

Re: TODO list (was Re: Contributing with code)

2017-12-31 Thread Stephen Frost
Tom, Robert, all, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Robert Haas writes: > > Also, let's delete the TODO list. People keep using it as a source of > > project ideas, and that's bad. > > If we're not going to maintain/curate it properly, I agree it's not > worth

Add default role 'pg_access_server_files'

2017-12-31 Thread Stephen Frost
having to have roles with superuser access. Thanks! Stephen From eb8be8ffbadcc37418dc12d59c6767e073028e35 Mon Sep 17 00:00:00 2001 From: Stephen Frost <sfr...@snowman.net> Date: Sun, 31 Dec 2017 14:01:12 -0500 Subject: [PATCH] Add default role pg_access_server_files This patch adds a new defaul

Re: [HACKERS] VACUUM and ANALYZE disagreeing on what reltuples means

2018-01-04 Thread Stephen Frost
Tomas, * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Sun, Nov 19, 2017 at 6:40 AM, Tomas Vondra > wrote: > > Thanks for looking into this. I agree your patch is more consistent and > > generally cleaner. > > This is classified as a bug fix, and is

Re: [HACKERS] Early locking option to parallel backup

2018-01-11 Thread Stephen Frost
Lucas, Robert, all, * Robert Haas (robertmh...@gmail.com) wrote: > On Mon, Nov 6, 2017 at 4:43 AM, Tom Lane wrote: > > I wonder if we couldn't somehow repurpose the work that was done for > > parallel workers' locks. Lots of security-type issues to be handled > > if we're to

Re: [HACKERS] Restrict concurrent update/delete with UPDATE of partition key

2018-01-11 Thread Stephen Frost
Amul, * amul sul (sula...@gmail.com) wrote: > Agree, updated in the attached patch. Patch 0001 also includes your > previous review comment[1] and typo correction suggested by Alvaro[2]. Looks like this needs to be rebased (though the failures aren't too bad, from what I'm seeing), so going to

Re: IndexTupleDSize macro seems redundant

2018-01-11 Thread Stephen Frost
Robert, all, * Robert Haas (robertmh...@gmail.com) wrote: > On Tue, Nov 21, 2017 at 9:26 AM, Amit Kapila wrote: > > +1. I was also once confused with these macros. I think this is a > > good cleanup. On a quick look, I don't see any problem with your > > changes. > >

Re: PATCH: Configurable file mode mask

2018-01-10 Thread Stephen Frost
David, * David Steele (da...@pgmasters.net) wrote: > On 1/8/18 8:58 PM, Peter Eisentraut wrote: > > On 1/3/18 08:11, Robert Haas wrote: > >> On Tue, Jan 2, 2018 at 11:43 AM, David Steele wrote: > > I think MakeDirectory() is a good wrapper, but isn't >

Re: [HACKERS] [PATCH] Overestimated filter cost and its mitigation

2018-01-06 Thread Stephen Frost
Greetings, * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Thu, Nov 9, 2017 at 12:33 PM, Ashutosh Bapat > wrote: > > Looking at order_qual_clauses(), we can say that a set of quals q1 > > qn are ordered the same irrespective of the set of clauses

Re: [HACKERS] plpgsql - additional extra checks

2018-01-06 Thread Stephen Frost
Greetings Pavel, * Pavel Stehule (pavel.steh...@gmail.com) wrote: > 2017-11-30 3:44 GMT+01:00 Michael Paquier : > > At least documentation needs patching, or this is going to generate > > warnings on HEAD at compilation. I am moving this to next CF for lack > > of

Re: [HACKERS] GUC for cleanup indexes threshold.

2018-01-06 Thread Stephen Frost
Greetings Peter, * Peter Geoghegan (p...@bowt.ie) wrote: > On Sat, Jan 6, 2018 at 2:20 PM, Stephen Frost <sfr...@snowman.net> wrote: > >> > IIRC the patches that makes the cleanup scan skip has a problem > >> > pointed by Peter[1], that is that we stash an XID wh

Re: [HACKERS] Refactoring identifier checks to consistently use strcmp

2018-01-06 Thread Stephen Frost
Greetings Michael, Daniel, all, * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Fri, Dec 1, 2017 at 4:14 AM, Robert Haas wrote: > > I think the changes in DefineView and ATExecSetRelOptions is wrong, > > because transformRelOptions() is still using pg_strcasecmp.

Re: PATCH: pgbench - option to build using ppoll() for larger connection counts

2018-01-06 Thread Stephen Frost
Doug, * Rady, Doug (radyd...@amazon.com) wrote: > This patch enables building pgbench to use ppoll() instead of select() > to allow for more than (FD_SETSIZE - 10) connections. As implemented, > when using ppoll(), the only connection limitation is system resources. Looks like this patch had

Re: [HACKERS] GUC for cleanup indexes threshold.

2018-01-06 Thread Stephen Frost
Greetings, (pruned the CC list) * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Thu, Nov 30, 2017 at 12:06 AM, Masahiko Sawada > wrote: > > On Wed, Nov 29, 2017 at 11:05 PM, Simon Riggs wrote: > >> Unless there is disagreement on the

Re: [HACKERS] [PATCH] Vacuum: Update FSM more frequently

2018-01-06 Thread Stephen Frost
Greetings Claudio, * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Mon, Nov 27, 2017 at 2:39 PM, Jing Wang wrote: > > A few general comments. > > > > + FreeSpaceMapVacuum(onerel, 64); > > > > Just want to know why '64' is used here? It's better to give a

Re: [HACKERS] Cached plans and statement generalization

2018-01-06 Thread Stephen Frost
Greetings, * Konstantin Knizhnik (k.knizh...@postgrespro.ru) wrote: > On 30.11.2017 04:59, Michael Paquier wrote: > >On Wed, Sep 13, 2017 at 2:11 AM, Konstantin Knizhnik > > wrote: > >>One more patch passing all regression tests with autoprepare_threshold=1. > >>I still

Re: [HACKERS] Secondary index access optimizations

2018-01-06 Thread Stephen Frost
Greetings, * Konstantin Knizhnik (k.knizh...@postgrespro.ru) wrote: > On 04.12.2017 19:44, Alvaro Herrera wrote: > >Konstantin Knizhnik wrote: > >> > >>On 30.11.2017 05:16, Michael Paquier wrote: > >>>On Mon, Nov 6, 2017 at 10:13 PM, Konstantin Knizhnik > >>> wrote: >

Re: Add default role 'pg_access_server_files'

2018-01-06 Thread Stephen Frost
Greetings Ryan! * Ryan Murphy (ryanfmur...@gmail.com) wrote: > Stephen, so far I've read thru your patch and familiarized myself with some > of the auth functionality in pg_authid.h and src/backend/utils/adt/acl.c > > The only question I have so far about your patch is the last several hunks of

Re: General purpose hashing func in pgbench

2018-01-06 Thread Stephen Frost
Greetings Ildar, * Fabien COELHO (coe...@cri.ensmp.fr) wrote: > >>I noticed from the source of all human knowledege (aka Wikipedia:-) > >>that there seems to be a murmur3 successor. Have you considered it? > >>One good reason to skip it would be that the implementation is long > >>and complex.

Re: [HACKERS] Surjective functional indexes

2018-01-06 Thread Stephen Frost
Greetings, * Konstantin Knizhnik (k.knizh...@postgrespro.ru) wrote: > On 15.12.2017 01:21, Michael Paquier wrote: > >On Fri, Dec 15, 2017 at 6:15 AM, Alvaro Herrera > >wrote: > >>Konstantin Knizhnik wrote: > >>>If you still thing that additional 16 bytes per relation in

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Stephen Frost
Robert, * Robert Haas (robertmh...@gmail.com) wrote: > On Mon, Jan 15, 2018 at 7:28 AM, Laurenz Albe > wrote: > > Everaldo Canuto wrote: > >> Also I don't see a consensus on this thread and I don't understand how > >> decisions are taken. > > > > It's just difficult

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Stephen Frost
Geoff, all, * Geoff Winkless (pgsqlad...@geoff.dj) wrote: > On 15 January 2018 at 16:10, Robert Haas wrote: > > > > More broadly, I think what is needed here is less C-fu than > > English-fu. If we come up with something good, we can make it print > > that thing. > > Can

GSoC 2018 Project Ideas & Mentors - Last Call

2018-01-18 Thread Stephen Frost
Greetings! I've gone through and cleaned up our GSoC 2018 Wiki page: https://wiki.postgresql.org/wiki/GSoC_2018 Please review! If you have any last-minute items, please add them! We could use some more mentors! If you would have some time over the summer to help with mentoring a GSoC project

Re: GSoC 2018 Project Ideas & Mentors - Last Call

2018-01-18 Thread Stephen Frost
Greetings, * Atri Sharma (atri.j...@gmail.com) wrote: > I can help with the Sorting project. Great! I've added you as a mentor. Thanks! Stephen signature.asc Description: PGP signature

Re: Add default role 'pg_access_server_files'

2018-01-19 Thread Stephen Frost
Michael, all, * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Thu, Jan 18, 2018 at 02:04:45PM +, Ryan Murphy wrote: > > I had not tried this before with my unpatched build of postgres. (In > > retrospect of course I should have). I expected my superuser to be > > able to perform

Re: [HACKERS] WIP: Restricting pg_rewind to data/wal dirs

2018-01-22 Thread Stephen Frost
Chris, * Chris Travers (chris.trav...@adjust.com) wrote: > Attached is the patch as submitted for commitfest. This has been stuck in Waiting for Author since before the commitfest started. I'll try to kick-start it but it seems like it's stuck because there's a fundamental disagreement about if

Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump

2018-01-22 Thread Stephen Frost
Tom, * Tom Lane (t...@sss.pgh.pa.us) wrote: > > On Monday, January 22, 2018, Stephen Frost <sfr...@snowman.net> wrote: > >> In the end, I feel like this patch has actually been through the ringer > >> and back because it was brought up in the context of solving a p

Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump

2018-01-24 Thread Stephen Frost
Tom, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost <sfr...@snowman.net> writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> No, if you have a nondefault ACL, that will still get applied. This > >> arrangement would drop comment changes, but I can't

Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump

2018-01-24 Thread Stephen Frost
Tom, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost <sfr...@snowman.net> writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> In further testing of that, I noticed that it made the behavior of our > >> other bugaboo, the public schema, rather inco

  1   2   3   4   5   6   >