Re: [HACKERS] Adding column_constraint description in ALTER TABLE synopsis

2018-02-04 Thread Lætitia Avrot
Hi, Thank you all for this so warm reception for my very first patch. Thanks Stephen to have thought to add that patch to the commit fest. As it was committed Friday, I was able to tell the whole story in my talk and that's great. And thanks again to everyone who helped me with that patch.

Re: [HACKERS] Adding column_constraint description in ALTER TABLE synopsis

2018-02-04 Thread Amit Langote
On 2018/02/02 19:41, Stephen Frost wrote: > * Amit Langote (langote_amit...@lab.ntt.co.jp) wrote: >> On 2018/01/23 8:57, Thomas Munro wrote: >>> Here's an update to move the new stuff to the correct side of the >>> closing "". Builds for me, and the typesetting looks OK. >>> I'm not sure why the

Re: [HACKERS] Adding column_constraint description in ALTER TABLE synopsis

2018-02-02 Thread Stephen Frost
Greetings, * Amit Langote (langote_amit...@lab.ntt.co.jp) wrote: > On 2018/01/23 8:57, Thomas Munro wrote: > > On Tue, Jan 23, 2018 at 12:41 PM, Thomas Munro > > wrote: > >> On Mon, Jan 15, 2018 at 2:32 PM, Stephen Frost wrote: > >>> If someone

Re: [HACKERS] Adding column_constraint description in ALTER TABLE synopsis

2018-01-22 Thread Amit Langote
On 2018/01/23 8:57, Thomas Munro wrote: > On Tue, Jan 23, 2018 at 12:41 PM, Thomas Munro > wrote: >> On Mon, Jan 15, 2018 at 2:32 PM, Stephen Frost wrote: >>> If someone else would like to review it, that'd be great, otherwise I'll >>> probably

Re: [HACKERS] Adding column_constraint description in ALTER TABLE synopsis

2018-01-22 Thread Thomas Munro
On Tue, Jan 23, 2018 at 12:41 PM, Thomas Munro wrote: > On Mon, Jan 15, 2018 at 2:32 PM, Stephen Frost wrote: >> If someone else would like to review it, that'd be great, otherwise I'll >> probably get it committed soon. > > FYI the v2 doesn't

Re: [HACKERS] Adding column_constraint description in ALTER TABLE synopsis

2018-01-14 Thread Stephen Frost
Greetings Lætitia, Amit, * Lætitia Avrot (laetitia.av...@gmail.com) wrote: > Thanks Stephen for the suggestion. I wan't thinking globally enough. I was > planning to look at it today but Amit was faster. So thanks Amit too! This seems to have gotten lost in the shuffle, but Amit's patch still