Re: [Patch]Add tab completion for DELETE ... USING
Hi Kirill-san, Thank you for your review and for updating the CF entry status! Regards, Tatsuya Kawata
Re: [Patch]Add tab completion for DELETE ... USING
On Sun, 11 Jan 2026 at 12:35, Tatsuya Kawata wrote: > > Hi! > > The updated v3 patch is attached as above. > Just reduced test cases. > > Regards, > Tatsuya Kawata > Hi! Sorry for the long response, no more complaints from my side. I have changed CF entry status to Ready FC -- Best regards, Kirill Reshke
Re: [Patch]Add tab completion for DELETE ... USING
Hi! The updated v3 patch is attached as above. Just reduced test cases. Regards, Tatsuya Kawata v3-0001-Add-tab-completion-for-DELETE-USING.patch Description: Binary data
Re: [Patch]Add tab completion for DELETE ... USING
Hi! Thank you for your review! > HI! What makes you think we need additional tab completion tests at all? > If we consult src/bin/psql changes history [0], it can be easily seen > that not every change to tab-complete.in.c is made with a new test. > This is (my own understanding, I may be wrong) because we only need to > test tab-complete patterns that are functionally different, not mirror > all cases from tab-complete.in.c in the TAP test. I agree that not every tab-complete change requires tests, and we don't need to mirror all cases from tab-complete.in.c. I also think tests that provide little benefit compared to their maintenance cost can be omitted. However, since this patch implements a previously unimplemented feature (removing a XXX TODO comment), I believe the primary test cases should be kept to verify the core functionality and prevent regressions. That said, I can reduce the test cases. The current 4 tests could be reduced to 2: One for USING (core functionality: table completion) One for USING (keyword completion after table) WDYT? Regards, Tatsuya Kawata
Re: [Patch]Add tab completion for DELETE ... USING
On Sat, 27 Dec 2025 at 05:50, Tatsuya Kawata wrote: > > Hi Chao-san, > > Thank you very much for your review! > > > Firs the first case: > > ``` > > +# check DELETE ... USING completion > > +check_completion( > > + "DELETE FROM tab1 USING my\t", > > + qr/mytab/, > > + "complete DELETE FROM tab USING with table name"); > > ``` > > > > Maybe just say “with tab”, because the rest test cases’ messages all say > > “USING tab”. > I fixed it as you mentioned. > The updated v2 is attached. > > Regards, > Tatsuya Kawata HI! What makes you think we need additional tab completion tests at all? If we consult src/bin/psql changes history [0], it can be easily seen that not every change to tab-complete.in.c is made with a new test. This is (my own understanding, I may be wrong) because we only need to test tab-complete patterns that are functionally different, not mirror all cases from tab-complete.in.c in the TAP test. WDYT? [0] https://github.com/postgres/postgres/commits/master/src/bin/psql -- Best regards, Kirill Reshke
Re: [Patch]Add tab completion for DELETE ... USING
Hi Chao-san, Thank you very much for your review! > Firs the first case: > ``` > +# check DELETE ... USING completion > +check_completion( > + "DELETE FROM tab1 USING my\t", > + qr/mytab/, > + "complete DELETE FROM tab USING with table name"); > ``` > > Maybe just say “with tab”, because the rest test cases’ messages all say “USING tab”. I fixed it as you mentioned. The updated v2 is attached. Regards, Tatsuya Kawata v2-0001-Add-tab-completion-for-DELETE-USING.patch Description: Binary data
Re: [Patch]Add tab completion for DELETE ... USING
> On Dec 25, 2025, at 23:51, Tatsuya Kawata wrote: > > Hi, > > I noticed that tab completion for DELETE ... USING clause was not > implemented. There was a TODO comment in tab-complete.in.c: > > /* XXX: implement tab completion for DELETE ... USING */ > The attached patch implements this feature. The following completions are now > supported: > > DELETE FROM USING -> suggests a list of tables > DELETE FROM USING -> suggests AS, WHERE > DELETE FROM USING AS -> suggests WHERE > DELETE FROM USING-> suggests WHERE (without AS > keyword) > > I've also added tests for all these cases in 010_tab_completion.pl. > > Regards, > Tatsuya Kawata > Overall looks good to me. A very tiny nitpick: Firs the first case: ``` +# check DELETE ... USING completion +check_completion( + "DELETE FROM tab1 USING my\t", + qr/mytab/, + "complete DELETE FROM tab USING with table name"); ``` Maybe just say “with tab”, because the rest test cases’ messages all say “USING tab”. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
