Re: Rewrite of pg_dump TAP tests
On Wed, Apr 04, 2018 at 10:25:03AM -0400, Stephen Frost wrote: > I've updated those tests as well and rebased the patch (though no real > changes were needed for the rebase). Passes all tests. I'll take > another look through the changes again but plan to push them in a few > hours, later on this afternoon. Okay, I can see that those have been pushed as 446f7f5. -- Michael signature.asc Description: PGP signature
Re: Rewrite of pg_dump TAP tests
Stephen Frost wrote: > Greetings, > > * Stephen Frost (sfr...@snowman.net) wrote: > > Attached is a patch (which applies cleaning against a2a2205, but not so > > much anymore, obviously, but I will fix after the releases) which > > greatly improves the big pg_dump TAP tests. There's probably more which > > can be done, but I expect people will be much happier with this. The > > cliff-notes are: > > Attached is an updated patch which applies cleanly against current > master. I've not yet looked into back-patching these changes, but will > if this can get some review and feedback, and folks like this better and > are ok with the same being done in the back-branches. Just looking at the commit message (sql script not dumped to screen), and the fact that this removes the bulk of the like/unlike arrays, I'd say this is a definite improvement over the existing tests. Perhaps we'd like to tweak more later, but this is a good step forward IMO. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Re: Rewrite of pg_dump TAP tests
Andres, * Andres Freund (and...@anarazel.de) wrote: > On 2018-02-26 13:15:04 -0500, Stephen Frost wrote: > > Attached is a patch (which applies cleaning against a2a2205, but not so > > much anymore, obviously, but I will fix after the releases) which > > greatly improves the big pg_dump TAP tests. There's probably more which > > can be done, but I expect people will be much happier with this. The > > cliff-notes are: > > Could you update? Working on it and will provide an update, hopefully by the end of the weekend. > Do you think this should be backpatched so we can backpatch tests when > backpatching fixes? That's an interesting question. I hadn't planned to and it wouldn't be trivial, but if others would like to see these changes back-patched then I'm willing to put in the work to do it. Thanks! Stephen signature.asc Description: PGP signature
Re: Rewrite of pg_dump TAP tests
Hi, On 2018-02-26 13:15:04 -0500, Stephen Frost wrote: > Attached is a patch (which applies cleaning against a2a2205, but not so > much anymore, obviously, but I will fix after the releases) which > greatly improves the big pg_dump TAP tests. There's probably more which > can be done, but I expect people will be much happier with this. The > cliff-notes are: Could you update? Do you think this should be backpatched so we can backpatch tests when backpatching fixes? Greetings, Andres Freund
