[HACKERS] GSoC 2017: weekly progress reports (week 9 and week 10)

2017-08-09 Thread Shubham Barai
Project: Explicitly support predicate locks in index AMs besides b-tree Hi, In the last two weeks, I mostly worked on predicate locking in rum index. Rum is based on gin access method. The main difference between rum and gin is that rum stores additional information in posting tree to perform a

Re: [HACKERS] dubious error message from partition.c

2017-08-09 Thread Dean Rasheed
On 9 August 2017 at 13:03, Robert Haas wrote: > On Tue, Aug 8, 2017 at 11:34 PM, Tom Lane wrote: >> A small suggestion is that it'd be better to write it like "Specified >> upper bound \"%s\" precedes lower bound \"%s\"." I think "succeeds" has >> more

Re: [HACKERS] WIP: Failover Slots

2017-08-09 Thread Robert Haas
On Tue, Aug 8, 2017 at 4:00 AM, Craig Ringer wrote: >> - When a standby connects to a master, it can optionally supply a list >> of slot names that it cares about. > > Wouldn't that immediately exclude use for PITR and snapshot recovery? I have > people right now who want

Re: [HACKERS] How can I find a specific collation in pg_collation when using ICU?

2017-08-09 Thread Peter Eisentraut
On 8/9/17 08:38, MauMau wrote: > I tried to find a particular collation name in pg_collation, but I > cannot understand the naming convention after reading the following > article. Specifically, I want to find out whether there is some > collation equivalent to Japanese_CI_AS in SQL Server, which

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

2017-08-09 Thread Thomas Munro
On Thu, Aug 10, 2017 at 1:39 AM, Thomas Munro wrote: > On my computer it took ~1.5 seconds to plan a 1000 partition join, > ~7.1 seconds to plan a 2000 partition join, and ~50 seconds to plan a > 4000 partition join. I poked around in a profiler a bit and saw that

[HACKERS] Comment in snapbuild.c file

2017-08-09 Thread Masahiko Sawada
Hi all, In snapbuild.c file, there is a comment as follows. * NB: Because of that xmax can be lower than xmin, because we only * increase xmax when a catalog modifying transaction commits. While odd * looking, it's correct and actually more efficient this way since we hit * fast

Re: [HACKERS] free space % calculation in pgstathashindex

2017-08-09 Thread Noah Misch
On Tue, Aug 08, 2017 at 02:30:51PM +0530, Amit Kapila wrote: > On Mon, Aug 7, 2017 at 9:38 PM, Ashutosh Sharma wrote: > > On Mon, Aug 7, 2017 at 7:19 PM, Amit Kapila wrote: > >> On Mon, Aug 7, 2017 at 6:07 PM, Ashutosh Sharma

Re: [HACKERS] Walsender timeouts and large transactions

2017-08-09 Thread Craig Ringer
On 9 August 2017 at 21:23, Petr Jelinek wrote: > On 02/08/17 19:35, Yura Sokolov wrote: > > The following review has been posted through the commitfest application: > > make installcheck-world: tested, passed > > Implements feature: not tested > > Spec

Re: [HACKERS] Parallel Append implementation

2017-08-09 Thread Amit Khandekar
On 9 August 2017 at 19:05, Robert Haas wrote: > On Wed, Jul 5, 2017 at 7:53 AM, Amit Khandekar wrote: >>> This is not applicable on the latest head i.e. commit -- >>> 08aed6604de2e6a9f4d499818d7c641cbf5eb9f7, looks like need a rebasing. >> >> Thanks

Re: [HACKERS] Quorum commit for multiple synchronous replication.

2017-08-09 Thread Michael Paquier
On Fri, Aug 4, 2017 at 8:19 AM, Masahiko Sawada wrote: > On Fri, Jul 28, 2017 at 2:24 PM, Noah Misch wrote: >> This item appears under "decisions to recheck mid-beta". If anyone is going >> to push for a change here, now is the time. > > It has been 1

Re: [HACKERS] Remove 1MB size limit in tsvector

2017-08-09 Thread Michael Paquier
On Wed, Aug 9, 2017 at 6:38 PM, Robert Haas wrote: > The patch doesn't really conform to our coding standards, though, so > you need to clean it up (or, if you're not sure what you need to do, > you need to have someone who knows how PostgreSQL code needs to look > review

[HACKERS] Re: ICU collation variant keywords and pg_collation entries (Was: [BUGS] Crash report for some ICU-52 (debian8) COLLATE and work_mem values)

2017-08-09 Thread Noah Misch
On Mon, Aug 07, 2017 at 06:23:56PM -0400, Tom Lane wrote: > Peter Eisentraut writes: > > On 8/6/17 20:07, Peter Geoghegan wrote: > >> I've looked into this. I'll give an example of what keyword variants > >> there are for Greek, and then discuss what I think each

Re: [HACKERS] Small code improvement for btree

2017-08-09 Thread Masahiko Sawada
On Wed, Aug 9, 2017 at 11:23 AM, Masahiko Sawada wrote: > On Mon, Aug 7, 2017 at 1:44 PM, Masahiko Sawada wrote: >> On Sat, Aug 5, 2017 at 3:29 AM, Peter Geoghegan wrote: >>> On Fri, Aug 4, 2017 at 11:12 AM, Alvaro Herrera >>>

Re: [HACKERS] PATCH: Batch/pipelining support for libpq

2017-08-09 Thread Vaishnavi Prabakaran
Andres Freund wrote : > If you were to send a gigabyte of queries, it'd buffer them all up in memory... So some >more intelligence is going to be needed. Firstly, sorry for the delayed response as I got busy with other activities. To buffer up the queries before flushing them to the socket, I

Re: [HACKERS] Timing-sensitive case in src/test/recovery TAP tests

2017-08-09 Thread Michael Paquier
On Tue, Aug 8, 2017 at 11:33 PM, Tom Lane wrote: > Michael Paquier writes: >> I got the same thought, wondering as well if get_slot_xmins should be >> renamed check_slot_xmins with the is() tests moved inside it as well. >> Not sure if that's worth

Re: [HACKERS] Default Partition for Range

2017-08-09 Thread Beena Emerson
Hello Rajkumar, On Wed, Aug 9, 2017 at 12:37 PM, Rajkumar Raghuwanshi wrote: > > Hi Beena, > > I have applied Jeevan's v24 patches and then your v9 patch over commit > 5ff3d73813ebcc3ff80be77c30b458d728951036. > and while testing I got a server crash. below

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix inadequacies in recently added wait events

2017-08-09 Thread Michael Paquier
On Tue, Aug 8, 2017 at 11:35 PM, Alvaro Herrera wrote: > Thread moved to -hackers. > > Thomas Munro wrote: >> On Wed, Aug 9, 2017 at 7:39 AM, Alvaro Herrera >> wrote: > >> > While at it, fix numerous other problems in the vicinity: > >> All of

Re: [HACKERS] Default Partition for Range

2017-08-09 Thread Rajkumar Raghuwanshi
On Wed, Aug 9, 2017 at 8:26 AM, Beena Emerson wrote: > I have updated the patch to make it similar to the way default/null is > handled in list partition, removing the PARTITION_RANGE_DATUM_DEFAULT. > This is to be applied over v24 patches shared by Jeevan [1] which >

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix inadequacies in recently added wait events

2017-08-09 Thread Thomas Munro
On Wed, Aug 9, 2017 at 6:42 PM, Michael Paquier wrote: > On Tue, Aug 8, 2017 at 11:35 PM, Alvaro Herrera > wrote: >>> All of the above seem like good candidates for a checker script in >>> src/tools/check_XXX.pl, a bit like the others I've

Re: [HACKERS] Page Scan Mode in Hash Index

2017-08-09 Thread Amit Kapila
On Mon, Aug 7, 2017 at 5:50 PM, Ashutosh Sharma wrote: > On Fri, Aug 4, 2017 at 7:14 PM, Amit Kapila wrote: >> On Sun, Jul 30, 2017 at 2:07 PM, Ashutosh Sharma >> wrote: >>> Hi, >>> >>> On Wed, May 10, 2017 at 2:28 PM,

Re: [HACKERS] parallelize queries containing initplans

2017-08-09 Thread Kuntal Ghosh
On Wed, Aug 9, 2017 at 10:24 AM, Haribabu Kommi wrote: > > I tested the latest patch and the parallel plan is getting choose for most > of > the init plans. > Thanks for testing. > For the following query the parallel plan is not chosen. The query contains > an init

Re: [HACKERS] parallelize queries containing initplans

2017-08-09 Thread Amit Kapila
On Wed, Aug 9, 2017 at 10:24 AM, Haribabu Kommi wrote: > > > On Mon, Jul 17, 2017 at 10:53 PM, Amit Kapila > wrote: >> >> On Tue, Mar 28, 2017 at 7:25 AM, Amit Kapila >> wrote: >> > On Thu, Mar 16, 2017 at 2:34 AM,

Re: [HACKERS] dubious error message from partition.c

2017-08-09 Thread Robert Haas
On Tue, Aug 8, 2017 at 11:34 PM, Tom Lane wrote: > A small suggestion is that it'd be better to write it like "Specified > upper bound \"%s\" precedes lower bound \"%s\"." I think "succeeds" has > more alternate meanings than "precedes", so the wording you have seems > more

[HACKERS] Re: [COMMITTERS] pgsql: Use MINVALUE/MAXVALUE instead of UNBOUNDED for range partition b

2017-08-09 Thread Robert Haas
On Tue, Aug 8, 2017 at 7:33 PM, Dean Rasheed wrote: > Well perhaps verbosity-reduction isn't sufficient justification but I > still think this is correct because logically any values in the bound > after MINVALUE/MAXVALUE are irrelevant, so it seems overly restrictive >

Re: [HACKERS] Default Partition for Range

2017-08-09 Thread Rajkumar Raghuwanshi
On Wed, Aug 9, 2017 at 1:54 PM, Beena Emerson wrote: > Hello Rajkumar, > > On Wed, Aug 9, 2017 at 12:37 PM, Rajkumar Raghuwanshi > wrote: > > > > Hi Beena, > > > > I have applied Jeevan's v24 patches and then your v9 patch over

Re: [HACKERS] Default Partition for Range

2017-08-09 Thread Robert Haas
On Wed, Aug 9, 2017 at 8:18 AM, Rajkumar Raghuwanshi wrote: > --difference in the description of default partition in case of list vs > range > > create table lp (a int) partition by list(a); > create table lp_d partition of lp DEFAULT; > postgres=# \d+ lp_d

[HACKERS] How can I find a specific collation in pg_collation when using ICU?

2017-08-09 Thread MauMau
Hello, I tried to find a particular collation name in pg_collation, but I cannot understand the naming convention after reading the following article. Specifically, I want to find out whether there is some collation equivalent to Japanese_CI_AS in SQL Server, which means Japanese,

Re: [HACKERS] Possible issue with expanded object infrastructure on Postgres 9.6.1

2017-08-09 Thread Justin Workman
On Tue, Aug 8, 2017 at 8:17 PM, Tom Lane wrote: > Peter Geoghegan writes: > > On Thu, Jan 19, 2017 at 5:45 PM, Peter Geoghegan wrote: > >> A customer is on 9.6.1, and complains of a segfault observed at least > >> 3 times. > > ... > > For the

Re: [HACKERS] Cache lookup errors with functions manipulation object addresses

2017-08-09 Thread Aleksander Alekseev
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed I believe this patch is "Ready for Committer". The new

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix inadequacies in recently added wait events

2017-08-09 Thread Alvaro Herrera
Tom Lane wrote: > I think generating whatever we can from a single authoritative file > is indeed a good idea. Yay. > But I had the impression that people also wanted to enforce a rule > about "only one use of each wait event name", which'd require a > checker script, no? (I'm not really

Re: [HACKERS] why not parallel seq scan for slow functions

2017-08-09 Thread Robert Haas
On Tue, Aug 8, 2017 at 3:50 AM, Amit Kapila wrote: > Right. > > I see two ways to include the cost of the target list for parallel > paths before rejecting them (a) Don't reject parallel paths > (Gather/GatherMerge) during add_path. This has the danger of path >

[HACKERS] More fun with container types

2017-08-09 Thread Tom Lane
While poking at the arrays-of-domains TODO item, I found yet another area in which the existing code fails to handle existing supported cases. Specifically, although DefineRange will happily take domains or composites as a range subtype, and we already noticed that domains-over-array-of- composite

Re: [HACKERS] Re: [GSOC][weekly report 9] Eliminate O(N^2) scaling from rw-conflict tracking in serializable transactions

2017-08-09 Thread Robert Haas
On Mon, Aug 7, 2017 at 1:51 PM, Alvaro Herrera wrote: > * the whole predicate.c stuff is written using SHM_QUEUE. I suppose > SHM_QUEUE works just fine, but predicate.c was being written at about > the same time (or a bit earlier) than the newer ilist.c interface

Re: [HACKERS] pl/perl extension fails on Windows

2017-08-09 Thread Robert Haas
On Tue, Aug 8, 2017 at 12:15 PM, Sandeep Thakkar wrote: > I copied and pasted that portion of the build log into file build.log > (attached) for Windows 32bit and Windows 64bit. Can you also share the output of 'perl -V' on each system? Comparing the 32-bit log

Re: [HACKERS] dubious error message from partition.c

2017-08-09 Thread Tom Lane
Alvaro Herrera writes: > Dean Rasheed wrote: >> There was an earlier suggestion to use "greater than or equal to". I >> think that would work quite well: > Is it possible to detect the equality case specifically and use a > different errdetail? Something like "the

Re: [HACKERS] dubious error message from partition.c

2017-08-09 Thread Alvaro Herrera
Dean Rasheed wrote: > On 9 August 2017 at 13:03, Robert Haas wrote: > > On Tue, Aug 8, 2017 at 11:34 PM, Tom Lane wrote: > >> A small suggestion is that it'd be better to write it like "Specified > >> upper bound \"%s\" precedes lower bound \"%s\"." I

Re: [HACKERS] How can I find a specific collation in pg_collation when using ICU?

2017-08-09 Thread Peter Geoghegan
On Wed, Aug 9, 2017 at 5:38 AM, MauMau wrote: > I tried to find a particular collation name in pg_collation, but I > cannot understand the naming convention after reading the following > article. Specifically, I want to find out whether there is some > collation equivalent

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix inadequacies in recently added wait events

2017-08-09 Thread Alvaro Herrera
This thread is surprising. If we generate the few lines of code being in trouble, we don't need any checker script, so I don't see why we'd go the route of the checker script instead. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA,

Re: [HACKERS] GSoC 2017: weekly progress reports (week 6)

2017-08-09 Thread Shubham Barai
Hi, Please find the updated patch for predicate locking in gin index here. There was a small issue in the previous patch. I didn't consider the case where only root page exists in the tree, and there is a predicate lock on it, and it gets split. If we treat the original page as a left page and

Re: [HACKERS] Remove 1MB size limit in tsvector

2017-08-09 Thread Robert Haas
On Tue, Aug 1, 2017 at 4:00 PM, Ildus K wrote: > It's a workaround. DatumGetTSVector and > DatumGetTSVectorCopy will upgrade tsvector on the fly if it > has old format. Hmm, that seems like a real fix, not just a workaround. If you can transparently read the old

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix inadequacies in recently added wait events

2017-08-09 Thread Tom Lane
Alvaro Herrera writes: > This thread is surprising. If we generate the few lines of code being > in trouble, we don't need any checker script, so I don't see why we'd go > the route of the checker script instead. I think generating whatever we can from a single

Re: [HACKERS] [PATCH v3] pg_progress() SQL function to monitor progression of long running SQL queries/utilities

2017-08-09 Thread Remi Colinet
2017-08-01 19:57 GMT+02:00 Robert Haas : > On Tue, Aug 1, 2017 at 12:35 PM, Remi Colinet > wrote: > > I did it in version 2 of the patch. > > I'am skeptical about the use of JSON, XML, and others in such output. > > > > Does anyone use these formats

[HACKERS] What users can do with custom ICU collations in Postgres 10

2017-08-09 Thread Peter Geoghegan
There are actually very many customizations to collations that are possible beyond what the "stock" ICU collations provide (whatever "stock" means). Some of these are really cool, and I can imagine use cases where they are very compelling that have nothing to do with internationalization (such

Re: [HACKERS] Cache lookup errors with functions manipulation object addresses

2017-08-09 Thread Michael Paquier
On Wed, Aug 9, 2017 at 2:47 PM, Aleksander Alekseev wrote: > I believe this patch is "Ready for Committer". > > The new status of this patch is: Ready for Committer Thanks for the lookup, but I think that this is still hasty as no discussion has happened about a couple

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix inadequacies in recently added wait events

2017-08-09 Thread Michael Paquier
On Wed, Aug 9, 2017 at 9:25 PM, Alvaro Herrera wrote: > Tom Lane wrote: >> I think generating whatever we can from a single authoritative file >> is indeed a good idea. > > Yay. Indeed. >> But I had the impression that people also wanted to enforce a rule >> about

Re: [HACKERS] Log LDAP "diagnostic messages"?

2017-08-09 Thread Ashutosh Bapat
On Thu, Aug 10, 2017 at 5:09 AM, Thomas Munro wrote: > On Thu, Jul 27, 2017 at 5:20 PM, Thomas Munro > wrote: >> Agreed. Here's a version that skips those useless detail messages >> using a coding pattern I found elsewhere. > >

Re: [HACKERS] How can I find a specific collation in pg_collation when using ICU?

2017-08-09 Thread Tsunakawa, Takayuki
From: pgsql-hackers-ow...@postgresql.org > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Peter Eisentraut > There are no case-insensitive collations in PostgreSQL (yet). That's sad news, as I expected ICU to bring its various collation features to PostgreSQL. I hope it will be easy

Re: [HACKERS] Log LDAP "diagnostic messages"?

2017-08-09 Thread Thomas Munro
On Thu, Aug 10, 2017 at 1:16 PM, Ashutosh Bapat wrote: > Please add this to the next commitfest. Done: https://commitfest.postgresql.org/14/1229/ -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list

Re: [HACKERS] How can I find a specific collation in pg_collation when using ICU?

2017-08-09 Thread Peter Geoghegan
On Wed, Aug 9, 2017 at 6:19 PM, Tsunakawa, Takayuki wrote: > From: pgsql-hackers-ow...@postgresql.org >> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Peter Eisentraut >> There are no case-insensitive collations in PostgreSQL (yet). > > That's sad news,

Re: [HACKERS] Log LDAP "diagnostic messages"?

2017-08-09 Thread Thomas Munro
On Thu, Jul 27, 2017 at 5:20 PM, Thomas Munro wrote: > Agreed. Here's a version that skips those useless detail messages > using a coding pattern I found elsewhere. Rebased after bf6b9e94. -- Thomas Munro http://www.enterprisedb.com

Re: [HACKERS] [BUGS] Replication to Postgres 10 on Windows is broken

2017-08-09 Thread Andres Freund
On 2017-08-08 19:25:37 -0400, Peter Eisentraut wrote: > On 8/7/17 21:06, Noah Misch wrote: > >> That would fit. Until v10 (commit 1e8a850), PQconnectStart() had no > >> in-tree > >> callers outside of libpq itself. > > [Action required within three days. This is a generic notification.] > > >

[HACKERS] Logical replication message type 'Y' is missing in docs

2017-08-09 Thread Masahiko Sawada
Hi, There is a type of logical replication message 'Y' for data types, but it's not documented in section 52.9. Logical Replication Message Formats. Attached patch fixes this. I think it can be PG10 item. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source

Re: [HACKERS] How can I find a specific collation in pg_collation when using ICU?

2017-08-09 Thread Tom Lane
Peter Geoghegan writes: > On Wed, Aug 9, 2017 at 6:19 PM, Tsunakawa, Takayuki > wrote: >> That's sad news, as I expected ICU to bring its various collation features >> to PostgreSQL. I hope it will be easy to add them. > The reason it is not easy

Re: [HACKERS] Causal reads take II

2017-08-09 Thread Thomas Munro
On Mon, Jul 31, 2017 at 5:49 PM, Thomas Munro wrote: > Here is a version to put it back. Rebased after conflicting commit 030273b7. Now using format-patch with a commit message to keep track of review/discussion history. -- Thomas Munro

Re: [HACKERS] expanding inheritance in partition bound order

2017-08-09 Thread Amit Langote
On 2017/08/05 2:25, Robert Haas wrote: > Concretely, my proposal is: > > 1. Before calling RelationGetPartitionDispatchInfo, the calling code > should use find_all_inheritors to lock all the relevant relations (or > the planner could use find_all_inheritors to get a list of relation > OIDs, store

Re: [HACKERS] dubious error message from partition.c

2017-08-09 Thread Amit Langote
On 2017/08/10 5:59, Tom Lane wrote: > Alvaro Herrera writes: >> Dean Rasheed wrote: >>> There was an earlier suggestion to use "greater than or equal to". I >>> think that would work quite well: > >> Is it possible to detect the equality case specifically and use a >>

Re: [HACKERS] parallelize queries containing initplans

2017-08-09 Thread Haribabu Kommi
On Wed, Aug 9, 2017 at 9:26 PM, Amit Kapila wrote: > On Wed, Aug 9, 2017 at 10:24 AM, Haribabu Kommi > wrote: > > > > > > For the following query the parallel plan is not chosen. The query > contains > > an init plan that refer the outer node.

[HACKERS] Review of DDL replication solution

2017-08-09 Thread Jeremy Finzel
Hello! I am new to Postgres backend development, and have created a recent project that has minimal C code. It is a transparent DDL replication solution built on top of pglogical, but with a concept that could be used also with other logical replication solutions if they support some mechanism

Re: [HACKERS] Parallel Append implementation

2017-08-09 Thread Robert Haas
On Wed, Jul 5, 2017 at 7:53 AM, Amit Khandekar wrote: >> This is not applicable on the latest head i.e. commit -- >> 08aed6604de2e6a9f4d499818d7c641cbf5eb9f7, looks like need a rebasing. > > Thanks for notifying. Attached is the rebased version of the patch. This again

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

2017-08-09 Thread Thomas Munro
On Tue, Aug 8, 2017 at 8:51 PM, Ashutosh Bapat wrote: > Updated patches attached. Hi, I started reviewing this. It's nicely commented, but it's also very complicated, and it's going to take me several rounds to understand what all the parts do, but here's some

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix inadequacies in recently added wait events

2017-08-09 Thread Tom Lane
Thomas Munro writes: > As for whether hypothetical check scripts would ever be run, I was > thinking we should stick them under some make target that developers > run all the time anyway -- perhaps "check". Shouldn't we catch simple > mechanically detectable

Re: [HACKERS] Walsender timeouts and large transactions

2017-08-09 Thread Petr Jelinek
On 02/08/17 19:35, Yura Sokolov wrote: > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: not tested > Spec compliant: not tested > Documentation:not tested > > There is no check

Re: [HACKERS] Timing-sensitive case in src/test/recovery TAP tests

2017-08-09 Thread Tom Lane
Michael Paquier writes: > On Tue, Aug 8, 2017 at 11:33 PM, Tom Lane wrote: >> Michael Paquier writes: >>> I got the same thought, wondering as well if get_slot_xmins should be >>> renamed check_slot_xmins with the is()

Re: [HACKERS] Remove 1MB size limit in tsvector

2017-08-09 Thread Torsten Zuehlsdorff
On 01.08.2017 22:00, Ildus K wrote: On Tue, 1 Aug 2017 15:33:08 -0400 Robert Haas wrote: On Tue, Aug 1, 2017 at 3:10 PM, Ildus K wrote: So this would break pg_upgrade for tsvector columns? I added a function that will convert old

Re: [HACKERS] "make check" with non-GNU make

2017-08-09 Thread Tom Lane
Thomas Munro writes: > On Wed, Aug 9, 2017 at 3:44 PM, Tom Lane wrote: >> Hmm, looking into Makefile.global.in, that step seems to be conditional on >> MAKELEVEL: > Ah, right. That coding is recommended in the GNU make manual to > distinguish

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix inadequacies in recently added wait events

2017-08-09 Thread Tom Lane
Robert Haas writes: > On Wed, Aug 9, 2017 at 10:14 AM, Tom Lane wrote: >> Thomas Munro writes: >>> As for whether hypothetical check scripts would ever be run, I was >>> thinking we should stick them under some make

Re: [HACKERS] Remove 1MB size limit in tsvector

2017-08-09 Thread Ildus Kurbangaliev
On Wed, 9 Aug 2017 09:01:44 +0200 Torsten Zuehlsdorff wrote: > On 01.08.2017 22:00, Ildus K wrote: > > On Tue, 1 Aug 2017 15:33:08 -0400 > > Robert Haas wrote: > > > >> On Tue, Aug 1, 2017 at 3:10 PM, Ildus K > >>

Re: [HACKERS] parallelize queries containing initplans

2017-08-09 Thread Haribabu Kommi
On Wed, Aug 9, 2017 at 8:54 PM, Kuntal Ghosh wrote: > On Wed, Aug 9, 2017 at 10:24 AM, Haribabu Kommi > wrote: > > > > I tested the latest patch and the parallel plan is getting choose for > most > > of > > the init plans. > > > Thanks for

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix inadequacies in recently added wait events

2017-08-09 Thread Robert Haas
On Wed, Aug 9, 2017 at 10:14 AM, Tom Lane wrote: > Thomas Munro writes: >> As for whether hypothetical check scripts would ever be run, I was >> thinking we should stick them under some make target that developers >> run all the time anyway --

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix inadequacies in recently added wait events

2017-08-09 Thread David Fetter
On Wed, Aug 09, 2017 at 10:56:50AM -0400, Tom Lane wrote: > Robert Haas writes: > > On Wed, Aug 9, 2017 at 10:14 AM, Tom Lane wrote: > >> Thomas Munro writes: > >>> As for whether hypothetical check scripts would ever be