Re: [HACKERS] Update comments in nodeModifyTable.c

2017-07-31 Thread Robert Haas
On Fri, Jul 28, 2017 at 8:12 AM, Etsuro Fujita <fujita.ets...@lab.ntt.co.jp> wrote: > On 2017/07/26 22:39, Robert Haas wrote: >> So the first part of the change weakens the assertion that a 'ctid' or >> 'wholerow' attribute will always be present by saying that an FDW may

Re: [HACKERS] Clarification in pg10's pgupgrade.html step 10 (upgrading standby servers)

2017-07-31 Thread Robert Haas
able > upgrading standbys following the existing procedure. Yeah, I don't understand it either, and I have never been convinced that there's any safe way to do it other than recloning the standbys from the upgraded master. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise

[HACKERS] Re: [bug fix] PG10: libpq doesn't connect to alternative hosts when some errors occur

2017-07-28 Thread Robert Haas
Have any beta-testers tested this and what do they think? The only non-developer (i.e. person not living in an ivory tower) who has weighed in here is Tels, who favored reversing the original decision and adopting Tsunakawa-san's position, and that was 2 months ago. I am pretty reluctant to tin

Re: [HACKERS] Patch: Write Amplification Reduction Method (WARM)

2017-07-28 Thread Robert Haas
at this point, if you tweak the configuration a little bit and don't do anything fancy like, say, try to roll back a transaction. :-) -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make c

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2017-07-31 Thread Robert Haas
the person who wrote these articles thinks it should be. Anyway, it would be good to understand what other well-regarded systems do before we choose what we want to do. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing

Re: [HACKERS] pg_stop_backup(wait_for_archive := true) on standby server

2017-07-31 Thread Robert Haas
omething about it quickly, because we're wrapping a new beta and a full set of back-branch releases next week. I'm personally hoping that what follows beta3 will be rc1, but if we have too much churn after beta3 we'll end up with a beta4, which could end up slipping the whole release cycle. -- Robert H

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2017-07-31 Thread Robert Haas
in the cluster; if they all think it's prepared, then it's prepared -- but if any of them think it's committed or aborted, then we change our local status to match and return that status. So once one node changes the status to committed or aborted it can propagate through the cluster even if connectivit

Re: LP_DEAD hinting and not holding on to a buffer pin on leaf page (Was: [HACKERS] [WIP] Zipfian distribution in pgbench)

2017-07-31 Thread Robert Haas
rent activity. That's hard to justify. But the fact that it is taking the slow-path when there *is* concurrent activity is harder to complain about. That might win or it might lose; the non-concurrent case only loses. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgr

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2017-07-31 Thread Robert Haas
from the shared memory queue. It should be possible to set things up so that a user who wishes to do so can run multiple copies of the resolver thread at the same time, which would be a good way to keep latency down if the system is very busy with distributed transactions. -- Robert Haas Enterp

Re: LP_DEAD hinting and not holding on to a buffer pin on leaf page (Was: [HACKERS] [WIP] Zipfian distribution in pgbench)

2017-07-31 Thread Robert Haas
uld be taken > when the LSN changed, but we do not give up on setting LP_DEAD bits. I > think we can justify going to the heap again in this slow path, if > that's what it takes. Yeah, that might possibly be a good approach. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterpri

Re: [HACKERS] WIP: Failover Slots

2017-08-02 Thread Robert Haas
, or it initially doesn't but it's later created. Thoughts? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [PATCH] Make ExplainBeginGroup()/ExplainEndGroup() public.

2017-08-02 Thread Robert Haas
On Tue, Jul 25, 2017 at 9:54 PM, Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote: > The patch is a kind of straightforward and looks fine for me. +1 for this change. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsq

Re: [HACKERS] Why does logical replication launcher exit with exit code 1?

2017-08-02 Thread Robert Haas
ently. But surely this isn't an example of that. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

2017-08-02 Thread Robert Haas
usts. We have fixed issues revealed by mine and > Rajkumar's testing. > What kinds of things you suspect? I'm not sure exactly. It's just hard with this kind of patch to make sure you've caught everything. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise P

Re: [HACKERS] reload-through-the-top-parent switch the partition table

2017-08-02 Thread Robert Haas
On Wed, Aug 2, 2017 at 1:58 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Robert Haas <robertmh...@gmail.com> writes: >> On Wed, Aug 2, 2017 at 1:08 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> --restore-via-partition-root ? > >> I worry someone w

Re: [HACKERS] Function Volatility and Views Unexpected Behavior

2017-08-02 Thread Robert Haas
e about the fact that the state of the PRNG has changed) and pg_sleep(), whose return value is always the same but whose side effects are of critical importance. Maybe we need separate terms for volatile-because-the-answer-is-unstable and volatile-because-it-has-side-effects. -- Robert Haas Enterpri

Re: [HACKERS] Why does logical replication launcher exit with exit code 1?

2017-08-01 Thread Robert Haas
You might've missed commit be7558162acc5578d0b2cf0c8d4c76b6076ce352. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] A bug in mapping attributes in ATExecAttachPartition()

2017-08-01 Thread Robert Haas
ld close part_rel before continuing to > consider the next partition, but mustn't do that if part_rel is really > attachRel. The new code does that too. Stylistically worse? Yeah. I mean, do you write: if (a) if (b) c(); rather than if (a && b) c(); ? -- Robert

Re: [HACKERS] Why does logical replication launcher exit with exit code 1?

2017-08-02 Thread Robert Haas
On Wed, Aug 2, 2017 at 9:33 PM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 8/2/17 16:52, Robert Haas wrote: >> I actually don't think it's that unreasonable to get notified when >> system-wide processes like the autovacuum launcher or the logical >>

Re: [HACKERS] foreign table creation and NOT VALID check constraints

2017-08-02 Thread Robert Haas
On Wed, Aug 2, 2017 at 9:41 PM, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: > On 2017/08/02 20:40, Robert Haas wrote: >> On Wed, Aug 2, 2017 at 3:46 AM, Ashutosh Bapat >> <ashutosh.ba...@enterprisedb.com> wrote: >>> If the user has specified "n

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

2017-08-02 Thread Robert Haas
re - e.g. the initial portion of build_joinrel_partition_info. There may be more, but I've run out of energy for tonight. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make chang

Re: [HACKERS] map_partition_varattnos() and whole-row vars

2017-08-02 Thread Robert Haas
needs to be done here? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] A bug in mapping attributes in ATExecAttachPartition()

2017-08-02 Thread Robert Haas
On Tue, Aug 1, 2017 at 9:44 PM, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: > I too dislike the shape of attachRel. How about we rename attachRel to > attachrel? So, attachrel_children, attachrel_constr, etc. It's still > long though... :) OK, I can live with that, I gue

Re: [HACKERS] typo for using "OBJECT_TYPE" for "security label on domain" in "gram.y"

2017-08-02 Thread Robert Haas
On Wed, Aug 2, 2017 at 6:04 AM, 高增琦 <pgf...@gmail.com> wrote: > Commit: 3f88672a4e4d8e648d24ccc65937da61c7660854 add "security label on > domain" > in "gram.y", and set "objtype" to "OBJECT_TYPE". > > Is this a typo? Looks like i

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-08-02 Thread Robert Haas
reate indexes > as you want. > > Feedback is very welcome. I'll add this patch to the next CF. I support adding an option for this, but I propose that we just make it a long-form option, similar to --log-prefix or --index-tablespace. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Ente

Re: [HACKERS] foreign table creation and NOT VALID check constraints

2017-08-02 Thread Robert Haas
ts to has some rows which will > violet the constraint. So, +1. +1 from me, too. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.p

Re: [HACKERS] reload-through-the-top-parent switch the partition table

2017-08-03 Thread Robert Haas
doing the job of pg_restore. So maybe --load-via-partition-root if nobody likes my previous suggestion of --partition-data-via-root ? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] intermittent failures in Cygwin from select_parallel tests

2017-08-03 Thread Robert Haas
a few "select() failed in postmaster: Bad address" > > I suspect a Cygwin signals bug. I'll try to distill a self-contained test > case for the Cygwin hackers. The lack of failures on buildfarm member brolga > argues that older Cygwin is not affected. Nice detective work. --

Re: [HACKERS] On Complex Source Code Reading Strategy

2017-08-03 Thread Robert Haas
gability is key. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] reload-through-the-top-parent switch the partition table

2017-08-03 Thread Robert Haas
--inserts or --no-unlogged-table-data apply to some but not all tables, but we didn't; why start here? I don't like the specific name --use-partitioned-table much either. Use it for what? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql

Re: [HACKERS] map_partition_varattnos() and whole-row vars

2017-08-03 Thread Robert Haas
On Thu, Aug 3, 2017 at 4:40 AM, Etsuro Fujita <fujita.ets...@lab.ntt.co.jp> wrote: > On 2017/08/03 17:12, Amit Langote wrote: >> Attached updated patches. > > Thanks for the patch! That looks good to me. Committed with some comment changes. -- Robert Ha

Re: [HACKERS] asynchronous execution

2017-08-01 Thread Robert Haas
and I think generalizing that to include the plan tree as well as expression trees is likely to be the long-term way forward here. Unfortunately, that's probably another gigantic patch (that should probably be written by Andres). -- Robert Haas EnterpriseDB: http://www.enterprisedb.com Th

Re: [HACKERS] parallel documentation improvements

2017-08-01 Thread Robert Haas
On Tue, Aug 1, 2017 at 3:15 PM, Erik Rijkers <e...@xs4all.nl> wrote: > On 2017-08-01 20:43, Robert Haas wrote: >> In commit 054637d2e08cda6a096f48cc99696136a06f4ef5, I updated the >> parallel query documentation to reflect recently-committed parallel >> >> Barri

Re: [HACKERS] Adding support for Default partition in partitioning

2017-08-01 Thread Robert Haas
oreign table. + The indentation isn't correct here - it doesn't match the surrounding paragraphs. The bit about list or range partitioning doesn't match the actual behavior of the other patches, but maybe you intended this to document both this feature and what Beena's doing. -- Robert Haas Enter

Re: [HACKERS] [PATCH] A hook for session start

2017-08-01 Thread Robert Haas
On Tue, Aug 1, 2017 at 3:37 PM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 7/21/17 12:59, Robert Haas wrote: >> That's an exceedingly-weak argument for rejecting this patch. The >> fact that you can probably hack around the lack of a hook for most &g

Re: [HACKERS] reload-through-the-top-parent switch the partition table

2017-08-01 Thread Robert Haas
mething that's *normally* true but potentially false if dependency sorting switches things around? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] Remove 1MB size limit in tsvector

2017-08-01 Thread Robert Haas
o the question that I asked is "yes, but I have a workaround" or does it mean that the answer is "no"? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) T

Re: [HACKERS] Update comments in nodeModifyTable.c

2017-08-03 Thread Robert Haas
On Thu, Aug 3, 2017 at 5:55 AM, Etsuro Fujita <fujita.ets...@lab.ntt.co.jp> wrote: > I updated the patch that way. Attached is a new version of the patch. Committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hacker

Re: [HACKERS] foreign table creation and NOT VALID check constraints

2017-08-03 Thread Robert Haas
On Thu, Aug 3, 2017 at 12:35 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Robert Haas <robertmh...@gmail.com> writes: >> On Wed, Aug 2, 2017 at 9:41 PM, Amit Langote >> <langote_amit...@lab.ntt.co.jp> wrote: >>> Attached is a patch. I think this could

Re: [HACKERS] Add Roman numeral conversion to to_number

2017-08-03 Thread Robert Haas
?) How much call is there for a format that can only represent values up to 3999? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Unused variable scanned_tuples in LVRelStats

2017-08-03 Thread Robert Haas
anned_tuples is closely tied to tupcount_pages, so it's a little confusing to pull one out and not the other. And we can't pull tupcount_pages out of LVRelStats because lazy_cleanup_index needs it. The current situation isn't doing any harm, so I'm not seeing much point in changing it. --

Re: [HACKERS] A bug in mapping attributes in ATExecAttachPartition()

2017-08-03 Thread Robert Haas
On Thu, Aug 3, 2017 at 1:04 AM, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: > Alright, attached updated 0001 does that. Committed 0001 and 0002. 0003 needs a rebase. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsq

Re: [HACKERS] Hash Functions

2017-08-03 Thread Robert Haas
ng links: https://research.neustar.biz/2011/12/29/choosing-a-good-hash-function-part-2/ http://greenrobot.org/essentials/features/performant-hash-functions-for-java/comparison-of-hash-functions/ https://www.strchr.com/hash_functions Thoughts? -- Robert Haas EnterpriseDB: http://www.e

Re: [HACKERS] Add Roman numeral conversion to to_number

2017-08-03 Thread Robert Haas
he existing code does is usually a good place to start -- whether you want to try to extend it is up to you. I'm not very interested in Roman numeral handling personally, so you might want to wait for some opinions from others. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterpri

Re: [HACKERS] Hash Functions

2017-08-03 Thread Robert Haas
some people want, I'd be inclined to do it. If it results in a noticeable slowdown on macrobenchmarks, then not so much, but otherwise, I'd rather do what people are asking for than spend time arguing about it. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Compa

Re: [HACKERS] Hash Functions

2017-08-03 Thread Robert Haas
with a relatively bad hash function for hash indexes (and hash > joins/aggs), and we should probably evolve it at some point. At the same > time there's currently people out there relying on the current hash > functions remaining stable. That to me is a bit of a separate problem. -- Robert

Re: [HACKERS] Hash Functions

2017-08-03 Thread Robert Haas
On Thu, Aug 3, 2017 at 5:50 PM, Andres Freund <and...@anarazel.de> wrote: > On 2017-08-03 17:43:44 -0400, Robert Haas wrote: >> For me, the basic point here is that we need a set of hash functions >> for hash partitioning that are different than what we use for hash >

Re: [HACKERS] [PATCH] pageinspect function to decode infomasks

2017-08-15 Thread Robert Haas
its as two separate bits, but that's not really true any more. They're a 2-bit field that can have one of four values: committed, aborted, frozen, or none of the above. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers maili

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

2017-08-15 Thread Robert Haas
artitions before expanding them, but that requires us to expand all the non-leaf tables first to maintain a consistent locking order in all scenarios. So the approach you've taken in this patch may need to be re-thought somewhat. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The E

Re: [HACKERS] expanding inheritance in partition bound order

2017-08-15 Thread Robert Haas
xecu.patch. This patch series is blocking a bunch of other things, so it would be nice if you could press forward with this quickly. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To mak

Re: [HACKERS] [COMMITTERS] pgsql: Simplify plpgsql's check for simple expressions.

2017-08-15 Thread Robert Haas
verything non-simple when force_parallel_mode is not off, or (2) teach exec_save_simple_expr() to see through a Gather node to the Result node underneath -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hac

Re: [HACKERS] [PATCH] pageinspect function to decode infomasks

2017-08-15 Thread Robert Haas
XMIN_ABORTED == HEAP_XMIN_FROZEN. Nobody is proposing to omit anything; to the contrary, what's being proposed is not to display the same thing twice (and in a misleading fashion, to boot). -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers

Re: [HACKERS] Proposal : For Auto-Prewarm.

2017-08-15 Thread Robert Haas
lease see the attached version. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company autoprewarm-rmh.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] [COMMITTERS] pgsql: Simplify plpgsql's check for simple expressions.

2017-08-15 Thread Robert Haas
re talking about will happen, but that seems to me to be a good thing. It lets you find planner bugs (or functions that a user has labelled incorrectly). -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hac

Re: [HACKERS] [COMMITTERS] pgsql: Simplify plpgsql's check for simple expressions.

2017-08-15 Thread Robert Haas
he only thing there is to make sure that such things never make it into a partial path. But it can't just decide that parallelism is no longer allowed *anywhere* in the query. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers m

Re: [HACKERS] POC: Sharing record typmods between backends

2017-08-15 Thread Robert Haas
n down the road. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

2017-08-16 Thread Robert Haas
h partitioned table. Probably we'd end up wanting to move at least some of the logic inside the existing loop into a subroutine. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

Re: [HACKERS] why not parallel seq scan for slow functions

2017-08-16 Thread Robert Haas
On Wed, Aug 16, 2017 at 7:23 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Tue, Aug 15, 2017 at 7:15 PM, Robert Haas <robertmh...@gmail.com> wrote: >> On Sat, Aug 12, 2017 at 9:18 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: >>> I think skipping a

Re: [HACKERS] [COMMITTERS] pgsql: Include foreign tables in information_schema.table_privileges

2017-08-16 Thread Robert Haas
where it was done afterward. So nobody will be able to count on this behavior one way or the other. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscr

Re: [HACKERS] POC: Sharing record typmods between backends

2017-08-16 Thread Robert Haas
On Tue, Aug 15, 2017 at 8:34 PM, Andres Freund <and...@anarazel.de> wrote: > On 2017-08-15 20:30:16 -0400, Robert Haas wrote: >> On Tue, Aug 15, 2017 at 6:06 PM, Andres Freund <and...@anarazel.de> wrote: >> > Interesting. I was apparently thinking slightly different

Re: [HACKERS] [PATCH] pageinspect function to decode infomasks

2017-08-16 Thread Robert Haas
ting issues. If there's an action item there, it might be to try to come up with a way to make the source code clearer. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make chang

Re: [HACKERS] [COMMITTERS] pgsql: Simplify plpgsql's check for simple expressions.

2017-08-16 Thread Robert Haas
On Wed, Aug 16, 2017 at 11:03 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Robert Haas <robertmh...@gmail.com> writes: >> On Tue, Aug 15, 2017 at 6:40 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> (In fact, a quick look shows a counterexample: if we pick a MinMax

Re: [HACKERS] Parallel Append implementation

2017-08-16 Thread Robert Haas
need to pull 78214 rows through the Gather node; why not do that? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [BUGS] [postgresql 10 beta3] unrecognized node type: 90

2017-08-16 Thread Robert Haas
lause, ought to do it. I chatted with Amit about this -- he's planning to look into it. I assume we'll hear from him tomorrow about this, but for official status update purposes I'll set a next-update date of one week from today (August 23rd). -- Robert Haas EnterpriseDB: http://www.enterpris

Re: [HACKERS] recovery_target_time = 'now' is not an error but still impractical setting

2017-08-16 Thread Robert Haas
ar 2000. Seems like this is just a plain old bug. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Orphaned files in base/[oid]

2017-08-16 Thread Robert Haas
ing predictable, I think we should add an undo subsystem instead of continuing to create ad-hoc solutions to problems like this. (Of course, that's being worked on by Thomas, Amit, and others.) -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via

Re: [HACKERS] Hash Functions

2017-08-16 Thread Robert Haas
On Thu, Aug 3, 2017 at 6:47 PM, Robert Haas <robertmh...@gmail.com> wrote: > That seems pretty lame, although it's sufficient to solve the > immediate problem, and I have to admit to a certain predilection for > things that solve the immediate problem without creating lots of &g

Re: [HACKERS] Refactoring identifier checks to consistently use strcmp

2017-08-16 Thread Robert Haas
On Wed, Aug 16, 2017 at 11:51 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > You have a point, but I'm not sure that this is such a bad compatibility > break as to be a reason not to change things to be more consistent. +1. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com Th

Re: [HACKERS] [COMMITTERS] pgsql: Simplify plpgsql's check for simple expressions.

2017-08-16 Thread Robert Haas
empt. Feel free to edit. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company clarify-force-parallel.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postg

Re: [HACKERS] reload-through-the-top-parent switch the partition table

2017-08-11 Thread Robert Haas
s a bunch of minor cosmetic changes. Barring objections, I'll commit it once the tree opens for v11 development. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company load-via-partition-root-rmh.patch Description: Binary data -- Sent via pgsql-hackers mai

Re: [HACKERS] Lazy hash table for XidInMVCCSnapshot (helps Zipfian a bit)

2017-08-11 Thread Robert Haas
as a general point that we really want another open-coded hash table -- I wonder if this could be made to use simplehash. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To m

Re: [HACKERS] shared memory based stat collector (was: Sharing record typmods between backends)

2017-08-14 Thread Robert Haas
m is not very optional. and 2. It allows unbounded bloat if there's no limit on the number of work items and is pointless is there is since you could then just use the main shared memory segment. I really think you should respond to those concerns, not just push a minimal fix. -- R

Re: [HACKERS] reload-through-the-top-parent switch the partition table

2017-08-14 Thread Robert Haas
On Mon, Aug 14, 2017 at 12:40 AM, Rushabh Lathia <rushabh.lat...@gmail.com> wrote: > On Fri, Aug 11, 2017 at 10:50 PM, Robert Haas <robertmh...@gmail.com> wrote: >> On Fri, Aug 11, 2017 at 5:36 AM, Rushabh Lathia >> <rushabh.lat...@gmail.com> wrote: >> >

Re: [HACKERS] [PATCH] pageinspect function to decode infomasks

2017-08-15 Thread Robert Haas
MIN_INVALID > when we detect that it's frozen, because that could well be misleading when > debugging. I don't think so -- the "committed" and "invalid" meanings are effectively canceled when the "frozen" mask is present. I mean, "committed"

Re: [HACKERS] scan on inheritance parent with no children in current session

2017-08-15 Thread Robert Haas
On Mon, Aug 14, 2017 at 1:49 AM, Ashutosh Bapat <ashutosh.ba...@enterprisedb.com> wrote: > I have modified the comments that way. Committed with some cleanup. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mai

Re: [HACKERS] Adding support for Default partition in partitioning

2017-08-15 Thread Robert Haas
On Wed, Jul 26, 2017 at 8:14 AM, Jeevan Ladhe <jeevan.la...@enterprisedb.com> wrote: > I have rebased the patches on the latest commit. This needs another rebase. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mai

Re: [HACKERS] [BUGS] [postgresql 10 beta3] unrecognized node type: 90

2017-08-15 Thread Robert Haas
or gather merge on the inner side > of join can be time-consuming. However, if you or others feel that it > is important to have a test to cover this code path, then I can try to > produce one. Committed. I believe that between this commit and the test-coverage commit from A

Re: [HACKERS] shared memory based stat collector (was: Sharing record typmods between backends)

2017-08-15 Thread Robert Haas
better in the future, and it adds a bunch of failure cases that we could just as well live without. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Simplify ACL handling for large objects and removal of superuser() checks

2017-08-15 Thread Robert Haas
patches: > - 0001 removes ALLOW_DANGEROUS_LO_FUNCTIONS > - 0002 replaces the superuser checks with GRANT permissions +1 for 0001 and 0002 in general, but I can't help noticing that they lead to a noticeable worsening of the error messages in the regression tests. -- Robert Haas EnterpriseDB: htt

Re: [HACKERS] why not parallel seq scan for slow functions

2017-08-15 Thread Robert Haas
to move that part as > well in generate_gather_paths. I don't think that can work, because at that point we don't know what target list the upper node wants to impose. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-h

Re: [HACKERS] pl/perl extension fails on Windows

2017-08-10 Thread Robert Haas
ve got pg_time_t plastered all over the backend but that's not actually time_t under the hood, so it's fine. I do see time_t being used in frontend code, but that won't matter for this. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent vi

Re: [HACKERS] pl/perl extension fails on Windows

2017-08-10 Thread Robert Haas
happens that the result is compatible with older Perl builds that used _USE_32BIT_TIME_T and not compatible with newer ones that don't. Maybe we need to make _USE_32BIT_TIME_T a compile-time configuration option on Windows, and then cross-check that our setting is compatible with Perl's s

Re: [HACKERS] reload-through-the-top-parent switch the partition table

2017-08-10 Thread Robert Haas
eturn getRootTableInfo(tbinfo->parents[0]); + +return tbinfo->parents[0]; +} This code should iterate, not recurse, to avoid any risk of blowing out the stack. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

2017-08-10 Thread Robert Haas
g a nested loop with an inner index scan on X. But you could also partition X on the fly using A's partitioning scheme and then join partitions of A against the on-the-fly-partitioned version of X. That's likely to be a lot better for a merge join with an underlying sort on X. -- Robert Haas Enter

Re: [HACKERS] [TRAP: FailedAssertion] causing server to crash

2017-08-10 Thread Robert Haas
bad to be wrong about this - but doing something we all agree is wrong can't be better than doing something that I, at least, think is correct. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql

Re: [HACKERS] WIP: Failover Slots

2017-08-09 Thread Robert Haas
slots, you may well be right, but I don't yet understand the reasons, and I want to understand the reasons. I think this stuff is too important to just have one person saying "here's a patch that does it this way" and everybody else just says "uh, ok". Once we adopt som

Re: [HACKERS] pgsql 10: hash indexes testing

2017-08-10 Thread Robert Haas
On Thu, Aug 10, 2017 at 6:41 AM, AP <a...@zip.com.au> wrote: > The index is 135GB rather than 900GB (from memory/give or take). Whoa. Big improvement. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing li

Re: [HACKERS] Server crash (FailedAssertion) due to catcache refcount mis-handling

2017-08-10 Thread Robert Haas
On Tue, Aug 8, 2017 at 10:48 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Robert Haas <robertmh...@gmail.com> writes: >> On Tue, Aug 8, 2017 at 4:34 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> In the meantime, I think my vote would be to remove AtEOXact_CatC

Re: [HACKERS] WIP: Failover Slots

2017-08-10 Thread Robert Haas
ure that this actually prevents the problem you describe. It also seems really complicated. Maybe you can explain further; perhaps there is a simpler solution (or perhaps this isn't as complicated as I currently think it is). -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] dubious error message from partition.c

2017-08-10 Thread Robert Haas
hope will be considered an improvement. Your proposed primary error message was: invalid range bound specification for partition \"%s\" I changed it to: empty range bound specified for partition \"%s\" Thanks for working on this. -- Robert Haas EnterpriseDB: http://www.ent

Re: [HACKERS] Default Partition for Range

2017-08-10 Thread Robert Haas
straint. > Partition constraint: true > > Please let me know your thoughts. I like "No partition constraint." of those options. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Proposal: Local indexes for partitioned table

2017-08-10 Thread Robert Haas
On Wed, Apr 19, 2017 at 5:25 AM, Maksim Milyutin <m.milyu...@postgrespro.ru> wrote: > Ok, thanks for the feedback. Then I'll use a new relkind for local > partitioned index in further development. Any update on this? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com Th

Re: [HACKERS] Getting server crash on Windows when using ICU collation

2017-08-10 Thread Robert Haas
Thanks. Should this be on the open items list? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Request more documentation for incompatibility of parallelism and plpgsql exec_run_select

2017-08-10 Thread Robert Haas
ing a persistent pool of workers that attach and detach instead of firing up new ones all the time, but that has a host of problems all of its own. The first one would be desirable change for a bunch of reasons but is not easy for reasons that are a little longer than I feel like explaining right

Re: [HACKERS] Parallel COPY FROM execution

2017-08-11 Thread Robert Haas
se latches directly, you'll have to somehow keep track of which processes need to be signaled. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] scan on inheritance parent with no children in current session

2017-08-11 Thread Robert Haas
in this case also. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Patches I'm thinking of pushing shortly

2017-08-11 Thread Robert Haas
hink it needs another look. I'd vote for putting this fix into v10, but maybe that's just me. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Request more documentation for incompatibility of parallelism and plpgsql exec_run_select

2017-08-11 Thread Robert Haas
code inside the loop, then run it until the next tuple shows up, etc. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgres

Re: [HACKERS] POC: Sharing record typmods between backends

2017-08-12 Thread Robert Haas
ff. I think it'd be pretty interesting to look at replacing parts of the stats collector machinery with something DHT-based. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make c

Re: [HACKERS] POC: Sharing record typmods between backends

2017-08-12 Thread Robert Haas
-database stats > data. Don't think we can just require that to be in memory :( Hmm. I'm not sure it wouldn't end up being *less* memory. Don't we end up caching 1 copy of it per backend, at least for the database to which that backend is connected? Accessing a shared copy would avoid that sort of

  1   2   3   4   5   6   7   8   9   10   >