[HACKERS] note about syntax for fillfactor patch

2006-07-02 Thread Tom Lane
I see that the just-applied fillfactor patch has changed the syntax for CREATE TABLE to replace OptWithOids: WITH OIDS{ $$ = MUST_HAVE_OIDS; } | WITHOUT OIDS { $$ = MUST_NOT_HAVE_OIDS; } | /*EMPTY*/

Re: [HACKERS] [COMMITTERS] pgsql: Do a pass of code review for the ALTER TABLE

2006-07-02 Thread Bruce Momjian
Neil Conway wrote: Log Message: --- Do a pass of code review for the ALTER TABLE ADD INHERITS patch. Keep the read lock we hold on the table's parent relation until commit. Update equalfuncs.c for the new field in AlterTableCmd. Various improvements to comments, variable names, and

Re: [HACKERS] note about syntax for fillfactor patch

2006-07-02 Thread Bruce Momjian
Tom Lane wrote: The latter seems seriously grotty: it forces the user to remember an Agreed. I propose that we change the syntax to be WITH OIDS | WITHOUT OIDS | WITH (definition) | /*EMPTY*/ and say that if you want to specify both OIDS and another option you

Re: [HACKERS] [COMMITTERS] pgsql: Do a pass of code review for the ALTER TABLE

2006-07-02 Thread Alvaro Herrera
Bruce Momjian wrote: Neil Conway wrote: Log Message: --- Do a pass of code review for the ALTER TABLE ADD INHERITS patch. Keep the read lock we hold on the table's parent relation until commit. Update equalfuncs.c for the new field in AlterTableCmd. Various improvements to

Re: [HACKERS] note about syntax for fillfactor patch

2006-07-02 Thread Simon Riggs
On Sun, 2006-07-02 at 12:06 -0400, Tom Lane wrote: I propose that we change the syntax to be WITH OIDS | WITHOUT OIDS | WITH (definition) | /*EMPTY*/ and say that if you want to specify both OIDS and another option you have to write oids or oids=false in the

Re: [HACKERS] [COMMITTERS] pgsql: Do a pass of code review for the

2006-07-02 Thread Andrew Dunstan
Alvaro Herrera wrote: Thanks, that is what was needed. The author obviously took the patch as far as he could, and we needed to adjust his XXX areas, rather than not apply the patch and have the code drifting. Hmm, is this how we should do things? I mean, should I finish the

Re: [HACKERS] [COMMITTERS] pgsql: Do a pass of code review for the

2006-07-02 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian wrote: Neil Conway wrote: Log Message: --- Do a pass of code review for the ALTER TABLE ADD INHERITS patch. Keep the read lock we hold on the table's parent relation until commit. Update equalfuncs.c for the new field in AlterTableCmd.

[HACKERS] request for feature: table value constructor (related to multivalue insert stmt)

2006-07-02 Thread Pavel Stehule
Hello hackers I think about solution multi values insert from TODO. There is one hack solution .. transformation from VALUES (a), (b) into SELECT a UNION ALL SELECT b. Or there is next (more general) solution .. implementation of table value constructor http://savage.net.au/SQL/sql-2003-2.bnf

[HACKERS] odd 7.4 build failure on new sparc machine

2006-07-02 Thread Andrew Dunstan
I am seeing a strange failure on the new box Sun donated, when trying to build 7.4 for the buildfarm. This is what I get: gmake[3]: Entering directory `/export/home/oicu/bf/root/REL7_4_STABLE/pgsql.5463/src/backend/port' ccache gcc -O2 -fno-strict-aliasing -g -Wall -Wmissing-prototypes

Re: [HACKERS] odd 7.4 build failure on new sparc machine

2006-07-02 Thread Andrew Dunstan
Andrew Dunstan wrote: I am seeing a strange failure on the new box Sun donated, when trying to build 7.4 for the buildfarm. This is what I get: [snip] What is odd is that the identical file seems to succeeed on the later 8.0 and 8.1 branches. This part at least is not true -

Re: [HACKERS] note about syntax for fillfactor patch

2006-07-02 Thread ITAGAKI Takahiro
Tom Lane [EMAIL PROTECTED] wrote: I propose that we change the syntax to be WITH OIDS | WITHOUT OIDS | WITH (definition) | /*EMPTY*/ and say that if you want to specify both OIDS and another option you have to write oids or oids=false in the definition list.

Re: [HACKERS] note about syntax for fillfactor patch

2006-07-02 Thread Tom Lane
ITAGAKI Takahiro [EMAIL PROTECTED] writes: # CREATE TABLE test1 (i int) WITH (oids=0); CREATE TABLE # CREATE TABLE test2 (i int) WITH (oids=false); ERROR: syntax error at or near false LINE 1: CREATE TABLE test2 (i int) WITH (oids=false); ^

Re: [HACKERS] odd 7.4 build failure on new sparc machine

2006-07-02 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: I am seeing a strange failure on the new box Sun donated, when trying to ccache gcc -O2 -fno-strict-aliasing -g -Wall -Wmissing-prototypes -Wmissing-declarations -c tas.s /usr/ccs/bin/ld -r -o SUBSYS.o dynloader.o pg_sema.o pg_shmem.o tas.o ld: