Re: [HACKERS] 8.3 version of ts_headline

2007-09-15 Thread Andreas Joseph Krogh
On Friday 14 September 2007 20:26:28 Tom Lane wrote: > Andreas Joseph Krogh <[EMAIL PROTECTED]> writes: > > In 8.2 this produces an error: > > > > SELECT headline('default', 'a b c', 'c'::tsquery, > > 'StartSel=, StopSel='); > > ERROR: syntax error > > DETAIL: Syntax error in position 15. > > Sur

[HACKERS] Hmmm ... isn't count_nondeletable_pages all wet?

2007-09-15 Thread Tom Lane
While looking at the HOT patch I suddenly started to question the sanity of vacuumlazy.c's count_nondeletable_pages(). It sits there and does a HeapTupleSatisfiesVacuum on any tuples it finds, and is willing to truncate away a page that contains only DEAD tuples. The problem with this theory is t

Re: [HACKERS] Hmmm ... isn't count_nondeletable_pages all wet?

2007-09-15 Thread Tom Lane
I wrote: > Is this analysis accurate, or am I missing something? If it is > accurate, do we need to postpone the upcoming releases to fix it? > I am thinking that some previously unexplained reports of index > corruption might now be explained ... Yeah, it's broken. Reproducing the race conditio