Re: [HACKERS] 8.5 release timetable, again

2009-08-24 Thread Peter Eisentraut
On sön, 2009-08-23 at 09:37 -0400, Robert Haas wrote: To some degree, what this boils down to is that you can have time-based releases or feature-based releases, but not both. Sure. But some people are trying to introduce another subvariant: The conference-circuit-based releases. ;-) It

Re: [HACKERS] SIGUSR1 pingpong between master na autovacum launcher causes crash

2009-08-24 Thread Zdenek Kotala
Tom Lane píše v so 22. 08. 2009 v 09:56 -0400: Zdenek Kotala zdenek.kot...@sun.com writes: There are most important records from yesterdays issues. Messages: - Aug 20 11:14:54 genunix: [ID 470503 kern.warning] WARNING: Sorry, no swap space to grow stack for pid 507 (postgres)

Re: [HACKERS] SIGUSR1 pingpong between master na autovacum launcher causes crash

2009-08-24 Thread Zdenek Kotala
Zdenek Kotala píše v po 24. 08. 2009 v 13:47 +0200: I tested Alvaro's patch and it works, because it does not lead to stack consumption, but it shows another bug in StartAutovacuumWorker() code. When fork fails bn structure is freed but ReleasePostmasterChildSlot() should be called as well.

[HACKERS] hba load error and silent mode

2009-08-24 Thread Andrew Dunstan
Last night I had to deal with a puzzled user of version 8.4 who found postgres refused to start but didn't log any error. It turned out that there was an error in the pg_hba.conf file, and the client was running in silent mode (the SUSE default). This seems like a bug, and it's certainly

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Magnus Hagander
On Mon, Aug 24, 2009 at 14:39, Andrew Dunstanand...@dunslane.net wrote: Last night I had to deal with a puzzled user of version 8.4  who found postgres refused to start but didn't log any error.  It turned out that there was an error in the pg_hba.conf file, and the client was running in

Re: [HACKERS] Slaying the HYPOTamus

2009-08-24 Thread Paul Matthews
This is to go with the hypot() patch I posted the other day. As other code, such as found in adt/float.c and adt/numeric.c, simply assumes that isnan() exists, despite it being a C99 function, I have assumed the same. The below code should be placed into a file called src/port/hypot.c.

Re: [HACKERS] clang's static checker report.

2009-08-24 Thread Peter Eisentraut
On mån, 2009-08-24 at 00:42 +0100, Grzegorz Jaskiewicz wrote: --enable-cassert, enabled, and also added exit_* in pg_dump to list of functions that never return. A few more functions to mark noreturn: DateTimeParseError(), and die_horribly() in pg_dump -- Sent via pgsql-hackers mailing

Re: [HACKERS] 8.5 release timetable, again

2009-08-24 Thread Robert Haas
On Mon, Aug 24, 2009 at 7:39 AM, Peter Eisentrautpete...@gmx.net wrote: On sön, 2009-08-23 at 09:37 -0400, Robert Haas wrote: To some degree, what this boils down to is that you can have time-based releases or feature-based releases, but not both. Sure.  But some people are trying to

Re: [HACKERS] Slaying the HYPOTamus

2009-08-24 Thread David Fetter
On Mon, Aug 24, 2009 at 11:14:19PM +1000, Paul Matthews wrote: This is to go with the hypot() patch I posted the other day. As other code, such as found in adt/float.c and adt/numeric.c, simply assumes that isnan() exists, despite it being a C99 function, I have assumed the same. The

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Andrew Dunstan
Magnus Hagander wrote: (Maybe there's a good case for deprecating silent mode. I'm not sure why Suse uses it. Other distros don't seem to feel the need.) Could be, but even with silent_mode=off that would be a problem, no? as in, the log wouldn't go where you'd expect it to go. It

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Joshua Tolley
On Mon, Aug 24, 2009 at 02:57:02PM +0200, Magnus Hagander wrote: On Mon, Aug 24, 2009 at 14:39, Andrew Dunstanand...@dunslane.net wrote: Last night I had to deal with a puzzled user of version 8.4  who found postgres refused to start but didn't log any error.  It turned out that there was

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: (Maybe there's a good case for deprecating silent mode. +1. The only reason to use it is that an init-script writer is too lazy to deal with things properly --- the thing in question here being exactly to think of a place for early failure messages to

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: Tom Lane wrote: It might be that a reasonable solution on our end would be for pmdaemonize to point stdout/stderr someplace other than /dev/null, perhaps $PGDATA/postmaster.log? Of course, it's not clear what we're supposed to do if that open()

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Andrew Dunstan
Tom Lane wrote: It might be that a reasonable solution on our end would be for pmdaemonize to point stdout/stderr someplace other than /dev/null, perhaps $PGDATA/postmaster.log? Of course, it's not clear what we're supposed to do if that open() fails ... Well, yes, but

Re: [HACKERS] DELETE syntax on JOINS

2009-08-24 Thread Alvaro Herrera
Bruce Momjian wrote: Ultimately, why not allow: DELETE h, tn FROM history AS h INNER JOIN term_node AS tn ON (h.nid = tn.nid) INNER JOIN term_data AS td ON (td.tid = tn.tid) WHERE h.uid = 2067 AND td.vid = 2 IMHO this would improve compliance towards other database systems.

Re: [HACKERS] SIGUSR1 pingpong between master na autovacum launcher causes crash

2009-08-24 Thread Tom Lane
Zdenek Kotala zdenek.kot...@sun.com writes: ... We can see there that AVlauncher really wait 100ms, but it is not enough when system is under stress. OK, thanks for checking that. I think that Alvaro's patch is good and it fix a crash problem. I also think that AVlauncher could wait little

Re: [HACKERS] SIGUSR1 pingpong between master na autovacum launcher causes crash

2009-08-24 Thread Alvaro Herrera
Zdenek Kotala wrote: Just a confirmation that Alvaro's patch+ReleasePostmasterChildSlot() fix solves the problem and PostgreSQL survives well during a memory shortages. So this patch would do it. I think this stuff about postmaster child slots is later than launcher/worker split. I don't

Re: [HACKERS] DELETE syntax on JOINS

2009-08-24 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian wrote: Ultimately, why not allow: DELETE h, tn FROM history AS h INNER JOIN term_node AS tn ON (h.nid = tn.nid) INNER JOIN term_data AS td ON (td.tid = tn.tid) WHERE h.uid = 2067 AND td.vid = 2 IMHO this would improve

[HACKERS] Bug in date arithmetic

2009-08-24 Thread David Fetter
Folks, While debugging an error with Aziz (postgres_newbie) Sharief in the #postgresql IRC channel, I found a major POLA violation: $ psql Welcome to psql 8.3.7, the PostgreSQL interactive terminal. Type: \copyright for distribution terms \h for help with SQL commands \? for help

Re: [HACKERS] DELETE syntax on JOINS

2009-08-24 Thread Alvaro Herrera
Bruce Momjian wrote: Alvaro Herrera wrote: Bruce Momjian wrote: Ultimately, why not allow: DELETE h, tn FROM history AS h INNER JOIN term_node AS tn ON (h.nid = tn.nid) INNER JOIN term_data AS td ON (td.tid = tn.tid) WHERE h.uid = 2067 AND td.vid = 2

Re: [HACKERS] compilation with libeditpreferred is broken

2009-08-24 Thread Tom Lane
Zdenek Kotala zdenek.kot...@sun.com writes: I attached conservative version of patch which only reorder #define to avoid cross including half from readline and half from editline. Applied, thanks. regards, tom lane -- Sent via pgsql-hackers mailing list

Re: [HACKERS] DELETE syntax on JOINS

2009-08-24 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian wrote: Alvaro Herrera wrote: Bruce Momjian wrote: Ultimately, why not allow: DELETE h, tn FROM history AS h INNER JOIN term_node AS tn ON (h.nid = tn.nid) INNER JOIN term_data AS td ON (td.tid = tn.tid) WHERE

Re: [HACKERS] 8.5 release timetable, again

2009-08-24 Thread Christopher Browne
pete...@gmx.net (Peter Eisentraut) writes: I suggest going with four commit fests. Three is too short. We already started the first one early, which didn't give those involved in the release any time to prepare some patches for it. So with three fests you'd only give the major developers 8

Re: [HACKERS] SIGUSR1 pingpong between master na autovacum launcher causes crash

2009-08-24 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Zdenek Kotala wrote: Just a confirmation that Alvaro's patch+ReleasePostmasterChildSlot() fix solves the problem and PostgreSQL survives well during a memory shortages. So this patch would do it. Looks good to me, but I think you should also

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Magnus Hagander
On Mon, Aug 24, 2009 at 16:31, Tom Lanet...@sss.pgh.pa.us wrote: Andrew Dunstan and...@dunslane.net writes: (Maybe there's a good case for deprecating silent mode. +1.  The only reason to use it is that an init-script writer is too lazy to deal with things properly --- the thing in question

Re: [HACKERS] DELETE syntax on JOINS

2009-08-24 Thread Bill Moran
In response to Bruce Momjian br...@momjian.us: Alvaro Herrera wrote: Bruce Momjian wrote: Ultimately, why not allow: DELETE h, tn FROM history AS h INNER JOIN term_node AS tn ON (h.nid = tn.nid) INNER JOIN term_data AS td ON (td.tid = tn.tid) WHERE h.uid =

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: I don't see why we couldn't move the hba call specifically, though. That's a fairly common error, so it would be good if the output went to the place that is actually configured in postgresql.conf. It's at least a lot more likely than most other

Re: [HACKERS] Bug in date arithmetic

2009-08-24 Thread Tom Lane
David Fetter da...@fetter.org writes: While debugging an error with Aziz (postgres_newbie) Sharief in the #postgresql IRC channel, I found a major POLA violation: I see no bug here. There is only one '+' operator with timestamptz as left input, and it is timestamptz plus interval, so the

Re: [HACKERS] DELETE syntax on JOINS

2009-08-24 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Bruce Momjian wrote: So the problem is that our DELETE ... USING does not allow ANSI join syntax? Can that be added? Not sure about that. USING is already an extension to the standard, so if we extend it a bit more, it can't be a problem,

Re: [HACKERS] Bug in date arithmetic

2009-08-24 Thread Sam Mason
On Mon, Aug 24, 2009 at 09:12:07AM -0700, David Fetter wrote: shac...@shackle:5432=# SELECT now() + '90'; ?column? --- 2009-09-03 19:03:43.195514-07 (1 row) shac...@shackle:5432=# SELECT now() - '90'; ERROR: date/time field

Re: [HACKERS] 8.5 release timetable, again

2009-08-24 Thread Tom Lane
Christopher Browne cbbro...@ca.afilias.info writes: I do agree that trying to force coordination with a specific conference in Ottawa seems like a very peculiar sort of forced scheduling. Well, PGCon is just a convenient concrete target. The real point here is that we're trying to get the

Re: [HACKERS] DELETE syntax on JOINS

2009-08-24 Thread Robert Haas
2009/8/24 Tom Lane t...@sss.pgh.pa.us: Alvaro Herrera alvhe...@commandprompt.com writes: Bruce Momjian wrote: So the problem is that our DELETE ... USING does not allow ANSI join syntax?  Can that be added? Not sure about that.  USING is already an extension to the standard, so if we extend

Re: [HACKERS] Bug in date arithmetic

2009-08-24 Thread Tom Lane
I wrote: ... I'm not sure why it's complaining about field overflow rather than syntax error when the literal is taken as a timestamp, but that's a pretty minor issue. Oh, of course, it's because we allow this shorthand: regression=# select '900102'::timestamptz; timestamptz

Re: [HACKERS] 8.5 release timetable, again

2009-08-24 Thread Greg Stark
On Mon, Aug 24, 2009 at 5:55 PM, Tom Lanet...@sss.pgh.pa.us wrote: Christopher Browne cbbro...@ca.afilias.info writes: I do agree that trying to force coordination with a specific conference in Ottawa seems like a very peculiar sort of forced scheduling. Well, PGCon is just a convenient

Re: [HACKERS] SIGUSR1 pingpong between master na autovacum launcher causes crash

2009-08-24 Thread Alvaro Herrera
Tom Lane wrote: Alvaro Herrera alvhe...@commandprompt.com writes: Zdenek Kotala wrote: Just a confirmation that Alvaro's patch+ReleasePostmasterChildSlot() fix solves the problem and PostgreSQL survives well during a memory shortages. So this patch would do it. Looks good to me,

Re: [HACKERS] DELETE syntax on JOINS

2009-08-24 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: 2009/8/24 Tom Lane t...@sss.pgh.pa.us: ... Some other systems allow it by letting you re-specify the target in the other clause, equivalently to DELETE FROM target t USING t LEFT JOIN other_table ot ON ... but we have always considered that the

Re: [HACKERS] Slaying the HYPOTamus

2009-08-24 Thread Kevin Grittner
David Fetter da...@fetter.org wrote: On Mon, Aug 24, 2009 at 11:14:19PM +1000, Paul Matthews wrote: These next two lines are a teensy bit baroque. Is there some significant speed increase that would justify them? if (x == 0.0) return 0.0; else { yx = y/x;

Re: [HACKERS] 8.5 release timetable, again

2009-08-24 Thread Josh Berkus
All, Yeah, conference-based releases is just a proxy for time-based releases. It's nice to have something to be happy about at the conference too. And it's a convenient time to start talking about the next release when you're all face-to-face. On the one hand: I'd say that we go for the

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Andrew Dunstan
Tom Lane wrote: Magnus Hagander mag...@hagander.net writes: I don't see why we couldn't move the hba call specifically, though. That's a fairly common error, so it would be good if the output went to the place that is actually configured in postgresql.conf. It's at least a lot more likely

Re: [HACKERS] DELETE syntax on JOINS

2009-08-24 Thread Sam Mason
On Mon, Aug 24, 2009 at 01:41:28PM -0400, Tom Lane wrote: The real problem with this is that all the good candidates for the reserved word are things people are probably already using as aliases, so we'd have a large risk of breaking existing queries. We could avoid that with a sufficiently

Re: [HACKERS] Slaying the HYPOTamus

2009-08-24 Thread David Fetter
On Mon, Aug 24, 2009 at 12:47:42PM -0500, Kevin Grittner wrote: David Fetter da...@fetter.org wrote: On Mon, Aug 24, 2009 at 11:14:19PM +1000, Paul Matthews wrote: These next two lines are a teensy bit baroque. Is there some significant speed increase that would justify them?

Re: [HACKERS] Bug in date arithmetic

2009-08-24 Thread David Fetter
On Mon, Aug 24, 2009 at 01:18:46PM -0400, Tom Lane wrote: I wrote: ... I'm not sure why it's complaining about field overflow rather than syntax error when the literal is taken as a timestamp, but that's a pretty minor issue. Oh, of course, it's because we allow this shorthand:

Re: [HACKERS] Slaying the HYPOTamus

2009-08-24 Thread Sam Mason
On Mon, Aug 24, 2009 at 07:07:13AM -0700, David Fetter wrote: These next two lines are a teensy bit baroque. Is there some significant speed increase that would justify them? Just noticed with your revised code that the following check: On Mon, Aug 24, 2009 at 11:14:19PM +1000, Paul Matthews

Re: [HACKERS] 8.5 release timetable, again

2009-08-24 Thread Robert Haas
On Mon, Aug 24, 2009 at 1:48 PM, Josh Berkusj...@agliodbs.com wrote: Therefore: I think, 3CFs, but we go all-out to get Standby/Replication into 8.5 in the next month.  So, every committer/major hacker on this list should pitch in to get those features done. So, is there someone here who

Re: [HACKERS] Slaying the HYPOTamus

2009-08-24 Thread Sam Mason
On Mon, Aug 24, 2009 at 06:59:38PM +0100, Sam Mason wrote: On Mon, Aug 24, 2009 at 11:14:19PM +1000, Paul Matthews wrote: if (x == 0.0) return 0.0; else { yx = y/x; is preventing a divide by zero on the line above. So it's not a performance hack, it's

Re: [HACKERS] Bug in date arithmetic

2009-08-24 Thread Tom Lane
David Fetter da...@fetter.org writes: On Mon, Aug 24, 2009 at 01:18:46PM -0400, Tom Lane wrote: Just out of curiosity, what were you *expecting* this to do? The gentleman in IRC was the one who was using the construct. Well, what did he think it would do? If it's a date it's invalid, and if

Re: [HACKERS] Bug in date arithmetic

2009-08-24 Thread Tom Lane
David Fetter da...@fetter.org writes: He expected '-' to subtract seconds, just as '+' added them. Ah. Well, what it boils down to is that in a scenario like known_type_expr operator unknown_literal we preferentially consider unknown_literal to be of the same type as the other

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: Tom Lane wrote: Oh, you mean move load_hba *down*, past the syslogger startup? Yeah, that would probably be all right. Well, that's what I originally said, yes ;-) But I don't think that precludes your more general suggestion regarding startup

Re: [HACKERS] Bug in date arithmetic

2009-08-24 Thread David Fetter
On Mon, Aug 24, 2009 at 02:05:38PM -0400, Tom Lane wrote: David Fetter da...@fetter.org writes: On Mon, Aug 24, 2009 at 01:18:46PM -0400, Tom Lane wrote: Just out of curiosity, what were you *expecting* this to do? The gentleman in IRC was the one who was using the construct. Well,

Re: [HACKERS] 8.5 release timetable, again

2009-08-24 Thread Tom Lane
Josh Berkus j...@agliodbs.com writes: So, is there someone here who could be helping with HS/SR and isn't? Why not? You mean, other than Simon's hands-off attitude? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] SIGUSR1 pingpong between master na autovacum launcher causes crash

2009-08-24 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Tom Lane wrote: Yeah, I added that recently to try to detect postmaster children that exit without cleaning up properly. I seem to have missed this error case :-(. Actually it looks like fork failure for regular backends gets it wrong too

Re: [HACKERS] SIGUSR1 pingpong between master na autovacum launcher causes crash

2009-08-24 Thread Alvaro Herrera
Tom Lane wrote: Alvaro Herrera alvhe...@commandprompt.com writes: Tom Lane wrote: Yeah, I added that recently to try to detect postmaster children that exit without cleaning up properly. I seem to have missed this error case :-(. Actually it looks like fork failure for regular

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: Tom Lane wrote: Oh, you mean move load_hba *down*, past the syslogger startup? Yeah, that would probably be all right. Well, that's what I originally said, yes ;-) But I don't think that precludes your

Re: [HACKERS] Slaying the HYPOTamus

2009-08-24 Thread Greg Stark
On Mon, Aug 24, 2009 at 6:52 PM, David Fetterda...@fetter.org wrote: double hypot( double x, double y ) {    double yx;    if( isinf(x) || isinf(y) )    return get_float8_infinity();    if( isnan(x) || isnan(y) )    return get_float8_nan(); For what it's worth though, check out the code

Re: [HACKERS] Determining client_encoding from client locale

2009-08-24 Thread Jaime Casanova
On Wed, Aug 19, 2009 at 11:08 AM, Jaime Casanovajcasa...@systemguards.com.ec wrote: On Tue, Aug 18, 2009 at 6:49 AM, Heikki Linnakangasheikki.linnakan...@enterprisedb.com wrote: Hmm, are you sure you the right version of libpq is being loaded at runtime? What does ldd ./test-libpq say?

Re: [HACKERS] Issues for named/mixed function notation patch

2009-08-24 Thread Pavel Stehule
Hello, I reworked patch to respect mentioned issues. - this patch still implement mixed notation - I am thing so this notation is really important. All others I respect. The behave is without change, fixed some bugs, enhanced regress tests. Sorry for delay. Regards Pavel Stehule p.s. Bernard,

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Magnus Hagander
On Mon, Aug 24, 2009 at 20:51, Andrew Dunstanand...@dunslane.net wrote: Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: Tom Lane wrote: Oh, you mean move load_hba *down*, past the syslogger startup? Yeah, that would probably be all right. Well, that's what I originally

Re: [HACKERS] Bug in date arithmetic

2009-08-24 Thread David Fetter
On Mon, Aug 24, 2009 at 02:31:35PM -0400, Tom Lane wrote: David Fetter da...@fetter.org writes: He expected '-' to subtract seconds, just as '+' added them. Ah. Well, what it boils down to is that in a scenario like known_type_expr operator unknown_literal we preferentially

Re: [HACKERS] hba load error and silent mode

2009-08-24 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: On Mon, Aug 24, 2009 at 20:51, Andrew Dunstanand...@dunslane.net wrote: We didn't check HBA validity at startup time before, did we? I would not be surprised to get more complaints now. Good point. We checked some of it, but we check it a whole lot

Re: [HACKERS] Bug in date arithmetic

2009-08-24 Thread Greg Stark
On Mon, Aug 24, 2009 at 8:27 PM, David Fetterda...@fetter.org wrote: I'm thinking that the unknown literal here should just cause an error in the case of '+'.  Same with '-', for what it's worth. That would make a lot of people very unhappy. They expect things like select date + '1 year' to

Re: [HACKERS] Feedback about Drupal SQL debugging

2009-08-24 Thread Peter Eisentraut
On fre, 2009-08-21 at 20:07 -0400, Tom Lane wrote: As of SQL99 it's supposed to be legal if you're grouping by a primary key (or some other cases where the other columns can be proved functionally dependent on the grouping columns, but that's the most useful one). We haven't got round to

Re: [HACKERS] Bug in date arithmetic

2009-08-24 Thread Tom Lane
Greg Stark gsst...@mit.edu writes: I wonder if we could get around this by inventing a new type date_or_interval which looks at the input and decides which it is using fairly strict rules. date_sub would take that type and do the appropriate operation based on what the constant had in it.

Re: [HACKERS] Bug in date arithmetic

2009-08-24 Thread David Fetter
On Mon, Aug 24, 2009 at 09:13:09PM +0100, Greg Stark wrote: On Mon, Aug 24, 2009 at 8:27 PM, David Fetterda...@fetter.org wrote: I'm thinking that the unknown literal here should just cause an error in the case of '+'.  Same with '-', for what it's worth. That would make a lot of people

Re: [HACKERS] 8.5 release timetable, again

2009-08-24 Thread Bruce Momjian
Josh Berkus wrote: All, Yeah, conference-based releases is just a proxy for time-based releases. It's nice to have something to be happy about at the conference too. And it's a convenient time to start talking about the next release when you're all face-to-face. On the one hand:

Re: [HACKERS] 8.5 release timetable, again

2009-08-24 Thread Bruce Momjian
Robert Haas wrote: As I've said before, I am presently of the opinion that Streaming Replication has little chance of making it into 8.5. This opinion is vulnerable to contrary evidence, like a new version of the patch showing up that shows massive progress. But the patch was bounced from

Re: [HACKERS] Bug in date arithmetic

2009-08-24 Thread Kevin Grittner
Greg Stark gsst...@mit.edu wrote: David Fetterda...@fetter.org wrote: I'm thinking that the unknown literal here should just cause an error in the case of '+'. Same with '-', for what it's worth. That would make a lot of people very unhappy. They expect things like select date + '1

Re: [HACKERS] 8.5 release timetable, again

2009-08-24 Thread Robert Haas
On Mon, Aug 24, 2009 at 4:56 PM, Bruce Momjianbr...@momjian.us wrote: Robert Haas wrote: As I've said before, I am presently of the opinion that Streaming Replication has little chance of making it into 8.5.  This opinion is vulnerable to contrary evidence, like a new version of the patch

Re: [HACKERS] 8.5 release timetable, again

2009-08-24 Thread Bruce Momjian
Robert Haas wrote: On Mon, Aug 24, 2009 at 4:56 PM, Bruce Momjianbr...@momjian.us wrote: Robert Haas wrote: As I've said before, I am presently of the opinion that Streaming Replication has little chance of making it into 8.5. ?This opinion is vulnerable to contrary evidence, like a new

Re: [HACKERS] DELETE syntax on JOINS

2009-08-24 Thread Bruce Momjian
Tom Lane wrote: Alvaro Herrera alvhe...@commandprompt.com writes: Bruce Momjian wrote: So the problem is that our DELETE ... USING does not allow ANSI join syntax? Can that be added? Not sure about that. USING is already an extension to the standard, so if we extend it a bit more,

Re: [HACKERS] 8.5 release timetable, again

2009-08-24 Thread Rick Vernam
On Monday 24 August 2009 3:51:31 pm Bruce Momjian wrote: folks were expecting it in 8.4. That is a slightly alarmist. Who are we going to lose these users to? the insane asylum? -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] 8.5 release timetable, again

2009-08-24 Thread David Fetter
On Mon, Aug 24, 2009 at 04:51:31PM -0400, Bruce Momjian wrote: Josh Berkus wrote: All, Yeah, conference-based releases is just a proxy for time-based releases. It's nice to have something to be happy about at the conference too. And it's a convenient time to start talking about

Re: [HACKERS] revised hstore patch

2009-08-24 Thread Andrew Gierth
Ron == Ron Mayer rm...@cheapcomplexdevices.com writes: At this point it's been 12 days since this was written and no updated patch has been posted, so I think it's well past time to move this to Returned with Feedback. Accordingly I'm going to make that change. Hopefully, an updated

Re: [HACKERS] alpha1 bundled -- please verify

2009-08-24 Thread Peter Eisentraut
On ons, 2009-08-19 at 19:11 +0200, Stefan Kaltenbrunner wrote: Tom Lane wrote: Peter Eisentraut pete...@gmx.net writes: Alpha1 has been bundled and is available at http://developer.postgresql.org/~petere/alpha/ Please check that it is sane. It looks like all the derived grammar files

Re: [HACKERS] Slaying the HYPOTamus

2009-08-24 Thread Paul Matthews
Greg Stark wrote: Also, the question arises what should be returned for hypot(Inf,NaN) which your code returns Inf for. Empirically, it seems the normal floating point behaviour is to return NaN so I think the NaN test should be first. See

Re: [HACKERS] Bug in date arithmetic

2009-08-24 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: I realize I'm in a minority on this, but I would also prefer an error. I expect things like SELECT date + (INTERVAL '1' YEAR) to just work. Uh, I think you're confused. That certainly works, and I didn't hear anyone proposing to change

Re: [HACKERS] 8.5 release timetable, again

2009-08-24 Thread Josh Berkus
I think if we do another release without Standby/replication, we'll start to lose a lot of users. People are waiting on that, and a lot of folks were expecting it in 8.4. That is a slightly alarmist. Who are we going to lose these users to? Drizzle. MySQL forks. CouchDB. Any database

Re: [HACKERS] DELETE syntax on JOINS

2009-08-24 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: What we cannot currently do is reference test twice: test= DELETE FROM test USING test; ERROR: table name test specified more than once test= DELETE FROM test t USING test t; ERROR: table name t specified more than

Re: [HACKERS] 8.5 release timetable, again

2009-08-24 Thread Tom Lane
Josh Berkus j...@agliodbs.com writes: That is a slightly alarmist. Who are we going to lose these users to? Drizzle. MySQL forks. CouchDB. Any database which has replication which you don't need a professional DBA to understand. Whether or not it works. You haven't explained why we'd

Re: [HACKERS] Slaying the HYPOTamus

2009-08-24 Thread Tom Lane
Paul Matthews p...@netspace.net.au writes: Just trying to implement correct C99 behaviour here. Around here we tend to read the Single Unix Spec before C99, and SUS saith something different: http://www.opengroup.org/onlinepubs/007908799/xsh/hypot.html It would be serious folly for us to

Re: [HACKERS] Bug in date arithmetic

2009-08-24 Thread David Fetter
On Mon, Aug 24, 2009 at 07:48:06PM -0400, Tom Lane wrote: Kevin Grittner kevin.gritt...@wicourts.gov writes: I realize I'm in a minority on this, but I would also prefer an error. I expect things like SELECT date + (INTERVAL '1' YEAR) to just work. Uh, I think you're confused.

Re: [HACKERS] Slaying the HYPOTamus

2009-08-24 Thread Greg Stark
On Tue, Aug 25, 2009 at 1:14 AM, Tom Lanet...@sss.pgh.pa.us wrote: Paul Matthews p...@netspace.net.au writes: Just trying to implement correct C99 behaviour here. Around here we tend to read the Single Unix Spec before C99, and SUS saith something different: It doesn't seem to anticipate NaN

[HACKERS] Bug in visibility hint bit

2009-08-24 Thread Jeff Janes
There seems to be a bug in the visibility map in 8.4.0, introduced to cvs on 2008-12-03. It results in tuples being called visible that shouldn't be. In heap_update function from heapam.c: /* * Note: we mustn't clear PD_ALL_VISIBLE flags before writing the WAL *

[HACKERS] [PATCH] Reworks for Access Control facilities (r2251)

2009-08-24 Thread KaiGai Kohei
The following url is a patch to rework access control facilities in PostgreSQL. http://sepgsql.googlecode.com/files/sepgsql-01-base-8.5devel-r2251.patch.gz The current implementation does not have well separation in what to be controled and how to be controled. For example, when we create a

Re: [HACKERS] DELETE syntax on JOINS

2009-08-24 Thread Josh Berkus
All, DELETE FROM target t USING t LEFT JOIN other_table ot ON ... but we have always considered that the target is *not* to be identified with any member of the FROM/USING clause, so it would be a serious compatibility break to change that now. What I don't get is why this is such a

Re: [HACKERS] Bug in visibility hint bit

2009-08-24 Thread Jeff Janes
On Mon, Aug 24, 2009 at 6:23 PM, Jeff Janesjeff.ja...@gmail.com wrote: There seems to be a bug in the visibility map in 8.4.0, introduced to cvs on 2008-12-03. It results in tuples being called visible that shouldn't be. Well, never mind. It took me a few days to track down the bug and in

Re: [HACKERS] 8.5 release timetable, again

2009-08-24 Thread David Fetter
On Mon, Aug 24, 2009 at 08:02:31PM -0400, Tom Lane wrote: Josh Berkus j...@agliodbs.com writes: That is a slightly alarmist. Who are we going to lose these users to? Drizzle. MySQL forks. CouchDB. Any database which has replication which you don't need a professional DBA to

Re: [HACKERS] Bug in date arithmetic

2009-08-24 Thread Josh Berkus
Tom, we preferentially consider unknown_literal to be of the same type as the other operand. I can't really think of what other assumption we would make. Any time a user doesn't specify a type, they're taking pot luck. Me, I always use some_timestamp + INTERVAL 'value' -- Josh Berkus

Re: [HACKERS] [PATCH] Reworks for Access Control facilities (r2251)

2009-08-24 Thread KaiGai Kohei
KaiGai Kohei wrote: The following url is a patch to rework access control facilities in PostgreSQL. http://sepgsql.googlecode.com/files/sepgsql-01-base-8.5devel-r2251.patch.gz IIRC, the limitation of attachment was 40kb, so I resent it using a pointing URL instead of attachment, sorry for

Re: [HACKERS] Bug in visibility hint bit

2009-08-24 Thread Alvaro Herrera
Jeff Janes escribió: On Mon, Aug 24, 2009 at 6:23 PM, Jeff Janesjeff.ja...@gmail.com wrote: There seems to be a bug in the visibility map in 8.4.0, introduced to cvs on 2008-12-03. It results in tuples being called visible that shouldn't be. Well, never mind. It took me a few days to

Re: [HACKERS] [PATCH] Reworks for Access Control facilities (r2251)

2009-08-24 Thread Alvaro Herrera
KaiGai Kohei wrote: KaiGai Kohei wrote: The following url is a patch to rework access control facilities in PostgreSQL. http://sepgsql.googlecode.com/files/sepgsql-01-base-8.5devel-r2251.patch.gz IIRC, the limitation of attachment was 40kb, so I resent it using a pointing URL

Re: [HACKERS] 8.5 release timetable, again

2009-08-24 Thread Robert Haas
On Mon, Aug 24, 2009 at 10:15 PM, David Fetterda...@fetter.org wrote: On Mon, Aug 24, 2009 at 08:02:31PM -0400, Tom Lane wrote: Josh Berkus j...@agliodbs.com writes: That is a slightly alarmist.  Who are we going to lose these users to? Drizzle.  MySQL forks.  CouchDB.  Any database which