Re: [HACKERS] [COMMITTERS] pgsql: Oops, don't forget to rewind the directory before scanning it to

2010-02-22 Thread Andres Freund
On Monday 22 February 2010 04:58:29 Tom Lane wrote: Fujii Masao masao.fu...@gmail.com writes: + Free(xldir); s/Free/FreeDir ? Yeah, that too. I think it's all good now, but please test. At least I havent seen any of the problems pointed out in fsync fun. One thing I was wondering

Re: [HACKERS] A thought on Index Organized Tables

2010-02-22 Thread Gokulakannan Somasundaram
Heikki, I had a quick look at the discussion on visibility map design. The main differences as i see it are a) IOT has both table and index in one structure. So no duplication of data b) With visibility maps, we have three structures a) Table b) Index c) Visibility map. So the disk

Re: [HACKERS] scheduler in core

2010-02-22 Thread Simon Riggs
On Sun, 2010-02-21 at 20:46 +0100, Dimitri Fontaine wrote: Simon Riggs si...@2ndquadrant.com writes: There is currently no way to run a separate daemon process that runs user code as part of Postgres, so that the startup code gets run immediately we startup, re-run if we crash and shut down

Re: [HACKERS] A thought on Index Organized Tables

2010-02-22 Thread Greg Stark
On Mon, Feb 22, 2010 at 8:18 AM, Gokulakannan Somasundaram gokul...@gmail.com wrote: a) IOT has both table and index in one structure. So no duplication of data b) With visibility maps, we have three structures a) Table b) Index c) Visibility map. So the disk footprint of the same data will be

Re: [HACKERS] A thought on Index Organized Tables

2010-02-22 Thread Gokulakannan Somasundaram
Forgot to include the group... On Mon, Feb 22, 2010 at 4:31 PM, Gokulakannan Somasundaram gokul...@gmail.com wrote: These sound like the same point to me. I don't think we're concerned with footprint -- only with how much of that footprint actually needs to be scanned. So if we have a

Re: [HACKERS] Streaming replication and pg_xlogfile_name()

2010-02-22 Thread Heikki Linnakangas
Fujii Masao wrote: On Thu, Jan 28, 2010 at 5:28 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: How about extending the format of the string returned by pg_last_xlog_receive/replay_location() to include the timeline ID? When it currently returns e.g '6/200016C', it could

Re: [HACKERS] Time travel on the buildfarm

2010-02-22 Thread Andrew Dunstan
Tom Lane wrote: It is currently 22:21:59 EST here. At 21:50 I committed a fix to copydir.c that cleaned up a couple of thinkos by Greg, including a misspelling that had been making all the builds fail for several hours. I went to see if any of the buildfarm had gone green yet, and indeed

Re: [HACKERS] A thought on Index Organized Tables

2010-02-22 Thread Alvaro Herrera
Greg Stark escribió: On Mon, Feb 22, 2010 at 8:18 AM, Gokulakannan Somasundaram gokul...@gmail.com wrote: a) IOT has both table and index in one structure. So no duplication of data b) With visibility maps, we have three structures a) Table b) Index c) Visibility map. So the disk footprint

Re: [HACKERS] Plans for 9.1, Grouping Sets, disabling multiqueries, contrib module for string, plpgpsm, preload dictionaries

2010-02-22 Thread Alvaro Herrera
Pavel Stehule escribió: Hello, * Now I am working on migration of plpgpsm to plpgsql 9.0 base. I hope so I understand SQL/PSM well so I am able to write production quality implementation. If you like, I can integrate it to core. It can share about 40-50% code with plpgpsm. The behave of

[HACKERS] ALTER TABLE documentation

2010-02-22 Thread Robert Haas
I just noticed that the current ALTER TABLE documentation doesn't do a very good job differentiating between commands that affect the whole table and commands that only affect specific columns. http://developer.postgresql.org/pgdocs/postgres/sql-altertable.html That didn't matter as much before,

Re: [HACKERS] [COMMITTERS] Re: pgsql: Speed up CREATE DATABASE by deferring the fsyncs until after

2010-02-22 Thread Tom Lane
Greg Stark gsst...@mit.edu writes: On Mon, Feb 22, 2010 at 2:54 AM, Tom Lane t...@sss.pgh.pa.us wrote: I also think it should scan the todir not the fromdir, just on general principles to avoid any possibility of race conditions. I had concluded that scanning the original directory was odd

Re: [HACKERS] Plans for 9.1, Grouping Sets, disabling multiqueries, contrib module for string, plpgpsm, preload dictionaries

2010-02-22 Thread Pavel Stehule
2010/2/22 Alvaro Herrera alvhe...@commandprompt.com: Pavel Stehule escribió: Hello, * Now I am working on migration of plpgpsm to plpgsql 9.0 base. I hope so I understand SQL/PSM well so I am able to write production quality implementation. If you like, I can integrate it to core. It can

Re: [HACKERS] ALTER TABLE SET STATISTICS requires AccessExclusiveLock

2010-02-22 Thread Bruce Momjian
Simon Riggs wrote: On Mon, 2009-10-19 at 12:56 -0300, Alvaro Herrera wrote: Simon Riggs wrote: On Fri, 2009-08-07 at 15:58 -0400, Alvaro Herrera wrote: Tom Lane wrote: Peter Eisentraut pete...@gmx.net writes: Is there a good reason for $subject, other than that the code is

Re: [HACKERS] [COMMITTERS] Re: pgsql: Speed up CREATE DATABASE by deferring the fsyncs until after

2010-02-22 Thread Tom Lane
BTW, I notice that after allegedly fixing things, we are now seeing fsync failures during CREATE DATABASE in the installcheck phase of buildfarm runs on (apparently) all the Windows critters, plus a couple of other platforms too. This mystifies me. I could believe that there was something still

Re: [HACKERS] Recent vendor SSL renegotiation patches break PostgreSQL

2010-02-22 Thread Magnus Hagander
2010/2/20 Tom Lane t...@sss.pgh.pa.us: Bruce Momjian br...@momjian.us writes: Tom Lane wrote: Chris Campbell chris_campb...@mac.com writes: Is there a way to detect when the SSL library has renegotiation disabled? Probably not.  The current set of emergency security patches would certainly

Re: [HACKERS] Recent vendor SSL renegotiation patches break PostgreSQL

2010-02-22 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: If so, shouldn't we try to disable renegotiation for all versions *before* it was properly fixed? If we could tell that, sure. But I don't believe there is any way to identify whether a given installation of openssl has this patched. Please don't

Re: [HACKERS] Recent vendor SSL renegotiation patches break PostgreSQL

2010-02-22 Thread Magnus Hagander
2010/2/22 Tom Lane t...@sss.pgh.pa.us: Magnus Hagander mag...@hagander.net writes: If so, shouldn't we try to disable renegotiation for all versions *before* it was properly fixed? If we could tell that, sure.  But I don't believe there is any way to identify whether a given installation of

Re: [HACKERS] Recent vendor SSL renegotiation patches break PostgreSQL

2010-02-22 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: 2010/2/22 Tom Lane t...@sss.pgh.pa.us: Red Hat's already shipping the patch.  Dunno about other vendors. Which patch? The one that breaks it, or the one that changes the protocol? The one with the protocol change. I think we already missed the

[HACKERS] Reason why set-value functions not allowed in GREATEST(), etc?

2010-02-22 Thread Hitoshi Harada
I just wonder why generate_series() is not allowed in GREATEST syntax. Looking through execQual.c, almost all syntactic evaluations like COALESCE, ARRAY[], ROW() doesn't allow set-value functions. Could someone tell the underlying reason? Also, using variadic functions introduced since 8.4, I

Re: [HACKERS] Recent vendor SSL renegotiation patches break PostgreSQL

2010-02-22 Thread Joshua D. Drake
On Mon, 22 Feb 2010 12:25:08 -0500, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: 2010/2/22 Tom Lane t...@sss.pgh.pa.us: Red Hat's already shipping the patch.  Dunno about other vendors. Which patch? The one that breaks it, or the one that changes the

Re: [HACKERS] scheduler in core

2010-02-22 Thread Jaime Casanova
On Sun, Feb 21, 2010 at 1:11 PM, Simon Riggs si...@2ndquadrant.com wrote: [...] Dimitri Fontaine dfonta...@hi-media.com writes: Dave Page dp...@pgadmin.org writes: Why not just use pgAgent? It's far more flexible than the design you've suggested, and already exists. What would it take to

Re: [HACKERS] Recent vendor SSL renegotiation patches break PostgreSQL

2010-02-22 Thread Joshua D. Drake
On Mon, 22 Feb 2010 18:00:33 +0100, Magnus Hagander mag...@hagander.net wrote: We also have to consider our Windows users, where *we* ship the OpenSSL library. Where there is no library we can ship right now that fixes it. We do? I mean I know that we provide the old 8.2/8.3 pginstaller, but

Re: [HACKERS] Recent vendor SSL renegotiation patches break PostgreSQL

2010-02-22 Thread Magnus Hagander
2010/2/22 Joshua D. Drake j...@commandprompt.com: On Mon, 22 Feb 2010 18:00:33 +0100, Magnus Hagander mag...@hagander.net wrote: We also have to consider our Windows users, where *we* ship the OpenSSL library. Where there is no library we can ship right now that fixes it. We do? I mean I

Re: [HACKERS] Recent vendor SSL renegotiation patches break PostgreSQL

2010-02-22 Thread Chris Campbell
On Feb 22, 2010, at 12:25 PM, Tom Lane wrote: I think we already missed the window where it would have been sensible to install a hack workaround for this. If we'd done that in November it might have been reasonable, but by now it's too late for any hack we install to spread much faster than

Re: [HACKERS] What does this configure warning mean?

2010-02-22 Thread Bruce Momjian
Simon Riggs wrote: On Thu, 2009-10-15 at 00:26 +0300, Peter Eisentraut wrote: On Wed, 2009-10-14 at 15:06 -0300, Alvaro Herrera wrote: Simon Riggs wrote: When I run ./configure, I get (...warning..) (If you are using the official distribution of PostgreSQL then you do

Re: [HACKERS] transaction_isolation vs. default_transaction_isolation

2010-02-22 Thread Bruce Momjian
Josh Berkus wrote: Yeah, they basically have semantics specified by the SQL standard that are not compatible with anything else in GUC land. They are more like SET LOCAL settings, but again not quite. Mind you, transaction_isolation and transaction_read_only aren't documented anywhere

Re: [HACKERS] Wire protocol docs

2010-02-22 Thread Bruce Momjian
Dave Page wrote: On Tue, Oct 13, 2009 at 6:24 PM, Tom Lane t...@sss.pgh.pa.us wrote: Dave Page dp...@pgadmin.org writes: Right. My complaint though, is that the docs imply that the info on how those values get set is in the docs somewhere, which appears to be incorrect. The libpq

Re: [HACKERS] What does this configure warning mean?

2010-02-22 Thread Alvaro Herrera
Bruce Momjian wrote: Simon Riggs wrote: If you have downloaded a full copy of the source then If you are building from a repository checkout ... We don't need to use the word tarball, but we do need to say what we mean. Anyway, its a seldom-used error message and I wouldn't have

Re: [HACKERS] What does this configure warning mean?

2010-02-22 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian wrote: Simon Riggs wrote: If you have downloaded a full copy of the source then If you are building from a repository checkout ... We don't need to use the word tarball, but we do need to say what we mean. Anyway, its a seldom-used error

Re: [HACKERS] Reason why set-value functions not allowed in GREATEST(), etc?

2010-02-22 Thread Pavel Stehule
2010/2/22 Hitoshi Harada umi.tan...@gmail.com: I just wonder why generate_series() is not allowed in GREATEST syntax. Looking through execQual.c,  almost all syntactic evaluations like COALESCE, ARRAY[], ROW() doesn't allow set-value functions. Could someone tell the underlying reason? Also,

Re: [HACKERS] scheduler in core

2010-02-22 Thread Heikki Linnakangas
Jaime Casanova wrote: On Sun, Feb 21, 2010 at 1:11 PM, Simon Riggs si...@2ndquadrant.com wrote: There is currently no way to run a separate daemon process that runs user code as part of Postgres, so that the startup code gets run immediately we startup, re-run if we crash and shut down cleanly

Re: [HACKERS] scheduler in core

2010-02-22 Thread Pavel Stehule
2010/2/22 Heikki Linnakangas heikki.linnakan...@enterprisedb.com: Jaime Casanova wrote: On Sun, Feb 21, 2010 at 1:11 PM, Simon Riggs si...@2ndquadrant.com wrote: There is currently no way to run a separate daemon process that runs user code as part of Postgres, so that the startup code gets

[HACKERS] tie user processes to postmaster was:(Re: [HACKERS] scheduler in core)

2010-02-22 Thread Jaime Casanova
On Mon, Feb 22, 2010 at 1:18 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Jaime Casanova wrote: so, is this idea (having some user processes be tied to postmaster start/stop) going to somewhere? I've added this to the TODO list. Now we just need someone to write it. if

Re: [HACKERS] scheduler in core

2010-02-22 Thread Merlin Moncure
On Sat, Feb 20, 2010 at 8:06 PM, Joshua D. Drake j...@commandprompt.com wrote: That doesn't mean it isn't a really good idea. It would be nice to have a comprehensive job scheduling solution that allows me to continue abstract away from external solutions and operating system dependencies.

Re: [HACKERS] Recent vendor SSL renegotiation patches break PostgreSQL

2010-02-22 Thread Joshua D. Drake
On Mon, 2010-02-22 at 18:45 +0100, Magnus Hagander wrote: 2010/2/22 Joshua D. Drake j...@commandprompt.com: On Mon, 22 Feb 2010 18:00:33 +0100, Magnus Hagander mag...@hagander.net wrote: We also have to consider our Windows users, where *we* ship the OpenSSL library. Where there is no

Re: [HACKERS] tie user processes to postmaster was:(Re: [HACKERS] scheduler in core)

2010-02-22 Thread Heikki Linnakangas
Jaime Casanova wrote: if we can do this, how should it work? Simon said: Yes, I think so. Rough design... integrated_user_processes = 'x, y, z' would run x(), y() and z() in their own processes. These would execute after startup, or at consistent point in recovery. The code for these

Re: [HACKERS] tie user processes to postmaster was:(Re: [HACKERS] scheduler in core)

2010-02-22 Thread Jaime Casanova
On Mon, Feb 22, 2010 at 1:50 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: we need those integrated processes at all when in a standby server? Yes. You might want to run e.g. scheduled reports from a standby reporting server, launched by a scheduler process. Or backups.

Re: [HACKERS] What does this configure warning mean?

2010-02-22 Thread Alvaro Herrera
Bruce Momjian wrote: Alvaro Herrera wrote: That's too subtle. I wouldn't figure out what it means if my life depended on it (then again, it doesn't). Well, official made no sense. Bundled seemed similar enough to tarball. What suggestion do you have? tarball ? -- Alvaro Herrera

Re: [HACKERS] Recent vendor SSL renegotiation patches break PostgreSQL

2010-02-22 Thread Dave Page
On 2/22/10, Joshua D. Drake j...@commandprompt.com wrote: On Mon, 2010-02-22 at 18:45 +0100, Magnus Hagander wrote: 2010/2/22 Joshua D. Drake j...@commandprompt.com: On Mon, 22 Feb 2010 18:00:33 +0100, Magnus Hagander mag...@hagander.net wrote: We also have to consider our Windows

Re: [HACKERS] Recent vendor SSL renegotiation patches break PostgreSQL

2010-02-22 Thread Magnus Hagander
2010/2/22 Chris Campbell chris_campb...@mac.com: On Feb 22, 2010, at 12:25 PM, Tom Lane wrote: I think we already missed the window where it would have been sensible to install a hack workaround for this.  If we'd done that in November it might have been reasonable, but by now it's too late

Re: [HACKERS] Recent vendor SSL renegotiation patches break PostgreSQL

2010-02-22 Thread Magnus Hagander
2010/2/22 Tom Lane t...@sss.pgh.pa.us: Magnus Hagander mag...@hagander.net writes: 2010/2/22 Tom Lane t...@sss.pgh.pa.us: Red Hat's already shipping the patch.  Dunno about other vendors. Which patch? The one that breaks it, or the one that changes the protocol? The one with the protocol

Re: [HACKERS] What does this configure warning mean?

2010-02-22 Thread Bruce Momjian
Alvaro Herrera wrote: Bruce Momjian wrote: Alvaro Herrera wrote: That's too subtle. I wouldn't figure out what it means if my life depended on it (then again, it doesn't). Well, official made no sense. Bundled seemed similar enough to tarball. What suggestion do you have?

Re: [HACKERS] tie user processes to postmaster was:(Re: [HACKERS] scheduler in core)

2010-02-22 Thread Tom Lane
Jaime Casanova jcasa...@systemguards.com.ec writes: heikki.linnakan...@enterprisedb.com wrote: API would be user_process_startup(), user_process_shutdown(). so it should be a GUC, that is settable only at start time. we need those integrated processes at all when in a standby server? This

Re: [HACKERS] Recent vendor SSL renegotiation patches break PostgreSQL

2010-02-22 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: 2010/2/22 Tom Lane t...@sss.pgh.pa.us: Magnus Hagander mag...@hagander.net writes: One way to deal with it would be to expose the whole renegotiation setting as a user configuratble option. So they can set *when* we renegotiate, which would also let

Re: [HACKERS] tie user processes to postmaster was:(Re: [HACKERS] scheduler in core)

2010-02-22 Thread Jaime Casanova
On Mon, Feb 22, 2010 at 2:53 PM, Tom Lane t...@sss.pgh.pa.us wrote: I still haven't seen a good reason for not using cron or Task Scheduler or other standard tools. - marketing? don't you hate when people say: Oracle has it!? - user dumbness: they forgot to start daemons they need (yes, i

Re: [HACKERS] tie user processes to postmaster was:(Re: [HACKERS] scheduler in core)

2010-02-22 Thread Jaime Casanova
On Mon, Feb 22, 2010 at 3:08 PM, Jaime Casanova jcasa...@systemguards.com.ec wrote: On Mon, Feb 22, 2010 at 2:53 PM, Tom Lane t...@sss.pgh.pa.us wrote: I still haven't seen a good reason for not using cron or Task Scheduler or other standard tools. - marketing? don't you hate when people

Re: [HACKERS] scheduler in core

2010-02-22 Thread Merlin Moncure
On Mon, Feb 22, 2010 at 2:29 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Merlin Moncure escribió: Like I noted above, what people want to schedule is going to be stored procedures.  Having both would virtually eliminate the need for scripting outside the database, which is a pretty

Re: [HACKERS] What does this configure warning mean?

2010-02-22 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: Alvaro Herrera wrote: Bruce Momjian wrote: With the attached patch, I have updated the message to use the wording bundled distribution. I think the point about the snapshot tarballs and official releases is that they are bundled rather than pulled via

Re: [HACKERS] What does this configure warning mean?

2010-02-22 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Alvaro Herrera wrote: Bruce Momjian wrote: With the attached patch, I have updated the message to use the wording bundled distribution. I think the point about the snapshot tarballs and official releases is that they are bundled

Re: [HACKERS] What does this configure warning mean?

2010-02-22 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Alvaro Herrera wrote: Bruce Momjian wrote: With the attached patch, I have updated the message to use the wording bundled distribution. I think the point about the snapshot tarballs and official releases is that they are bundled

Re: [HACKERS] Reason why set-value functions not allowed in GREATEST(), etc?

2010-02-22 Thread Tom Lane
Hitoshi Harada umi.tan...@gmail.com writes: I just wonder why generate_series() is not allowed in GREATEST syntax. Looking through execQual.c, almost all syntactic evaluations like COALESCE, ARRAY[], ROW() doesn't allow set-value functions. Could someone tell the underlying reason? Laziness,

Re: [HACKERS] What does this configure warning mean?

2010-02-22 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: Should we just go ahead and say official releases and daily snapshots? Please just revert the patch. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] What does this configure warning mean?

2010-02-22 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Should we just go ahead and say official releases and daily snapshots? Please just revert the patch. So much for my trying to improve things. Reverted. -- Bruce Momjian br...@momjian.ushttp://momjian.us EnterpriseDB

Re: [HACKERS] tie user processes to postmaster was:(Re: [HACKERS] scheduler in core)

2010-02-22 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: This seems like a solution in search of a problem to me. The most salient aspect of such processes is that they would necessarily run as the postgres user I happen to run my PGQ tickers and londiste daemons as londiste user and make it a superuser (at least

Re: [HACKERS] tie user processes to postmaster was:(Re: [HACKERS] scheduler in core)

2010-02-22 Thread Merlin Moncure
On Mon, Feb 22, 2010 at 2:53 PM, Tom Lane t...@sss.pgh.pa.us wrote: I still haven't seen a good reason for not using cron or Task Scheduler or other standard tools. *) provided and popular feature in higher end databases *) the audience you cater to expects it *) IMO, it should simply not be

Re: [HACKERS] tie user processes to postmaster was:(Re: [HACKERS] scheduler in core)

2010-02-22 Thread Tom Lane
Dimitri Fontaine dfonta...@hi-media.com writes: Tom Lane t...@sss.pgh.pa.us writes: This seems like a solution in search of a problem to me. The most salient aspect of such processes is that they would necessarily run as the postgres user The precedent are archive and restore command. They

Re: [HACKERS] tie user processes to postmaster was:(Re: [HACKERS] scheduler in core)

2010-02-22 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: Well, yeah, but you *must* trust those commands because every last bit of your database content passes through their hands. That is not an argument why you need to trust a scheduling facility --- much less the tasks it schedules. It seems to me that CREATE

Re: [HACKERS] scheduler in core

2010-02-22 Thread Alvaro Herrera
Merlin Moncure escribió: Like I noted above, what people want to schedule is going to be stored procedures. Having both would virtually eliminate the need for scripting outside the database, which is a pretty big deal since external scripts are a real pain to keep cross platform. Since

Re: [HACKERS] tie user processes to postmaster was:(Re: [HACKERS] scheduler in core)

2010-02-22 Thread David Christensen
On Feb 22, 2010, at 5:22 PM, Jaime Casanova wrote: On Mon, Feb 22, 2010 at 4:37 PM, Tom Lane t...@sss.pgh.pa.us wrote: Dimitri Fontaine dfonta...@hi-media.com writes: Tom Lane t...@sss.pgh.pa.us writes: This seems like a solution in search of a problem to me. The most salient aspect of

Re: [HACKERS] remove useless set of active snap

2010-02-22 Thread Bruce Momjian
Alvaro Herrera wrote: This patch removes a useless pushing of an active snapshot on PortalStart. Instead of push/get/pop of the active snapshot, without any intervening use of the active snapshot, we just pass a local snapshot down to CreateQueryDesc. Alvaro, what happened to this patch? --

Re: [HACKERS] commented out para in docs

2010-02-22 Thread Bruce Momjian
Andrew Dunstan wrote: We have this para in the CREATE TABLE docs, commented out, as shown. It seems to have been like that for a long time (see http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/ref/create_table.sgml?annotate=1.48). Surely we should either include it or remove

Re: [HACKERS] tie user processes to postmaster was:(Re: [HACKERS] scheduler in core)

2010-02-22 Thread Jaime Casanova
On Mon, Feb 22, 2010 at 4:37 PM, Tom Lane t...@sss.pgh.pa.us wrote: Dimitri Fontaine dfonta...@hi-media.com writes: Tom Lane t...@sss.pgh.pa.us writes: This seems like a solution in search of a problem to me.  The most salient aspect of such processes is that they would necessarily run as the

Re: [HACKERS] remove useless set of active snap

2010-02-22 Thread Alvaro Herrera
Bruce Momjian wrote: Alvaro Herrera wrote: This patch removes a useless pushing of an active snapshot on PortalStart. Instead of push/get/pop of the active snapshot, without any intervening use of the active snapshot, we just pass a local snapshot down to CreateQueryDesc. Alvaro, what

Re: [HACKERS] tie user processes to postmaster was:(Re: [HACKERS] scheduler in core)

2010-02-22 Thread Alvaro Herrera
David Christensen wrote: What are the semantics? If you launch a process and it crashes, is the postmaster responsible for relaunching it? Is there any additional monitoring of that process it would be expected to do? What defined hooks/events would you want to launch these processes from?

Re: [HACKERS] [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server

2010-02-22 Thread Bruce Momjian
What happened to this patch? I don't see any objections, but it was not applied. --- Jim Cox wrote: On Tue, Sep 29, 2009 at 12:00 AM, Alvaro Herrera alvhe...@commandprompt.com wrote: Jim Cox escribi?: Attached s/b a

Re: [HACKERS] Issues for named/mixed function notation patch

2010-02-22 Thread Bruce Momjian
Can someone work on a patch to implement the document changes suggested below? --- Jeff Davis wrote: On Tue, 2009-09-15 at 10:51 +0200, Pavel Stehule wrote: My renonc, please, try new patch. I forgot mark regproc.c file.

Re: [HACKERS] numeric_to_number() function skipping some digits

2010-02-22 Thread Bruce Momjian
Added to TODO: |Fix to_number() handling for values not matching the format string --- Jeevan Chalke wrote: Hi, On Mon, Sep 21, 2009 at 12:36 PM, Brendan Jurd dire...@gmail.com wrote: 2009/9/21 Jeevan

Re: [HACKERS] updated hstore patch

2010-02-22 Thread Bruce Momjian
Tom Lane wrote: David E. Wheeler da...@kineticode.com writes: On Sep 20, 2009, at 8:43 AM, Tom Lane wrote: Yeah, this is a long-standing generic issue, and not really hstore's problem to fix. So then does there need to be some documentation for how to deal with this, for those doing

Re: [HACKERS] [PATCH] backend: compare word-at-a-time in bcTruelen

2010-02-22 Thread Bruce Momjian
Tom Lane wrote: Jeremy Kerr j...@ozlabs.org writes: Stephen, If the updated function is always faster when the overall string is at least, say, 16 characters long, But that's not the case - the cost of the function (and the speedup from the previous version) depends on the number of

Re: [HACKERS] Streaming replication and pg_xlogfile_name()

2010-02-22 Thread Fujii Masao
On Mon, Feb 22, 2010 at 9:30 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Thinking about this again, I'm not sure this is a good idea. Using curFileTLI makes sense if you're going to call pg_xlogfile_name() and would expect it to return the filename of the file containing

Re: [HACKERS] Elementary dependency look-up

2010-02-22 Thread Bruce Momjian
Added to TODO: |Add function to dump pg_depend information cleanly --- Greg Smith wrote: On Wed, 9 Sep 2009, decibel wrote: What might be more useful is a view that takes the guesswork out of using

[HACKERS] function side effects

2010-02-22 Thread Tatsuo Ishii
Hi, I'm wondering if we could detect a funcion has a side effect, i.e. does a write to database. This is neccessary for pgpool to decide if a qeury should to be sent to all of databases or not. If a query includes functions which do writes to database, it should send the query to all of

[HACKERS] synchronous commit in dump

2010-02-22 Thread Jaime Casanova
Hi, it's safe to set synchrounous_commit to off in a pg_dump generated script? if yes, would this help to the performance of restore a database? -- Atentamente, Jaime Casanova Soporte y capacitación de PostgreSQL Asesoría y desarrollo de sistemas Guayaquil - Ecuador Cel. +59387171157 -- Sent

Re: [SPAM][HACKERS] function side effects

2010-02-22 Thread Takahiro Itagaki
Tatsuo Ishii is...@postgresql.org wrote: VOLATILE functions such as random() and timeofday() apparently do not write and sending those queries that include such functions is overkill. Can we VOLATILE property divide into two categories, say, VOLATILE without write, and VOLATILE with write?

Re: [HACKERS] function side effects

2010-02-22 Thread Tom Lane
Tatsuo Ishii is...@postgresql.org writes: I'm wondering if we could detect a funcion has a side effect, i.e. does a write to database. Currently we have three properties of functions: IMMUTABLE, STABLE and VOLATILE. According to docs IMMUTABLE or STABLE functions do not write to database.

[HACKERS] recovery.conf.sample

2010-02-22 Thread Fujii Masao
Hi, recovery.conf.sample has the following section for Hot Standby. Is this still required? #--- # HOT STANDBY PARAMETERS #--- # # If you want to

Re: [HACKERS] A thought on Index Organized Tables

2010-02-22 Thread Takahiro Itagaki
Gokulakannan Somasundaram gokul...@gmail.com wrote: a) IOT has both table and index in one structure. So no duplication of data b) With visibility maps, we have three structures a) Table b) Index c) Visibility map. So the disk footprint of the same data will be higher in postgres ( 2x + size

Re: [HACKERS] tie user processes to postmaster was:(Re: [HACKERS] scheduler in core)

2010-02-22 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Regarding hooks or events, I think postmaster should be kept simple: launch at start, reset at crash recovery, kill at stop. Salt and pepper allowed but that's about it -- more complex ingredients are out of the question due to added code to

Re: [HACKERS] A thought on Index Organized Tables

2010-02-22 Thread Tom Lane
Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp writes: Instead, how about excluding columns in primary keys from table data? How will you implement select * from mytable ? Or even select * from mytable where non_primary_key = something ? If you can't do either of those without great expense, I

Re: [HACKERS] More robust pg_hba.conf parsing/error logging

2010-02-22 Thread Bruce Momjian
Tom Lane wrote: Alvaro Herrera alvhe...@commandprompt.com writes: Andrew Dunstan wrote: It will affect any dbname or username in mixed or upper case, not just ALL, won't it? No, I am suggesting to change only the comparisons to the literals all, sameuser, samegroup and samerole. What

Re: [HACKERS] Adding \ev view editor?

2010-02-22 Thread Bruce Momjian
Is this a TODO? --- Josh Berkus wrote: All, I've grown to adore the new \ef function editor. It doesn't seem like it would be that difficult to add a view editor as \ev. While editors would also be good for other

Re: [HACKERS] phypot - Pygmy Hippotause ?

2010-02-22 Thread Bruce Momjian
I assume this is not something we are supposed to apply. --- Paul Matthews wrote: Kevin Grittner wrote: The first test seems unnecessary if you have the second. x = 0, so x can't be zero unless y is, too.

Re: [HACKERS] tie user processes to postmaster

2010-02-22 Thread Takahiro Itagaki
Jaime Casanova jcasa...@systemguards.com.ec wrote: integrated_user_processes = 'x, y, z' API would be user_process_startup(), user_process_shutdown(). FYI, pg_statsinfo version 2 emulates the same behavior with shared_preload_libraries and spawn an user process in _PG_init(). But it's still

Re: [HACKERS] pretty print viewdefs

2010-02-22 Thread Bruce Momjian
What happened to this? I didn't see it applied. --- Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: OK, and how are we going to set that flag? Like I did, with a separate function? I would be inclined

Re: [HACKERS] A thought on Index Organized Tables

2010-02-22 Thread Takahiro Itagaki
Tom Lane t...@sss.pgh.pa.us wrote: Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp writes: Instead, how about excluding columns in primary keys from table data? How will you implement select * from mytable ? Or even select * from mytable where non_primary_key = something ? Use index

Re: [HACKERS] A thought on Index Organized Tables

2010-02-22 Thread Tom Lane
Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp writes: Tom Lane t...@sss.pgh.pa.us wrote: Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp writes: Instead, how about excluding columns in primary keys from table data? How will you implement select * from mytable ? Or even select * from

Re: [HACKERS] A thought on Index Organized Tables

2010-02-22 Thread Takahiro Itagaki
Tom Lane t...@sss.pgh.pa.us wrote: Also, we're using the same technique for TOASTed values. The cost can be compared with select * from mytable where toasted_value = something, no? No, because toast pointers point in the direction you need to traverse. AFAICS, this proposal involves

[HACKERS] to_char(HH12) with intervals

2010-02-22 Thread Bruce Momjian
bruce wrote: bruce wrote: Dave Page wrote: This was posted as a documentation comment: to_char(interval '0d 0h 12m 44s', 'DD HH MI SS'); with HH and HH12 will return 12 instead of 0. Testing on 8.4.1, it does seem to be the case that you get 00 12 12 44. Seems bogus to

Re: [HACKERS] Streaming replication and pg_xlogfile_name()

2010-02-22 Thread Heikki Linnakangas
Fujii Masao wrote: On Mon, Feb 22, 2010 at 9:30 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Thinking about this again, I'm not sure this is a good idea. Using curFileTLI makes sense if you're going to call pg_xlogfile_name() and would expect it to return the filename of

Re: [HACKERS] [COMMITTERS] Re: pgsql: Speed up CREATE DATABASE by deferring the fsyncs until after

2010-02-22 Thread Andres Freund
Hi Tom, On Tuesday 23 February 2010 06:37:26 Tom Lane wrote: I wrote: Any theories about what is happening? Now, this doesn't mean that all is fine and dandy. I believe that a majority of Unixen will reject attempts to open directories for writing, so this solution puts us even further