Hello
2011/7/14 Alvaro Herrera alvhe...@commandprompt.com:
Excerpts from Pavel Stehule's message of jue jul 14 16:25:56 -0400 2011:
2011/7/14 Alvaro Herrera alvhe...@commandprompt.com:
A couple items for this patch:
it is good idea
Thanks ... I expect you're going to resubmit the patch
Hi!
Thank you for review. I've few questions about it.
On Fri, Jul 15, 2011 at 2:13 AM, Nathan Boley npbo...@gmail.com wrote:
First, it makes me uncomfortable that you are using the MCV and histogram
slot
kinds in a way that is very different from other data types.
I realize that tsvector
On Thu, Jul 14, 2011 at 10:54 PM, Josh Berkus j...@agliodbs.com wrote:
As one of said vendors, I completely disagree.
I don't agree that you qualify as a vendor. You're on the friggin' core
team.
And I look after the development of the leading open source management
tool for PostgreSQL, as
On 14.07.2011 13:29, Alexander Korotkov wrote:
On Thu, Jul 14, 2011 at 12:56 PM, Heikki Linnakangas
heikki.linnakan...@enterprisedb.com wrote:
First, notice that we're setting ptr-parent = top. 'top' is the current
node we're processing, and ptr represents the node to the right of the
current
On Fri, Jul 15, 2011 at 2:13 AM, Nathan Boley npbo...@gmail.com wrote:
First, it makes me uncomfortable that you are using the MCV and histogram
slot
kinds in a way that is very different from other data types.
I realize that tsvector uses MCV in the same way that you do but:
1) I don't
On 13.07.2011 22:04, Heikki Linnakangas wrote:
On 13.07.2011 21:56, Alexander Korotkov wrote:
Thank you very much for detail explanation. But this line of modified
patch
seems strange for me:
*newchildoffnum = blkno;
I believe it should be:
*newchildoffnum = i;
Yes, you're right. It's scary
On Fri, Jul 15, 2011 at 1:27 PM, Heikki Linnakangas
heikki.linnakan...@enterprisedb.com wrote:
Ok, committed this now.
Thank you.
I decided to rename the childoffnum field to downlinkoffnum. I figured
it'd be dangerous that the field means something subtly different in
different versions,
Fri, Jul 15, 2011 at 12:53 AM, Heikki Linnakangas
heikki.linnakan...@enterprisedb.com wrote:
On 14.07.2011 23:41, Alexander Korotkov wrote:
Do you think using rightlink as pointer to parent page is possible
during
index build? It would allow to simplify code significantly, because of no
On 15/07/11 14:57, Tatsuo Ishii wrote:
Maybe we could add more info regarding current usage and requested
amount in addition to the temp file limit value. I mean something
like:
ERROR: aborting due to exceeding temp file limit. Current usage 9000kB,
requested size 1024kB, thus it will exceed
2011/7/15 Mark Kirkwood mark.kirkw...@catalyst.net.nz:
On 15/07/11 14:57, Tatsuo Ishii wrote:
Maybe we could add more info regarding current usage and requested
amount in addition to the temp file limit value. I mean something
like:
ERROR: aborting due to exceeding temp file limit. Current
On Fri, Jul 15, 2011 at 12:56 AM, Pavan Deolasee
pavan.deola...@gmail.com wrote:
On Thu, Jul 14, 2011 at 6:22 PM, Simon Riggs si...@2ndquadrant.com wrote:
This is a very rare issue, because of all the work yourself and Heikki
have put in.
I don't think its rare case since vacuum on any
On Jul 14, 2011, at 4:42 AM, Simon Riggs si...@2ndquadrant.com wrote:
On Thu, Jul 14, 2011 at 9:57 AM, Fujii Masao masao.fu...@gmail.com wrote:
Currently walwriter might write out the WAL before a transaction commits.
IOW, walwriter tries to write out the WAL in wal_buffers in every wakeups.
My instrumentation wasn't that good. I was using powertop 1.13, which
apparently goes to great lengths to group processes by various
criteria (including process group), but doesn't actually offer the
option of seeing that instrumentation per process.
I'm using version 1.98 beta 1 as of now, which
On Fri, Jul 15, 2011 at 2:29 PM, Robert Haas robertmh...@gmail.com wrote:
If the primary goal here is to reduce power consumption, another option
would be to keep the regular wake-ups most of the time but have some
mechanism for putting the process to sleep until wakened when no activity
Oh, I see. You essentially do a merge join of all the posting trees of
query keys.
Hmm, but we do need to scan all the posting trees of all the matched
keys in whole anyway. We could collect all TIDs in the posting lists of
all the keys into separate TIDBitmaps, and then combine the bitmaps,
Magnus,
Thank you for reviewing my patch. I'm going to modify the patch according to
your comments and re-submit it. Before that, I'd like to discuss some points
and get your agreement.
From: Magnus Hagander mag...@hagander.net
+para
+ On Windows, you need to register an
=?ISO-8859-1?Q?C=E9dric_Villemain?= cedric.villemain.deb...@gmail.com writes:
On 15/07/11 14:57, Tatsuo Ishii wrote:
Maybe we could add more info regarding current usage and requested
amount in addition to the temp file limit value. I mean something
like:
ERROR: aborting due to exceeding
Peter Eisentraut pete...@gmx.net writes:
(Going through some loose ends in the information schema ...)
Is my understanding right that the ON COMMIT action of temporary tables
is not recorded in the system catalogs anywhere? Would make sense,
wouldn't be a big problem, just want to make sure I
Excerpts from Simon Riggs's message of vie jul 15 09:55:40 -0400 2011:
On Fri, Jul 15, 2011 at 2:29 PM, Robert Haas robertmh...@gmail.com wrote:
If the primary goal here is to reduce power consumption, another option
would be to keep the regular wake-ups most of the time but have some
Excerpts from Josh Berkus's message of jue jul 14 15:01:10 -0400 2011:
All,
Currently we have 8 patches Ready for Committer in the current CF.
Some of them have been that status for some time.
From traffic on this list, I'm getting the impression that nobody other
than Robert, Heikki and
Magnus Hagander mag...@hagander.net writes:
On Thu, Jul 14, 2011 at 21:59, Josh Berkus j...@agliodbs.com wrote:
So if we're going to break compatibility, then we could stand to make a
little noise about it.
We've broken the admin apps in pretty much every single release. And
they generally
On Fri, Jul 15, 2011 at 17:25, Tom Lane t...@sss.pgh.pa.us wrote:
Magnus Hagander mag...@hagander.net writes:
On Thu, Jul 14, 2011 at 21:59, Josh Berkus j...@agliodbs.com wrote:
So if we're going to break compatibility, then we could stand to make a
little noise about it.
We've broken the
David E. Wheeler da...@kineticode.com writes:
So pgTAP creates temporary tables to store result sets so that it can then
compare the results of two queries. The function in question was getting a
list of columns in such a temporary table in order to make sure that the
types were the same
Peter Eisentraut pete...@gmx.net wrote:
Some of these new error messages from the SSI code are a mouthful:
not enough elements in RWConflictPool to record a rw-conflict
not enough elements in RWConflictPool to record a potential
rw-conflict
These are basically out of shared
On Jul 15, 2011, at 8:55 AM, Simon Riggs si...@2ndquadrant.com wrote:
On Fri, Jul 15, 2011 at 2:29 PM, Robert Haas robertmh...@gmail.com wrote:
If the primary goal here is to reduce power consumption, another option
would be to keep the regular wake-ups most of the time but have some
Thanks, applied.
---
Florian Pflug wrote:
On Jul14, 2011, at 22:18 , Bruce Momjian wrote:
!OID of the database in which the lock target exists, or
!zero if the lock is a shared object, or
!
Robert Haas robertmh...@gmail.com writes:
On Jul 15, 2011, at 8:55 AM, Simon Riggs si...@2ndquadrant.com wrote:
The only difference is how bulk write operations are handled. As long
as we wake WALWriter before wal_buffers fills then we'll be good.
Wakeup once per wal buffer is too much. I
On Jul 15, 2011, at 12:06 PM, Kevin Grittner kevin.gritt...@wicourts.gov
wrote:
I have a suspicion that we might sometimes find the information
conveyed by the detail useful when responding to users with
questions; but the language as it stands seems confusing for users.
I think removing info
Robert Haas robertmh...@gmail.com writes:
On Jul 15, 2011, at 12:06 PM, Kevin Grittner kevin.gritt...@wicourts.gov
wrote:
I have a suspicion that we might sometimes find the information
conveyed by the detail useful when responding to users with
questions; but the language as it stands seems
On 2011-07-14 02:42, Josh Berkus wrote:
The first two are difficult patches, but the other two are not. Please
volunteer to give these patches a review; we owe it to our contributors
to review everything before the end of the CF.
When is the end of the CF? (I'm strongly suspecting today, but
Yeb Havinga yebhavi...@gmail.com writes:
On 2011-07-14 02:42, Josh Berkus wrote:
The first two are difficult patches, but the other two are not. Please
volunteer to give these patches a review; we owe it to our contributors
to review everything before the end of the CF.
When is the end of
On Thu, Jul 14, 2011 at 01:42, Josh Berkus j...@agliodbs.com wrote:
Allow multiple Postgres clusters running on the same machine to
distinguish themselves in the event log
https://commitfest.postgresql.org/action/patch_view?id=562
I've reviewed this now, but I won't have time to take it
Excerpts from Tom Lane's message of vie jul 15 14:33:34 -0400 2011:
I think that Peter's real concern is whether these are worth
translating, and I share that doubt. Perhaps we should invent an
errdetail_internal, parallel to errmsg_internal, that works like
errdetail but doesn't treat the
On Mon, Jul 4, 2011 at 10:22 PM, Joseph Adams
joeyadams3.14...@gmail.com wrote:
I'll try to submit a revised patch within the next couple days.
Sorry this is later than I said.
I addressed the issues covered in the review. I also fixed a bug
where \u0022 would become , which is invalid JSON,
Alvaro,
It seems that by mentioning some people but not all, you offended both
the people you mentioned (at least some of them, because they are
already actively helping) and those that you didn't (at least some of
them, because they are already actively helping; those that are not
Robert,
I should be able to do some performance testing on this, but not today.
Questions:
(1) can you re-link me to the pgbench and sysbench setup you used to
test this originally? I'd like to implement those.
(2) the max machine I can test these on is 16 cores. Is that adequate,
or do we
Josh,
Fair enough. If the pg_comments patch does go down in flames, I can
circle back and patch up the rest of the holes in \dd.
I am unable to figure out the status of the pg_comments patch from this
thread. What's going on with it?
--
Josh Berkus
PostgreSQL Experts Inc.
All,
As you can probably tell, we are not ready to end the commitfest. (I
think Robert gave me this CF to show why even talking about a one-week
mini-fest is a fantasy. If so, successful.).
I've booted the patches which obviously aren't going to be immediately
ready. Nine patches are ready
Alvaro Herrera alvhe...@commandprompt.com wrote:
Excerpts from Tom Lane's message:
I think that Peter's real concern is whether these are worth
translating, and I share that doubt. Perhaps we should invent an
errdetail_internal, parallel to errmsg_internal, that works like
errdetail but
Excerpts from Josh Berkus's message of vie jul 15 16:32:42 -0400 2011:
Alvaro,
It seems that by mentioning some people but not all, you offended both
the people you mentioned (at least some of them, because they are
already actively helping) and those that you didn't (at least some of
Josh Berkus wrote:
Alvaro,
It seems that by mentioning some people but not all, you offended both
the people you mentioned (at least some of them, because they are
already actively helping) and those that you didn't (at least some of
them, because they are already actively helping;
Hello!
Recently we have upgraded our debian system (sid),
which has since started crashing mysteriously.
We are still looking into that. It runs on 3ware RAID.
Postgres package is 8.4.8-2.
The database came back up apparently ok, except
for indexes. Running reindex produces this error on
one of
Robert Haas robertmh...@gmail.com writes:
On Fri, Jul 8, 2011 at 9:36 AM, Martin Pihlak martin.pih...@gmail.com wrote:
On 07/03/2011 05:08 AM, Steve Singer wrote:
Since the original patch was submitted as a WIP patch and this version
wasn't sent until well into the commit fest I am not sure if
Yeah, everybody's super-touchy this week. Must be the weather.
Somehow blaming everyone else doesn't seem like the proper reaction. :-(
Look, it wasn't meant to be a complete list, or even a representative
one. That's why I tagged a Bueller? at the end. Even for those who
don't get the
Actually, not MCV slot is used but MCELEM. It is a different slot. ps_stats
view map both into same fileds.
Yes, you're right. I am sorry about the error.
Surely, non-standard use of histogram slot
should be avoided.
Agreed.
Best,
Nathan
--
Sent via pgsql-hackers mailing list
Josh Berkus j...@agliodbs.com writes:
You might notice that we don't publish a list of committers anywhere.
In fact, *I* don't have one.
http://wiki.postgresql.org/wiki/Committers
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
It's been a few days since I've run through my usual builds and
tests, and I just discovered that part of my routine was broken by
this commit:
http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=846af54dd5a77dc02feeb5e34283608012cfb217
The isolation tests are broken when run
On Fri, Jul 15, 2011 at 15:03, MauMau maumau...@gmail.com wrote:
Magnus,
Thank you for reviewing my patch. I'm going to modify the patch according to
your comments and re-submit it. Before that, I'd like to discuss some points
and get your agreement.
Ok, please do. If you want to, you can
http://wiki.postgresql.org/wiki/Committers
Oh, thanks! I didn't know that existed.
So, if any of the following people could possibly pick up even one patch
from the current commitfest and commit it, it would clear out our
pending commit list:
* Bruce Momjian
* Tatsuo Ishii
* Andrew Dunstan
*
Excerpts from Alexey Kluykin's message of jue jul 14 09:18:15 -0400 2011:
On Jul 14, 2011, at 4:38 AM, Alvaro Herrera wrote:
On Jul14, 2011, at 01:38 , Alvaro Herrera wrote:
This is happening because a check for total number of errors so far is
happening only after coming across at
Kevin Grittner kevin.gritt...@wicourts.gov wrote:
Alvaro Herrera alvhe...@commandprompt.com wrote:
Excerpts from Tom Lane's message:
I think that Peter's real concern is whether these are worth
translating, and I share that doubt. Perhaps we should invent
an errdetail_internal, parallel to
Excerpts from Josh Berkus's message of vie jul 15 18:33:14 -0400 2011:
http://wiki.postgresql.org/wiki/Committers
Oh, thanks! I didn't know that existed.
So, if any of the following people could possibly pick up even one patch
from the current commitfest and commit it, it would clear
On Fri, Jul 15, 2011 at 4:48 PM, Josh Berkus j...@agliodbs.com wrote:
I am unable to figure out the status of the pg_comments patch from this
thread. What's going on with it?
I don't blame you :-)
I think this thread got so confusing because two separate topics were
intertwined. (I'm going to
On 7/15/11 3:54 PM, Josh Kupershmidt wrote:
So that's where the pg_comments patch stands, at least AIUI. Clear as
mud yet? :)
Sounds like returned with feedback to me.
--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com
--
Sent via pgsql-hackers mailing list
Excerpts from Noah Misch's message of mié jul 13 01:34:10 -0400 2011:
coypu failed during the run of the test due to a different session being
chosen
as the deadlock victim. We can now vary deadlock_timeout to prevent this; see
attached fklocks-tests-deadlock_timeout.patch. This also makes
Alvaro,
The ready for committer state does not mean that the committer can
grab the patch and apply it. Last time I checked, one was still
expected to review it and take full responsibility for any breakage
caused by it.
You're absolutely correct. Which is why committer bandwidth is such a
Excerpts from Kevin Grittner's message of vie jul 15 18:23:10 -0400 2011:
It's been a few days since I've run through my usual builds and
tests, and I just discovered that part of my routine was broken by
this commit:
Pavel Stehule pavel.steh...@gmail.com writes:
I am sending a updated patch
I looked over this patch a bit. I guess my main concern about it
is that the set of items to be reported seems to have been made up on
a whim. I think that we ought to follow the SQL standard, which has a
pretty clearly
Alvaro Herrera alvhe...@commandprompt.com writes:
Excerpts from Alexey Kluykin's message of jue jul 14 09:18:15 -0400 2011:
This is happening because a check for total number of errors so far
is happening only after coming across at least one non-recognized
configuration option. What about
Kevin Grittner kevin.gritt...@wicourts.gov writes:
OK, after getting distracted by test failures caused by an unrelated
commit, I've confirmed that this passes my usual tests. I don't
know anything about the tools used for extracting the text for the
translators, so if that needs any
On Jul 13, 2011, at 2:23 PM, David E. Wheeler wrote:
Wasn't newsysviews supposed to deal with these sorts of issues? Why were they
rejected?
Unless they recently came up again and got rejected again; the original
complaint was that some of their conventions didn't follow information_schema
On Fri, Jul 15, 2011 at 7:01 PM, Josh Berkus j...@agliodbs.com wrote:
On 7/15/11 3:54 PM, Josh Kupershmidt wrote:
So that's where the pg_comments patch stands, at least AIUI. Clear as
mud yet? :)
Sounds like returned with feedback to me.
Yeah, that's fine for this CF (though I do welcome any
On Jul 15, 2011, at 3:48 PM, Josh Berkus j...@agliodbs.com wrote:
Josh,
Fair enough. If the pg_comments patch does go down in flames, I can
circle back and patch up the rest of the holes in \dd.
I am unable to figure out the status of the pg_comments patch from this
thread. What's going
Hello,
The attached file is a revised patch which reflects all review comments by
Magnus in:
http://archives.postgresql.org/pgsql-hackers/2011-07/msg00839.php
I made sure the previous tests (both custom and default PostgreSQL event
source) succeeded.
I'm submitting this to the currently
Hello,
I re-submitted a patch and added a comment on the page below. I chose
patch from the comment type drop-down box, but the patch status does not
change from waiting on author. I expected the patch status would become
needs review.
Patch: Allow multiple Postgres clusters running on the
65 matches
Mail list logo
