[HACKERS] how to get the effected row after execute a query

2011-08-19 Thread EazonGuo
Hello, I have a question. In SQL Server, we can use @@rowcount to get the efftected row which record last query 's effected row .So I have a question: In Postgresql, how we can get the effected row? Is there some similar functions to complete this? -- Best regards Eazon

Re: [HACKERS] how to get the effected row after execute a query

2011-08-19 Thread Pavel Stehule
Hello 2011/8/19 EazonGuo eazon...@gmail.com: Hello, I have a question. In SQL Server, we can use @@rowcount to get the efftected row which record last query 's  effected row .So I have a question: In Postgresql, how we can get the effected row? Is there some similar functions to complete

Re: [HACKERS] [v9.1] sepgsql - userspace access vector cache

2011-08-19 Thread Kohei KaiGai
2011/8/18 Robert Haas robertmh...@gmail.com: On Thu, Aug 18, 2011 at 1:17 PM, Kohei Kaigai kohei.kai...@emea.nec.com wrote: That's lame.  I think we need to patch contrib/sepgsql so that it fails to build in that case, rather than building and then not working. It might be the following

Re: [HACKERS] [v9.1] sepgsql - userspace access vector cache

2011-08-19 Thread Kohei KaiGai
I fixed up the security policy for regression test, and chkselinuxenv script. The revised security policy allows test domains to execute programs being installed under home directories. In addition, the revised chkselinuxenv newly checks necessary commands to run this script itself, and changed

[HACKERS] wrong plpgsql's line counting 9.1

2011-08-19 Thread Pavel Stehule
Hello I found a bug in plpgsql parser. create table t(a int, b int); postgres=# \sf fx CREATE OR REPLACE FUNCTION public.fx() RETURNS void LANGUAGE plpgsql AS $function$ declare r record; begin r := (10,20)::t; if true then raise notice '% %', r.c, r.b; end if; end; $function$

Re: [HACKERS] wrong plpgsql's line counting 9.1

2011-08-19 Thread Pavel Stehule
Hello I am sorry, it's noise regards Pavel 2011/8/19 Pavel Stehule pavel.steh...@gmail.com: Hello I found a bug in plpgsql parser. create table t(a int, b int); postgres=# \sf fx CREATE OR REPLACE FUNCTION public.fx()  RETURNS void  LANGUAGE plpgsql AS $function$ declare r record;

Re: [HACKERS] the big picture for index-only scans

2011-08-19 Thread Gokulakannan Somasundaram
Note that we already have the visibility map, and the accesses needed to update it are already there. Granted, we'll have to change the logic slightly to make it crash safe, but I don't expect that to add any meaningful overhead - the changes are going to be where the bits are set, ie.

Re: [HACKERS] Backup's from standby

2011-08-19 Thread Valentine Gogichashvili
What issue we may face if you take a backups(includes data dir + wal files) at standby without LVM snapshot? The backup might be corrupted in arbitrary ways. And what will happen, if one issues a pg_start_backup() on the master, then takes a file-backup on slave, and issues

Re: [HACKERS] make -j4 world falls over

2011-08-19 Thread Tom Lane
I wrote: I ran into $SUBJECT whilst doing trial RPM packaging of 9.1. BTW, the failure seems rather hard to provoke at -j4 ... so it was just bad luck that my first rpmbuild run fell over. However, in manual testing, it fails pretty much every time at -j16, on my 4-processor Fedora box.

Re: [HACKERS] [v9.1] sepgsql - userspace access vector cache

2011-08-19 Thread Tom Lane
Kohei KaiGai kai...@kaigai.gr.jp writes: 2011/8/18 Robert Haas robertmh...@gmail.com: Actually, as I look at this more, I think this build system is completely mis-designed.  Given that you want to build sepgsql, selinux is not an optional feature.  So the stuff in contrib/sepgsql/Makefile

Re: [HACKERS] [v9.1] sepgsql - userspace access vector cache

2011-08-19 Thread Robert Haas
On Fri, Aug 19, 2011 at 9:59 AM, Tom Lane t...@sss.pgh.pa.us wrote: Kohei KaiGai kai...@kaigai.gr.jp writes: 2011/8/18 Robert Haas robertmh...@gmail.com: Actually, as I look at this more, I think this build system is completely mis-designed.  Given that you want to build sepgsql, selinux is

Re: [HACKERS] the big picture for index-only scans

2011-08-19 Thread Robert Haas
On Fri, Aug 19, 2011 at 9:19 AM, Gokulakannan Somasundaram gokul...@gmail.com wrote: The fact that the proposal is for crash safe visibility map, to become a default package of any Postgresql table will definitely have wide ranging implications on OLTP performance. Well, that would certainly

Re: [HACKERS] [v9.1] sepgsql - userspace access vector cache

2011-08-19 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Fri, Aug 19, 2011 at 9:59 AM, Tom Lane t...@sss.pgh.pa.us wrote: This patch seems unnecessary to me. Hmm. I see now that it's parallel, but I find it pretty confusing that building sepgsql without specifying --with-selinux results in a shared

Re: [HACKERS] [v9.1] sepgsql - userspace access vector cache

2011-08-19 Thread Robert Haas
On Fri, Aug 19, 2011 at 10:20 AM, Tom Lane t...@sss.pgh.pa.us wrote: Why not just: SHLIB_LINK = -lselinux I wouldn't have any particular objection to that (although I think it's supposed to be += here). Oh, right. I don't see that any of the other changes Kaigai proposed are helpful,

Re: [HACKERS] [v9.1] sepgsql - userspace access vector cache

2011-08-19 Thread Robert Haas
On Fri, Aug 19, 2011 at 10:31 AM, Robert Haas robertmh...@gmail.com wrote: On Fri, Aug 19, 2011 at 10:20 AM, Tom Lane t...@sss.pgh.pa.us wrote: Why not just: SHLIB_LINK = -lselinux I wouldn't have any particular objection to that (although I think it's supposed to be += here). Oh, right.

[HACKERS] How to define global variable in postgresql

2011-08-19 Thread EazonGuo
Hello. How can we define a global variable in postgresql? -- Best regards Eazon

Re: [HACKERS] How to define global variable in postgresql

2011-08-19 Thread Christopher Browne
On Fri, Aug 19, 2011 at 10:58 AM, EazonGuo eazon...@gmail.com wrote: Hello. How can we define a global variable in postgresql? I believe CREATE TABLE is the usual mechanism to do this sort of thing. -- When confronted by a difficult problem, solve it by reducing it to the question, How would

Re: [HACKERS] the big picture for index-only scans

2011-08-19 Thread Bruce Momjian
Robert Haas wrote: I am happy to have pg_upgrade skip upgrading visibility map files --- it already has code to conditionally process them because they only exist in = 8.4: ? ? ? ?/* fsm/vm files added in PG 8.4 */ ? ? ? ?if (GET_MAJOR_VERSION(old_cluster.major_version) = 804) ? ? ?

Re: [HACKERS] the big picture for index-only scans

2011-08-19 Thread Robert Haas
On Fri, Aug 19, 2011 at 11:22 AM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: I am happy to have pg_upgrade skip upgrading visibility map files --- it already has code to conditionally process them because they only exist in = 8.4: ? ? ? ?/* fsm/vm files added in PG 8.4 */

Re: [HACKERS] [v9.1] sepgsql - userspace access vector cache

2011-08-19 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On further review, if the initial configure was done without --with-libxml, xml2 is doomed anyway. True, but it's still possible to build a shlib that will then not work. I just did, after manually supplying the right -I switch: make

Re: [HACKERS] [v9.1] sepgsql - userspace access vector cache

2011-08-19 Thread Kohei Kaigai
-Original Message- From: Robert Haas [mailto:robertmh...@gmail.com] Sent: 19. August 2011 15:55 To: Tom Lane Cc: Kohei KaiGai; Kohei Kaigai; Yeb Havinga; PgHacker Subject: Re: [HACKERS] [v9.1] sepgsql - userspace access vector cache On Fri, Aug 19, 2011 at 10:31 AM, Robert Haas

Re: [HACKERS] [v9.1] sepgsql - userspace access vector cache

2011-08-19 Thread Robert Haas
On Fri, Aug 19, 2011 at 11:26 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On further review, if the initial configure was done without --with-libxml, xml2 is doomed anyway. True, but it's still possible to build a shlib that will then not work. I just

Re: [HACKERS] [v9.1] sepgsql - userspace access vector cache

2011-08-19 Thread Tom Lane
Kohei Kaigai kohei.kai...@emea.nec.com writes: One point I'm worrying about is a case when contrib/sepgsql is compiled with older libselinux than minimum requirement. In this case, we may not notice the broken module unless user tries to load it actually. Is there a good idea to ensure compile

Re: [HACKERS] [v9.1] sepgsql - userspace access vector cache

2011-08-19 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Fri, Aug 19, 2011 at 11:26 AM, Tom Lane t...@sss.pgh.pa.us wrote: No objection to fixing or backpatching this, but I'm not seeing the argument for treating this module differently from contrib/xml2. Because I screwed it up accidentally for sepgsql,

Re: [HACKERS] [v9.1] sepgsql - userspace access vector cache

2011-08-19 Thread Kohei Kaigai
-Original Message- From: Tom Lane [mailto:t...@sss.pgh.pa.us] Sent: 19. August 2011 16:34 To: Kohei Kaigai Cc: Robert Haas; Kohei KaiGai; Yeb Havinga; PgHacker Subject: Re: [HACKERS] [v9.1] sepgsql - userspace access vector cache Kohei Kaigai kohei.kai...@emea.nec.com writes:

Re: [HACKERS] [v9.1] sepgsql - userspace access vector cache

2011-08-19 Thread Tom Lane
Kohei Kaigai kohei.kai...@emea.nec.com writes: From: Tom Lane [mailto:t...@sss.pgh.pa.us] Well, they should get at least a warning from referencing undefined functions, no? Yes. User should notice warning messages due to undefined symbols. I'm not certain whether it makes sense to add

Re: [HACKERS] [v9.1] sepgsql - userspace access vector cache

2011-08-19 Thread Robert Haas
On Fri, Aug 19, 2011 at 11:46 AM, Tom Lane t...@sss.pgh.pa.us wrote: Kohei Kaigai kohei.kai...@emea.nec.com writes: From: Tom Lane [mailto:t...@sss.pgh.pa.us] Well, they should get at least a warning from referencing undefined functions, no? Yes. User should notice warning messages due to

Re: [HACKERS] [v9.1] sepgsql - userspace access vector cache

2011-08-19 Thread Robert Haas
On Fri, Aug 19, 2011 at 11:40 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Fri, Aug 19, 2011 at 11:26 AM, Tom Lane t...@sss.pgh.pa.us wrote: No objection to fixing or backpatching this, but I'm not seeing the argument for treating this module differently

Re: [HACKERS] How to define global variable in postgresql

2011-08-19 Thread Florian Weimer
Hello. How can we define a global variable in postgresql? Do you mean session-private, but persistent across transactions? Configuration parameters can be abused for this purpose. -- Florian Weimerfwei...@bfk.de BFK edv-consulting GmbH http://www.bfk.de/ Kriegsstraße 100

Re: [HACKERS] Transient plans versus the SPI API

2011-08-19 Thread Tom Lane
[ getting back to the planner finally ] Simon Riggs si...@2ndquadrant.com writes: On Wed, Aug 3, 2011 at 8:33 PM, Tom Lane t...@sss.pgh.pa.us wrote: Simon Riggs si...@2ndquadrant.com writes: I think its possible to tell automatically whether we need to replan always or not based upon the path

Re: [HACKERS] New copyright program

2011-08-19 Thread Bruce Momjian
David Fetter wrote: Folks, I noticed that src/tools/copyright looks like it can only be run on Bruce's machine, so this translation to Perl is intended: 1. To make the script idempotent, which allows its safe use in automated tools that might run it many times. 2. To get the script

Re: [HACKERS] the big picture for index-only scans

2011-08-19 Thread Gokulakannan Somasundaram
Well, that would certainly be alarming if true, but I don't think it is. As far as I can see, the overhead of making the visibility map crash-safe is just (1) a very small percentage increase in the work being done by VACUUM and (2) a slight possibility of extra work done by a foreground

Re: [HACKERS] the big picture for index-only scans

2011-08-19 Thread Gokulakannan Somasundaram
Well, that would certainly be alarming if true, but I don't think it is. As far as I can see, the overhead of making the visibility map crash-safe is just (1) a very small percentage increase in the work being done by VACUUM and (2) a slight possibility of extra work done by a foreground

[HACKERS] Rethinking sinval callback hook API

2011-08-19 Thread Tom Lane
Currently, we have two types of callbacks that can be registered to get control when an invalidation message is received: syscache callbacks and relcache callbacks. It strikes me that we might be better advised to unify these into a single type of callback that gets a SharedInvalidationMessage

[HACKERS] two index bitmap scan of a big table hash_seq_search

2011-08-19 Thread Sergey E. Koposov
Hello Hackers, I've recently noticed a particularly strange behaviour of one of my simple queries: SELECT ra,dec FROM sdssdr7.photoobjall WHERE ra BETWEEN 175 and 190 AND dec BETWEEN 17 And 23 ; The table is quite large (1.1Tb, 10^9 rows, and has Btree indexes on ra,dec columns). The plan

Re: [HACKERS] the big picture for index-only scans

2011-08-19 Thread Heikki Linnakangas
On 19.08.2011 21:06, Gokulakannan Somasundaram wrote: If you are following the same design that Heikki put forward, then there is a problem with it in maintaining the bits in page and the bits in visibility map in sync, which we have already discussed. Are you referring to this:

Re: [HACKERS] the big picture for index-only scans

2011-08-19 Thread Gokulakannan Somasundaram
On Sat, Aug 20, 2011 at 2:25 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: On 19.08.2011 21:06, Gokulakannan Somasundaram wrote: If you are following the same design that Heikki put forward, then there is a problem with it in maintaining the bits in page and the bits in

Re: [HACKERS] the big picture for index-only scans

2011-08-19 Thread Gokulakannan Somasundaram
On Sat, Aug 20, 2011 at 2:51 AM, Gokulakannan Somasundaram gokul...@gmail.com wrote: On Sat, Aug 20, 2011 at 2:25 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: On 19.08.2011 21:06, Gokulakannan Somasundaram wrote: If you are following the same design that Heikki put

Re: [HACKERS] FATAL: ReleaseSavepoint: unexpected state STARTED

2011-08-19 Thread Robert Haas
On Thu, Aug 18, 2011 at 3:57 AM, Marcin Mańk marcin.m...@gmail.com wrote: On Wed, Aug 17, 2011 at 11:30 PM, Tom Lane t...@sss.pgh.pa.us wrote: =?UTF-8?B?TWFyY2luIE1hxYRr?= marcin.m...@gmail.com writes:  psql -c 'release q; prepare q(int) as select 1' FATAL:  ReleaseSavepoint: unexpected state

Re: [HACKERS] FATAL: ReleaseSavepoint: unexpected state STARTED

2011-08-19 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: I spent some time looking at this afternoon and it appears that the root of this problem is that we're a bit schizophrenic about whether a multi-query command string constitutes a transaction or not. Yeah. The current behavior sort of automatically

Re: [HACKERS] the big picture for index-only scans

2011-08-19 Thread Robert Haas
On Fri, Aug 19, 2011 at 2:51 PM, Gokulakannan Somasundaram gokul...@gmail.com wrote: On Sat, Aug 20, 2011 at 2:25 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: On 19.08.2011 21:06, Gokulakannan Somasundaram wrote: If you are following the same design that Heikki put

Re: [HACKERS] FATAL: ReleaseSavepoint: unexpected state STARTED

2011-08-19 Thread Robert Haas
On Fri, Aug 19, 2011 at 3:31 PM, Tom Lane t...@sss.pgh.pa.us wrote: As for ROLLBACK, I think it should chuck an error instead of doing this funny emit-a-warning-and-silently-arrange-for-the-transaction-to-be-aborted-later thing. I'm pretty unexcited about changing the behavior of

Re: [HACKERS] the big picture for index-only scans

2011-08-19 Thread Robert Haas
On Fri, Aug 19, 2011 at 4:02 PM, Robert Haas robertmh...@gmail.com wrote: Hmm, you have a point.  If 100 backends simultaneously write to 100 different pages, and all of those pages are all-visible, then it's possible that they could end up fighting over the buffer content lock on the

Re: [HACKERS] New copyright program

2011-08-19 Thread Kris Jurka
On 8/19/2011 10:51 AM, Bruce Momjian wrote: David Fetter wrote: [Here's a new copyright program.] Thanks. Applied to HEAD. I never liked putting scripts in git that only I could run, but I thought if something happened to me, it would be good to record what I did. The Perl solution is

Re: [HACKERS] How to define global variable in postgresql

2011-08-19 Thread Valentine Gogichashvili
Hello. How can we define a global variable in postgresql? you can also use global structure in plpython for example: http://www.postgresql.org/docs/9.0/static/plpython-sharing.html

Re: [HACKERS] Transient plans versus the SPI API

2011-08-19 Thread Simon Riggs
On Fri, Aug 19, 2011 at 6:13 PM, Tom Lane t...@sss.pgh.pa.us wrote: [ getting back to the planner finally ] Simon Riggs si...@2ndquadrant.com writes: On Wed, Aug 3, 2011 at 8:33 PM, Tom Lane t...@sss.pgh.pa.us wrote: Simon Riggs si...@2ndquadrant.com writes: I think its possible to tell

Re: [HACKERS] New copyright program

2011-08-19 Thread Kris Jurka
On Fri, 19 Aug 2011, Kris Jurka wrote: For me this fails with: Bareword Tie::File not allowed while strict subs in use at /home/jurka/pg/server/postgresql/src/tools/copyright.pl line 28. This fixes things for me. The copyright matching wasn't working for me either without escaping

Re: [HACKERS] New copyright program

2011-08-19 Thread David Fetter
On Fri, Aug 19, 2011 at 05:34:01PM -0400, Kris Jurka wrote: On Fri, 19 Aug 2011, Kris Jurka wrote: For me this fails with: Bareword Tie::File not allowed while strict subs in use at /home/jurka/pg/server/postgresql/src/tools/copyright.pl line 28. This fixes things for me. The

Re: [HACKERS] New copyright program

2011-08-19 Thread Bruce Momjian
Kris Jurka wrote: On Fri, 19 Aug 2011, Kris Jurka wrote: For me this fails with: Bareword Tie::File not allowed while strict subs in use at /home/jurka/pg/server/postgresql/src/tools/copyright.pl line 28. This fixes things for me. The copyright matching wasn't working for

Re: [HACKERS] New copyright program

2011-08-19 Thread Kris Jurka
On Fri, 19 Aug 2011, Bruce Momjian wrote: Was able to reproduce the error you reported with Perl 5.10. I then tried the single-quote idea I got from Googling, but then got an error about TIEARRAY being missing, so I recoded it as a simple file open/close. I also incorported your regex

Re: [HACKERS] New copyright program

2011-08-19 Thread Bruce Momjian
Kris Jurka wrote: On Fri, 19 Aug 2011, Bruce Momjian wrote: Was able to reproduce the error you reported with Perl 5.10. I then tried the single-quote idea I got from Googling, but then got an error about TIEARRAY being missing, so I recoded it as a simple file open/close. I also

Re: [HACKERS] New copyright program

2011-08-19 Thread Andrew Dunstan
On 08/19/2011 07:31 PM, Bruce Momjian wrote: Kris Jurka wrote: Did you also try the use Tie::File addition in my fix because your current coding doesn't work at all. The tie operation is key to actually writing out the modified copyright notice. Your version just updates the copyright year

Re: [HACKERS] New copyright program

2011-08-19 Thread Bruce Momjian
Andrew Dunstan wrote: On 08/19/2011 07:31 PM, Bruce Momjian wrote: Kris Jurka wrote: Did you also try the use Tie::File addition in my fix because your current coding doesn't work at all. The tie operation is key to actually writing out the modified copyright notice. Your version

Re: [HACKERS] New copyright program

2011-08-19 Thread Kris Jurka
On Fri, 19 Aug 2011, Bruce Momjian wrote: Andrew Dunstan wrote: It probably doesn't matter that much in this context, but I should point out that Tie::File is not universally available. Some years ago I had to revert its use in the buildfarm code for that reason. In general we

Re: [HACKERS] New copyright program

2011-08-19 Thread David Fetter
On Fri, Aug 19, 2011 at 07:37:29PM -0400, Andrew Dunstan wrote: On 08/19/2011 07:31 PM, Bruce Momjian wrote: Kris Jurka wrote: Did you also try the use Tie::File addition in my fix because your current coding doesn't work at all. The tie operation is key to actually writing out the

Re: [HACKERS] New copyright program

2011-08-19 Thread Andrew Dunstan
On 08/19/2011 09:02 PM, David Fetter wrote: On Fri, Aug 19, 2011 at 07:37:29PM -0400, Andrew Dunstan wrote: On 08/19/2011 07:31 PM, Bruce Momjian wrote: Kris Jurka wrote: Did you also try the use Tie::File addition in my fix because your current coding doesn't work at all. The tie

Re: [HACKERS] New copyright program

2011-08-19 Thread David Fetter
On Fri, Aug 19, 2011 at 09:22:03PM -0400, Andrew Dunstan wrote: On 08/19/2011 09:02 PM, David Fetter wrote: On Fri, Aug 19, 2011 at 07:37:29PM -0400, Andrew Dunstan wrote: On 08/19/2011 07:31 PM, Bruce Momjian wrote: Kris Jurka wrote: Did you also try the use Tie::File addition in my fix

Re: [HACKERS] New copyright program

2011-08-19 Thread Bruce Momjian
David Fetter wrote: On Fri, Aug 19, 2011 at 09:22:03PM -0400, Andrew Dunstan wrote: On 08/19/2011 09:02 PM, David Fetter wrote: On Fri, Aug 19, 2011 at 07:37:29PM -0400, Andrew Dunstan wrote: On 08/19/2011 07:31 PM, Bruce Momjian wrote: Kris Jurka wrote: Did you also try the use

Re: [HACKERS] New copyright program

2011-08-19 Thread Andrew Dunstan
On 08/19/2011 09:39 PM, David Fetter wrote: Tie::File ships as part of core Perl for all non-EOL versions, so I really can't consider this as a problem. Which are those? 5.12 and 5.14 are still supported. 5.10 and earlier are EOL. http://news.perlfoundation.org/2011/05/perl-514.html

Re: [HACKERS] New copyright program

2011-08-19 Thread David Fetter
On Fri, Aug 19, 2011 at 09:49:35PM -0400, Bruce Momjian wrote: David Fetter wrote: On Fri, Aug 19, 2011 at 09:22:03PM -0400, Andrew Dunstan wrote: On 08/19/2011 09:02 PM, David Fetter wrote: On Fri, Aug 19, 2011 at 07:37:29PM -0400, Andrew Dunstan wrote: On 08/19/2011 07:31 PM,

Re: [HACKERS] two index bitmap scan of a big table hash_seq_search

2011-08-19 Thread Tom Lane
Sergey E. Koposov m...@sai.msu.ru writes: But the funny thing I noticed is that the query after running a certain amount of time doing I/O, starts to use 100%CPU and spend 99% the time in hash_seq_search. Here is the oprofile of PG during that period: CPU: Intel Core/i7, speed

Re: [HACKERS] the big picture for index-only scans

2011-08-19 Thread Heikki Linnakangas
On 19.08.2011 23:02, Robert Haas wrote: On Fri, Aug 19, 2011 at 2:51 PM, Gokulakannan Somasundaram gokul...@gmail.com wrote: won't it make the 99 sessions wait for that visibility map while holding the exclusive lock on the 99 heap pages? Hmm, you have a point. If 100 backends

Re: [HACKERS] the big picture for index-only scans

2011-08-19 Thread Heikki Linnakangas
On 19.08.2011 23:17, Robert Haas wrote: On Fri, Aug 19, 2011 at 4:02 PM, Robert Haasrobertmh...@gmail.com wrote: Hmm, you have a point. If 100 backends simultaneously write to 100 different pages, and all of those pages are all-visible, then it's possible that they could end up fighting over