Re: [HACKERS] Bugs in superuser_reserved_connections and max_wal_senders vs max_connections

2012-08-10 Thread Magnus Hagander
On Thu, Aug 9, 2012 at 4:17 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: The check in PostmasterMain(): if (ReservedBackends = MaxBackends) { write_stderr(%s: superuser_reserved_connections must be less than max_connections\n,

Re: [HACKERS] Prevent restored WAL files from being archived again Re: Unnecessary WAL archiving after failover

2012-08-10 Thread Fujii Masao
On Thu, Aug 9, 2012 at 11:24 PM, Simon Riggs si...@2ndquadrant.com wrote: On 9 August 2012 00:08, Simon Riggs si...@2ndquadrant.com wrote: Will look at the refactored version tomorrow. Rather than implement the minimal patch onto HEAD, I've written a refactored patch. [attached] This fixes

[HACKERS] error handling in logging hooks

2012-08-10 Thread Peter Eisentraut
What is the intended way to handle errors in the new logging hook? For example, errors in establishing a connection to wherever a hook wants to send things. The reference implementation pg_logforward just uses fprintf(stderr) to communicate its own errors, which doesn't seem ideal. Calling

Re: [HACKERS] bug of pg_trgm?

2012-08-10 Thread Fujii Masao
On Thu, Aug 9, 2012 at 2:28 AM, Tom Lane t...@sss.pgh.pa.us wrote: Fujii Masao masao.fu...@gmail.com writes: When I used pg_trgm, I encountered the problem that the search result of SeqScan was the different from that of BitmapScan even if the search keyword was the same. Is this a bug?

Re: [HACKERS] WIP patch for consolidating misplaced-aggregate checks

2012-08-10 Thread Greg Stark
On Thu, Aug 9, 2012 at 5:40 PM, Tom Lane t...@sss.pgh.pa.us wrote: Fair enough. I was not sold on doing that either. I would still like to know if it's okay to use one string with %s for the cases where there's not a good reason for the context to be more than just a SQL keyword. Given that

Re: [HACKERS] bug of pg_trgm?

2012-08-10 Thread Fujii Masao
On Thu, Aug 9, 2012 at 3:05 AM, Tom Lane t...@sss.pgh.pa.us wrote: ... btw, I think there is another problem here, which is that generate_wildcard_trgm will restart get_wildcard_part at the same place that the second loop exits, which means it would do the wrong thing if what it returns is a

Re: [HACKERS] Prevent restored WAL files from being archived again Re: Unnecessary WAL archiving after failover

2012-08-10 Thread Fujii Masao
On Thu, Aug 9, 2012 at 8:08 AM, Simon Riggs si...@2ndquadrant.com wrote: On 29 July 2012 16:01, Fujii Masao masao.fu...@gmail.com wrote: Attached patch changes the startup process so that it creates .done file whenever WAL file is successfully restored, whether archive mode is enabled or not.

[HACKERS] Out of office

2012-08-10 Thread armin . schoeffmann
Dear sender, I'm away from the office till 19th of August. In the meantime, please contact my colleague Alfred Vater at alfred.va...@aegaeon.de - Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

[HACKERS] Out of office

2012-08-10 Thread armin . schoeffmann
Dear sender, I'm away from the office till 19th of August. In the meantime, please contact my colleague Alfred Vater at alfred.va...@aegaeon.de - Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Ability to listen on two unix sockets

2012-08-10 Thread Tom Lane
Honza Horak hho...@redhat.com writes: Alternate-port-number support has been removed from the patch, as per Tom's e-mail from 07/03/12. It can be add in the future, if we really need it. I've reviewed and committed this. There were some cosmetic things I adjusted, as well as a couple of

Re: [HACKERS] -Wformat-zero-length

2012-08-10 Thread Peter Eisentraut
On 8/8/12 5:29 PM, Alvaro Herrera wrote: I think those 14 is a bit of a made-up number. Several of those steps are about building pg_upgrade, not actually using it. And there are some that are optional anyway. Compare the pg_upgrade instructions

[HACKERS] macports and brew postgresql --universal builds

2012-08-10 Thread Doug Coleman
The MacPorts Project (http://www.macports.org/) supports building universal binaries (32/64bit binaries in one file) for most projects. For PostgreSQL, they apply two patches after the configure script to correct some of the typedefs. Otherwise, the build fails in compiling a switch statement with

Re: [HACKERS] macports and brew postgresql --universal builds

2012-08-10 Thread Tom Lane
Doug Coleman doug.cole...@gmail.com writes: The MacPorts Project (http://www.macports.org/) supports building universal binaries (32/64bit binaries in one file) for most projects. For PostgreSQL, they apply two patches after the configure script to correct some of the typedefs. Otherwise, the

Re: [HACKERS] Mailsystem maintenance/migration announcement

2012-08-10 Thread Alvaro Herrera
Excerpts from Stefan Kaltenbrunner's message of lun ago 06 13:21:49 -0400 2012: We are currently planning to finalize the ongoing work on the mailsystem migration we started earlier this year by migrating the two remaining components of the postgresql.org mailsystem infrastructure to new

Re: [HACKERS] macports and brew postgresql --universal builds

2012-08-10 Thread Daniel Farina
On Fri, Aug 10, 2012 at 3:44 PM, Tom Lane t...@sss.pgh.pa.us wrote: The files you link to don't make much sense to me (they do not look like patch diffs) but they seem to suggest hard-wiring configure results into the source code, which does not sound like an acceptable solution from our

Re: [HACKERS] macports and brew postgresql --universal builds

2012-08-10 Thread Doug Coleman
What it looks like is the first line of each section is pattern matching. If __LP64__ is defined, then it's a 64-bit architecture, and we want to use the top part of the if statement. The #defines they target seem to be all of the ones that are different on 32bit platforms. I agree that you

Re: [HACKERS] bug of pg_trgm?

2012-08-10 Thread Tom Lane
Fujii Masao masao.fu...@gmail.com writes: On Thu, Aug 9, 2012 at 2:28 AM, Tom Lane t...@sss.pgh.pa.us wrote: I'm also inclined to think that we should remove *both* flag resets before the second loop. The logic here is that we are reprocessing the same character seen in the last iteration of

Re: [HACKERS] 16-bit page checksums for 9.2

2012-08-10 Thread Jeff Davis
On Sun, 2012-02-19 at 21:49 +, Simon Riggs wrote: On Thu, Feb 16, 2012 at 11:16 AM, Simon Riggs si...@2ndquadrant.com wrote: v8 attached v10 attached. This patch covers all the valid concerns discussed and has been extensively tested. Is there something I can do to help get this

Re: [HACKERS] bug of pg_trgm?

2012-08-10 Thread Tom Lane
Fujii Masao masao.fu...@gmail.com writes: On Thu, Aug 9, 2012 at 3:05 AM, Tom Lane t...@sss.pgh.pa.us wrote: Probably a minimal fix for this could be made by backing up endword one byte before returning it if in_escape is true when the second loop exits. That would not scale up to preserving

Re: [HACKERS] -Wformat-zero-length

2012-08-10 Thread Dimitri Fontaine
Another thing worth considering is to have pg_upgrade init, stop and start clusters as necessary instead of requesting the user to do it. I think this is two less steps. Then you'd need to expose the entire pg_ctl shutdown mode logic through pg_upgrade, which might not make things

Re: [HACKERS] -Wformat-zero-length

2012-08-10 Thread Bruce Momjian
On Sat, Aug 11, 2012 at 01:48:13AM +0200, Dimitri Fontaine wrote: Another thing worth considering is to have pg_upgrade init, stop and start clusters as necessary instead of requesting the user to do it. I think this is two less steps. Then you'd need to expose the entire pg_ctl

Re: [HACKERS] macports and brew postgresql --universal builds

2012-08-10 Thread Andrew Dunstan
On 08/10/2012 06:44 PM, Tom Lane wrote: Doug Coleman doug.cole...@gmail.com writes: The MacPorts Project (http://www.macports.org/) supports building universal binaries (32/64bit binaries in one file) for most projects. For PostgreSQL, they apply two patches after the configure script to