On Wed, Nov 21, 2012 at 4:34 PM, Andres Freund wrote:
> On 2012-11-21 14:57:08 +0900, Michael Paquier wrote:
>
> Ah, I see. Could you try the following diff?
>
> diff --git a/src/backend/replication/logical/snapbuild.c
> b/src/backend/replication/logical/snapbuild.c
> index df24b33..797a126 100644
2012/11/21 Shigeru Hanada :
> Thank for the comment!
>
> On Tue, Nov 20, 2012 at 10:23 PM, Kohei KaiGai wrote:
>>
>> I also think the new "use_remote_explain" option is good. It works fine
>> when we try to use this fdw over the network with latency more or less.
>> It seems to me its default is "
2012-11-20 20:32 keltezéssel, Boszormenyi Zoltan írta:
2012-11-20 17:03 keltezéssel, Boszormenyi Zoltan írta:
2012-11-18 17:20 keltezéssel, Magnus Hagander írta:
Much of the tar stuff is very similar (I haven't looked to see if it's
identical) to the stuff in backend/replication/basebackup.c.
Hi Josh,
On 11/20/2012 11:53:23 PM, Josh Kupershmidt wrote:
> Hi Karl,
> I signed on to review this patch for the current CF.
I noticed. Thanks very much.
> On Fri, Sep 21, 2012 at 8:54 AM, Karl O. Pinc wrote:
> > On 09/20/2012 12:24:49 PM, Karl O. Pinc wrote:
> > First, the problem:
> >
> >
On 2012-11-20 22:55:52 -0500, Tom Lane wrote:
> Abhijit Menon-Sen writes:
> >> While I'm thinking about it, why are the fields of a binaryheap_node
> >> called "key" and "value"? That implies a semantics not actually used
> >> here. Maybe "value1" and "value2" instead?
>
> > Yes, I discussed thi
Hi All ,
When am trying to query a table temp_table1(sms_type varchar(20),sms_info
varchar(100),sms_id integer)
Query :: select sms_type,count(*) from temp_table1 group by 1 order by 2
desc;
Then i got following errors , i dont know whats wrong in this .
*ERROR: volatile EquivalenceClass has no s
Boszormenyi Zoltan wrote:
> The problem is that it calls pg_malloc() which is an executable-specific
> function. Some of the bin/* executables define it as calling exit(1)
> when malloc() returns NULL, some call it with exit(EXIT_FAILURE)
> which happens to be 1 but still can be different from the
2012-11-21 14:19 keltezéssel, Alvaro Herrera írta:
Boszormenyi Zoltan wrote:
The problem is that it calls pg_malloc() which is an executable-specific
function. Some of the bin/* executables define it as calling exit(1)
when malloc() returns NULL, some call it with exit(EXIT_FAILURE)
which happe
On 20.11.2012 21:44, Tom Lane wrote:
init_var_from_num's header comment could use some more work. The
statement that one "must not modify the returned var" is false in some
sense, since for instance numeric_ceil() does that. The key is that you
have to replace the digit buffer not modify it in-
Boszormenyi Zoltan wrote:
> 2012-11-21 14:19 keltezéssel, Alvaro Herrera írta:
> >Boszormenyi Zoltan wrote:
> >
> >>The problem is that it calls pg_malloc() which is an executable-specific
> >>function. Some of the bin/* executables define it as calling exit(1)
> >>when malloc() returns NULL, some
Boszormenyi Zoltan writes:
> pg_basebackup needs pg_malloc() to call disconnect_and_exit(1)
> instead to quit cleanly and not leave an "unexpected EOF from client"
> message in the server log. Which is a macro at the moment, but
> has to be turned into a real function for the reasons below.
man 2
2012-11-21 15:29 keltezéssel, Tom Lane írta:
Boszormenyi Zoltan writes:
pg_basebackup needs pg_malloc() to call disconnect_and_exit(1)
instead to quit cleanly and not leave an "unexpected EOF from client"
message in the server log. Which is a macro at the moment, but
has to be turned into a rea
On Mon, Nov 19, 2012 at 6:19 PM, Peter Eisentraut wrote:
> On Tue, 2012-11-06 at 10:57 -0500, Robert Haas wrote:
>> But, with the attached patch:
>>
>> rhaas=# create function xyz(smallint) returns smallint as $$select
>> $1$$ language sql;
>> CREATE FUNCTION
>> rhaas=# select xyz(5);
>> xyz
>> -
On Wed, Nov 21, 2012 at 6:08 AM, Andres Freund wrote:
> On 2012-11-20 22:55:52 -0500, Tom Lane wrote:
>> Abhijit Menon-Sen writes:
>> >> While I'm thinking about it, why are the fields of a binaryheap_node
>> >> called "key" and "value"? That implies a semantics not actually used
>> >> here. Ma
Hi,
Przemek Lisowski writes:
> HOW LOAD DLL AND USE MY EXTERNAL
> FUNCTION ?
You need to declare it in SQL, maybe like this:
create function public.transform(text) returns text
as '$libdir/fservice', 'transform' language C;
See also the LOAD command and the CREATE EXTENSION documentation
On 29 August 2012 23:39, Tom Lane wrote:
> The main downside I can see is that code that used to work is likely
> to stop working as soon as someone creates a potential overloading
> situation. Worse, the error message could be pretty confusing, since
> if you had been successfully calling f(sma
Given we're calling to_lower() on a single byte in the code referred
to, should we even be doing that when we have a multi-byte encoding
and the high bit is set?
Nobody responded to this, but I'm rather inclined to say we should not.
Here's a simple patch to avoid this case.
Comments?
Simon Riggs writes:
> It would be useful if we issued a NOTICE when an ambiguity is
> introduced, rather than when using it.
I think that's pie in the sky, since whether there is an ambiguity
will depend not only on what set of functions exists, but what the
caller's search_path is.
Andrew Dunstan writes:
> Here's a simple patch to avoid this case.
> Comments?
I'm not sure that's the only place we're doing this ...
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://w
On 11/21/2012 11:11 AM, Tom Lane wrote:
Andrew Dunstan writes:
Here's a simple patch to avoid this case.
Comments?
I'm not sure that's the only place we're doing this ...
Oh, Hmm, darn. Where else do you think we might?
cheers
andrew
--
Sent via pgsql-hackers
After upgrading a pretty big database (serveral hundred gig) from 8.2 to 9.2
I'm getting some "PANIC: could not write to log file" messages. Actually I got
two of them. One yesterday and one today.
* postgres 9.2.1 is running on a windows 2003 server (downloaded the zip
archive binaries
Andrew Dunstan writes:
> On 11/21/2012 11:11 AM, Tom Lane wrote:
>> I'm not sure that's the only place we're doing this ...
> Oh, Hmm, darn. Where else do you think we might?
Dunno, but grepping for isupper and/or tolower should find any such
places.
regards, tom lane
On Wed, Nov 21, 2012 at 8:51 AM, Cyril VELTER wrote:
>
>After upgrading a pretty big database (serveral hundred gig) from 8.2 to
> 9.2 I'm getting some "PANIC: could not write to log file" messages. Actually
> I got two of them. One yesterday and one today.
How was the upgrade done?
Cheer
On Wed, Nov 21, 2012 at 9:46 AM, Robert Haas wrote:
> I guess I'll take another whack at it.
New version attached.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
binaryheap-rmh2.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list
On Sun, Nov 18, 2012 at 5:49 PM, Tomas Vondra wrote:
> The two main changes are these:
>
> (1) The stats file is split into a common "db" file, containing all the
> DB Entries, and per-database files with tables/functions. The common
> file is still called "pgstat.stat", the per-db files h
On 2012-11-21 12:54:30 -0500, Robert Haas wrote:
> On Wed, Nov 21, 2012 at 9:46 AM, Robert Haas wrote:
> > I guess I'll take another whack at it.
>
> New version attached.
I think the assert in replace_first should be
Assert(!binaryheap_empty(heap) && heap->has_heap_property);
instead of
Assert(
On 20.11.2012 15:33, Amit Kapila wrote:
Defect-2:
1. start primary A
2. start standby B following A
3. start cascade standby C following B.
4. Start another standby D following C.
5. Execute the following commands in the primary A.
create table tbl(f int);
I'm breaking this out into it's own thread, for my own sanity if
nothing else :) And it's an isolated feature after all.
I still agree with the previous review at
http://archives.postgresql.org/message-id/1349321071.23971.0.ca...@vanquo.pezone.net
about keeping the data in more than one place.
Ba
Robert Haas escribió:
> On Wed, Nov 21, 2012 at 9:46 AM, Robert Haas wrote:
> > I guess I'll take another whack at it.
>
> New version attached.
The following comments still talk about "key and value", thus need
an update:
+ * binaryheap_add_unordered
+ *
+ * Adds the given key and value to the
On 21/11/12 18:10:12, mailto:jeff.ja...@gmail.com wrote:
> On Wed, Nov 21, 2012 at 8:51 AM, Cyril VELTER
> wrote:
> >
> >After upgrading a pretty big database (serveral hundred gig) from 8.2 to
> > 9.2 I'm getting some "PANIC: could not write to log file" messages.
> > Actually I
> > got t
On 11/15/12 3:53 PM, Karl O. Pinc wrote:
> This patch gives the end user control over psql's
> error stream. This allows a single psql session
> to use \o to send both errors and table output
> to multiple files. Useful when capturing test output, etc.
What does this do that cannot in practice b
On Thu, Nov 15, 2012 at 1:46 PM, Peter Eisentraut wrote:
> On 11/15/12 9:40 AM, Tom Lane wrote:
>> Peter Eisentraut writes:
>>> I think it might be worth adding -Wlogical-op to the standard warning
>>> options (for supported compilers, determined by configure test).
>>
>> Does that add any new wa
On Wed, Nov 21, 2012 at 1:30 PM, Alvaro Herrera
wrote:
> The following comments still talk about "key and value", thus need
> an update:
Oops.
> This comment needs updated (s/comparator/compare/, and also add
> has_heap_property and arg):
Fixed.
> I would suggest to add prefixes to struct memb
On Sat, Nov 17, 2012 at 1:22 AM, Peter Eisentraut wrote:
> On Mon, 2012-11-12 at 11:42 -0600, Karl O. Pinc wrote:
>> Could ALTER TABLE use an option to drop the
>> primary key constraint? I needed to do that,
>> found it was not obvious, and this lead me to
>> try to improve things.
>
> That coul
Here is a WIP patch for enhancements to json generation.
First, there is the much_requested json_agg, which will aggregate rows
directly to json. So the following will now work:
select json_agg(my_table) from mytable;
select json_agg(q) from () q;
One open question regarding this feat
On 2012-11-21 15:09:12 -0500, Robert Haas wrote:
> On Wed, Nov 21, 2012 at 1:30 PM, Alvaro Herrera
> wrote:
> > The following comments still talk about "key and value", thus need
> > an update:
>
> Oops.
>
> > This comment needs updated (s/comparator/compare/, and also add
> > has_heap_property an
On Sat, Nov 17, 2012 at 1:05 PM, Philip Taylor wrote:
> CREATE TABLE foo (
>x CHAR(32) PRIMARY KEY,
>y CHAR(32) NOT NULL,
>EXCLUDE USING gist ((ARRAY[x, y]) WITH &&)
> );
My first thought was you were going to have better luck with text
rather than char(n), but a little bit of experim
Hi,
2012-11-21 19:19 keltezéssel, Magnus Hagander írta:
I'm breaking this out into it's own thread, for my own sanity if
nothing else :) And it's an isolated feature after all.
I still agree with the previous review at
http://archives.postgresql.org/message-id/1349321071.23971.0.ca...@vanquo.pe
On Wed, Nov 21, 2012 at 10:01 PM, Boszormenyi Zoltan wrote:
> Hi,
>
> 2012-11-21 19:19 keltezéssel, Magnus Hagander írta:
>
>> I'm breaking this out into it's own thread, for my own sanity if
>> nothing else :) And it's an isolated feature after all.
>>
>> I still agree with the previous review at
On 11/16/12 9:03 AM, Merlin Moncure wrote:
Atri ran some quick n dirty tests to see if there
were any regressions. He benched a large scan followed by vacuum. So
far, results are inconclusive so better testing methodologies will
definitely be greatly appreciated. One of the challenges with wor
On Tue, Nov 20, 2012 at 4:50 PM, Jeff Janes wrote:
> On Tue, Nov 20, 2012 at 1:26 PM, Merlin Moncure wrote:
>> In this sprawling thread on scaling issues [1], the topic meandered
>> into StrategyGetBuffer() -- in particular the clock sweep loop. I'm
>> wondering:
>>
>> *) If there shouldn't be a
On 11/21/12 9:42 AM, Robert Haas wrote:
> On Mon, Nov 19, 2012 at 6:19 PM, Peter Eisentraut wrote:
>> On Tue, 2012-11-06 at 10:57 -0500, Robert Haas wrote:
>>> But, with the attached patch:
>>>
>>> rhaas=# create function xyz(smallint) returns smallint as $$select
>>> $1$$ language sql;
>>> CREATE
On Mon, 2012-11-19 at 14:46 -0500, Tom Lane wrote:
> Jeff Davis writes:
> > As I said elsewhere in the thread, I'm not planning to introduce any
> > additional locking. There is already precedent in IndexOnlyNext.
>
> Of course, that just begs the question of whether the code in
> IndexOnlyNext i
On Thu, Nov 15, 2012 at 11:16 AM, Robert Haas wrote:
>
> So what's next here? Do you want to work on these issue some more?
> Or does Jeff?
This has been rewritten enough that I no longer feel much ownership of it.
I'd prefer to leave it to Peter or Greg S., if they are willing to do it.
Cheer
On Thu, Nov 15, 2012 at 9:13 AM, Andres Freund wrote:
> On 2012-11-15 09:06:23 -0800, Jeff Janes wrote:
>> On Wed, Nov 14, 2012 at 5:17 PM, Andres Freund
>> wrote:
>> > ---
>> > src/bin/Makefile| 2 +-
>> > src/bin/xlogdump/Makefile | 25 +++
>> > src/bin/xlogdump/xlogdump.c |
On 2012-11-21 14:57:14 -0800, Jeff Janes wrote:
> On Thu, Nov 15, 2012 at 9:13 AM, Andres Freund wrote:
> > On 2012-11-15 09:06:23 -0800, Jeff Janes wrote:
> >> On Wed, Nov 14, 2012 at 5:17 PM, Andres Freund
> >> wrote:
> >> > ---
> >> > src/bin/Makefile| 2 +-
> >> > src/bin/xlog
On 11/8/12 2:16 PM, Josh Berkus wrote:
Also, logging only the long-running queries is less useful than people
on this list seem to think. When I'm doing real performance analysis, I
need to see *everything* which was run, not just the slow stuff. Often
the real problem is a query which used to
On 2012-11-21 18:35:34 +0900, Michael Paquier wrote:
> On Wed, Nov 21, 2012 at 4:34 PM, Andres Freund wrote:
>
> > On 2012-11-21 14:57:08 +0900, Michael Paquier wrote:
> >
> > Ah, I see. Could you try the following diff?
> >
> > diff --git a/src/backend/replication/logical/snapbuild.c
> > b/src/ba
On 22/11/12 12:15, Greg Smith wrote:
On 11/8/12 2:16 PM, Josh Berkus wrote:
Also, logging only the long-running queries is less useful than people
on this list seem to think. When I'm doing real performance analysis, I
need to see *everything* which was run, not just the slow stuff. Often
the
On Thu, Nov 22, 2012 at 8:25 AM, Andres Freund wrote:
> I really don't understand whats going on here then. Youve said you made
> sure that there is a catalog snapshot. Which means you would need
> something like:
> WARNING: connecting to postgres
> WARNING: Initiating logical rep
> LOG: comput
On 2012-11-22 09:13:30 +0900, Michael Paquier wrote:
> On Thu, Nov 22, 2012 at 8:25 AM, Andres Freund wrote:
>
> > I really don't understand whats going on here then. Youve said you made
> > sure that there is a catalog snapshot. Which means you would need
> > something like:
> > WARNING: connecti
past 11/15.
Regards,
Jeff Davis
rm-pd-all-visible-20121121.patch.gz
Description: GNU Zip compressed data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
At 2012-11-21 15:09:12 -0500, robertmh...@gmail.com wrote:
>
> > The following comments still talk about "key and value", thus need
> > an update:
>
> Oops.
In the same vein, "Returns NULL if the heap is empty" no longer applies
to binaryheap_first and binaryheap_remove_first. Plus there is an ex
On Thursday, November 22, 2012 3:26 AM Merlin Moncure wrote:
> On Tue, Nov 20, 2012 at 4:50 PM, Jeff Janes
> wrote:
> > On Tue, Nov 20, 2012 at 1:26 PM, Merlin Moncure
> wrote:
> >> In this sprawling thread on scaling issues [1], the topic meandered
> >> into StrategyGetBuffer() -- in particular
On 11/21/2012 01:41:56 PM, Peter Eisentraut wrote:
> On 11/15/12 3:53 PM, Karl O. Pinc wrote:
> > This patch gives the end user control over psql's
> > error stream. This allows a single psql session
> > to use \o to send both errors and table output
> > to multiple files. Useful when capturing t
On 11/21/2012 02:12:26 PM, Robert Haas wrote:
> On Sat, Nov 17, 2012 at 1:22 AM, Peter Eisentraut
> wrote:
> > On Mon, 2012-11-12 at 11:42 -0600, Karl O. Pinc wrote:
> >> Could ALTER TABLE use an option to drop the
> >> primary key constraint? I needed to do that,
> >> found it was not obvious, a
On 11/21/2012 03:16 PM, Andrew Dunstan wrote:
Here is a WIP patch for enhancements to json generation.
First, there is the much_requested json_agg, which will aggregate rows
directly to json. So the following will now work:
select json_agg(my_table) from mytable;
select json_agg(q) f
On 11/21/2012 01:41:56 PM, Peter Eisentraut wrote:
> On 11/15/12 3:53 PM, Karl O. Pinc wrote:
> > This patch gives the end user control over psql's
> > error stream. This allows a single psql session
> > to use \o to send both errors and table output
> > to multiple files. Useful when capturing t
On Wed, Nov 21, 2012 at 7:31 PM, Kohei KaiGai wrote:
> At execute_query(), it stores the retrieved rows onto tuplestore of
> festate->tuples at once. Doesn't it make problems when remote-
> table has very big number of rows?
>
No. postgres_fdw uses single-row processing mode of libpq when
retri
On 11/21/2012 10:00:11 PM, Karl O. Pinc wrote:
> On 11/21/2012 02:12:26 PM, Robert Haas wrote:
> > On Sat, Nov 17, 2012 at 1:22 AM, Peter Eisentraut
> > wrote:
> > > On Mon, 2012-11-12 at 11:42 -0600, Karl O. Pinc wrote:
> > >> Could ALTER TABLE use an option to drop the
> > >> primary key constra
On Mon, Nov 19, 2012 at 8:52 PM, Amit kapila wrote:
> On Monday, November 19, 2012 5:53 AM Jeff Janes wrote:
> On Sun, Oct 21, 2012 at 12:59 AM, Amit kapila
> wrote:
> > On Saturday, October 20, 2012 11:03 PM Jeff Janes wrote:
> >
> >>Run the modes in reciprocating order?
> >> Sorry, I didn't un
2012-11-21 22:15 keltezéssel, Magnus Hagander írta:
On Wed, Nov 21, 2012 at 10:01 PM, Boszormenyi Zoltan wrote:
Hi,
2012-11-21 19:19 keltezéssel, Magnus Hagander írta:
I'm breaking this out into it's own thread, for my own sanity if
nothing else :) And it's an isolated feature after all.
I
62 matches
Mail list logo
